SimplyVanilla / SimplyPerms / #18

Committed 11 Mar 2024 09:36PM UTC coverage: 26.178% (-2.1%) from 28.261%

Build # #18

Build Type

push

github

Committed by

web-flow

Commit Message

Fix velocity crash #3 (#10)

* Fixed [Velocity crash](https://gist.github.com/Netherwhal/5e37bd8a1656dbb9ac8cc88530144a65) happening when users in list are null

* Added forced stack trace to individuate error on Velocity restart

* Removed internal static list and reworked constructor

* Created UsersManager to keep track of loaded users

* Added usersManager field

* Added addUser method

* Updated some methods to use users manager

* Updated to use users manager to retrieve users

* Updated SimplePermProvider

Run Details

1 of 24 new or added lines in 4 files covered. (4.17%)

1 existing line in 1 file now uncovered.

50 of 191 relevant lines covered (26.18%)

0.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/main/java/net/simplyvanilla/simplyperms/SimplePermProvider.java

package net.simplyvanilla.simplyperms;

import com.velocitypowered.api.permission.PermissionFunction;
import com.velocitypowered.api.permission.PermissionProvider;
import com.velocitypowered.api.permission.PermissionSubject;
import com.velocitypowered.api.permission.Tristate;
import com.velocitypowered.api.proxy.Player;
import net.simplyvanilla.simplyperms.users.User;

import java.util.UUID;

public class SimplePermProvider implements PermissionProvider {
    protected final SimplyPerms plugin;

    public SimplePermProvider(SimplyPerms plugin) {
        this.plugin = plugin;
    }

    @Override
    public PermissionFunction createFunction(final PermissionSubject subject) {
        return new SimplePermFunction(this.plugin, subject);
    }

    private record SimplePermFunction(SimplyPerms plugin, PermissionSubject subject) implements PermissionFunction {

        @Override
        public Tristate getPermissionValue(final String permission) {
            if (this.subject instanceof Player) {
                UUID uuid = ((Player) this.subject).getUniqueId();
                User user = this.plugin.getUsersManager().getUser(uuid);
                return user.getPermissionState(permission);
            }
            return Tristate.TRUE;
        }
    }
}

1	package net.simplyvanilla.simplyperms;
2
3	import com.velocitypowered.api.permission.PermissionFunction;
4	import com.velocitypowered.api.permission.PermissionProvider;
5	import com.velocitypowered.api.permission.PermissionSubject;
6	import com.velocitypowered.api.permission.Tristate;
7	import com.velocitypowered.api.proxy.Player;
8	import net.simplyvanilla.simplyperms.users.User;
9
10	import java.util.UUID;
11
12	public class SimplePermProvider implements PermissionProvider {
13	protected final SimplyPerms plugin;
14
NEW 15	public SimplePermProvider(SimplyPerms plugin) {	×
NEW 16	this.plugin = plugin;	×
NEW 17	}	×
18
19	@Override
20	public PermissionFunction createFunction(final PermissionSubject subject) {
NEW 21	return new SimplePermFunction(this.plugin, subject);	×
22	}
23
NEW 24	private record SimplePermFunction(SimplyPerms plugin, PermissionSubject subject) implements PermissionFunction {	×
25
26	@Override
27	public Tristate getPermissionValue(final String permission) {
28	if (this.subject instanceof Player) {	×
29	UUID uuid = ((Player) this.subject).getUniqueId();	×
NEW 30	User user = this.plugin.getUsersManager().getUser(uuid);	×
31	return user.getPermissionState(permission);	×
32	}
33	return Tristate.TRUE;	×
34	}
35	}
36	}

SimplyVanilla / SimplyPerms / #18

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous