8212685604

Committed 09 Mar 2024 06:16AM UTC coverage: 83.804% (-0.06%) from 83.861%

Build # 8212685604

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #1409 from pbiering/fix-1314

add option for global permit of delete of collection (default: True t…

Run Details

1558 of 1987 branches covered (78.41%)

Branch coverage included in aggregate %.

6 of 7 new or added lines in 3 files covered. (85.71%)

2 existing lines in 1 file now uncovered.

3482 of 4027 relevant lines covered (86.47%)

20.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.19

/radicale/app/delete.py

# This file is part of Radicale - CalDAV and CardDAV server
# Copyright © 2008 Nicolas Kandel
# Copyright © 2008 Pascal Halter
# Copyright © 2008-2017 Guillaume Ayoub
# Copyright © 2017-2018 Unrud <unrud@outlook.com>
#
# This library is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Radicale.  If not, see <http://www.gnu.org/licenses/>.

import xml.etree.ElementTree as ET
from http import client
from typing import Optional

from radicale import httputils, storage, types, xmlutils
from radicale.app.base import Access, ApplicationBase


def xml_delete(base_prefix: str, path: str, collection: storage.BaseCollection,
               item_href: Optional[str] = None) -> ET.Element:
    """Read and answer DELETE requests.

    Read rfc4918-9.6 for info.

    """
    collection.delete(item_href)

    multistatus = ET.Element(xmlutils.make_clark("D:multistatus"))
    response = ET.Element(xmlutils.make_clark("D:response"))
    multistatus.append(response)

    href_element = ET.Element(xmlutils.make_clark("D:href"))
    href_element.text = xmlutils.make_href(base_prefix, path)
    response.append(href_element)

    status = ET.Element(xmlutils.make_clark("D:status"))
    status.text = xmlutils.make_response(200)
    response.append(status)

    return multistatus


class ApplicationPartDelete(ApplicationBase):

    def do_DELETE(self, environ: types.WSGIEnviron, base_prefix: str,
                  path: str, user: str) -> types.WSGIResponse:
        """Manage DELETE request."""
        access = Access(self._rights, user, path)
        if not access.check("w"):
            return httputils.NOT_ALLOWED
        with self._storage.acquire_lock("w", user):
            item = next(iter(self._storage.discover(path)), None)
            if not item:
                return httputils.NOT_FOUND
            if not access.check("w", item):
                return httputils.NOT_ALLOWED
            if_match = environ.get("HTTP_IF_MATCH", "*")
            if if_match not in ("*", item.etag):
                # ETag precondition not verified, do not delete item
                return httputils.PRECONDITION_FAILED
            if isinstance(item, storage.BaseCollection):
                if self._permit_delete_collection:
                    xml_answer = xml_delete(base_prefix, path, item)
                else:
                    return httputils.NOT_ALLOWED
            else:
                assert item.collection is not None
                assert item.href is not None
                xml_answer = xml_delete(
                    base_prefix, path, item.collection, item.href)
            headers = {"Content-Type": "text/xml; charset=%s" % self._encoding}
            return client.OK, headers, self._xml_response(xml_answer)

1	# This file is part of Radicale - CalDAV and CardDAV server
2	# Copyright © 2008 Nicolas Kandel
3	# Copyright © 2008 Pascal Halter
4	# Copyright © 2008-2017 Guillaume Ayoub
5	# Copyright © 2017-2018 Unrud <unrud@outlook.com>
6	#
7	# This library is free software: you can redistribute it and/or modify
8	# it under the terms of the GNU General Public License as published by
9	# the Free Software Foundation, either version 3 of the License, or
10	# (at your option) any later version.
11	#
12	# This library is distributed in the hope that it will be useful,
13	# but WITHOUT ANY WARRANTY; without even the implied warranty of
14	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15	# GNU General Public License for more details.
16	#
17	# You should have received a copy of the GNU General Public License
18	# along with Radicale. If not, see <http://www.gnu.org/licenses/>.
19
20	import xml.etree.ElementTree as ET	24✔
21	from http import client	24✔
22	from typing import Optional	24✔
23
24	from radicale import httputils, storage, types, xmlutils	24✔
25	from radicale.app.base import Access, ApplicationBase	24✔
26
27
28	def xml_delete(base_prefix: str, path: str, collection: storage.BaseCollection,	24✔
29	item_href: Optional[str] = None) -> ET.Element:
30	"""Read and answer DELETE requests.
31
32	Read rfc4918-9.6 for info.
33
34	"""
35	collection.delete(item_href)	24✔
36
37	multistatus = ET.Element(xmlutils.make_clark("D:multistatus"))	24✔
38	response = ET.Element(xmlutils.make_clark("D:response"))	24✔
39	multistatus.append(response)	24✔
40
41	href_element = ET.Element(xmlutils.make_clark("D:href"))	24✔
42	href_element.text = xmlutils.make_href(base_prefix, path)	24✔
43	response.append(href_element)	24✔
44
45	status = ET.Element(xmlutils.make_clark("D:status"))	24✔
46	status.text = xmlutils.make_response(200)	24✔
47	response.append(status)	24✔
48
49	return multistatus	24✔
50
51
52	class ApplicationPartDelete(ApplicationBase):	24✔
53
54	def do_DELETE(self, environ: types.WSGIEnviron, base_prefix: str,	24✔
55	path: str, user: str) -> types.WSGIResponse:
56	"""Manage DELETE request."""
57	access = Access(self._rights, user, path)	24✔
58	if not access.check("w"):	24!
59	return httputils.NOT_ALLOWED	×
60	with self._storage.acquire_lock("w", user):	24✔
61	item = next(iter(self._storage.discover(path)), None)	24✔
62	if not item:	24✔
63	return httputils.NOT_FOUND	24✔
64	if not access.check("w", item):	24!
65	return httputils.NOT_ALLOWED	×
66	if_match = environ.get("HTTP_IF_MATCH", "*")	24✔
67	if if_match not in ("*", item.etag):	24!
68	# ETag precondition not verified, do not delete item
69	return httputils.PRECONDITION_FAILED	×
70	if isinstance(item, storage.BaseCollection):	24✔
71	if self._permit_delete_collection:	24!
72	xml_answer = xml_delete(base_prefix, path, item)	24✔
73	else:
NEW 74	return httputils.NOT_ALLOWED	×
75	else:
76	assert item.collection is not None	24✔
77	assert item.href is not None	24✔
78	xml_answer = xml_delete(	24✔
79	base_prefix, path, item.collection, item.href)
80	headers = {"Content-Type": "text/xml; charset=%s" % self._encoding}	24✔
81	return client.OK, headers, self._xml_response(xml_answer)	24✔

Kozea / Radicale / 8212685604

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous