8187959343

Committed 07 Mar 2024 12:17PM UTC coverage: 93.428% (+0.02%) from 93.405%

Build # 8187959343

Build Type

Pull #1268

github

Committed by

iamacook

Commit Message

Add test

Pull Request Pull Request #1268: Migrate `DataDecoded` to `zod`

Run Details

1751 of 2107 branches covered (83.1%)

Branch coverage included in aggregate %.

22 of 23 new or added lines in 7 files covered. (95.65%)

1 existing line in 1 file now uncovered.

6438 of 6658 relevant lines covered (96.7%)

345.42 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/src/domain/data-decoder/data-decoded.validator.ts

import { Injectable } from '@nestjs/common';
import { ValidateFunction } from 'ajv';
import { DataDecoded } from '@/domain/data-decoder/entities/data-decoded.entity';
import {
  DATA_DECODED_PARAMETER_SCHEMA_ID,
  DATA_DECODED_SCHEMA_ID,
  dataDecodedParameterSchema,
  dataDecodedSchema,
} from '@/domain/data-decoder/entities/schemas/data-decoded.schema';
import { IValidator } from '@/domain/interfaces/validator.interface';
import { GenericValidator } from '@/validation/providers/generic.validator';
import { JsonSchemaService } from '@/validation/providers/json-schema.service';

// TODO: Remove after creation, module, multisig and transaction type are migrated to zod
@Injectable()
export class DataDecodedValidator implements IValidator<DataDecoded> {
  private readonly isValidDataDecoded: ValidateFunction<DataDecoded>;

  constructor(
    private readonly genericValidator: GenericValidator,
    private readonly jsonSchemaService: JsonSchemaService,
  ) {
    this.jsonSchemaService.getSchema(
      DATA_DECODED_PARAMETER_SCHEMA_ID,
      dataDecodedParameterSchema,
    );
    this.isValidDataDecoded = this.jsonSchemaService.getSchema(
      DATA_DECODED_SCHEMA_ID,
      dataDecodedSchema,
    );
  }

  validate(data: unknown): DataDecoded {
    return this.genericValidator.validate(this.isValidDataDecoded, data);
  }
}

1	import { Injectable } from '@nestjs/common';	92✔
2	import { ValidateFunction } from 'ajv';
3	import { DataDecoded } from '@/domain/data-decoder/entities/data-decoded.entity';
4	import {	92✔
5	DATA_DECODED_PARAMETER_SCHEMA_ID,
6	DATA_DECODED_SCHEMA_ID,
7	dataDecodedParameterSchema,
8	dataDecodedSchema,
9	} from '@/domain/data-decoder/entities/schemas/data-decoded.schema';
10	import { IValidator } from '@/domain/interfaces/validator.interface';
11	import { GenericValidator } from '@/validation/providers/generic.validator';	92✔
12	import { JsonSchemaService } from '@/validation/providers/json-schema.service';	92✔
13
14	// TODO: Remove after creation, module, multisig and transaction type are migrated to zod
15	@Injectable()
16	export class DataDecodedValidator implements IValidator<DataDecoded> {	92✔
17	private readonly isValidDataDecoded: ValidateFunction<DataDecoded>;
18
19	constructor(
20	private readonly genericValidator: GenericValidator,	1,090✔
21	private readonly jsonSchemaService: JsonSchemaService,	1,090✔
22	) {
23	this.jsonSchemaService.getSchema(	1,090✔
24	DATA_DECODED_PARAMETER_SCHEMA_ID,
25	dataDecodedParameterSchema,
26	);
27	this.isValidDataDecoded = this.jsonSchemaService.getSchema(	1,090✔
28	DATA_DECODED_SCHEMA_ID,
29	dataDecodedSchema,
30	);
31	}
32
33	validate(data: unknown): DataDecoded {
UNCOV 34	return this.genericValidator.validate(this.isValidDataDecoded, data);	×
35	}
36	}

safe-global / safe-client-gateway / 8187959343

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous