8178799794

Committed 06 Mar 2024 09:09PM UTC coverage: 76.258% (-0.06%) from 76.315%

Build # 8178799794

Build Type

Pull #2001

github

Committed by

web-flow

Commit Message

Merge fb3715254 into 9bbf98f33

Pull Request Pull Request #2001: chore(core): Remove assert, cast, stubProps, checkProps, ...

Run Details

1841 of 2376 branches covered (77.48%)

Branch coverage included in aggregate %.

55 of 76 new or added lines in 22 files covered. (72.37%)

3 existing lines in 1 file now uncovered.

22554 of 29614 relevant lines covered (76.16%)

21.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.26

/modules/engine/src/transform/buffer-transform.ts

// luma.gl
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors

import {Device, Buffer, BufferRange, TransformFeedback, RenderPassProps} from '@luma.gl/core';
import {getPassthroughFS} from '@luma.gl/shadertools';
import {Model} from '../model/model';
import type {ModelProps} from '..';

/**
 * Properties for creating a {@link BufferTransform}
 * @deprecated
 */
export type BufferTransformProps = Omit<ModelProps, 'fs'> & {
  fs?: ModelProps['fs']; // override as optional
  feedbackBuffers?: Record<string, Buffer | BufferRange>;
};

/**
 * Creates a pipeline for buffer→buffer transforms.
 * @deprecated
 */
export class BufferTransform {
  readonly device: Device;
  readonly model: Model;
  readonly transformFeedback: TransformFeedback;

  /** @deprecated Use device feature test. */
  static isSupported(device: Device): boolean {
    return device?.info?.type === 'webgl';
  }

  constructor(device: Device, props: BufferTransformProps = Model.defaultProps) {
    if (!BufferTransform.isSupported(device)) {
      throw new Error('BufferTransform not yet implemented on WebGPU');
    }

    this.device = device;

    this.model = new Model(this.device, {
      id: props.id || 'buffer-transform-model',
      fs: props.fs || getPassthroughFS(),
      topology: props.topology || 'point-list',
      ...props
    });

    this.transformFeedback = this.device.createTransformFeedback({
      layout: this.model.pipeline.shaderLayout,
      buffers: props.feedbackBuffers
    });

    this.model.setTransformFeedback(this.transformFeedback);

    Object.seal(this);
  }

  /** Destroy owned resources. */
  destroy(): void {
    if (this.model) {
      this.model.destroy();
    }
  }

  /** @deprecated Use {@link destroy}. */
  delete(): void {
    this.destroy();
  }

  /** Run one transform loop. */
  run(options?: RenderPassProps): void {
    const renderPass = this.device.beginRenderPass(options);
    this.model.draw(renderPass);
    renderPass.end();
  }

  /** @deprecated */
  update(...args: any[]): void {
    // TODO(v9): Method should likely be removed for v9. Keeping a method stub
    // to assist with migrating DeckGL usage.
    // eslint-disable-next-line no-console
    console.warn('TextureTransform#update() not implemented');
  }

  /** Returns the {@link Buffer} or {@link BufferRange} for given varying name. */
  getBuffer(varyingName: string): Buffer | BufferRange | null {
    return this.transformFeedback.getBuffer(varyingName);
  }

  readAsync(varyingName: string): Promise<Uint8Array> {
    const result = this.getBuffer(varyingName);
    if (result instanceof Buffer) {
      return result.readAsync();
    }
    const {buffer, byteOffset = 0, byteLength = buffer.byteLength} = result;
    return buffer.readAsync(byteOffset, byteLength);
  }
}

1	// luma.gl	1✔
2	// SPDX-License-Identifier: MIT	1✔
3	// Copyright (c) vis.gl contributors	1✔
4		1✔
5	import {Device, Buffer, BufferRange, TransformFeedback, RenderPassProps} from '@luma.gl/core';	1✔
6	import {getPassthroughFS} from '@luma.gl/shadertools';	1✔
7	import {Model} from '../model/model';	1✔
8	import type {ModelProps} from '..';	1✔
9		1✔
10	/**	1✔
11	* Properties for creating a {@link BufferTransform}	1✔
12	* @deprecated	1✔
13	*/	1✔
14	export type BufferTransformProps = Omit<ModelProps, 'fs'> & {	1✔
15	fs?: ModelProps['fs']; // override as optional	1✔
16	feedbackBuffers?: Record<string, Buffer \| BufferRange>;	1✔
17	};	1✔
18		1✔
19	/**	1✔
20	* Creates a pipeline for buffer→buffer transforms.	1✔
21	* @deprecated	1✔
22	*/	1✔
23	export class BufferTransform {	1✔
24	readonly device: Device;	7✔
25	readonly model: Model;	7✔
26	readonly transformFeedback: TransformFeedback;	7✔
27		7✔
28	/** @deprecated Use device feature test. */	7✔
29	static isSupported(device: Device): boolean {	7✔
30	return device?.info?.type === 'webgl';	12✔
31	}	12✔
32		7✔
33	constructor(device: Device, props: BufferTransformProps = Model.defaultProps) {	7✔
34	if (!BufferTransform.isSupported(device)) {	7!
NEW 35	throw new Error('BufferTransform not yet implemented on WebGPU');	×
NEW 36	}	×
37		7✔
38	this.device = device;	7✔
39		7✔
40	this.model = new Model(this.device, {	7✔
41	id: props.id \|\| 'buffer-transform-model',	7✔
42	fs: props.fs \|\| getPassthroughFS(),	7✔
43	topology: props.topology \|\| 'point-list',	7✔
44	...props	7✔
45	});	7✔
46		7✔
47	this.transformFeedback = this.device.createTransformFeedback({	7✔
48	layout: this.model.pipeline.shaderLayout,	7✔
49	buffers: props.feedbackBuffers	7✔
50	});	7✔
51		7✔
52	this.model.setTransformFeedback(this.transformFeedback);	7✔
53		7✔
54	Object.seal(this);	7✔
55	}	7✔
56		7✔
57	/** Destroy owned resources. */	7✔
58	destroy(): void {	7✔
59	if (this.model) {	×
60	this.model.destroy();	×
61	}	×
62	}	×
63		7✔
64	/** @deprecated Use {@link destroy}. */	7✔
65	delete(): void {	7✔
66	this.destroy();	×
67	}	×
68		7✔
69	/** Run one transform loop. */	7✔
70	run(options?: RenderPassProps): void {	7✔
71	const renderPass = this.device.beginRenderPass(options);	6✔
72	this.model.draw(renderPass);	6✔
73	renderPass.end();	6✔
74	}	6✔
75		7✔
76	/** @deprecated */	7✔
77	update(...args: any[]): void {	7✔
78	// TODO(v9): Method should likely be removed for v9. Keeping a method stub	×
79	// to assist with migrating DeckGL usage.	×
80	// eslint-disable-next-line no-console	×
81	console.warn('TextureTransform#update() not implemented');	×
82	}	×
83		7✔
84	/** Returns the {@link Buffer} or {@link BufferRange} for given varying name. */	7✔
85	getBuffer(varyingName: string): Buffer \| BufferRange \| null {	7✔
86	return this.transformFeedback.getBuffer(varyingName);	6✔
87	}	6✔
88		7✔
89	readAsync(varyingName: string): Promise<Uint8Array> {	7✔
90	const result = this.getBuffer(varyingName);	6✔
91	if (result instanceof Buffer) {	6!
92	return result.readAsync();	×
93	}	×
94	const {buffer, byteOffset = 0, byteLength = buffer.byteLength} = result;	6✔
95	return buffer.readAsync(byteOffset, byteLength);	6✔
96	}	6✔
97	}	7✔

visgl / luma.gl / 8178799794

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous