8172656707

Committed 06 Mar 2024 01:11PM UTC coverage: 93.544% (+0.3%) from 93.277%

Build # 8172656707

Build Type

Pull #1248

github

Committed by

iamacook

Commit Message

Add empty default value

Pull Request Pull Request #1248: Align and validate `ILockingApi` return types

Run Details

1729 of 2082 branches covered (83.05%)

Branch coverage included in aggregate %.

51 of 53 new or added lines in 9 files covered. (96.23%)

3 existing lines in 2 files now uncovered.

6399 of 6607 relevant lines covered (96.85%)

347.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71

/src/routes/locking/locking.controller.ts

import { LockingEvent } from '@/domain/locking/entities/locking-event.entity';
import { Rank } from '@/domain/locking/entities/rank.entity';
import { PaginationDataDecorator } from '@/routes/common/decorators/pagination.data.decorator';
import { RouteUrlDecorator } from '@/routes/common/decorators/route.url.decorator';
import { Page } from '@/routes/common/entities/page.entity';
import { PaginationData } from '@/routes/common/pagination/pagination.data';
import { LockingService } from '@/routes/locking/locking.service';
import { Controller, Get, Param } from '@nestjs/common';
import { ApiTags } from '@nestjs/swagger';

@ApiTags('locking')
@Controller({
  path: 'locking',
  version: '1',
})
export class LockingController {
  constructor(private readonly lockingService: LockingService) {}

  @Get('/:safeAddress/rank')
  async getRank(@Param('safeAddress') safeAddress: string): Promise<Rank> {
    return this.lockingService.getRank(safeAddress);
  }

  @Get('/leaderboard')
  async getLeaderboard(
    @RouteUrlDecorator() routeUrl: URL,
    @PaginationDataDecorator() paginationData: PaginationData,
  ): Promise<Page<Rank>> {
    return this.lockingService.getLeaderboard({ routeUrl, paginationData });
  }

  @Get('/:safeAddress/history')
  async getLockingHistory(
    @Param('safeAddress') safeAddress: string,
    @RouteUrlDecorator() routeUrl: URL,
    @PaginationDataDecorator() paginationData: PaginationData,
  ): Promise<Page<LockingEvent>> {
    return this.lockingService.getLockingHistory({
      safeAddress,
      routeUrl,
      paginationData,
    });
  }
}

1	import { LockingEvent } from '@/domain/locking/entities/locking-event.entity';
2	import { Rank } from '@/domain/locking/entities/rank.entity';
3	import { PaginationDataDecorator } from '@/routes/common/decorators/pagination.data.decorator';	84✔
4	import { RouteUrlDecorator } from '@/routes/common/decorators/route.url.decorator';	84✔
5	import { Page } from '@/routes/common/entities/page.entity';
6	import { PaginationData } from '@/routes/common/pagination/pagination.data';	84✔
7	import { LockingService } from '@/routes/locking/locking.service';	84✔
8	import { Controller, Get, Param } from '@nestjs/common';	84✔
9	import { ApiTags } from '@nestjs/swagger';	84✔
10
11	@ApiTags('locking')
12	@Controller({
13	path: 'locking',
14	version: '1',
15	})
16	export class LockingController {	84✔
17	constructor(private readonly lockingService: LockingService) {}	1,040✔
18
19	@Get('/:safeAddress/rank')
20	async getRank(@Param('safeAddress') safeAddress: string): Promise<Rank> {	84✔
UNCOV 21	return this.lockingService.getRank(safeAddress);	×
22	}
23
24	@Get('/leaderboard')
25	async getLeaderboard(	84✔
26	@RouteUrlDecorator() routeUrl: URL,
27	@PaginationDataDecorator() paginationData: PaginationData,
28	): Promise<Page<Rank>> {
UNCOV 29	return this.lockingService.getLeaderboard({ routeUrl, paginationData });	×
30	}
31
32	@Get('/:safeAddress/history')
33	async getLockingHistory(	84✔
34	@Param('safeAddress') safeAddress: string,
35	@RouteUrlDecorator() routeUrl: URL,
36	@PaginationDataDecorator() paginationData: PaginationData,
37	): Promise<Page<LockingEvent>> {
38	return this.lockingService.getLockingHistory({	6✔
39	safeAddress,
40	routeUrl,
41	paginationData,
42	});
43	}
44	}

safe-global / safe-client-gateway / 8172656707

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous