2075

Committed 27 Feb 2024 04:12PM UTC coverage: 90.97% (+0.05%) from 90.925%

Build # 2075

Build Type

push

Evergreen

Committed by

web-flow

Commit Message

Eliminate copies when accessing values from Bson types (#7377)

Returning things by value performs a deep copy, which is very expensive when
those things are also bson containers.

Re-align the naming with the convention names for the functions rather than
being weird and different.

Run Details

93914 of 173104 branches covered (54.25%)

82 of 82 new or added lines in 9 files covered. (100.0%)

66 existing lines in 16 files now uncovered.

238508 of 262184 relevant lines covered (90.97%)

5724419.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.72

/src/realm/array_blobs_big.cpp

/*************************************************************************
 *
 * Copyright 2016 Realm Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 **************************************************************************/

#include <algorithm>

#include <realm/array_blobs_big.hpp>
#include <realm/column_integer.hpp>


using namespace realm;

BinaryData ArrayBigBlobs::get_at(size_t ndx, size_t& pos) const noexcept
{
    ref_type ref = get_as_ref(ndx);
    if (ref == 0)
        return {}; // realm::null();

    ArrayBlob blob(m_alloc);
    blob.init_from_ref(ref);

    return blob.get_at(pos);
}


void ArrayBigBlobs::add(BinaryData value, bool add_zero_term)
{
    REALM_ASSERT_7(value.size(), ==, 0, ||, value.data(), !=, 0);

    if (value.is_null()) {
        Array::add(0); // Throws
    }
    else {
        ArrayBlob new_blob(m_alloc);
        new_blob.create();                                                      // Throws
        ref_type ref = new_blob.add(value.data(), value.size(), add_zero_term); // Throws
        Array::add(from_ref(ref));                                              // Throws
    }
}


void ArrayBigBlobs::set(size_t ndx, BinaryData value, bool add_zero_term)
{
    REALM_ASSERT_3(ndx, <, size());
    REALM_ASSERT_7(value.size(), ==, 0, ||, value.data(), !=, 0);

    ref_type ref = get_as_ref(ndx);

    if (ref == 0 && value.is_null()) {
        return;
    }
    else if (ref == 0 && value.data() != nullptr) {
        ArrayBlob new_blob(m_alloc);
        new_blob.create();                                             // Throws
        ref = new_blob.add(value.data(), value.size(), add_zero_term); // Throws
        Array::set_as_ref(ndx, ref);
        return;
    }
    else if (ref != 0 && value.data() != nullptr) {
        char* header = m_alloc.translate(ref);
        if (Array::get_context_flag_from_header(header)) {
            Array arr(m_alloc);
            arr.init_from_mem(MemRef(header, ref, m_alloc));
            arr.set_parent(this, ndx);
            ref_type new_ref =
                arr.blob_replace(0, arr.blob_size(), value.data(), value.size(), add_zero_term); // Throws
            if (new_ref != ref) {
                Array::set_as_ref(ndx, new_ref);
            }
        }
        else {
            ArrayBlob blob(m_alloc);
            blob.init_from_mem(MemRef(header, ref, m_alloc));
            blob.set_parent(this, ndx);
            ref_type new_ref = blob.replace(0, blob.blob_size(), value.data(), value.size(), add_zero_term); // Throws
            if (new_ref != ref) {
                Array::set_as_ref(ndx, new_ref);
            }
        }
        return;
    }
    else if (ref != 0 && value.is_null()) {
        Array::destroy_deep(ref, get_alloc());
        Array::set(ndx, 0);
        return;
    }
    REALM_ASSERT(false);
}


void ArrayBigBlobs::insert(size_t ndx, BinaryData value, bool add_zero_term)
{
    REALM_ASSERT_3(ndx, <=, size());
    REALM_ASSERT_7(value.size(), ==, 0, ||, value.data(), !=, 0);

    if (value.is_null()) {
        Array::insert(ndx, 0); // Throws
    }
    else {
        ArrayBlob new_blob(m_alloc);
        new_blob.create();                                                      // Throws
        ref_type ref = new_blob.add(value.data(), value.size(), add_zero_term); // Throws

        Array::insert(ndx, int64_t(ref)); // Throws
    }
}


size_t ArrayBigBlobs::count(BinaryData value, bool is_string, size_t begin, size_t end) const noexcept
{
    size_t num_matches = 0;

    size_t begin_2 = begin;
    for (;;) {
        size_t ndx = find_first(value, is_string, begin_2, end);
        if (ndx == not_found)
            break;
        ++num_matches;
        begin_2 = ndx + 1;
    }

    return num_matches;
}


size_t ArrayBigBlobs::find_first(BinaryData value, bool is_string, size_t begin, size_t end) const noexcept
{
    if (end == npos)
        end = m_size;
    REALM_ASSERT_11(begin, <=, m_size, &&, end, <=, m_size, &&, begin, <=, end);

    // When strings are stored as blobs, they are always zero-terminated
    // but the value we get as input might not be.
    size_t value_size = value.size();
    size_t full_size = is_string ? value_size + 1 : value_size;

    if (value.is_null()) {
        for (size_t i = begin; i != end; ++i) {
            ref_type ref = get_as_ref(i);
            if (ref == 0)
                return i;
        }
    }
    else {
        for (size_t i = begin; i != end; ++i) {
            ref_type ref = get_as_ref(i);
            if (ref) {
                const char* blob_header = get_alloc().translate(ref);
                size_t sz = get_size_from_header(blob_header);
                if (sz == full_size) {
                    const char* blob_value = ArrayBlob::get(blob_header, 0);
                    if (std::equal(blob_value, blob_value + value_size, value.data()))
                        return i;
                }
            }
        }
    }

    return not_found;
}


void ArrayBigBlobs::find_all(IntegerColumn& result, BinaryData value, bool is_string, size_t add_offset, size_t begin,
                             size_t end)
{
    size_t begin_2 = begin;
    for (;;) {
        size_t ndx = find_first(value, is_string, begin_2, end);
        if (ndx == not_found)
            break;
        result.add(add_offset + ndx); // Throws
        begin_2 = ndx + 1;
    }
}



void ArrayBigBlobs::verify() const
{
#ifdef REALM_DEBUG
    REALM_ASSERT(has_refs());
    for (size_t i = 0; i < size(); ++i) {
        ref_type blob_ref = Array::get_as_ref(i);
        // 0 is used to indicate realm::null()
        if (blob_ref != 0) {
            ArrayBlob blob(m_alloc);
            blob.init_from_ref(blob_ref);
            blob.verify();
        }
    }
#endif
}


1	/*************************************************************************
2	*
3	* Copyright 2016 Realm Inc.
4	*
5	* Licensed under the Apache License, Version 2.0 (the "License");
6	* you may not use this file except in compliance with the License.
7	* You may obtain a copy of the License at
8	*
9	* http://www.apache.org/licenses/LICENSE-2.0
10	*
11	* Unless required by applicable law or agreed to in writing, software
12	* distributed under the License is distributed on an "AS IS" BASIS,
13	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14	* See the License for the specific language governing permissions and
15	* limitations under the License.
16	*
17	**************************************************************************/
18
19	#include <algorithm>
20
21	#include <realm/array_blobs_big.hpp>
22	#include <realm/column_integer.hpp>
23
24
25	using namespace realm;
26
27	BinaryData ArrayBigBlobs::get_at(size_t ndx, size_t& pos) const noexcept
28	{	374,172✔
29	ref_type ref = get_as_ref(ndx);	374,172✔
30	if (ref == 0)	374,172✔
31	return {}; // realm::null();	82,065✔
32		142,527✔
33	ArrayBlob blob(m_alloc);	292,107✔
34	blob.init_from_ref(ref);	292,107✔
35		142,527✔
36	return blob.get_at(pos);	292,107✔
37	}	292,107✔
38
39
40	void ArrayBigBlobs::add(BinaryData value, bool add_zero_term)
41	{	87,057✔
42	REALM_ASSERT_7(value.size(), ==, 0, \|\|, value.data(), !=, 0);	87,057✔
43		43,551✔
44	if (value.is_null()) {	87,057✔
45	Array::add(0); // Throws	33,930✔
46	}	33,930✔
47	else {	53,127✔
48	ArrayBlob new_blob(m_alloc);	53,127✔
49	new_blob.create(); // Throws	53,127✔
50	ref_type ref = new_blob.add(value.data(), value.size(), add_zero_term); // Throws	53,127✔
51	Array::add(from_ref(ref)); // Throws	53,127✔
52	}	53,127✔
53	}	87,057✔
54
55
56	void ArrayBigBlobs::set(size_t ndx, BinaryData value, bool add_zero_term)
57	{	5,477,937✔
58	REALM_ASSERT_3(ndx, <, size());	5,477,937✔
59	REALM_ASSERT_7(value.size(), ==, 0, \|\|, value.data(), !=, 0);	5,477,937✔
60		2,739,273✔
61	ref_type ref = get_as_ref(ndx);	5,477,937✔
62		2,739,273✔
63	if (ref == 0 && value.is_null()) {	5,477,937✔
64	return;	1,692✔
65	}	1,692✔
66	else if (ref == 0 && value.data() != nullptr) {	5,476,245✔
67	ArrayBlob new_blob(m_alloc);	1,385,568✔
68	new_blob.create(); // Throws	1,385,568✔
69	ref = new_blob.add(value.data(), value.size(), add_zero_term); // Throws	1,385,568✔
70	Array::set_as_ref(ndx, ref);	1,385,568✔
71	return;	1,385,568✔
72	}	1,385,568✔
73	else if (ref != 0 && value.data() != nullptr) {	4,091,589✔
74	char* header = m_alloc.translate(ref);	4,082,151✔
75	if (Array::get_context_flag_from_header(header)) {	4,082,151✔
76	Array arr(m_alloc);	6✔
77	arr.init_from_mem(MemRef(header, ref, m_alloc));	6✔
78	arr.set_parent(this, ndx);	6✔
79	ref_type new_ref =	6✔
80	arr.blob_replace(0, arr.blob_size(), value.data(), value.size(), add_zero_term); // Throws	6✔
81	if (new_ref != ref) {	6✔
UNCOV 82	Array::set_as_ref(ndx, new_ref);	×
UNCOV 83	}	×
84	}	6✔
85	else {	4,082,145✔
86	ArrayBlob blob(m_alloc);	4,082,145✔
87	blob.init_from_mem(MemRef(header, ref, m_alloc));	4,082,145✔
88	blob.set_parent(this, ndx);	4,082,145✔
89	ref_type new_ref = blob.replace(0, blob.blob_size(), value.data(), value.size(), add_zero_term); // Throws	4,082,145✔
90	if (new_ref != ref) {	4,082,145✔
91	Array::set_as_ref(ndx, new_ref);	3,721,377✔
92	}	3,721,377✔
93	}	4,082,145✔
94	return;	4,082,151✔
95	}	4,082,151✔
96	else if (ref != 0 && value.is_null()) {	9,186✔
97	Array::destroy_deep(ref, get_alloc());	7,950✔
98	Array::set(ndx, 0);	7,950✔
99	return;	7,950✔
100	}	7,950✔
101	REALM_ASSERT(false);	2,147,484,883✔
102	}	2,147,484,883✔
103
104
105	void ArrayBigBlobs::insert(size_t ndx, BinaryData value, bool add_zero_term)
106	{	2,401,122✔
107	REALM_ASSERT_3(ndx, <=, size());	2,401,122✔
108	REALM_ASSERT_7(value.size(), ==, 0, \|\|, value.data(), !=, 0);	2,401,122✔
109		1,182,597✔
110	if (value.is_null()) {	2,401,122✔
111	Array::insert(ndx, 0); // Throws	1,425,615✔
112	}	1,425,615✔
113	else {	975,507✔
114	ArrayBlob new_blob(m_alloc);	975,507✔
115	new_blob.create(); // Throws	975,507✔
116	ref_type ref = new_blob.add(value.data(), value.size(), add_zero_term); // Throws	975,507✔
117		470,109✔
118	Array::insert(ndx, int64_t(ref)); // Throws	975,507✔
119	}	975,507✔
120	}	2,401,122✔
121
122
123	size_t ArrayBigBlobs::count(BinaryData value, bool is_string, size_t begin, size_t end) const noexcept
124	{	12✔
125	size_t num_matches = 0;	12✔
126		6✔
127	size_t begin_2 = begin;	12✔
128	for (;;) {	48✔
129	size_t ndx = find_first(value, is_string, begin_2, end);	48✔
130	if (ndx == not_found)	48✔
131	break;	12✔
132	++num_matches;	36✔
133	begin_2 = ndx + 1;	36✔
134	}	36✔
135		6✔
136	return num_matches;	12✔
137	}	12✔
138
139
140	size_t ArrayBigBlobs::find_first(BinaryData value, bool is_string, size_t begin, size_t end) const noexcept
141	{	256,053✔
142	if (end == npos)	256,053✔
143	end = m_size;	108✔
144	REALM_ASSERT_11(begin, <=, m_size, &&, end, <=, m_size, &&, begin, <=, end);	256,053✔
145		128,004✔
146	// When strings are stored as blobs, they are always zero-terminated	128,004✔
147	// but the value we get as input might not be.	128,004✔
148	size_t value_size = value.size();	256,053✔
149	size_t full_size = is_string ? value_size + 1 : value_size;	256,026✔
150		128,004✔
151	if (value.is_null()) {	256,053✔
152	for (size_t i = begin; i != end; ++i) {	67,221✔
153	ref_type ref = get_as_ref(i);	67,215✔
154	if (ref == 0)	67,215✔
155	return i;	67,167✔
156	}	67,215✔
157	}	67,173✔
158	else {	188,880✔
159	for (size_t i = begin; i != end; ++i) {	2,530,089✔
160	ref_type ref = get_as_ref(i);	2,515,728✔
161	if (ref) {	2,515,728✔
162	const char* blob_header = get_alloc().translate(ref);	2,451,927✔
163	size_t sz = get_size_from_header(blob_header);	2,451,927✔
164	if (sz == full_size) {	2,451,927✔
165	const char* blob_value = ArrayBlob::get(blob_header, 0);	972,420✔
166	if (std::equal(blob_value, blob_value + value_size, value.data()))	972,420✔
167	return i;	174,519✔
168	}	972,420✔
169	}	2,451,927✔
170	}	2,515,728✔
171	}	188,880✔
172		128,004✔
173	return not_found;	135,171✔
174	}	256,053✔
175
176
177	void ArrayBigBlobs::find_all(IntegerColumn& result, BinaryData value, bool is_string, size_t add_offset, size_t begin,
178	size_t end)
179	{	12✔
180	size_t begin_2 = begin;	12✔
181	for (;;) {	48✔
182	size_t ndx = find_first(value, is_string, begin_2, end);	48✔
183	if (ndx == not_found)	48✔
184	break;	12✔
185	result.add(add_offset + ndx); // Throws	36✔
186	begin_2 = ndx + 1;	36✔
187	}	36✔
188	}	12✔
189
190
191
192	void ArrayBigBlobs::verify() const
193	{	66,504✔
194	#ifdef REALM_DEBUG	66,504✔
195	REALM_ASSERT(has_refs());	66,504✔
196	for (size_t i = 0; i < size(); ++i) {	11,368,497✔
197	ref_type blob_ref = Array::get_as_ref(i);	11,301,993✔
198	// 0 is used to indicate realm::null()	5,650,500✔
199	if (blob_ref != 0) {	11,301,996✔
200	ArrayBlob blob(m_alloc);	11,301,927✔
201	blob.init_from_ref(blob_ref);	11,301,927✔
202	blob.verify();	11,301,927✔
203	}	11,301,927✔
204	}	11,301,993✔
205	#endif	66,504✔
206	}	66,504✔
207

realm / realm-core / 2075

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous