7970407897

Committed 20 Feb 2024 08:20AM UTC coverage: 66.686% (+0.003%) from 66.683%

Build # 7970407897

Build Type

push

github

Committed by

web-flow

Commit Message

fix(openapi): skip requestBody if input is false (#6163)

* fix(openapi): skip requestBody if input is false

* cs fix

* fix phpstan error

* cs fix

* merge condition

---------

Co-authored-by: soyuka <soyuka@users.noreply.github.com>

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

86 existing lines in 9 files now uncovered.

16306 of 24452 relevant lines covered (66.69%)

37.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.62

/src/Symfony/EventListener/ValidateListener.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\EventListener;

use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
use ApiPlatform\State\Util\OperationRequestInitiatorTrait;
use ApiPlatform\Validator\Exception\ValidationException;
use ApiPlatform\Validator\ValidatorInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\ViewEvent;

/**
 * Validates data.
 *
 * @author Kévin Dunglas <dunglas@gmail.com>
 */
final class ValidateListener
{
    use OperationRequestInitiatorTrait;

    public const OPERATION_ATTRIBUTE_KEY = 'validate';

    public function __construct(private readonly ValidatorInterface $validator, ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory)
    {
        $this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;
    }

    /**
     * Validates data returned by the controller if applicable.
     *
     * @throws ValidationException
     */
    public function onKernelView(ViewEvent $event): void
    {
        $controllerResult = $event->getControllerResult();
        $request = $event->getRequest();
        $operation = $this->initializeOperation($request);
        if ('api_platform.symfony.main_controller' === $operation?->getController() || $request->attributes->get('_api_platform_disable_listeners')) {
            return;
        }

        if (
            $controllerResult instanceof Response
            || $request->isMethodSafe()
            || $request->isMethod('DELETE')
        ) {
            return;
        }

        if (!$operation || !($operation->canValidate() ?? true)) {
            return;
        }

        $this->validator->validate($controllerResult, $operation->getValidationContext() ?? []);
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\EventListener;
15
16	use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
17	use ApiPlatform\State\Util\OperationRequestInitiatorTrait;
18	use ApiPlatform\Validator\Exception\ValidationException;
19	use ApiPlatform\Validator\ValidatorInterface;
20	use Symfony\Component\HttpFoundation\Response;
21	use Symfony\Component\HttpKernel\Event\ViewEvent;
22
23	/**
24	* Validates data.
25	*
26	* @author Kévin Dunglas <dunglas@gmail.com>
27	*/
28	final class ValidateListener
29	{
30	use OperationRequestInitiatorTrait;
31
32	public const OPERATION_ATTRIBUTE_KEY = 'validate';
33
34	public function __construct(private readonly ValidatorInterface $validator, ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory)
35	{
UNCOV 36	$this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;	16✔
37	}
38
39	/**
40	* Validates data returned by the controller if applicable.
41	*
42	* @throws ValidationException
43	*/
44	public function onKernelView(ViewEvent $event): void
45	{
UNCOV 46	$controllerResult = $event->getControllerResult();	16✔
UNCOV 47	$request = $event->getRequest();	16✔
UNCOV 48	$operation = $this->initializeOperation($request);	16✔
UNCOV 49	if ('api_platform.symfony.main_controller' === $operation?->getController() \|\| $request->attributes->get('_api_platform_disable_listeners')) {	16✔
50	return;	×
51	}
52
53	if (
UNCOV 54	$controllerResult instanceof Response	16✔
UNCOV 55	\|\| $request->isMethodSafe()	16✔
UNCOV 56	\|\| $request->isMethod('DELETE')	16✔
57	) {
UNCOV 58	return;	13✔
59	}
60
UNCOV 61	if (!$operation \|\| !($operation->canValidate() ?? true)) {	3✔
62	return;	×
63	}
64
UNCOV 65	$this->validator->validate($controllerResult, $operation->getValidationContext() ?? []);	3✔
66	}
67	}

api-platform / core / 7970407897

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous