7306930104

Committed 23 Dec 2023 07:22AM UTC coverage: 83.197% (+0.2%) from 83.005%

Build # 7306930104

Build Type

Pull #55

github

Committed by

web-flow

Commit Message

Merge 3da2aacd7 into 6bec5a62a

Pull Request Pull Request #55: Fix semver lt

Run Details

512 of 691 branches covered (0.0%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 3 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

2226 of 2600 relevant lines covered (85.62%)

1117.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.07

/src/plumbing/link.ts

import SemVer, * as semver from "../utils/semver.ts"
import { Package, Installation } from "../types.ts"
import useCellar from "../hooks/useCellar.ts"
import { panic } from "../utils/error.ts"
import fs from "node:fs/promises"
import Path from "../utils/Path.ts"

export default async function link(pkg: Package | Installation) {
  const installation = await useCellar().resolve(pkg)
  pkg = installation.pkg

  const versions = (await useCellar()
    .ls(installation.pkg.project))
    .map(({pkg: {version}, path}) => [version, path] as [SemVer, Path])
    .sort(([a],[b]) => a.compare(b))

  if (versions.length <= 0) {
    const err = new Error('no versions')
    err.cause = pkg
    throw err
  }

  const shelf = installation.path.parent()
  const newest = versions.slice(-1)[0]
  const vMm = `${pkg.version.major}.${pkg.version.minor}`
  const minorRange = new semver.Range(`^${vMm}`)
  const mostMinor = versions.filter(v => minorRange.satisfies(v[0])).at(-1) ?? panic()

  if (mostMinor[0].neq(pkg.version)) return
  // ^^ if we’re not the most minor we definitely not the most major

  await makeSymlink(`v${vMm}`)

  const majorRange = new semver.Range(`^${pkg.version.major.toString()}`)
  const mostMajor = versions.filter(v => majorRange.satisfies(v[0])).at(-1) ?? panic()

  if (mostMajor[0].neq(pkg.version)) return
  // ^^ if we’re not the most major we definitely aren’t the newest

  await makeSymlink(`v${pkg.version.major}`)

  if (pkg.version.eq(newest[0])) {
    await makeSymlink('v*')
  }

  async function makeSymlink(symname: string) {
    try {
      const what_we_make = shelf.join(symname)
      if (what_we_make.isSymlink()) {
        try {
          // using this rather than rm due to bug in deno shims that
          // tries to call rmdir on the symlink because the symlink points to a dir
          await fs.unlink(what_we_make.string)
        } catch (err) {
          // we were deleted by another thing linking simultaneously
          //FIXME our flock should surround the link step too
          if (err.code != 'ENOENT') throw err
        }
      }

      await Deno.symlink(
        installation.path.basename(),  // makes it relative
        shelf.join(symname).rm().string,
        {type: 'dir'})
      } catch (err) {
        if (err instanceof Deno.errors.AlreadyExists || err.code === 'EEXIST') {
          //FIXME race condition for installing the same pkg simultaneously
          // real fix is to lock around the entire download/untar/link process
          return
        } else {
          throw err
        }
      }
  }
}

1	import SemVer, * as semver from "../utils/semver.ts"	9✔
2	import { Package, Installation } from "../types.ts"
3	import useCellar from "../hooks/useCellar.ts"	9✔
4	import { panic } from "../utils/error.ts"	9✔
5	import fs from "node:fs/promises"	9✔
6	import Path from "../utils/Path.ts"
7
8	export default async function link(pkg: Package \| Installation) {	6✔
9	const installation = await useCellar().resolve(pkg)	14✔
10	pkg = installation.pkg	14✔
11
12	const versions = (await useCellar()	14✔
13	.ls(installation.pkg.project))	14✔
14	.map(({pkg: {version}, path}) => [version, path] as [SemVer, Path])	58✔
15	.sort(([a],[b]) => a.compare(b))	×
16
17	if (versions.length <= 0) {	×
18	const err = new Error('no versions')	×
19	err.cause = pkg	×
20	throw err	×
21	}	×
22
23	const shelf = installation.path.parent()	14✔
24	const newest = versions.slice(-1)[0]	14✔
25	const vMm = `${pkg.version.major}.${pkg.version.minor}`	14✔
26	const minorRange = new semver.Range(`^${vMm}`)	14✔
27	const mostMinor = versions.filter(v => minorRange.satisfies(v[0])).at(-1) ?? panic()	×
28
29	if (mostMinor[0].neq(pkg.version)) return	×
30	// ^^ if we’re not the most minor we definitely not the most major	14✔
31
32	await makeSymlink(`v${vMm}`)	14✔
33
34	const majorRange = new semver.Range(`^${pkg.version.major.toString()}`)	14✔
35	const mostMajor = versions.filter(v => majorRange.satisfies(v[0])).at(-1) ?? panic()	×
36
37	if (mostMajor[0].neq(pkg.version)) return	×
38	// ^^ if we’re not the most major we definitely aren’t the newest	14✔
39
40	await makeSymlink(`v${pkg.version.major}`)	14✔
41
42	if (pkg.version.eq(newest[0])) {	14✔
43	await makeSymlink('v*')	14✔
44	}	14✔
45
46	async function makeSymlink(symname: string) {	14✔
47	try {	38✔
48	const what_we_make = shelf.join(symname)	38✔
49	if (what_we_make.isSymlink()) {	38✔
50	try {	50✔
51	// using this rather than rm due to bug in deno shims that	50✔
52	// tries to call rmdir on the symlink because the symlink points to a dir	50✔
53	await fs.unlink(what_we_make.string)	50✔
54	} catch (err) {	×
55	// we were deleted by another thing linking simultaneously	×
56	//FIXME our flock should surround the link step too	×
57	if (err.code != 'ENOENT') throw err	×
58	}	×
59	}	50✔
60
61	await Deno.symlink(	38✔
62	installation.path.basename(), // makes it relative	38✔
63	shelf.join(symname).rm().string,	38✔
64	{type: 'dir'})	114✔
UNCOV 65	} catch (err) {	×
66	if (err instanceof Deno.errors.AlreadyExists \|\| err.code === 'EEXIST') {	×
UNCOV 67	//FIXME race condition for installing the same pkg simultaneously	×
UNCOV 68	// real fix is to lock around the entire download/untar/link process	×
UNCOV 69	return	×
70	} else {	×
71	throw err	×
72	}	×
UNCOV 73	}	×
74	}	38✔
75	}	14✔

pkgxdev / libpkgx / 7306930104

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous