#11333

Committed 20 Dec 2023 03:56PM UTC coverage: 88.145% (+0.006%) from 88.139%

Build Type

push

Committed by

Commit Message

Fix multi-namespace class inheritance transpile bug (#990)

* Add failing unit test

* Fix test case after simplifying too much

* Fix getParentClassIndex always using top-level namespace

Run Details

5669 of 6900 branches covered (0.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

8570 of 9254 relevant lines covered (92.61%)

1651.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.0

/src/types/FloatType.ts

import type { BscType } from './BscType';
import { DoubleType } from './DoubleType';
import { DynamicType } from './DynamicType';
import { IntegerType } from './IntegerType';
import { LongIntegerType } from './LongIntegerType';

export class FloatType implements BscType {
    constructor(
        public typeText?: string
    ) { }

    public isAssignableTo(targetType: BscType) {
        return (
            targetType instanceof FloatType ||
            targetType instanceof DynamicType
        );
    }

    public isConvertibleTo(targetType: BscType) {
        if (
            targetType instanceof DynamicType ||
            targetType instanceof IntegerType ||
            targetType instanceof FloatType ||
            targetType instanceof DoubleType ||
            targetType instanceof LongIntegerType
        ) {
            return true;
        } else {
            return false;
        }
    }

    public toString() {
        return this.typeText ?? 'float';
    }

    public toTypeString(): string {
        return this.toString();
    }
}

1	import type { BscType } from './BscType';
2	import { DoubleType } from './DoubleType';	1✔
3	import { DynamicType } from './DynamicType';	1✔
4	import { IntegerType } from './IntegerType';	1✔
5	import { LongIntegerType } from './LongIntegerType';	1✔
6
7	export class FloatType implements BscType {	1✔
8	constructor(
9	public typeText?: string	96✔
10	) { }
11
12	public isAssignableTo(targetType: BscType) {
13	return (	3✔
14	targetType instanceof FloatType \|\|	5✔
15	targetType instanceof DynamicType
16	);
17	}
18
19	public isConvertibleTo(targetType: BscType) {
20	if (	×
21	targetType instanceof DynamicType \|\|	×
22	targetType instanceof IntegerType \|\|
23	targetType instanceof FloatType \|\|
24	targetType instanceof DoubleType \|\|
25	targetType instanceof LongIntegerType
26	) {
27	return true;	×
28	} else {
29	return false;	×
30	}
31	}
32
33	public toString() {
34	return this.typeText ?? 'float';	7✔
35	}
36
37	public toTypeString(): string {
38	return this.toString();	6✔
39	}
40	}

rokucommunity / brighterscript / #11333

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous