#11333

Committed 20 Dec 2023 03:56PM UTC coverage: 88.145% (+0.006%) from 88.139%

Build Type

push

Committed by

Commit Message

Fix multi-namespace class inheritance transpile bug (#990)

* Add failing unit test

* Fix test case after simplifying too much

* Fix getParentClassIndex always using top-level namespace

Run Details

5669 of 6900 branches covered (0.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

8570 of 9254 relevant lines covered (92.61%)

1651.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

29.41

/src/types/CustomType.ts

import { isCustomType, isDynamicType } from '../astUtils/reflection';
import type { BscType } from './BscType';

export class CustomType implements BscType {

    constructor(public name: string) {
    }

    public toString() {
        return this.name;
    }

    public toTypeString(): string {
        return 'object';
    }

    public isAssignableTo(targetType: BscType) {
        //TODO for now, if the custom types have the same name, assume they're the same thing
        if (isCustomType(targetType) && targetType.name === this.name) {
            return true;
        } else if (isDynamicType(targetType)) {
            return true;
        } else {
            return false;
        }
    }

    public isConvertibleTo(targetType: BscType) {
        return this.isAssignableTo(targetType);
    }
}

1	import { isCustomType, isDynamicType } from '../astUtils/reflection';	1✔
2	import type { BscType } from './BscType';
3
4	export class CustomType implements BscType {	1✔
5
6	constructor(public name: string) {	97✔
7	}
8
9	public toString() {
10	return this.name;	1✔
11	}
12
13	public toTypeString(): string {
14	return 'object';	2✔
15	}
16
17	public isAssignableTo(targetType: BscType) {
18	//TODO for now, if the custom types have the same name, assume they're the same thing
19	if (isCustomType(targetType) && targetType.name === this.name) {	×
20	return true;	×
21	} else if (isDynamicType(targetType)) {	×
22	return true;	×
23	} else {
24	return false;	×
25	}
26	}
27
28	public isConvertibleTo(targetType: BscType) {
29	return this.isAssignableTo(targetType);	×
30	}
31	}

rokucommunity / brighterscript / #11333

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous