2457

pending completion

Build # 2457

Build Type

Pull #2927

travis-ci

Committed by

ehjay

Commit Message

[[FEAT]] Error for literals on rhs of `instanceof`

This patch adds a new error that is used when a literal is found on the
right-hand side of the `instanceof` infix operator. A warning is used when a
function declaration is found.

Literals generate errors:

    x instanceof 0;
    x instanceof '';
    x instanceof null;
    x instanceof undefined;
    x instanceof {};
    x instanceof [];
    x instanceof /./;
    x instanceof ``;

Function declarations generate warnings:

    x instanceof function() {};
    x instanceof function MyUnusableFunction() {};

But this is okay:

    x instanceof /x/.constructor;
    x instanceof "".constructor;

as per GH-2773

References:

    Closes GH-2777

Pull Request Pull Request #2927: [[FEAT]] Error for literals on rhs of `instanceof`

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

3958 of 4053 relevant lines covered (97.66%)

6425.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.94

/src/jshint.js

Build SHA Not Found

The commit SHA "764ef45880c57a21253e821d36a7871ab3279d32" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

jshint / jshint / 2457

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous