7209710539

Committed 14 Dec 2023 01:42PM UTC coverage: 67.202% (-0.6%) from 67.789%

Build # 7209710539

Build Type

Pull #163

github

Committed by

web-flow

Commit Message

Merge 1fad6ab87 into 186814f86

Pull Request Pull Request #163: Generic/AssignmentInCondition: improve sniff code coverage

Run Details

19865 of 29560 relevant lines covered (67.2%)

4.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.84

/src/Standards/PEAR/Sniffs/Classes/ClassDeclarationSniff.php

<?php
/**
 * Checks the declaration of the class is correct.
 *
 * @author    Greg Sherwood <gsherwood@squiz.net>
 * @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
 * @license   https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
 */

namespace PHP_CodeSniffer\Standards\PEAR\Sniffs\Classes;

use PHP_CodeSniffer\Files\File;
use PHP_CodeSniffer\Sniffs\Sniff;

class ClassDeclarationSniff implements Sniff
{


    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        return [
            T_CLASS,
            T_INTERFACE,
            T_TRAIT,
            T_ENUM,
        ];

    }//end register()


    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
     * @param integer                     $stackPtr  The position of the current token in the
     *                                               stack passed in $tokens.
     *
     * @return void
     */
    public function process(File $phpcsFile, $stackPtr)
    {
        $tokens    = $phpcsFile->getTokens();
        $errorData = [strtolower($tokens[$stackPtr]['content'])];

        if (isset($tokens[$stackPtr]['scope_opener']) === false) {
            $error = 'Possible parse error: %s missing opening or closing brace';
            $phpcsFile->addWarning($error, $stackPtr, 'MissingBrace', $errorData);
            return;
        }

        $curlyBrace  = $tokens[$stackPtr]['scope_opener'];
        $lastContent = $phpcsFile->findPrevious(T_WHITESPACE, ($curlyBrace - 1), $stackPtr, true);
        $classLine   = $tokens[$lastContent]['line'];
        $braceLine   = $tokens[$curlyBrace]['line'];
        if ($braceLine === $classLine) {
            $phpcsFile->recordMetric($stackPtr, 'Class opening brace placement', 'same line');
            $error = 'Opening brace of a %s must be on the line after the definition';
            $fix   = $phpcsFile->addFixableError($error, $curlyBrace, 'OpenBraceNewLine', $errorData);
            if ($fix === true) {
                $phpcsFile->fixer->beginChangeset();
                if ($tokens[($curlyBrace - 1)]['code'] === T_WHITESPACE) {
                    $phpcsFile->fixer->replaceToken(($curlyBrace - 1), '');
                }

                $phpcsFile->fixer->addNewlineBefore($curlyBrace);
                $phpcsFile->fixer->endChangeset();
            }

            return;
        } else {
            $phpcsFile->recordMetric($stackPtr, 'Class opening brace placement', 'new line');

            if ($braceLine > ($classLine + 1)) {
                $error = 'Opening brace of a %s must be on the line following the %s declaration; found %s line(s)';
                $data  = [
                    $tokens[$stackPtr]['content'],
                    $tokens[$stackPtr]['content'],
                    ($braceLine - $classLine - 1),
                ];
                $fix   = $phpcsFile->addFixableError($error, $curlyBrace, 'OpenBraceWrongLine', $data);
                if ($fix === true) {
                    $phpcsFile->fixer->beginChangeset();
                    for ($i = ($curlyBrace - 1); $i > $lastContent; $i--) {
                        if ($tokens[$i]['line'] === ($tokens[$curlyBrace]['line'] + 1)) {
                            break;
                        }

                        $phpcsFile->fixer->replaceToken($i, '');
                    }

                    $phpcsFile->fixer->endChangeset();
                }

                return;
            }//end if
        }//end if

        if ($tokens[($curlyBrace + 1)]['content'] !== $phpcsFile->eolChar) {
            $error = 'Opening %s brace must be on a line by itself';

            $nextNonWhitespace = $phpcsFile->findNext(T_WHITESPACE, ($curlyBrace + 1), null, true);
            if ($tokens[$nextNonWhitespace]['code'] === T_PHPCS_IGNORE) {
                // Don't auto-fix if the next thing is a PHPCS ignore annotation.
                $phpcsFile->addError($error, $curlyBrace, 'OpenBraceNotAlone', $errorData);
            } else {
                $fix = $phpcsFile->addFixableError($error, $curlyBrace, 'OpenBraceNotAlone', $errorData);
                if ($fix === true) {
                    $phpcsFile->fixer->addNewline($curlyBrace);
                }
            }
        }

        if ($tokens[($curlyBrace - 1)]['code'] === T_WHITESPACE) {
            $prevContent = $tokens[($curlyBrace - 1)]['content'];
            if ($prevContent === $phpcsFile->eolChar) {
                $spaces = 0;
            } else {
                $spaces = $tokens[($curlyBrace - 1)]['length'];
            }

            $first    = $phpcsFile->findFirstOnLine(T_WHITESPACE, $stackPtr, true);
            $expected = ($tokens[$first]['column'] - 1);
            if ($spaces !== $expected) {
                $error = 'Expected %s spaces before opening brace; %s found';
                $data  = [
                    $expected,
                    $spaces,
                ];

                $fix = $phpcsFile->addFixableError($error, $curlyBrace, 'SpaceBeforeBrace', $data);
                if ($fix === true) {
                    $indent = str_repeat(' ', $expected);
                    if ($spaces === 0) {
                        $phpcsFile->fixer->addContentBefore($curlyBrace, $indent);
                    } else {
                        $phpcsFile->fixer->replaceToken(($curlyBrace - 1), $indent);
                    }
                }
            }
        }//end if

    }//end process()


}//end class

1	<?php
2	/**
3	* Checks the declaration of the class is correct.
4	*
5	* @author Greg Sherwood <gsherwood@squiz.net>
6	* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
7	* @license https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
8	*/
9
10	namespace PHP_CodeSniffer\Standards\PEAR\Sniffs\Classes;
11
12	use PHP_CodeSniffer\Files\File;
13	use PHP_CodeSniffer\Sniffs\Sniff;
14
15	class ClassDeclarationSniff implements Sniff
16	{
17
18
19	/**
20	* Returns an array of tokens this test wants to listen for.
21	*
22	* @return array
23	*/
24	public function register()	3✔
25	{
26	return [	1✔
27	T_CLASS,	3✔
28	T_INTERFACE,	3✔
29	T_TRAIT,	3✔
30	T_ENUM,	3✔
31	];	2✔
32
33	}//end register()
34
35
36	/**
37	* Processes this test, when one of its tokens is encountered.
38	*
39	* @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
40	* @param integer $stackPtr The position of the current token in the
41	* stack passed in $tokens.
42	*
43	* @return void
44	*/
45	public function process(File $phpcsFile, $stackPtr)	3✔
46	{
47	$tokens = $phpcsFile->getTokens();	3✔
48	$errorData = [strtolower($tokens[$stackPtr]['content'])];	3✔
49
50	if (isset($tokens[$stackPtr]['scope_opener']) === false) {	3✔
51	$error = 'Possible parse error: %s missing opening or closing brace';	3✔
52	$phpcsFile->addWarning($error, $stackPtr, 'MissingBrace', $errorData);	3✔
53	return;	3✔
54	}
55
56	$curlyBrace = $tokens[$stackPtr]['scope_opener'];	3✔
57	$lastContent = $phpcsFile->findPrevious(T_WHITESPACE, ($curlyBrace - 1), $stackPtr, true);	3✔
58	$classLine = $tokens[$lastContent]['line'];	3✔
59	$braceLine = $tokens[$curlyBrace]['line'];	3✔
60	if ($braceLine === $classLine) {	3✔
61	$phpcsFile->recordMetric($stackPtr, 'Class opening brace placement', 'same line');	3✔
62	$error = 'Opening brace of a %s must be on the line after the definition';	3✔
63	$fix = $phpcsFile->addFixableError($error, $curlyBrace, 'OpenBraceNewLine', $errorData);	3✔
64	if ($fix === true) {	3✔
65	$phpcsFile->fixer->beginChangeset();	3✔
66	if ($tokens[($curlyBrace - 1)]['code'] === T_WHITESPACE) {	3✔
67	$phpcsFile->fixer->replaceToken(($curlyBrace - 1), '');	3✔
68	}	1✔
69
70	$phpcsFile->fixer->addNewlineBefore($curlyBrace);	3✔
71	$phpcsFile->fixer->endChangeset();	3✔
72	}	1✔
73
74	return;	3✔
75	} else {
76	$phpcsFile->recordMetric($stackPtr, 'Class opening brace placement', 'new line');	3✔
77
78	if ($braceLine > ($classLine + 1)) {	3✔
79	$error = 'Opening brace of a %s must be on the line following the %s declaration; found %s line(s)';	3✔
80	$data = [	1✔
81	$tokens[$stackPtr]['content'],	3✔
82	$tokens[$stackPtr]['content'],	3✔
83	($braceLine - $classLine - 1),	3✔
84	];	2✔
85	$fix = $phpcsFile->addFixableError($error, $curlyBrace, 'OpenBraceWrongLine', $data);	3✔
86	if ($fix === true) {	3✔
87	$phpcsFile->fixer->beginChangeset();	3✔
88	for ($i = ($curlyBrace - 1); $i > $lastContent; $i--) {	3✔
89	if ($tokens[$i]['line'] === ($tokens[$curlyBrace]['line'] + 1)) {	3✔
90	break;	×
91	}
92
93	$phpcsFile->fixer->replaceToken($i, '');	3✔
94	}	1✔
95
96	$phpcsFile->fixer->endChangeset();	3✔
97	}	1✔
98
99	return;	3✔
100	}//end if
101	}//end if
102
103	if ($tokens[($curlyBrace + 1)]['content'] !== $phpcsFile->eolChar) {	3✔
104	$error = 'Opening %s brace must be on a line by itself';	3✔
105
106	$nextNonWhitespace = $phpcsFile->findNext(T_WHITESPACE, ($curlyBrace + 1), null, true);	3✔
107	if ($tokens[$nextNonWhitespace]['code'] === T_PHPCS_IGNORE) {	3✔
108	// Don't auto-fix if the next thing is a PHPCS ignore annotation.
109	$phpcsFile->addError($error, $curlyBrace, 'OpenBraceNotAlone', $errorData);	3✔
110	} else {	1✔
111	$fix = $phpcsFile->addFixableError($error, $curlyBrace, 'OpenBraceNotAlone', $errorData);	3✔
112	if ($fix === true) {	3✔
113	$phpcsFile->fixer->addNewline($curlyBrace);	3✔
114	}	1✔
115	}
116	}	1✔
117
118	if ($tokens[($curlyBrace - 1)]['code'] === T_WHITESPACE) {	3✔
119	$prevContent = $tokens[($curlyBrace - 1)]['content'];	3✔
120	if ($prevContent === $phpcsFile->eolChar) {	3✔
121	$spaces = 0;	3✔
122	} else {	1✔
123	$spaces = $tokens[($curlyBrace - 1)]['length'];	3✔
124	}
125
126	$first = $phpcsFile->findFirstOnLine(T_WHITESPACE, $stackPtr, true);	3✔
127	$expected = ($tokens[$first]['column'] - 1);	3✔
128	if ($spaces !== $expected) {	3✔
129	$error = 'Expected %s spaces before opening brace; %s found';	3✔
130	$data = [	1✔
131	$expected,	3✔
132	$spaces,	3✔
133	];	2✔
134
135	$fix = $phpcsFile->addFixableError($error, $curlyBrace, 'SpaceBeforeBrace', $data);	3✔
136	if ($fix === true) {	3✔
137	$indent = str_repeat(' ', $expected);	3✔
138	if ($spaces === 0) {	3✔
139	$phpcsFile->fixer->addContentBefore($curlyBrace, $indent);	3✔
140	} else {	1✔
141	$phpcsFile->fixer->replaceToken(($curlyBrace - 1), $indent);	3✔
142	}
143	}	1✔
144	}	1✔
145	}//end if	1✔
146
147	}//end process()	2✔
148
149
150	}//end class

PHPCSStandards / PHP_CodeSniffer / 7209710539

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous