7103123871

Committed 05 Dec 2023 03:44PM UTC coverage: 89.273% (-0.02%) from 89.292%

Build # 7103123871

Build Type

push

github

Committed by

web-flow

Commit Message

Do not filter ERC721 transfers (#914)

ERC721 marked as non-trusted are no longer filtered. The main reason behind this is that most token lists work with ERC20 tokens (a non `trusted` token is a token that is not part of such list).

Run Details

1440 of 1758 branches covered (0.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

5276 of 5765 relevant lines covered (91.52%)

154.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.82

/src/routes/transactions/entities/transfers/erc721-transfer.entity.ts

import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
import { Transfer } from '@/routes/transactions/entities/transfers/transfer.entity';

export class Erc721Transfer extends Transfer {
  @ApiProperty()
  tokenAddress: string;
  @ApiProperty()
  tokenId: string;
  @ApiPropertyOptional({ type: String, nullable: true })
  tokenName: string | null;
  @ApiPropertyOptional({ type: String, nullable: true })
  tokenSymbol: string | null;
  @ApiPropertyOptional({ type: String, nullable: true })
  logoUri: string | null;
  @ApiPropertyOptional({ type: Boolean, nullable: true })
  trusted: boolean | null;

  constructor(
    tokenAddress: string,
    tokenId: string,
    tokenName: string | null = null,
    tokenSymbol: string | null = null,
    logoUri: string | null = null,
    trusted: boolean | null = null,
  ) {
    super('ERC721');
    this.tokenAddress = tokenAddress;
    this.tokenId = tokenId;
    this.tokenName = tokenName;
    this.tokenSymbol = tokenSymbol;
    this.logoUri = logoUri;
    this.trusted = trusted;
  }
}

export function isErc721Transfer(
  transfer: Transfer,
): transfer is Erc721Transfer {
  return transfer.type === 'ERC721';
}

1	import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';	78✔
2	import { Transfer } from '@/routes/transactions/entities/transfers/transfer.entity';	78✔
3
4	export class Erc721Transfer extends Transfer {	78✔
5	@ApiProperty()
6	tokenAddress: string;	78✔
7	@ApiProperty()
8	tokenId: string;	78✔
9	@ApiPropertyOptional({ type: String, nullable: true })
10	tokenName: string \| null;	78✔
11	@ApiPropertyOptional({ type: String, nullable: true })
12	tokenSymbol: string \| null;	78✔
13	@ApiPropertyOptional({ type: String, nullable: true })
14	logoUri: string \| null;	78✔
15	@ApiPropertyOptional({ type: Boolean, nullable: true })
16	trusted: boolean \| null;	78✔
17
18	constructor(
19	tokenAddress: string,
20	tokenId: string,
21	tokenName: string \| null = null,	×
22	tokenSymbol: string \| null = null,	×
23	logoUri: string \| null = null,	×
24	trusted: boolean \| null = null,	1✔
25	) {
26	super('ERC721');	10✔
27	this.tokenAddress = tokenAddress;	10✔
28	this.tokenId = tokenId;	10✔
29	this.tokenName = tokenName;	10✔
30	this.tokenSymbol = tokenSymbol;	10✔
31	this.logoUri = logoUri;	10✔
32	this.trusted = trusted;	10✔
33	}
34	}
35
36	export function isErc721Transfer(	78✔
37	transfer: Transfer,
38	): transfer is Erc721Transfer {
UNCOV 39	return transfer.type === 'ERC721';	×
40	}

safe-global / safe-client-gateway / 7103123871

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous