7089346302

Committed 04 Dec 2023 04:11PM UTC coverage: 76.647% (+0.2%) from 76.423%

Build # 7089346302

Build Type

Pull #1855

github

Committed by

web-flow

Commit Message

Merge bd41b718e into 195bed39c

Pull Request Pull Request #1855: Move WebGL resource tests under modules/core-tests/

Run Details

1851 of 2471 branches covered (0.0%)

Branch coverage included in aggregate %.

93 of 160 new or added lines in 6 files covered. (58.13%)

2 existing lines in 1 file now uncovered.

35056 of 45681 relevant lines covered (76.74%)

43.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

17.54

/modules/webgl/test/adapter/resources/webgl-vertex-array.spec.ts

// luma.gl, MIT license
// Copyright (c) vis.gl contributors

import test from 'tape-promise/tape';
import {getWebGLTestDevices} from '@luma.gl/test-utils';

import {GL} from '@luma.gl/constants';
import {BufferWithAccessor, WEBGLVertexArray} from '@luma.gl/webgl';

// TODO(v9): Fix and re-enable test.
test.skip('WEBGLVertexArray#divisors', t => {
  for (const device of getWebGLTestDevices()) {
    const vertexArray = new WEBGLVertexArray(device);

    const maxVertexAttributes = device.limits.maxVertexAttributes;

    for (let i = 0; i < maxVertexAttributes; i++) {
      device.gl2?.bindVertexArray(vertexArray.handle);
      const divisor = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_DIVISOR);
      device.gl2?.bindVertexArray(null);

      t.equal(divisor, 0, `vertex attribute ${i} should have 0 divisor`);
    }

    vertexArray.destroy();
  }
  t.end();
});

// TODO(v9): Fix and re-enable test.
test.skip('WEBGLVertexArray#enable', t => {
  for (const device of getWebGLTestDevices()) {
    const renderPipeline = device.createRenderPipeline({});
    const vertexArray = device.createVertexArray({renderPipeline}) as WEBGLVertexArray;

    const maxVertexAttributes = device.limits.maxVertexAttributes;
    t.ok(maxVertexAttributes >= 8, 'maxVertexAttributes >= 8');

    for (let i = 1; i < maxVertexAttributes; i++) {
      device.gl2?.bindVertexArray(vertexArray.handle);
      const enabled = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_ENABLED);
      device.gl2?.bindVertexArray(null);

      t.equal(enabled, false, `vertex attribute ${i} should initially be disabled`);
    }

    for (let i = 0; i < maxVertexAttributes; i++) {
      // @ts-ignore
      vertexArray._enable(i);
    }

    for (let i = 0; i < maxVertexAttributes; i++) {
      device.gl2?.bindVertexArray(vertexArray.handle);
      const enabled = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_ENABLED);
      device.gl2?.bindVertexArray(null);

      t.equal(enabled, true, `vertex attribute ${i} should now be enabled`);
    }

    for (let i = 1; i < maxVertexAttributes; i++) {
      // @ts-ignore
      vertexArray._enable(i, false);
    }

    // t.equal(vertexArray.getParameter(GL.VERTEX_ATTRIB_ARRAY_ENABLED, {location: 0}), true,
    //   'vertex attribute 0 should **NOT** be disabled');

    for (let i = 1; i < maxVertexAttributes; i++) {
      device.gl2?.bindVertexArray(vertexArray.handle);
      const enabled = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_ENABLED);
      device.gl2?.bindVertexArray(null);

      t.equal(enabled, false, `vertex attribute ${i} should now be disabled`);
    }

    vertexArray.destroy();
    renderPipeline.destroy();
  }

  t.end();
});

// TODO(v9): Fix and re-enable test.
test.skip('WEBGLVertexArray#getConstantBuffer', t => {
  for (const device of getWebGLTestDevices()) {
    const vertexArray = new WEBGLVertexArray(device);

    let buffer = vertexArray.getConstantBuffer(100, new Float32Array([5, 4, 3])) as BufferWithAccessor;

    t.equal(buffer.byteLength, 1200, 'byteLength should match');
    t.equal(buffer.bytesUsed, 1200, 'bytesUsed should match');

    buffer = vertexArray.getConstantBuffer(5, new Float32Array([5, 3, 2])) as BufferWithAccessor;
    t.equal(buffer.byteLength, 1200, 'byteLength should be unchanged');
    t.equal(buffer.bytesUsed, 60, 'bytesUsed should have changed');

    vertexArray.destroy();

    // if (device.isWebGL2) {
    //   const vertexArray2 = WEBGLVertexArray.getDefaultArray(gl2);
    //   buffer = vertexArray2.getConstantBuffer(5, new Float32Array([5, 3, 2]));
    //   t.equal(buffer.byteLength, 60, 'byteLength should be unchanged');
    //   t.equal(buffer.bytesUsed, 60, 'bytesUsed should have changed');
    //   const data = buffer.getData();
    //   t.deepEqual(
    //     data,
    //     new Float32Array([5, 3, 2, 5, 3, 2, 5, 3, 2, 5, 3, 2, 5, 3, 2]),
    //     'Constant buffer was correctly set'
    //   );
    //   t.comment(JSON.stringify(data));
    // }
  }
  t.end();
});

1	// luma.gl, MIT license	1✔
2	// Copyright (c) vis.gl contributors	1✔
3		1✔
4	import test from 'tape-promise/tape';	1✔
5	import {getWebGLTestDevices} from '@luma.gl/test-utils';	1✔
6		1✔
7	import {GL} from '@luma.gl/constants';	1✔
8	import {BufferWithAccessor, WEBGLVertexArray} from '@luma.gl/webgl';	1✔
9		1✔
10	// TODO(v9): Fix and re-enable test.	1✔
11	test.skip('WEBGLVertexArray#divisors', t => {	1✔
12	for (const device of getWebGLTestDevices()) {	×
13	const vertexArray = new WEBGLVertexArray(device);	×
14		×
15	const maxVertexAttributes = device.limits.maxVertexAttributes;	×
16		×
17	for (let i = 0; i < maxVertexAttributes; i++) {	×
18	device.gl2?.bindVertexArray(vertexArray.handle);	×
19	const divisor = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_DIVISOR);	×
20	device.gl2?.bindVertexArray(null);	×
21		×
22	t.equal(divisor, 0, `vertex attribute ${i} should have 0 divisor`);	×
23	}	×
24		×
25	vertexArray.destroy();	×
26	}	×
27	t.end();	×
28	});	1✔
29		1✔
30	// TODO(v9): Fix and re-enable test.	1✔
31	test.skip('WEBGLVertexArray#enable', t => {	1✔
32	for (const device of getWebGLTestDevices()) {	×
33	const renderPipeline = device.createRenderPipeline({});	×
34	const vertexArray = device.createVertexArray({renderPipeline}) as WEBGLVertexArray;	×
35		×
36	const maxVertexAttributes = device.limits.maxVertexAttributes;	×
37	t.ok(maxVertexAttributes >= 8, 'maxVertexAttributes >= 8');	×
38		×
39	for (let i = 1; i < maxVertexAttributes; i++) {	×
40	device.gl2?.bindVertexArray(vertexArray.handle);	×
41	const enabled = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_ENABLED);	×
42	device.gl2?.bindVertexArray(null);	×
43		×
44	t.equal(enabled, false, `vertex attribute ${i} should initially be disabled`);	×
45	}	×
46		×
47	for (let i = 0; i < maxVertexAttributes; i++) {	×
48	// @ts-ignore	×
49	vertexArray._enable(i);	×
50	}	×
51		×
52	for (let i = 0; i < maxVertexAttributes; i++) {	×
53	device.gl2?.bindVertexArray(vertexArray.handle);	×
54	const enabled = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_ENABLED);	×
55	device.gl2?.bindVertexArray(null);	×
56		×
57	t.equal(enabled, true, `vertex attribute ${i} should now be enabled`);	×
58	}	×
59		×
60	for (let i = 1; i < maxVertexAttributes; i++) {	×
61	// @ts-ignore	×
62	vertexArray._enable(i, false);	×
63	}	×
64		×
65	// t.equal(vertexArray.getParameter(GL.VERTEX_ATTRIB_ARRAY_ENABLED, {location: 0}), true,	×
66	// 'vertex attribute 0 should NOT be disabled');	×
67		×
68	for (let i = 1; i < maxVertexAttributes; i++) {	×
69	device.gl2?.bindVertexArray(vertexArray.handle);	×
70	const enabled = device.gl.getVertexAttrib(i, GL.VERTEX_ATTRIB_ARRAY_ENABLED);	×
71	device.gl2?.bindVertexArray(null);	×
72		×
73	t.equal(enabled, false, `vertex attribute ${i} should now be disabled`);	×
74	}	×
75		×
76	vertexArray.destroy();	×
77	renderPipeline.destroy();	×
78	}	×
79		×
80	t.end();	×
81	});	1✔
82		1✔
83	// TODO(v9): Fix and re-enable test.	1✔
84	test.skip('WEBGLVertexArray#getConstantBuffer', t => {	1✔
85	for (const device of getWebGLTestDevices()) {	×
86	const vertexArray = new WEBGLVertexArray(device);	×
87		×
NEW 88	let buffer = vertexArray.getConstantBuffer(100, new Float32Array([5, 4, 3])) as BufferWithAccessor;	×
89		×
90	t.equal(buffer.byteLength, 1200, 'byteLength should match');	×
91	t.equal(buffer.bytesUsed, 1200, 'bytesUsed should match');	×
92		×
NEW 93	buffer = vertexArray.getConstantBuffer(5, new Float32Array([5, 3, 2])) as BufferWithAccessor;	×
94	t.equal(buffer.byteLength, 1200, 'byteLength should be unchanged');	×
95	t.equal(buffer.bytesUsed, 60, 'bytesUsed should have changed');	×
96		×
97	vertexArray.destroy();	×
98		×
NEW 99	// if (device.isWebGL2) {	×
NEW 100	// const vertexArray2 = WEBGLVertexArray.getDefaultArray(gl2);	×
NEW 101	// buffer = vertexArray2.getConstantBuffer(5, new Float32Array([5, 3, 2]));	×
NEW 102	// t.equal(buffer.byteLength, 60, 'byteLength should be unchanged');	×
NEW 103	// t.equal(buffer.bytesUsed, 60, 'bytesUsed should have changed');	×
NEW 104	// const data = buffer.getData();	×
NEW 105	// t.deepEqual(	×
NEW 106	// data,	×
NEW 107	// new Float32Array([5, 3, 2, 5, 3, 2, 5, 3, 2, 5, 3, 2, 5, 3, 2]),	×
NEW 108	// 'Constant buffer was correctly set'	×
NEW 109	// );	×
NEW 110	// t.comment(JSON.stringify(data));	×
NEW 111	// }	×
112	}	×
113	t.end();	×
114	});	1✔

visgl / luma.gl / 7089346302

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous