7065053339

Committed 01 Dec 2023 08:47PM UTC coverage: 97.272% (-0.03%) from 97.3%

Build # 7065053339

Build Type

Pull #54

github

Committed by

Bryce-Soghigian

Commit Message

Revert "Merge pull request #13 from Azure/bsoghigian/removing-sdk-retries"

This reverts commit 19d06fd74, reversing
changes made to 9bfdf1626.

Pull Request Pull Request #54: Revert "Merge pull request #13 from Azure/bsoghigian/removing-sdk-ret…

Run Details

0 of 15 new or added lines in 1 file covered. (0.0%)

33334 of 34269 relevant lines covered (97.27%)

35.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/pkg/utils/opts/armopts.go

/*
Portions Copyright (c) Microsoft Corporation.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package opts

import (
        "net/http"
        "time"

        "github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
        "github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
        "github.com/Azure/karpenter/pkg/auth"
)

func DefaultArmOpts() *arm.ClientOptions {
        opts := &arm.ClientOptions{}
        opts.Telemetry = DefaultTelemetryOpts()
        opts.Retry = DefaultRetryOpts()
        opts.Transport = defaultHTTPClient
        return opts
}

func DefaultRetryOpts() policy.RetryOptions {
        return policy.RetryOptions{
                MaxRetries: 20,
                // Note the default retry behavior is exponential backoff
                RetryDelay: time.Second * 5,
                // TODO: bsoghigian: Investigate if we want to leverage some of the status codes other than the defaults.
                // the defaults are // StatusCodes specifies the HTTP status codes that indicate the operation should be retried.
                // A nil slice will use the following values.
                //   http.StatusRequestTimeout      408
                //   http.StatusTooManyRequests     429
                //   http.StatusInternalServerError 500
                //   http.StatusBadGateway          502
                //   http.StatusServiceUnavailable  503
                //   http.StatusGatewayTimeout      504
                // Specifying values will replace the default values.
                // Specifying an empty slice will disable retries for HTTP status codes.
                // StatusCodes: nil,
        }
}

func DefaultHTTPClient() *http.Client {
        return defaultHTTPClient
}

func DefaultTelemetryOpts() policy.TelemetryOptions {
        return policy.TelemetryOptions{
                ApplicationID: auth.GetUserAgentExtension(),
        }
}

1	/*
2	Portions Copyright (c) Microsoft Corporation.
3
4	Licensed under the Apache License, Version 2.0 (the "License");
5	you may not use this file except in compliance with the License.
6	You may obtain a copy of the License at
7
8	http://www.apache.org/licenses/LICENSE-2.0
9
10	Unless required by applicable law or agreed to in writing, software
11	distributed under the License is distributed on an "AS IS" BASIS,
12	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	See the License for the specific language governing permissions and
14	limitations under the License.
15	*/
16
17	package opts
18
19	import (
20	"net/http"
21	"time"
22
23	"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
24	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
25	"github.com/Azure/karpenter/pkg/auth"
26	)
27
28	func DefaultArmOpts() *arm.ClientOptions {	×
29	opts := &arm.ClientOptions{}	×
30	opts.Telemetry = DefaultTelemetryOpts()	×
31	opts.Retry = DefaultRetryOpts()	×
32	opts.Transport = defaultHTTPClient	×
33	return opts	×
34	}	×
35
36	func DefaultRetryOpts() policy.RetryOptions {	×
37	return policy.RetryOptions{	×
NEW 38	MaxRetries: 20,	×
NEW 39	// Note the default retry behavior is exponential backoff	×
NEW 40	RetryDelay: time.Second * 5,	×
NEW 41	// TODO: bsoghigian: Investigate if we want to leverage some of the status codes other than the defaults.	×
NEW 42	// the defaults are // StatusCodes specifies the HTTP status codes that indicate the operation should be retried.	×
NEW 43	// A nil slice will use the following values.	×
NEW 44	// http.StatusRequestTimeout 408	×
NEW 45	// http.StatusTooManyRequests 429	×
NEW 46	// http.StatusInternalServerError 500	×
NEW 47	// http.StatusBadGateway 502	×
NEW 48	// http.StatusServiceUnavailable 503	×
NEW 49	// http.StatusGatewayTimeout 504	×
NEW 50	// Specifying values will replace the default values.	×
NEW 51	// Specifying an empty slice will disable retries for HTTP status codes.	×
NEW 52	// StatusCodes: nil,	×
53	}	×
54	}	×
55
56	func DefaultHTTPClient() *http.Client {	×
57	return defaultHTTPClient	×
58	}	×
59
60	func DefaultTelemetryOpts() policy.TelemetryOptions {	×
61	return policy.TelemetryOptions{	×
62	ApplicationID: auth.GetUserAgentExtension(),	×
63	}	×
64	}	×

Azure / karpenter / 7065053339

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous