7004843404

Committed 27 Nov 2023 11:48AM UTC coverage: 49.206% (-0.03%) from 49.232%

Build # 7004843404

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #20858 from Yoast/improve-copy-in-the-ftc-57

Run Details

15305 of 31104 relevant lines covered (49.21%)

4.03 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/admin/class-bulk-description-editor-list-table.php

<?php
/**
 * WPSEO plugin file.
 *
 * @package WPSEO\Admin\Bulk Editor
 * @since   1.5.0
 */

/**
 * Implements table for bulk description editing.
 */
class WPSEO_Bulk_Description_List_Table extends WPSEO_Bulk_List_Table {

        /**
         * Current type for this class will be (meta) description.
         *
         * @var string
         */
        protected $page_type = 'description';

        /**
         * Settings with are used in __construct.
         *
         * @var array
         */
        protected $settings = [
                'singular' => 'wpseo_bulk_description',
                'plural'   => 'wpseo_bulk_descriptions',
                'ajax'     => true,
        ];

        /**
         * The field in the database where meta field is saved.
         *
         * @var string
         */
        protected $target_db_field = 'metadesc';

        /**
         * The columns shown on the table.
         *
         * @return array
         */
        public function get_columns() {
                $columns = [
                        'col_existing_yoast_seo_metadesc' => __( 'Existing Yoast Meta Description', 'wordpress-seo' ),
                        'col_new_yoast_seo_metadesc'      => __( 'New Yoast Meta Description', 'wordpress-seo' ),
                ];

                return $this->merge_columns( $columns );
        }

        /**
         * Parse the metadescription.
         *
         * @param string $column_name Column name.
         * @param object $record      Data object.
         * @param string $attributes  HTML attributes.
         *
         * @return string
         */
        protected function parse_page_specific_column( $column_name, $record, $attributes ) {
                switch ( $column_name ) {
                        case 'col_new_yoast_seo_metadesc':
                                return sprintf(
                                        '<textarea id="%1$s" name="%1$s" class="wpseo-new-metadesc" data-id="%2$s" aria-labelledby="col_new_yoast_seo_metadesc"></textarea>',
                                        esc_attr( 'wpseo-new-metadesc-' . $record->ID ),
                                        esc_attr( $record->ID )
                                );

                        case 'col_existing_yoast_seo_metadesc':
                                // @todo Inconsistent return/echo behavior R.
                                // I traced the escaping of the attributes to WPSEO_Bulk_List_Table::column_attributes. Alexander.
                                // The output of WPSEO_Bulk_List_Table::parse_meta_data_field is properly escaped.
                                // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
                                echo $this->parse_meta_data_field( $record->ID, $attributes );
                                break;
                }
        }
}

1	<?php
2	/**
3	* WPSEO plugin file.
4	*
5	* @package WPSEO\Admin\Bulk Editor
6	* @since 1.5.0
7	*/
8
9	/**
10	* Implements table for bulk description editing.
11	*/
12	class WPSEO_Bulk_Description_List_Table extends WPSEO_Bulk_List_Table {
13
14	/**
15	* Current type for this class will be (meta) description.
16	*
17	* @var string
18	*/
19	protected $page_type = 'description';
20
21	/**
22	* Settings with are used in __construct.
23	*
24	* @var array
25	*/
26	protected $settings = [
27	'singular' => 'wpseo_bulk_description',
28	'plural' => 'wpseo_bulk_descriptions',
29	'ajax' => true,
30	];
31
32	/**
33	* The field in the database where meta field is saved.
34	*
35	* @var string
36	*/
37	protected $target_db_field = 'metadesc';
38
39	/**
40	* The columns shown on the table.
41	*
42	* @return array
43	*/
44	public function get_columns() {	×
45	$columns = [	×
46	'col_existing_yoast_seo_metadesc' => __( 'Existing Yoast Meta Description', 'wordpress-seo' ),	×
47	'col_new_yoast_seo_metadesc' => __( 'New Yoast Meta Description', 'wordpress-seo' ),	×
48	];	×
49
50	return $this->merge_columns( $columns );	×
51	}
52
53	/**
54	* Parse the metadescription.
55	*
56	* @param string $column_name Column name.
57	* @param object $record Data object.
58	* @param string $attributes HTML attributes.
59	*
60	* @return string
61	*/
62	protected function parse_page_specific_column( $column_name, $record, $attributes ) {	×
63	switch ( $column_name ) {
64	case 'col_new_yoast_seo_metadesc':	×
65	return sprintf(	×
66	'<textarea id="%1$s" name="%1$s" class="wpseo-new-metadesc" data-id="%2$s" aria-labelledby="col_new_yoast_seo_metadesc"></textarea>',	×
67	esc_attr( 'wpseo-new-metadesc-' . $record->ID ),	×
68	esc_attr( $record->ID )	×
69	);	×
70
71	case 'col_existing_yoast_seo_metadesc':	×
72	// @todo Inconsistent return/echo behavior R.
73	// I traced the escaping of the attributes to WPSEO_Bulk_List_Table::column_attributes. Alexander.
74	// The output of WPSEO_Bulk_List_Table::parse_meta_data_field is properly escaped.
75	// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
76	echo $this->parse_meta_data_field( $record->ID, $attributes );	×
77	break;	×
78	}
79	}
80	}

Yoast / wordpress-seo / 7004843404

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous