6874151195

Committed 15 Nov 2023 07:19AM UTC coverage: 87.265% (-0.1%) from 87.406%

Build # 6874151195

Build Type

Pull #161

github

Committed by

Nuzhy-Deriv

Commit Message

fix: padding issues in tablet navigation

Pull Request Pull Request #161: nuzhy/navigation bar fixes

Run Details

187 of 261 branches covered (0.0%)

Branch coverage included in aggregate %.

11 of 30 new or added lines in 8 files covered. (36.67%)

10 existing lines in 3 files now uncovered.

6549 of 7458 relevant lines covered (87.81%)

3.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

28.57

/libs/blocks/src/lib/navigation/desktop/desktop.nav-item.tsx

import { CustomLink } from '@deriv-com/components';
import { useNavigation } from '@deriv-com/hooks';
import { NavItem } from '@deriv-com/providers';
import { Text } from '@deriv/quill-design';
import React from 'react';

export interface DesktopNavItemProps {
  item: NavItem;
  navItemName: string;
}

export const DesktopNavItem: React.FC<DesktopNavItemProps> = ({
  item,
  navItemName,
}) => {
  const { onListItemHover } = useNavigation();

  return (
    <li
      className="flex h-full items-center justify-center px-general-lg text-center"
      onMouseEnter={() => {
        if (item.type === 'nav-dropdown') {
          onListItemHover?.(navItemName);
        }
      }}
    >
      {item.type === 'direct' ? (
        <CustomLink
          className="text-typography-default"
          href={item.href}
          onMouseEnter={() => {
            onListItemHover?.(navItemName);
          }}
        >
          {item.text}
        </CustomLink>
      ) : (
        <Text
          size="sm"
          className="cursor-pointer text-typography-default hover:text-typography-link"
        >
          {item.text}
        </Text>
      )}
    </li>
  );
};

export default DesktopNavItem;

1	import { CustomLink } from '@deriv-com/components';	2✔
2	import { useNavigation } from '@deriv-com/hooks';	2✔
3	import { NavItem } from '@deriv-com/providers';	2✔
4	import { Text } from '@deriv/quill-design';	2✔
5	import React from 'react';	2✔
6		2✔
7	export interface DesktopNavItemProps {	2✔
8	item: NavItem;	2✔
9	navItemName: string;	2✔
10	}	2✔
11		2✔
12	export const DesktopNavItem: React.FC<DesktopNavItemProps> = ({	2✔
13	item,	×
14	navItemName,	×
15	}) => {	×
16	const { onListItemHover } = useNavigation();	×
17		×
18	return (	×
19	<li	×
20	className="flex h-full items-center justify-center px-general-lg text-center"	×
21	onMouseEnter={() => {	×
22	if (item.type === 'nav-dropdown') {	×
23	onListItemHover?.(navItemName);	×
24	}	×
25	}}	×
26	>	×
27	{item.type === 'direct' ? (	×
28	<CustomLink	×
NEW 29	className="text-typography-default"	×
30	href={item.href}	×
31	onMouseEnter={() => {	×
32	onListItemHover?.(navItemName);	×
33	}}	×
34	>	×
35	{item.text}	×
36	</CustomLink>	×
37	) : (	×
NEW 38	<Text	×
NEW 39	size="sm"	×
NEW 40	className="cursor-pointer text-typography-default hover:text-typography-link"	×
NEW 41	>	×
42	{item.text}	×
43	</Text>	×
44	)}	×
UNCOV 45	</li>	×
UNCOV 46	);	×
UNCOV 47	};	×
48		2✔
49	export default DesktopNavItem;	2✔

deriv-com / deriv-com-v2 / 6874151195

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous