#3666

Committed 26 Oct 2023 04:47PM UTC coverage: 66.029% (-9.1%) from 75.156%

Build # #3666

Build Type

push

Committed by

Commit Message

opengrok web project code smell fixes (#4457)

---------

Signed-off-by: Gino Augustine <ginoaugustine@gmail.com>

Run Details

19 of 19 new or added lines in 4 files covered. (100.0%)

38701 of 58612 relevant lines covered (66.03%)

0.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.0

/opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/php/PhpAnalyzer.java

/*
 * CDDL HEADER START
 *
 * The contents of this file are subject to the terms of the
 * Common Development and Distribution License (the "License").
 * You may not use this file except in compliance with the License.
 *
 * See LICENSE.txt included in this distribution for the specific
 * language governing permissions and limitations under the License.
 *
 * When distributing Covered Code, include this CDDL HEADER in each
 * file and include the License file at LICENSE.txt.
 * If applicable, add the following below this CDDL HEADER, with the
 * fields enclosed by brackets "[]" replaced with your own identifying
 * information: Portions Copyright [yyyy] [name of copyright owner]
 *
 * CDDL HEADER END
 */

/*
 * Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved.
 * Portions Copyright (c) 2017, 2020, Chris Fraire <cfraire@me.com>.
 */
package org.opengrok.indexer.analysis.php;

import java.io.Reader;
import org.opengrok.indexer.analysis.AbstractAnalyzer;
import org.opengrok.indexer.analysis.AnalyzerFactory;
import org.opengrok.indexer.analysis.JFlexTokenizer;
import org.opengrok.indexer.analysis.JFlexXref;
import org.opengrok.indexer.analysis.plain.AbstractSourceCodeAnalyzer;

/**
 *
 * @author Miroslav Osladil
 */
@SuppressWarnings("java:S110")
public class PhpAnalyzer extends AbstractSourceCodeAnalyzer {

    /**
     * Creates a new instance of PhpAnalyzer.
     * @param factory defined instance for the analyzer
     */
    protected PhpAnalyzer(AnalyzerFactory factory) {
        super(factory, () -> new JFlexTokenizer(new PhpSymbolTokenizer(
                AbstractAnalyzer.DUMMY_READER)));
    }

    /**
     * @return {@code "PHP"}
     */
    @Override
    public String getCtagsLang() {
        return "PHP";
    }

    /**
     * Gets a version number to be used to tag processed documents so that
     * re-analysis can be re-done later if a stored version number is different
     * from the current implementation.
     * @return 20180208_00
     */
    @Override
    protected int getSpecializedVersionNo() {
        return 20180208_00; // Edit comment above too!
    }

    /**
     * Creates a wrapped {@link PhpXref} instance.
     * @param reader the data to produce xref for
     * @return a defined instance
     */
    @Override
    protected JFlexXref newXref(Reader reader) {
        return new JFlexXref(new PhpXref(reader));
    }
}

1	/*
2	* CDDL HEADER START
3	*
4	* The contents of this file are subject to the terms of the
5	* Common Development and Distribution License (the "License").
6	* You may not use this file except in compliance with the License.
7	*
8	* See LICENSE.txt included in this distribution for the specific
9	* language governing permissions and limitations under the License.
10	*
11	* When distributing Covered Code, include this CDDL HEADER in each
12	* file and include the License file at LICENSE.txt.
13	* If applicable, add the following below this CDDL HEADER, with the
14	* fields enclosed by brackets "[]" replaced with your own identifying
15	* information: Portions Copyright [yyyy] [name of copyright owner]
16	*
17	* CDDL HEADER END
18	*/
19
20	/*
21	* Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved.
22	* Portions Copyright (c) 2017, 2020, Chris Fraire <cfraire@me.com>.
23	*/
24	package org.opengrok.indexer.analysis.php;
25
26	import java.io.Reader;
27	import org.opengrok.indexer.analysis.AbstractAnalyzer;
28	import org.opengrok.indexer.analysis.AnalyzerFactory;
29	import org.opengrok.indexer.analysis.JFlexTokenizer;
30	import org.opengrok.indexer.analysis.JFlexXref;
31	import org.opengrok.indexer.analysis.plain.AbstractSourceCodeAnalyzer;
32
33	/**
34	*
35	* @author Miroslav Osladil
36	*/
37	@SuppressWarnings("java:S110")
38	public class PhpAnalyzer extends AbstractSourceCodeAnalyzer {
39
40	/**
41	* Creates a new instance of PhpAnalyzer.
42	* @param factory defined instance for the analyzer
43	*/
44	protected PhpAnalyzer(AnalyzerFactory factory) {
45	super(factory, () -> new JFlexTokenizer(new PhpSymbolTokenizer(	1✔
46	AbstractAnalyzer.DUMMY_READER)));
47	}	1✔
48
49	/**
50	* @return {@code "PHP"}
51	*/
52	@Override
53	public String getCtagsLang() {
54	return "PHP";	1✔
55	}
56
57	/**
58	* Gets a version number to be used to tag processed documents so that
59	* re-analysis can be re-done later if a stored version number is different
60	* from the current implementation.
61	* @return 20180208_00
62	*/
63	@Override
64	protected int getSpecializedVersionNo() {
65	return 20180208_00; // Edit comment above too!	1✔
66	}
67
68	/**
69	* Creates a wrapped {@link PhpXref} instance.
70	* @param reader the data to produce xref for
71	* @return a defined instance
72	*/
73	@Override
74	protected JFlexXref newXref(Reader reader) {
75	return new JFlexXref(new PhpXref(reader));	×
76	}
77	}

oracle / opengrok / #3666

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous