48389652

Committed 28 Oct 2023 06:22PM UTC coverage: 92.443% (+0.5%) from 91.9%

Build # 48389652

Build Type

push

appveyor

Committed by

web-flow

Commit Message

MPEG4 Cleanup (#88)

* Round one

* Round 2

* Fixing up mpeg4box file

* Fix names of box types to match style

* Fix names of box types to match style

* Separate boxes into separate files ... not working yet.

* Decomposing handler type to a bytevector. This is clumsy but will be cleaned up shortly

* Moving rendering to a utility class. Fixes cyclic dependencies

* Adding stuff to index and moving things around to let tests run

* Fixing iso handler box that was broken

* Public fields to properties

* Removing redundant variable typing

* Removing redundant casts

* Removing child factory from isoAudioSampleEntry.ts

* Removing child factory from appleAnnotationBox.ts

* Removing child factory from appleItemListBox.ts and isoMetaBox.ts

* Removing child factory from isoSampleDescriptionBox.ts

* Removing child factory from isoSampleTableBox.ts and isoUserDataBox.ts

* Child factories have been outlawed

* Introduce a handler type class

* Simplify the mpeg4boxtype class

* handler types in a different class

* Rewrite the get* methods

* Some tests

* Single itunes tag tests

* Performer roles (bug fixed), genres

* 99% coverage of appletag

* Pretty much the last cleanup I want to do before another release cycle.

* Leaving a todo

* Ok two more tweaks

Run Details

3250 of 4147 branches covered (0.0%)

Branch coverage included in aggregate %.

1763 of 1763 new or added lines in 39 files covered. (100.0%)

26757 of 28313 relevant lines covered (94.5%)

422.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

28.57

/src/mpeg4/boxes/textBox.ts

import Mpeg4Box from "./mpeg4Box";
import Mpeg4BoxHeader from "../mpeg4BoxHeader";
import {ByteVector} from "../../byteVector";
import {File} from "../../file";

/**
 * Represents an MP4 text box
 */
export default class TextBox extends Mpeg4Box {
    /**
     * Private constructor to force construction via static functions.
     */
    private constructor() {
        super();
    }

    /**
     * Constructs and initializes a new instance of @see TextBox with a provided header and handler
     * by reading the contents from a specified file.
     * @param header A @see Mpeg4BoxHeader object containing the header to use for the new instance.
     * @param file A @see File object to read the contents of the box from.
     * @param handlerType Type of the handler box object containing the handler that applies to the
     *     new instance, or undefined if no handler applies.
     * @returns A new instance of @see TextBox
     */
    public static fromFile(header: Mpeg4BoxHeader, file: File, handlerType: ByteVector): TextBox {
        const instance = new TextBox();
        instance.initializeFromHeader(header, handlerType);
        instance.data = instance.loadData(file);

        return instance;
    }
}

1	import Mpeg4Box from "./mpeg4Box";	1✔
2	import Mpeg4BoxHeader from "../mpeg4BoxHeader";
3	import {ByteVector} from "../../byteVector";
4	import {File} from "../../file";
5
6	/**
7	* Represents an MP4 text box
8	*/
9	export default class TextBox extends Mpeg4Box {	1✔
10	/**
11	* Private constructor to force construction via static functions.
12	*/
13	private constructor() {
14	super();	×
15	}
16
17	/**
18	* Constructs and initializes a new instance of @see TextBox with a provided header and handler
19	* by reading the contents from a specified file.
20	* @param header A @see Mpeg4BoxHeader object containing the header to use for the new instance.
21	* @param file A @see File object to read the contents of the box from.
22	* @param handlerType Type of the handler box object containing the handler that applies to the
23	* new instance, or undefined if no handler applies.
24	* @returns A new instance of @see TextBox
25	*/
26	public static fromFile(header: Mpeg4BoxHeader, file: File, handlerType: ByteVector): TextBox {
27	const instance = new TextBox();	×
28	instance.initializeFromHeader(header, handlerType);	×
29	instance.data = instance.loadData(file);	×
30
31	return instance;	×
32	}
33	}

benrr101 / node-taglib-sharp / 48389652

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous