6676852353

Committed 28 Oct 2023 12:23PM UTC coverage: 85.016% (+0.003%) from 85.013%

Build # 6676852353

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #79 from CMU-17313Q/integrating-jshint

Integrating the JShint Tool

Run Details

10221 of 13255 branches covered (0.0%)

Branch coverage included in aggregate %.

23 of 26 new or added lines in 17 files covered. (88.46%)

3 existing lines in 2 files now uncovered.

22624 of 25379 relevant lines covered (89.14%)

3228.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.36

/src/socket.io/categories.js

'use strict';

const categories = require('../categories');
const privileges = require('../privileges');
const user = require('../user');
const topics = require('../topics');

const SocketCategories = module.exports;

require('./categories/search')(SocketCategories);

SocketCategories.getRecentReplies = async function (socket, cid) {
    return await categories.getRecentReplies(cid, socket.uid, 0, 4);
};

SocketCategories.get = async function (socket) {
    async function getCategories() {
        const cids = await categories.getCidsByPrivilege('categories:cid', socket.uid, 'find');
        return await categories.getCategoriesData(cids);
    }
    const [isAdmin, categoriesData] = await Promise.all([
        user.isAdministrator(socket.uid),
        getCategories(),
    ]);
    return categoriesData.filter(category => category && (!category.disabled || isAdmin));
};

SocketCategories.getWatchedCategories = async function (socket) {
    const [categoriesData, ignoredCids] = await Promise.all([
        categories.getCategoriesByPrivilege('cid:0:children', socket.uid, 'find'),
        user.getIgnoredCategories(socket.uid),
    ]);
    return categoriesData.filter(category => category && !ignoredCids.includes(String(category.cid)));
};

SocketCategories.loadMore = async function (socket, data) {
    if (!data) {
        throw new Error('[[error:invalid-data]]');
    }
    data.query = data.query || {};
    const [userPrivileges, settings, targetUid] = await Promise.all([
        privileges.categories.get(data.cid, socket.uid),
        user.getSettings(socket.uid),
        user.getUidByUserslug(data.query.author),
    ]);

    if (!userPrivileges.read) {
        throw new Error('[[error:no-privileges]]');
    }

    const infScrollTopicsPerPage = 20;
    const sort = data.sort || data.categoryTopicSort;

    let start = Math.max(0, parseInt(data.after, 10));

    if (data.direction === -1) {
        start -= infScrollTopicsPerPage;
    }

    let stop = start + infScrollTopicsPerPage - 1;

    start = Math.max(0, start);
    stop = Math.max(0, stop);
    const result = await categories.getCategoryTopics({
        uid: socket.uid,
        cid: data.cid,
        start: start,
        stop: stop,
        sort: sort,
        settings: settings,
        query: data.query,
        tag: data.query.tag,
        targetUid: targetUid,
    });
    categories.modifyTopicsByPrivilege(result.topics, userPrivileges);

    result.privileges = userPrivileges;
    result.template = {
        category: true,
        name: 'category',
    };
    return result;
};

SocketCategories.getTopicCount = async function (socket, cid) {
    return await categories.getCategoryField(cid, 'topic_count');
};

SocketCategories.getCategoriesByPrivilege = async function (socket, privilege) {
    return await categories.getCategoriesByPrivilege('categories:cid', socket.uid, privilege);
};

SocketCategories.getMoveCategories = async function (socket, data) {
    return await SocketCategories.getSelectCategories(socket, data);
};

SocketCategories.getSelectCategories = async function (socket) {
    const [isAdmin, categoriesData] = await Promise.all([
        user.isAdministrator(socket.uid),
        categories.buildForSelect(socket.uid, 'find', ['disabled', 'link']),
    ]);
    return categoriesData.filter(category => category && (!category.disabled || isAdmin) && !category.link);
};

SocketCategories.setWatchState = async function (socket, data) {
    if (!data || !data.cid || !data.state) {
        throw new Error('[[error:invalid-data]]');
    }
    return await ignoreOrWatch(async (uid, cids) => {
        await user.setCategoryWatchState(uid, cids, categories.watchStates[data.state]);
    }, socket, data);
};

SocketCategories.watch = async function (socket, data) {
    return await ignoreOrWatch(user.watchCategory, socket, data);
};

SocketCategories.ignore = async function (socket, data) {
    return await ignoreOrWatch(user.ignoreCategory, socket, data);
};

async function ignoreOrWatch(fn, socket, data) {
    let targetUid = socket.uid;
    const cids = Array.isArray(data.cid) ? data.cid.map(cid => parseInt(cid, 10)) : [parseInt(data.cid, 10)];
    if (data.hasOwnProperty('uid')) {
        targetUid = data.uid;
    }
    await user.isAdminOrGlobalModOrSelf(socket.uid, targetUid);
    const allCids = await categories.getAllCidsFromSet('categories:cid');
    const categoryData = await categories.getCategoriesFields(allCids, ['cid', 'parentCid']);

    // filter to subcategories of cid
    let cat;
    do {
        cat = categoryData.find(c => !cids.includes(c.cid) && cids.includes(c.parentCid));
        if (cat) {
            cids.push(cat.cid);
        }
    } while (cat);

    await fn(targetUid, cids);
    await topics.pushUnreadCount(targetUid);
    return cids;
}

SocketCategories.isModerator = async function (socket, cid) {
    return await user.isModerator(socket.uid, cid);
};

SocketCategories.loadMoreSubCategories = async function (socket, data) {
    if (!data || !data.cid || parseInt(data.start, 10) <= 0) {
        throw new Error('[[error:invalid-data]]');
    }
    const allowed = await privileges.categories.can('read', data.cid, socket.uid);
    if (!allowed) {
        throw new Error('[[error:no-privileges]]');
    }
    const category = await categories.getCategoryData(data.cid);
    await categories.getChildrenTree(category, socket.uid);
    const allCategories = [];
    categories.flattenCategories(allCategories, category.children);
    await categories.getRecentTopicReplies(allCategories, socket.uid);
    const start = parseInt(data.start, 10);
    return category.children.slice(start, start + category.subCategoriesPerPage);
};

require('../promisify')(SocketCategories);

1	'use strict';
2
3	const categories = require('../categories');	4✔
4	const privileges = require('../privileges');	4✔
5	const user = require('../user');	4✔
6	const topics = require('../topics');	4✔
7
8	const SocketCategories = module.exports;	4✔
9
10	require('./categories/search')(SocketCategories);	4✔
11
12	SocketCategories.getRecentReplies = async function (socket, cid) {	4✔
13	return await categories.getRecentReplies(cid, socket.uid, 0, 4);	4✔
14	};
15
16	SocketCategories.get = async function (socket) {	4✔
17	async function getCategories() {
18	const cids = await categories.getCidsByPrivilege('categories:cid', socket.uid, 'find');	4✔
19	return await categories.getCategoriesData(cids);	4✔
20	}
21	const [isAdmin, categoriesData] = await Promise.all([	4✔
22	user.isAdministrator(socket.uid),
23	getCategories(),
24	]);
25	return categoriesData.filter(category => category && (!category.disabled \|\| isAdmin));	24!
26	};
27
28	SocketCategories.getWatchedCategories = async function (socket) {	4✔
29	const [categoriesData, ignoredCids] = await Promise.all([	4✔
30	categories.getCategoriesByPrivilege('cid:0:children', socket.uid, 'find'),
31	user.getIgnoredCategories(socket.uid),
32	]);
33	return categoriesData.filter(category => category && !ignoredCids.includes(String(category.cid)));	16✔
34	};
35
36	SocketCategories.loadMore = async function (socket, data) {	4✔
37	if (!data) {	8!
38	throw new Error('[[error:invalid-data]]');	×
39	}
40	data.query = data.query \|\| {};	8✔
41	const [userPrivileges, settings, targetUid] = await Promise.all([	8✔
42	privileges.categories.get(data.cid, socket.uid),
43	user.getSettings(socket.uid),
44	user.getUidByUserslug(data.query.author),
45	]);
46
47	if (!userPrivileges.read) {	8!
48	throw new Error('[[error:no-privileges]]');	×
49	}
50
51	const infScrollTopicsPerPage = 20;	8✔
52	const sort = data.sort \|\| data.categoryTopicSort;	8✔
53
54	let start = Math.max(0, parseInt(data.after, 10));	8✔
55
56	if (data.direction === -1) {	8!
57	start -= infScrollTopicsPerPage;	×
58	}
59
60	let stop = start + infScrollTopicsPerPage - 1;	8✔
61
62	start = Math.max(0, start);	8✔
63	stop = Math.max(0, stop);	8✔
64	const result = await categories.getCategoryTopics({	8✔
65	uid: socket.uid,
66	cid: data.cid,
67	start: start,
68	stop: stop,
69	sort: sort,
70	settings: settings,
71	query: data.query,
72	tag: data.query.tag,
73	targetUid: targetUid,
74	});
75	categories.modifyTopicsByPrivilege(result.topics, userPrivileges);	8✔
76
77	result.privileges = userPrivileges;	8✔
78	result.template = {	8✔
79	category: true,
80	name: 'category',
81	};
82	return result;	8✔
83	};
84
85	SocketCategories.getTopicCount = async function (socket, cid) {	4✔
86	return await categories.getCategoryField(cid, 'topic_count');	4✔
87	};
88
89	SocketCategories.getCategoriesByPrivilege = async function (socket, privilege) {	4✔
90	return await categories.getCategoriesByPrivilege('categories:cid', socket.uid, privilege);	4✔
91	};
92
93	SocketCategories.getMoveCategories = async function (socket, data) {	4✔
94	return await SocketCategories.getSelectCategories(socket, data);	4✔
95	};
96
97	SocketCategories.getSelectCategories = async function (socket) {	4✔
98	const [isAdmin, categoriesData] = await Promise.all([	4✔
99	user.isAdministrator(socket.uid),
100	categories.buildForSelect(socket.uid, 'find', ['disabled', 'link']),
101	]);
102	return categoriesData.filter(category => category && (!category.disabled \|\| isAdmin) && !category.link);	24!
103	};
104
105	SocketCategories.setWatchState = async function (socket, data) {	4✔
106	if (!data \|\| !data.cid \|\| !data.state) {	4!
107	throw new Error('[[error:invalid-data]]');	×
108	}
109	return await ignoreOrWatch(async (uid, cids) => {	4✔
110	await user.setCategoryWatchState(uid, cids, categories.watchStates[data.state]);	4✔
111	}, socket, data);
112	};
113
114	SocketCategories.watch = async function (socket, data) {	4✔
115	return await ignoreOrWatch(user.watchCategory, socket, data);	4✔
116	};
117
118	SocketCategories.ignore = async function (socket, data) {	4✔
119	return await ignoreOrWatch(user.ignoreCategory, socket, data);	4✔
120	};
121
122	async function ignoreOrWatch(fn, socket, data) {
123	let targetUid = socket.uid;	12✔
124	const cids = Array.isArray(data.cid) ? data.cid.map(cid => parseInt(cid, 10)) : [parseInt(data.cid, 10)];	12!
125	if (data.hasOwnProperty('uid')) {	12!
126	targetUid = data.uid;	×
127	}
128	await user.isAdminOrGlobalModOrSelf(socket.uid, targetUid);	12✔
129	const allCids = await categories.getAllCidsFromSet('categories:cid');	12✔
130	const categoryData = await categories.getCategoriesFields(allCids, ['cid', 'parentCid']);	12✔
131
132	// filter to subcategories of cid
133	let cat;
134	do {	12✔
135	cat = categoryData.find(c => !cids.includes(c.cid) && cids.includes(c.parentCid));	72✔
136	if (cat) {	12!
137	cids.push(cat.cid);	×
138	}
139	} while (cat);
140
141	await fn(targetUid, cids);	12✔
142	await topics.pushUnreadCount(targetUid);	8✔
143	return cids;	8✔
144	}
145
146	SocketCategories.isModerator = async function (socket, cid) {	4✔
147	return await user.isModerator(socket.uid, cid);	4✔
148	};
149
150	SocketCategories.loadMoreSubCategories = async function (socket, data) {	4✔
NEW 151	if (!data \|\| !data.cid \|\| parseInt(data.start, 10) <= 0) {	×
152	throw new Error('[[error:invalid-data]]');	×
153	}
154	const allowed = await privileges.categories.can('read', data.cid, socket.uid);	×
155	if (!allowed) {	×
156	throw new Error('[[error:no-privileges]]');	×
157	}
158	const category = await categories.getCategoryData(data.cid);	×
159	await categories.getChildrenTree(category, socket.uid);	×
160	const allCategories = [];	×
161	categories.flattenCategories(allCategories, category.children);	×
162	await categories.getRecentTopicReplies(allCategories, socket.uid);	×
163	const start = parseInt(data.start, 10);	×
164	return category.children.slice(start, start + category.subCategoriesPerPage);	×
165	};
166
167	require('../promisify')(SocketCategories);	4✔

CMU-17313Q / fall23-nodebb-just-relax / 6676852353

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous