6668183435

Committed 27 Oct 2023 01:58PM UTC coverage: 56.102% (-0.3%) from 56.395%

Build # 6668183435

Build Type

Pull #13226

github

Committed by

web-flow

Commit Message

Merge 1b84b6242 into 4e41c4285

Pull Request Pull Request #13226: Cleanup `ueberbackend.cc` a bit

Run Details

30184 of 84938 branches covered (0.0%)

Branch coverage included in aggregate %.

190 of 245 new or added lines in 1 file covered. (77.55%)

2280 existing lines in 49 files now uncovered.

103177 of 152773 relevant lines covered (67.54%)

2697402.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.07

/pdns/serialtweaker.cc

/*
    PowerDNS Versatile Database Driven Nameserver
    Copyright (C) 2002-2011  PowerDNS.COM BV

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License version 2 as
    published by the Free Software Foundation

    Additionally, the license of this program contains a special
    exception which allows to distribute the program in binary form when
    it is linked against OpenSSL.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
*/

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include "dnsseckeeper.hh"
#include "dnspacket.hh"
#include "namespaces.hh"

uint32_t localtime_format_YYYYMMDDSS(time_t t, uint32_t seq)
{
  struct tm tm;
  localtime_r(&t, &tm);
  return
      (uint32_t)(tm.tm_year+1900) * 1000000u
    + (uint32_t)(tm.tm_mon + 1) * 10000u
    + (uint32_t)tm.tm_mday * 100u
    + seq;
}

uint32_t calculateEditSOA(uint32_t old_serial, const string& kind, const DNSName& zonename)
{
  if(pdns_iequals(kind,"INCEPTION-INCREMENT")) {
    time_t inception = getStartOfWeek();
    uint32_t inception_serial = localtime_format_YYYYMMDDSS(inception, 1);
    uint32_t dont_increment_after = localtime_format_YYYYMMDDSS(inception + 2*86400, 99);

    if(old_serial < inception_serial - 1) { /* less than <inceptionday>00 */
      return inception_serial; /* return <inceptionday>01   (skipping <inceptionday>00 as possible value) */
    } else if (old_serial < inception_serial+1) {
      /* "<inceptionday>00" and "<inceptionday>01" are reserved for inception increasing, so jump to "<inceptionday>02" */
      return inception_serial+1;
    } else if(old_serial <= dont_increment_after) { /* >= <inceptionday>00 but <= <inceptionday+2>99 */
      return old_serial + 1;
    }
  }
  else if(pdns_iequals(kind,"INCREMENT-WEEKS")) {
    time_t inception = getStartOfWeek();
    return (old_serial + (inception / (7*86400)));
  }
  else if(pdns_iequals(kind,"EPOCH")) {
    // coverity[store_truncates_time_t]
    return time(nullptr);
  }
  else if(pdns_iequals(kind,"INCEPTION-EPOCH")) {
    uint32_t inception = getStartOfWeek();
    if (old_serial < inception)
      return inception;
  }
  else if(pdns_iequals(kind,"NONE")) {
    // do nothing to serial. needed because a metadata of "" will use the default-soa-edit setting instead.
  }
  else if(!kind.empty()) {
    g_log<<Logger::Warning<<"SOA-EDIT type '"<<kind<<"' for zone "<<zonename<<" is unknown."<<endl;
  }
  // Seen strictly, this is a broken config: we can only come here if
  // both SOA-EDIT and default-soa-edit are set to "", but the latter
  // should be set to "NONE" instead.
  return old_serial;
}

uint32_t calculateEditSOA(uint32_t old_serial, DNSSECKeeper& dk, const DNSName& zonename) {
  string kind;
  dk.getSoaEdit(zonename, kind);
  return calculateEditSOA(old_serial, kind, zonename);
}

/** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API. */
static uint32_t calculateIncreaseSOA(uint32_t old_serial, const string& increaseKind, const string& editKind, const DNSName& zonename) {
  if (pdns_iequals(increaseKind, "SOA-EDIT-INCREASE")) {
    uint32_t new_serial = old_serial;
    if (!editKind.empty()) {
      if (pdns_iequals(editKind, "INCEPTION-EPOCH")) {
        new_serial = calculateEditSOA(old_serial, "EPOCH", zonename);
      } else {
        new_serial = calculateEditSOA(old_serial, editKind, zonename);
      }
    }
    if (new_serial <= old_serial) {
      new_serial = old_serial + 1;
    }
    return new_serial;
  }
  else if (pdns_iequals(increaseKind, "SOA-EDIT")) {
    return calculateEditSOA(old_serial, editKind, zonename);
  }
  else if (pdns_iequals(increaseKind, "INCREASE")) {
    return old_serial + 1;
  }
  else if (pdns_iequals(increaseKind, "EPOCH")) {
    // coverity[store_truncates_time_t]
    return time(nullptr);
  }
  else if (pdns_iequals(increaseKind, "DEFAULT")) {
    time_t now = time(nullptr);
    uint32_t new_serial = localtime_format_YYYYMMDDSS(now, 1);
    if (new_serial <= old_serial) {
        new_serial = old_serial + 1;
    }
    return new_serial;
  } else if(!increaseKind.empty()) {
    g_log<<Logger::Warning<<"SOA-EDIT-API/DNSUPDATE type '"<<increaseKind<<"' for zone "<<zonename<<" is unknown."<<endl;
  }
  return old_serial;
}

/** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API.
 * Good if you already *have* a DNSResourceRecord.
 * Content in rr is suitable for writing into a backend.
 *
 * @return true if changes may have been made
 */
bool increaseSOARecord(DNSResourceRecord& rr, const string& increaseKind, const string& editKind) {
  if (increaseKind.empty())
    return false;

  SOAData sd;
  fillSOAData(rr.content, sd);

  sd.serial = calculateIncreaseSOA(sd.serial, increaseKind, editKind, rr.qname);
  rr.content = makeSOAContent(sd)->getZoneRepresentation(true);
  return true;
}

/** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API.
 * Makes a mostly reset DNSResourceRecord for you in @param rrout.
 * Content in rrout is suitable for writing into a backend.
 *
 * @return true if rrout is now valid
 */
bool makeIncreasedSOARecord(SOAData& sd, const string& increaseKind, const string& editKind, DNSResourceRecord& rrout) {
  if (increaseKind.empty())
    return false;

  sd.serial = calculateIncreaseSOA(sd.serial, increaseKind, editKind, sd.qname);
  rrout.qname = sd.qname;
  rrout.content = makeSOAContent(sd)->getZoneRepresentation(true);
  rrout.qtype = QType::SOA;
  rrout.domain_id = sd.domain_id;
  rrout.auth = true;
  rrout.ttl = sd.ttl;

  return true;
}

DNSZoneRecord makeEditedDNSZRFromSOAData(DNSSECKeeper& dk, const SOAData& sd, DNSResourceRecord::Place place) {
  SOAData edited = sd;
  edited.serial = calculateEditSOA(sd.serial, dk, sd.qname);

  DNSRecord soa;
  soa.d_name = sd.qname;
  soa.d_type = QType::SOA;
  soa.d_ttl = sd.ttl;
  soa.d_place = place;
  soa.setContent(makeSOAContent(edited));

  DNSZoneRecord dzr;
  dzr.domain_id = sd.domain_id;
  dzr.signttl = sd.ttl;
  dzr.auth = true;
  dzr.dr = std::move(soa);

  return dzr;
}

1	/*
2	PowerDNS Versatile Database Driven Nameserver
3	Copyright (C) 2002-2011 PowerDNS.COM BV
4
5	This program is free software; you can redistribute it and/or modify
6	it under the terms of the GNU General Public License version 2 as
7	published by the Free Software Foundation
8
9	Additionally, the license of this program contains a special
10	exception which allows to distribute the program in binary form when
11	it is linked against OpenSSL.
12
13	This program is distributed in the hope that it will be useful,
14	but WITHOUT ANY WARRANTY; without even the implied warranty of
15	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	GNU General Public License for more details.
17
18	You should have received a copy of the GNU General Public License
19	along with this program; if not, write to the Free Software
20	Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
21	*/
22
23	#ifdef HAVE_CONFIG_H
24	#include "config.h"
25	#endif
26	#include "dnsseckeeper.hh"
27	#include "dnspacket.hh"
28	#include "namespaces.hh"
29
30	uint32_t localtime_format_YYYYMMDDSS(time_t t, uint32_t seq)
31	{	4,327✔
32	struct tm tm;	4,327✔
33	localtime_r(&t, &tm);	4,327✔
34	return	4,327✔
35	(uint32_t)(tm.tm_year+1900) * 1000000u	4,327✔
36	+ (uint32_t)(tm.tm_mon + 1) * 10000u	4,327✔
37	+ (uint32_t)tm.tm_mday * 100u	4,327✔
38	+ seq;	4,327✔
39	}	4,327✔
40
41	uint32_t calculateEditSOA(uint32_t old_serial, const string& kind, const DNSName& zonename)
42	{	19,422✔
43	if(pdns_iequals(kind,"INCEPTION-INCREMENT")) {	19,422✔
44	time_t inception = getStartOfWeek();	1,933✔
45	uint32_t inception_serial = localtime_format_YYYYMMDDSS(inception, 1);	1,933✔
46	uint32_t dont_increment_after = localtime_format_YYYYMMDDSS(inception + 2*86400, 99);	1,933✔
47
48	if(old_serial < inception_serial - 1) { /* less than <inceptionday>00 */	1,933✔
49	return inception_serial; /* return <inceptionday>01 (skipping <inceptionday>00 as possible value) */	537✔
50	} else if (old_serial < inception_serial+1) {	1,396✔
51	/* "<inceptionday>00" and "<inceptionday>01" are reserved for inception increasing, so jump to "<inceptionday>02" */
52	return inception_serial+1;	20✔
53	} else if(old_serial <= dont_increment_after) { /* >= <inceptionday>00 but <= <inceptionday+2>99 */	1,376✔
54	return old_serial + 1;	1,328✔
55	}	1,328✔
56	}	1,933✔
57	else if(pdns_iequals(kind,"INCREMENT-WEEKS")) {	17,489!
UNCOV 58	time_t inception = getStartOfWeek();	×
UNCOV 59	return (old_serial + (inception / (7*86400)));	×
UNCOV 60	}	×
61	else if(pdns_iequals(kind,"EPOCH")) {	17,489!
62	// coverity[store_truncates_time_t]
UNCOV 63	return time(nullptr);	×
UNCOV 64	}	×
65	else if(pdns_iequals(kind,"INCEPTION-EPOCH")) {	17,489!
66	uint32_t inception = getStartOfWeek();	×
67	if (old_serial < inception)	×
68	return inception;	×
69	}	×
70	else if(pdns_iequals(kind,"NONE")) {	17,489!
71	// do nothing to serial. needed because a metadata of "" will use the default-soa-edit setting instead.
72	}	×
73	else if(!kind.empty()) {	17,489!
74	g_log<<Logger::Warning<<"SOA-EDIT type '"<<kind<<"' for zone "<<zonename<<" is unknown."<<endl;	×
75	}	×
76	// Seen strictly, this is a broken config: we can only come here if
77	// both SOA-EDIT and default-soa-edit are set to "", but the latter
78	// should be set to "NONE" instead.
79	return old_serial;	17,537✔
80	}	19,422✔
81
82	uint32_t calculateEditSOA(uint32_t old_serial, DNSSECKeeper& dk, const DNSName& zonename) {	17,348✔
83	string kind;	17,348✔
84	dk.getSoaEdit(zonename, kind);	17,348✔
85	return calculateEditSOA(old_serial, kind, zonename);	17,348✔
86	}	17,348✔
87
88	/** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API. */
89	static uint32_t calculateIncreaseSOA(uint32_t old_serial, const string& increaseKind, const string& editKind, const DNSName& zonename) {	493✔
90	if (pdns_iequals(increaseKind, "SOA-EDIT-INCREASE")) {	493✔
91	uint32_t new_serial = old_serial;	16✔
92	if (!editKind.empty()) {	16!
93	if (pdns_iequals(editKind, "INCEPTION-EPOCH")) {	16!
UNCOV 94	new_serial = calculateEditSOA(old_serial, "EPOCH", zonename);	×
95	} else {	16✔
96	new_serial = calculateEditSOA(old_serial, editKind, zonename);	16✔
97	}	16✔
98	}	16✔
99	if (new_serial <= old_serial) {	16!
UNCOV 100	new_serial = old_serial + 1;	×
UNCOV 101	}	×
102	return new_serial;	16✔
103	}	16✔
104	else if (pdns_iequals(increaseKind, "SOA-EDIT")) {	477!
105	return calculateEditSOA(old_serial, editKind, zonename);	×
106	}	×
107	else if (pdns_iequals(increaseKind, "INCREASE")) {	477!
108	return old_serial + 1;	×
109	}	×
110	else if (pdns_iequals(increaseKind, "EPOCH")) {	477✔
111	// coverity[store_truncates_time_t]
112	return time(nullptr);	16✔
113	}	16✔
114	else if (pdns_iequals(increaseKind, "DEFAULT")) {	461!
115	time_t now = time(nullptr);	461✔
116	uint32_t new_serial = localtime_format_YYYYMMDDSS(now, 1);	461✔
117	if (new_serial <= old_serial) {	461✔
118	new_serial = old_serial + 1;	80✔
119	}	80✔
120	return new_serial;	461✔
121	} else if(!increaseKind.empty()) {	461!
122	g_log<<Logger::Warning<<"SOA-EDIT-API/DNSUPDATE type '"<<increaseKind<<"' for zone "<<zonename<<" is unknown."<<endl;	×
123	}	×
124	return old_serial;	×
125	}	493✔
126
127	/** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API.
128	* Good if you already have a DNSResourceRecord.
129	* Content in rr is suitable for writing into a backend.
130	*
131	* @return true if changes may have been made
132	*/
133	bool increaseSOARecord(DNSResourceRecord& rr, const string& increaseKind, const string& editKind) {	24✔
134	if (increaseKind.empty())	24✔
135	return false;	4✔
136
137	SOAData sd;	20✔
138	fillSOAData(rr.content, sd);	20✔
139
140	sd.serial = calculateIncreaseSOA(sd.serial, increaseKind, editKind, rr.qname);	20✔
141	rr.content = makeSOAContent(sd)->getZoneRepresentation(true);	20✔
142	return true;	20✔
143	}	24✔
144
145	/** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API.
146	* Makes a mostly reset DNSResourceRecord for you in @param rrout.
147	* Content in rrout is suitable for writing into a backend.
148	*
149	* @return true if rrout is now valid
150	*/
151	bool makeIncreasedSOARecord(SOAData& sd, const string& increaseKind, const string& editKind, DNSResourceRecord& rrout) {	473✔
152	if (increaseKind.empty())	473!
153	return false;	×
154
155	sd.serial = calculateIncreaseSOA(sd.serial, increaseKind, editKind, sd.qname);	473✔
156	rrout.qname = sd.qname;	473✔
157	rrout.content = makeSOAContent(sd)->getZoneRepresentation(true);	473✔
158	rrout.qtype = QType::SOA;	473✔
159	rrout.domain_id = sd.domain_id;	473✔
160	rrout.auth = true;	473✔
161	rrout.ttl = sd.ttl;	473✔
162
163	return true;	473✔
164	}	473✔
165
166	DNSZoneRecord makeEditedDNSZRFromSOAData(DNSSECKeeper& dk, const SOAData& sd, DNSResourceRecord::Place place) {	17,336✔
167	SOAData edited = sd;	17,336✔
168	edited.serial = calculateEditSOA(sd.serial, dk, sd.qname);	17,336✔
169
170	DNSRecord soa;	17,336✔
171	soa.d_name = sd.qname;	17,336✔
172	soa.d_type = QType::SOA;	17,336✔
173	soa.d_ttl = sd.ttl;	17,336✔
174	soa.d_place = place;	17,336✔
175	soa.setContent(makeSOAContent(edited));	17,336✔
176
177	DNSZoneRecord dzr;	17,336✔
178	dzr.domain_id = sd.domain_id;	17,336✔
179	dzr.signttl = sd.ttl;	17,336✔
180	dzr.auth = true;	17,336✔
181	dzr.dr = std::move(soa);	17,336✔
182
183	return dzr;	17,336✔
184	}	17,336✔

PowerDNS / pdns / 6668183435

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous