6624301158

Committed 24 Oct 2023 08:29AM UTC coverage: 57.483% (+0.8%) from 56.645%

Build # 6624301158

Build Type

Pull #13413

github

Committed by

web-flow

Commit Message

Merge b0c30b2bb into 37f369c9f

Pull Request Pull Request #13413: dnsdist: Allow building of dnsdist against boringssl on OpenBSD

Run Details

31225 of 84938 branches covered (0.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

426 existing lines in 13 files now uncovered.

105412 of 152762 relevant lines covered (69.0%)

2823314.38 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/pdns/recursordist/secpoll-recursor.cc

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include "secpoll-recursor.hh"
#include "syncres.hh"
#include "logger.hh"
#include "arguments.hh"
#include "version.hh"
#include "validate-recursor.hh"
#include "secpoll.hh"

#include <stdint.h>
#ifndef PACKAGEVERSION
#define PACKAGEVERSION getPDNSVersion()
#endif

uint32_t g_security_status;
string g_security_message;

void doSecPoll(time_t* last_secpoll, Logr::log_t log)
{
  if (::arg()["security-poll-suffix"].empty())
    return;

  string pkgv(PACKAGEVERSION);
  struct timeval now;
  gettimeofday(&now, 0);

  /* update last_secpoll right now, even if it fails
     we don't want to retry right away and hammer the server */
  *last_secpoll = now.tv_sec;

  SyncRes sr(now);
  if (g_dnssecmode != DNSSECMode::Off) {
    sr.setDoDNSSEC(true);
    sr.setDNSSECValidationRequested(true);
  }
  sr.setId("SecPoll");

  vector<DNSRecord> ret;

  string version = "recursor-" + pkgv;
  string qstring(version.substr(0, 63) + ".security-status." + ::arg()["security-poll-suffix"]);

  if (*qstring.rbegin() != '.')
    qstring += '.';

  boost::replace_all(qstring, "+", "_");
  boost::replace_all(qstring, "~", "_");

  vState state = vState::Indeterminate;
  DNSName query(qstring);
  int res = sr.beginResolve(query, QType(QType::TXT), 1, ret);

  if (g_dnssecmode != DNSSECMode::Off && res) {
    state = sr.getValidationState();
  }

  auto vlog = log->withValues("version", Logging::Loggable(pkgv), "query", Logging::Loggable(query));
  if (vStateIsBogus(state)) {
    SLOG(g_log << Logger::Error << "Failed to retrieve security status update for '" + pkgv + "' on '" << query << "', DNSSEC validation result was Bogus!" << endl,
         vlog->info(Logr::Error, "Failed to retrieve security status update", "validationResult", Logging::Loggable(vStateToString(state))));
    if (g_security_status == 1) // If we were OK, go to unknown
      g_security_status = 0;
    return;
  }

  if (res == RCode::NXDomain && !isReleaseVersion(pkgv)) {
    SLOG(g_log << Logger::Warning << "Not validating response for security status update, this is a non-release version" << endl,
         vlog->info(Logr::Warning, "Not validating response for security status update, this is a non-release version"));
    return;
  }

  string security_message;
  int security_status = g_security_status;

  try {
    processSecPoll(res, ret, security_status, security_message);
  }
  catch (const PDNSException& pe) {
    g_security_status = security_status;
    SLOG(g_log << Logger::Warning << "Failed to retrieve security status update for '" << pkgv << "' on '" << query << "': " << pe.reason << endl,
         vlog->error(Logr::Warning, pe.reason, "Failed to retrieve security status update"));
    return;
  }

  g_security_message = security_message;

  auto rlog = vlog->withValues("securitymessage", Logging::Loggable(g_security_message), "status", Logging::Loggable(security_status));
  if (g_security_status != 1 && security_status == 1) {
    SLOG(g_log << Logger::Warning << "Polled security status of version " << pkgv << ", no known issues reported: " << g_security_message << endl,
         rlog->info(Logr::Notice, "Polled security status of version, no known issues reported"));
  }
  if (security_status == 2) {
    SLOG(g_log << Logger::Error << "PowerDNS Security Update Recommended: " << g_security_message << endl,
         rlog->info(Logr::Error, "PowerDNS Security Update Recommended"));
  }
  if (security_status == 3) {
    SLOG(g_log << Logger::Error << "PowerDNS Security Update Mandatory: " << g_security_message << endl,
         rlog->info(Logr::Error, "PowerDNS Security Update Mandatory"));
  }

  g_security_status = security_status;
}

1	#ifdef HAVE_CONFIG_H
2	#include "config.h"
3	#endif
4	#include "secpoll-recursor.hh"
5	#include "syncres.hh"
6	#include "logger.hh"
7	#include "arguments.hh"
8	#include "version.hh"
9	#include "validate-recursor.hh"
10	#include "secpoll.hh"
11
12	#include <stdint.h>
13	#ifndef PACKAGEVERSION
UNCOV 14	#define PACKAGEVERSION getPDNSVersion()	×
15	#endif
16
17	uint32_t g_security_status;
18	string g_security_message;
19
20	void doSecPoll(time_t* last_secpoll, Logr::log_t log)
UNCOV 21	{	×
UNCOV 22	if (::arg()["security-poll-suffix"].empty())	×
23	return;	×
24
UNCOV 25	string pkgv(PACKAGEVERSION);	×
UNCOV 26	struct timeval now;	×
UNCOV 27	gettimeofday(&now, 0);	×
28
29	/* update last_secpoll right now, even if it fails
30	we don't want to retry right away and hammer the server */
UNCOV 31	*last_secpoll = now.tv_sec;	×
32
UNCOV 33	SyncRes sr(now);	×
UNCOV 34	if (g_dnssecmode != DNSSECMode::Off) {	×
UNCOV 35	sr.setDoDNSSEC(true);	×
UNCOV 36	sr.setDNSSECValidationRequested(true);	×
UNCOV 37	}	×
UNCOV 38	sr.setId("SecPoll");	×
39
UNCOV 40	vector<DNSRecord> ret;	×
41
UNCOV 42	string version = "recursor-" + pkgv;	×
UNCOV 43	string qstring(version.substr(0, 63) + ".security-status." + ::arg()["security-poll-suffix"]);	×
44
UNCOV 45	if (*qstring.rbegin() != '.')	×
46	qstring += '.';	×
47
UNCOV 48	boost::replace_all(qstring, "+", "_");	×
UNCOV 49	boost::replace_all(qstring, "~", "_");	×
50
UNCOV 51	vState state = vState::Indeterminate;	×
UNCOV 52	DNSName query(qstring);	×
UNCOV 53	int res = sr.beginResolve(query, QType(QType::TXT), 1, ret);	×
54
UNCOV 55	if (g_dnssecmode != DNSSECMode::Off && res) {	×
56	state = sr.getValidationState();	×
57	}	×
58
UNCOV 59	auto vlog = log->withValues("version", Logging::Loggable(pkgv), "query", Logging::Loggable(query));	×
UNCOV 60	if (vStateIsBogus(state)) {	×
61	SLOG(g_log << Logger::Error << "Failed to retrieve security status update for '" + pkgv + "' on '" << query << "', DNSSEC validation result was Bogus!" << endl,	×
62	vlog->info(Logr::Error, "Failed to retrieve security status update", "validationResult", Logging::Loggable(vStateToString(state))));	×
63	if (g_security_status == 1) // If we were OK, go to unknown	×
64	g_security_status = 0;	×
65	return;	×
66	}	×
67
UNCOV 68	if (res == RCode::NXDomain && !isReleaseVersion(pkgv)) {	×
69	SLOG(g_log << Logger::Warning << "Not validating response for security status update, this is a non-release version" << endl,	×
70	vlog->info(Logr::Warning, "Not validating response for security status update, this is a non-release version"));	×
71	return;	×
72	}	×
73
UNCOV 74	string security_message;	×
UNCOV 75	int security_status = g_security_status;	×
76
UNCOV 77	try {	×
UNCOV 78	processSecPoll(res, ret, security_status, security_message);	×
UNCOV 79	}	×
UNCOV 80	catch (const PDNSException& pe) {	×
81	g_security_status = security_status;	×
82	SLOG(g_log << Logger::Warning << "Failed to retrieve security status update for '" << pkgv << "' on '" << query << "': " << pe.reason << endl,	×
83	vlog->error(Logr::Warning, pe.reason, "Failed to retrieve security status update"));	×
84	return;	×
85	}	×
86
87	g_security_message = security_message;	×
88
89	auto rlog = vlog->withValues("securitymessage", Logging::Loggable(g_security_message), "status", Logging::Loggable(security_status));	×
90	if (g_security_status != 1 && security_status == 1) {	×
91	SLOG(g_log << Logger::Warning << "Polled security status of version " << pkgv << ", no known issues reported: " << g_security_message << endl,	×
92	rlog->info(Logr::Notice, "Polled security status of version, no known issues reported"));	×
93	}	×
94	if (security_status == 2) {	×
95	SLOG(g_log << Logger::Error << "PowerDNS Security Update Recommended: " << g_security_message << endl,	×
96	rlog->info(Logr::Error, "PowerDNS Security Update Recommended"));	×
97	}	×
98	if (security_status == 3) {	×
99	SLOG(g_log << Logger::Error << "PowerDNS Security Update Mandatory: " << g_security_message << endl,	×
100	rlog->info(Logr::Error, "PowerDNS Security Update Mandatory"));	×
101	}	×
102
103	g_security_status = security_status;	×
104	}	×

PowerDNS / pdns / 6624301158

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous