6517266969

Committed 14 Oct 2023 11:05AM UTC coverage: 12.469% (+0.2%) from 12.308%

Build # 6517266969

Build Type

push

github

Committed by

web-flow

Commit Message

Implementing plugins for better separation (#39)

* Start implementing plugins for better separation
* massive refactor in attempt to split appdomains for plugins
* (breaks old mapping profiles)
* Fix error when switching from mouse button trigger to keyboard trigger and clicking in the combobox where the mouse button capture textbox is.
* Simplify code by removing legacy
* SImplify grouping actions
* Fix profile and add helpful opposite mapping generator tool
* Change solution hierarchy
* Restrict AppDomain plugins went from Zone.MyComputer -> .Internet
* create keypair in ci
* Install the .NET framework tools
* Run command in workflow
* Plugin permissions. Plugins disabled by default
* update readme (icon is no longer used)
* Plugin action runs in seperated process
* Remove unused dependencies.
* Fix action name display for mapping
* Fix Lua plugin script calls (NOTE: laggy when using MessageBox)
* convert project to sdk style
* Add editorconfig and start cleaning up
* Fix documentation. Update namespaces to match files (breaks profiles)
* Include all projects in tests, disable building docs on debug
* Add messagebox script action
* Add tests for pluginhost
* Remove administrator from window title test
* add some icons to ui
* Add enabling/disabling plugins
* Close plugins when Key2Joy shuts down
* Fix appcommand failing
* Fix plugin permission form crashing. Fix plugin load exception not showing warning
* Handle plugin host closing better when app has crashed
* Seperate host and client logic in remote event subscriber
* Ensure the PluginHost shuts down if the app crashes
* Better error output for plugins
* Fix cmd interop not working, add some tests
* also generate docs on plugins
* Fix build order with docs
* Fix enum script parameters and ensure actions share environment scopes
* Fix _wpftmp folders being created dotnet/wpf#2930
* Fix sequence action. Add disabled trigger/action for unloaded plugins on start... (continued)

Run Details

180 of 1703 branches covered (0.0%)

Branch coverage included in aggregate %.

6419 of 6419 new or added lines in 207 files covered. (100.0%)

1035 of 8041 relevant lines covered (12.87%)

8445.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Key2Joy.Gui/Mapping/Actions/Scripting/ScriptActionControl.cs

using System;
using System.IO;
using System.Windows.Forms;
using Esprima;
using Key2Joy.Contracts.Mapping;
using Key2Joy.Contracts.Mapping.Actions;
using Key2Joy.Mapping.Actions.Scripting;

namespace Key2Joy.Gui.Mapping;

[MappingControl(
    ForTypes = new[]
    {
        typeof(JavascriptAction),
        typeof(LuaScriptAction),
    },
    ImageResourceName = "script_code"
)]
public partial class ScriptActionControl : UserControl, IActionOptionsControl
{
    public event EventHandler OptionsChanged;

    public ScriptActionControl()
    {
        this.InitializeComponent();

        this.pnlFileInput.Visible = !this.chkDirectInput.Checked;
    }

    public void Select(object action)
    {
        var thisAction = (BaseScriptAction)action;

        var mappingType = action.GetType();
        string languageName;

        // If it's LuaScriptAction or JavascriptAction change the typename to ScriptAction
        if (mappingType == typeof(LuaScriptAction))
        {
            languageName = "Lua";
        }
        else if (mappingType == typeof(JavascriptAction))
        {
            languageName = "Javascript";
        }
        else
        {
            languageName = "Unknown Language";
        }

        this.lblInfo.Text = $"{languageName} Script:";

        this.txtScript.Text = this.txtFilePath.Text = thisAction.Script;
        this.chkDirectInput.Checked = !thisAction.IsScriptPath;
        this.pnlFileInput.Visible = !this.chkDirectInput.Checked;
    }

    public void Setup(object action)
    {
        var thisAction = (BaseScriptAction)action;

        thisAction.IsScriptPath = !this.chkDirectInput.Checked;

        if (thisAction.IsScriptPath)
        {
            thisAction.Script = this.txtFilePath.Text;
            return;
        }

        thisAction.Script = this.txtScript.Text;
    }

    public bool CanMappingSave(object action)
    {
        var thisAction = (BaseScriptAction)action;
        var mappingType = action.GetType();

        if (mappingType == typeof(LuaScriptAction))
        {
            // TODO: Parse Lua and check for errors
        }
        else if (mappingType == typeof(JavascriptAction))
        {
            // Since we only get a ParserError somewhere inside Esprima.dll, we check for errors here
            var parser = new JavaScriptParser();

            try
            {
                parser.ParseScript(thisAction.Script);
            }
            catch (ParserException ex)
            {
                MessageBox.Show(ex.Message, "Script Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                return false;
            }
        }

        return MessageBox.Show(
            "Scripts can click and type like you do and therefor impersonate you. "
            + "Scripts could cause harm to your pc, you or else. "
            + "For that reason you should only run scripts that you trust!"
            + "\n\nDo you trust this script?",
            "Warning:! Scripts can be dangerous!",
            MessageBoxButtons.YesNoCancel,
            MessageBoxIcon.Warning) == DialogResult.Yes;
    }

    private void TxtScript_TextChanged(object sender, EventArgs e) => OptionsChanged?.Invoke(this, EventArgs.Empty);

    private void TxtFilePath_TextChanged(object sender, EventArgs e) => OptionsChanged?.Invoke(this, EventArgs.Empty);

    private void ChkDirectInput_CheckedChanged(object sender, EventArgs e)
    {
        this.txtScript.Visible = this.chkDirectInput.Checked;
        this.pnlFileInput.Visible = !this.chkDirectInput.Checked;
        OptionsChanged?.Invoke(this, EventArgs.Empty);
        this.PerformLayout();
    }

    private void BtnBrowseFile_Click(object sender, EventArgs e)
    {
        OpenFileDialog filePicker = new();

        if (filePicker.ShowDialog() != DialogResult.OK)
        {
            return;
        }

        var file = filePicker.FileName;
        try
        {
            File.ReadAllText(file);
            this.txtFilePath.Text = file;
            OptionsChanged?.Invoke(this, EventArgs.Empty);
        }
        catch (IOException)
        {
            MessageBox.Show($"This file could not be loaded as a script.", "Invalid script file!", MessageBoxButtons.OK, MessageBoxIcon.Error);
        }
    }
}

1	using System;
2	using System.IO;
3	using System.Windows.Forms;
4	using Esprima;
5	using Key2Joy.Contracts.Mapping;
6	using Key2Joy.Contracts.Mapping.Actions;
7	using Key2Joy.Mapping.Actions.Scripting;
8
9	namespace Key2Joy.Gui.Mapping;
10
11	[MappingControl(
12	ForTypes = new[]
13	{
14	typeof(JavascriptAction),
15	typeof(LuaScriptAction),
16	},
17	ImageResourceName = "script_code"
18	)]
19	public partial class ScriptActionControl : UserControl, IActionOptionsControl
20	{
21	public event EventHandler OptionsChanged;
22
23	public ScriptActionControl()	×
24	{	×
25	this.InitializeComponent();	×
26
27	this.pnlFileInput.Visible = !this.chkDirectInput.Checked;	×
28	}	×
29
30	public void Select(object action)
31	{	×
32	var thisAction = (BaseScriptAction)action;	×
33
34	var mappingType = action.GetType();	×
35	string languageName;
36
37	// If it's LuaScriptAction or JavascriptAction change the typename to ScriptAction
38	if (mappingType == typeof(LuaScriptAction))	×
39	{	×
40	languageName = "Lua";	×
41	}	×
42	else if (mappingType == typeof(JavascriptAction))	×
43	{	×
44	languageName = "Javascript";	×
45	}	×
46	else
47	{	×
48	languageName = "Unknown Language";	×
49	}	×
50
51	this.lblInfo.Text = $"{languageName} Script:";	×
52
53	this.txtScript.Text = this.txtFilePath.Text = thisAction.Script;	×
54	this.chkDirectInput.Checked = !thisAction.IsScriptPath;	×
55	this.pnlFileInput.Visible = !this.chkDirectInput.Checked;	×
56	}	×
57
58	public void Setup(object action)
59	{	×
60	var thisAction = (BaseScriptAction)action;	×
61
62	thisAction.IsScriptPath = !this.chkDirectInput.Checked;	×
63
64	if (thisAction.IsScriptPath)	×
65	{	×
66	thisAction.Script = this.txtFilePath.Text;	×
67	return;	×
68	}
69
70	thisAction.Script = this.txtScript.Text;	×
71	}	×
72
73	public bool CanMappingSave(object action)
74	{	×
75	var thisAction = (BaseScriptAction)action;	×
76	var mappingType = action.GetType();	×
77
78	if (mappingType == typeof(LuaScriptAction))	×
79	{	×
80	// TODO: Parse Lua and check for errors
81	}	×
82	else if (mappingType == typeof(JavascriptAction))	×
83	{	×
84	// Since we only get a ParserError somewhere inside Esprima.dll, we check for errors here
85	var parser = new JavaScriptParser();	×
86
87	try
88	{	×
89	parser.ParseScript(thisAction.Script);	×
90	}	×
91	catch (ParserException ex)	×
92	{	×
93	MessageBox.Show(ex.Message, "Script Error", MessageBoxButtons.OK, MessageBoxIcon.Error);	×
94	return false;	×
95	}
96	}	×
97
98	return MessageBox.Show(	×
99	"Scripts can click and type like you do and therefor impersonate you. "	×
100	+ "Scripts could cause harm to your pc, you or else. "	×
101	+ "For that reason you should only run scripts that you trust!"	×
102	+ "\n\nDo you trust this script?",	×
103	"Warning:! Scripts can be dangerous!",	×
104	MessageBoxButtons.YesNoCancel,	×
105	MessageBoxIcon.Warning) == DialogResult.Yes;	×
106	}	×
107
108	private void TxtScript_TextChanged(object sender, EventArgs e) => OptionsChanged?.Invoke(this, EventArgs.Empty);	×
109
110	private void TxtFilePath_TextChanged(object sender, EventArgs e) => OptionsChanged?.Invoke(this, EventArgs.Empty);	×
111
112	private void ChkDirectInput_CheckedChanged(object sender, EventArgs e)
113	{	×
114	this.txtScript.Visible = this.chkDirectInput.Checked;	×
115	this.pnlFileInput.Visible = !this.chkDirectInput.Checked;	×
116	OptionsChanged?.Invoke(this, EventArgs.Empty);	×
117	this.PerformLayout();	×
118	}	×
119
120	private void BtnBrowseFile_Click(object sender, EventArgs e)
121	{	×
122	OpenFileDialog filePicker = new();	×
123
124	if (filePicker.ShowDialog() != DialogResult.OK)	×
125	{	×
126	return;	×
127	}
128
129	var file = filePicker.FileName;	×
130	try
131	{	×
132	File.ReadAllText(file);	×
133	this.txtFilePath.Text = file;	×
134	OptionsChanged?.Invoke(this, EventArgs.Empty);	×
135	}	×
136	catch (IOException)	×
137	{	×
138	MessageBox.Show($"This file could not be loaded as a script.", "Invalid script file!", MessageBoxButtons.OK, MessageBoxIcon.Error);	×
139	}	×
140	}	×
141	}

luttje / Key2Joy / 6517266969

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous