6517266969

Committed 14 Oct 2023 11:05AM UTC coverage: 12.469% (+0.2%) from 12.308%

Build # 6517266969

Build Type

push

github

Committed by

web-flow

Commit Message

Implementing plugins for better separation (#39)

* Start implementing plugins for better separation
* massive refactor in attempt to split appdomains for plugins
* (breaks old mapping profiles)
* Fix error when switching from mouse button trigger to keyboard trigger and clicking in the combobox where the mouse button capture textbox is.
* Simplify code by removing legacy
* SImplify grouping actions
* Fix profile and add helpful opposite mapping generator tool
* Change solution hierarchy
* Restrict AppDomain plugins went from Zone.MyComputer -> .Internet
* create keypair in ci
* Install the .NET framework tools
* Run command in workflow
* Plugin permissions. Plugins disabled by default
* update readme (icon is no longer used)
* Plugin action runs in seperated process
* Remove unused dependencies.
* Fix action name display for mapping
* Fix Lua plugin script calls (NOTE: laggy when using MessageBox)
* convert project to sdk style
* Add editorconfig and start cleaning up
* Fix documentation. Update namespaces to match files (breaks profiles)
* Include all projects in tests, disable building docs on debug
* Add messagebox script action
* Add tests for pluginhost
* Remove administrator from window title test
* add some icons to ui
* Add enabling/disabling plugins
* Close plugins when Key2Joy shuts down
* Fix appcommand failing
* Fix plugin permission form crashing. Fix plugin load exception not showing warning
* Handle plugin host closing better when app has crashed
* Seperate host and client logic in remote event subscriber
* Ensure the PluginHost shuts down if the app crashes
* Better error output for plugins
* Fix cmd interop not working, add some tests
* also generate docs on plugins
* Fix build order with docs
* Fix enum script parameters and ensure actions share environment scopes
* Fix _wpftmp folders being created dotnet/wpf#2930
* Fix sequence action. Add disabled trigger/action for unloaded plugins on start... (continued)

Run Details

180 of 1703 branches covered (0.0%)

Branch coverage included in aggregate %.

6419 of 6419 new or added lines in 207 files covered. (100.0%)

1035 of 8041 relevant lines covered (12.87%)

8445.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

47.92

/Core/Key2Joy.PluginHost/Program.cs

using System;
using System.Collections;
using System.Diagnostics;
using System.Runtime.Remoting;
using System.Runtime.Remoting.Channels;
using System.Runtime.Remoting.Channels.Ipc;
using System.Runtime.Serialization.Formatters;
using System.Windows.Threading;
using Key2Joy.Contracts;
using Key2Joy.Contracts.Plugins.Remoting;
using static Key2Joy.PluginHost.Native;

namespace Key2Joy.PluginHost;

internal class Program
{
    public static Dispatcher AppDispatcher { get; private set; }

    private static string portName;

    [STAThread]
    private static void Main(string[] args)
    {
        if (args.Length != 1)
        {
            Console.Error.WriteLine("Usage: PluginHost name");
            return;
        }

        SetConsoleCtrlHandler(ProcessExitHandler, true);

        try
        {
            portName = args[0];
            Console.WriteLine("Starting PluginHost {0}", portName);

            AppDispatcher = Dispatcher.CurrentDispatcher;

            BinaryServerFormatterSinkProvider serverProvider = new() { TypeFilterLevel = TypeFilterLevel.Full };
            BinaryClientFormatterSinkProvider clientProvider = new();
            Hashtable properties = new();
            properties["portName"] = portName;

            // Note:https://github.com/microsoft/win32-app-isolation/issues/16
            IpcChannel channel = new(properties, clientProvider, serverProvider);
            ChannelServices.RegisterChannel(channel, false);

            RemotingConfiguration.RegisterWellKnownServiceType(
                typeof(PluginHost), nameof(PluginHost), WellKnownObjectMode.Singleton);

            RemoteEventSubscriber.InitClient(portName);
            RemoteEventSubscriber.ClientInstance.Disposing += (s, e) => AppDispatcher.InvokeShutdown();
            Console.WriteLine($"Connected to pipe @ {RemotePipe.GetClientPipeName(portName)}");

            Dispatcher.Run();
        }
        catch (Exception ex)
        {
            Output.WriteLine(ex);
            Debugger.Launch();
            var mostInnerException = ex;

            while (mostInnerException.InnerException != null)
            {
                mostInnerException = mostInnerException.InnerException;
            }

            RemoteEventSubscriber.ClientInstance.Exit();
            Console.WriteLine(mostInnerException.Message);
        }
    }

    private static bool ProcessExitHandler(CtrlType sig)
    {
        RemoteEventSubscriber.ClientInstance.Exit();
        Console.WriteLine("Sending close signal...");
        return false;
    }
}

1	using System;
2	using System.Collections;
3	using System.Diagnostics;
4	using System.Runtime.Remoting;
5	using System.Runtime.Remoting.Channels;
6	using System.Runtime.Remoting.Channels.Ipc;
7	using System.Runtime.Serialization.Formatters;
8	using System.Windows.Threading;
9	using Key2Joy.Contracts;
10	using Key2Joy.Contracts.Plugins.Remoting;
11	using static Key2Joy.PluginHost.Native;
12
13	namespace Key2Joy.PluginHost;
14
15	internal class Program
16	{
17	public static Dispatcher AppDispatcher { get; private set; }	9✔
18
19	private static string portName;
20
21	[STAThread]
22	private static void Main(string[] args)
23	{	9✔
24	if (args.Length != 1)	9!
25	{	×
26	Console.Error.WriteLine("Usage: PluginHost name");	×
27	return;	×
28	}
29
30	SetConsoleCtrlHandler(ProcessExitHandler, true);	9✔
31
32	try
33	{	9✔
34	portName = args[0];	9✔
35	Console.WriteLine("Starting PluginHost {0}", portName);	9✔
36
37	AppDispatcher = Dispatcher.CurrentDispatcher;	9✔
38
39	BinaryServerFormatterSinkProvider serverProvider = new() { TypeFilterLevel = TypeFilterLevel.Full };	9✔
40	BinaryClientFormatterSinkProvider clientProvider = new();	9✔
41	Hashtable properties = new();	9✔
42	properties["portName"] = portName;	9✔
43
44	// Note:https://github.com/microsoft/win32-app-isolation/issues/16
45	IpcChannel channel = new(properties, clientProvider, serverProvider);	9✔
46	ChannelServices.RegisterChannel(channel, false);	9✔
47
48	RemotingConfiguration.RegisterWellKnownServiceType(	9✔
49	typeof(PluginHost), nameof(PluginHost), WellKnownObjectMode.Singleton);	9✔
50
51	RemoteEventSubscriber.InitClient(portName);	9✔
52	RemoteEventSubscriber.ClientInstance.Disposing += (s, e) => AppDispatcher.InvokeShutdown();	9✔
53	Console.WriteLine($"Connected to pipe @ {RemotePipe.GetClientPipeName(portName)}");	9✔
54
55	Dispatcher.Run();	9✔
56	}	×
57	catch (Exception ex)	×
58	{	×
59	Output.WriteLine(ex);	×
60	Debugger.Launch();	×
61	var mostInnerException = ex;	×
62
63	while (mostInnerException.InnerException != null)	×
64	{	×
65	mostInnerException = mostInnerException.InnerException;	×
66	}	×
67
68	RemoteEventSubscriber.ClientInstance.Exit();	×
69	Console.WriteLine(mostInnerException.Message);	×
70	}	×
71	}	×
72
73	private static bool ProcessExitHandler(CtrlType sig)
74	{	×
75	RemoteEventSubscriber.ClientInstance.Exit();	×
76	Console.WriteLine("Sending close signal...");	×
77	return false;	×
78	}	×
79	}

luttje / Key2Joy / 6517266969

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous