6517266969

Committed 14 Oct 2023 11:05AM UTC coverage: 12.469% (+0.2%) from 12.308%

Build # 6517266969

Build Type

push

github

Committed by

web-flow

Commit Message

Implementing plugins for better separation (#39)

* Start implementing plugins for better separation
* massive refactor in attempt to split appdomains for plugins
* (breaks old mapping profiles)
* Fix error when switching from mouse button trigger to keyboard trigger and clicking in the combobox where the mouse button capture textbox is.
* Simplify code by removing legacy
* SImplify grouping actions
* Fix profile and add helpful opposite mapping generator tool
* Change solution hierarchy
* Restrict AppDomain plugins went from Zone.MyComputer -> .Internet
* create keypair in ci
* Install the .NET framework tools
* Run command in workflow
* Plugin permissions. Plugins disabled by default
* update readme (icon is no longer used)
* Plugin action runs in seperated process
* Remove unused dependencies.
* Fix action name display for mapping
* Fix Lua plugin script calls (NOTE: laggy when using MessageBox)
* convert project to sdk style
* Add editorconfig and start cleaning up
* Fix documentation. Update namespaces to match files (breaks profiles)
* Include all projects in tests, disable building docs on debug
* Add messagebox script action
* Add tests for pluginhost
* Remove administrator from window title test
* add some icons to ui
* Add enabling/disabling plugins
* Close plugins when Key2Joy shuts down
* Fix appcommand failing
* Fix plugin permission form crashing. Fix plugin load exception not showing warning
* Handle plugin host closing better when app has crashed
* Seperate host and client logic in remote event subscriber
* Ensure the PluginHost shuts down if the app crashes
* Better error output for plugins
* Fix cmd interop not working, add some tests
* also generate docs on plugins
* Fix build order with docs
* Fix enum script parameters and ensure actions share environment scopes
* Fix _wpftmp folders being created dotnet/wpf#2930
* Fix sequence action. Add disabled trigger/action for unloaded plugins on start... (continued)

Run Details

180 of 1703 branches covered (0.0%)

Branch coverage included in aggregate %.

6419 of 6419 new or added lines in 207 files covered. (100.0%)

1035 of 8041 relevant lines covered (12.87%)

8445.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Core/Key2Joy.Core/Plugins/MappingTypeHelper.cs

﻿using System;
using System.Collections.Generic;
using System.Runtime.Remoting;
using Key2Joy.Contracts.Mapping;
using Key2Joy.Contracts.Plugins;

namespace Key2Joy.Plugins;

public class MappingTypeHelper
{
    /// <summary>
    /// Ensures the typename is valid, splitting the long variant into its short form
    /// </summary>
    /// <param name="typeInfoTypeName"></param>
    /// <returns></returns>
    public static string EnsureSimpleTypeName(string typeInfoTypeName) => typeInfoTypeName.Split(',')[0];

    /// <summary>
    /// Gets the typename, even if the object is a proxy
    /// </summary>
    /// <param name="typeFactories"></param>
    /// <param name="instance"></param>
    /// <returns></returns>
    /// <exception cref="ArgumentException"></exception>
    public static string GetTypeFullName<T>(IDictionary<string, MappingTypeFactory<T>> typeFactories, AbstractMappingAspect instance)
        where T : AbstractMappingAspect
    {
        var realObject = GetRealObject(instance);
        var realTypeName = GetRealTypeName(realObject);

        if (!typeFactories.ContainsKey(realTypeName))
        {
            throw new ArgumentException("Only allowed types may be (de)serialized");
        }

        return realTypeName;
    }

    /// <summary>
    /// Gets the typename, even if the object is a proxy
    /// </summary>
    /// <param name="typeFactories"></param>
    /// <param name="instance"></param>
    /// <returns></returns>
    /// <exception cref="ArgumentException"></exception>
    public static string GetTypeFullName(IDictionary<string, MappingTypeFactory> typeFactories, AbstractMappingAspect instance)
    {
        var realObject = GetRealObject(instance);
        var realTypeName = GetRealTypeName(realObject);

        if (!typeFactories.ContainsKey(realTypeName))
        {
            throw new ArgumentException("Only allowed types may be (de)serialized");
        }

        return realTypeName;
    }

    private static string GetRealTypeName(MarshalByRefObject realObject)
    {
        if (RemotingServices.IsTransparentProxy(realObject))
        {
            var objRef = RemotingServices.GetObjRefForProxy(realObject);
            return EnsureSimpleTypeName(objRef.TypeInfo.TypeName);
        }

        return realObject.GetType().FullName;
    }

    private static MarshalByRefObject GetRealObject(AbstractMappingAspect instance)
    {
        if (instance is IGetRealObject<PluginAction> pluginAction)
        {
            return pluginAction.GetRealObject();
        }
        else if (instance is IGetRealObject<PluginTrigger> pluginTrigger)
        {
            return pluginTrigger.GetRealObject();
        }

        return instance;
    }
}

1	using System;
2	using System.Collections.Generic;
3	using System.Runtime.Remoting;
4	using Key2Joy.Contracts.Mapping;
5	using Key2Joy.Contracts.Plugins;
6
7	namespace Key2Joy.Plugins;
8
9	public class MappingTypeHelper
10	{
11	/// <summary>
12	/// Ensures the typename is valid, splitting the long variant into its short form
13	/// </summary>
14	/// <param name="typeInfoTypeName"></param>
15	/// <returns></returns>
16	public static string EnsureSimpleTypeName(string typeInfoTypeName) => typeInfoTypeName.Split(',')[0];	×
17
18	/// <summary>
19	/// Gets the typename, even if the object is a proxy
20	/// </summary>
21	/// <param name="typeFactories"></param>
22	/// <param name="instance"></param>
23	/// <returns></returns>
24	/// <exception cref="ArgumentException"></exception>
25	public static string GetTypeFullName<T>(IDictionary<string, MappingTypeFactory<T>> typeFactories, AbstractMappingAspect instance)
26	where T : AbstractMappingAspect
27	{	×
28	var realObject = GetRealObject(instance);	×
29	var realTypeName = GetRealTypeName(realObject);	×
30
31	if (!typeFactories.ContainsKey(realTypeName))	×
32	{	×
33	throw new ArgumentException("Only allowed types may be (de)serialized");	×
34	}
35
36	return realTypeName;	×
37	}	×
38
39	/// <summary>
40	/// Gets the typename, even if the object is a proxy
41	/// </summary>
42	/// <param name="typeFactories"></param>
43	/// <param name="instance"></param>
44	/// <returns></returns>
45	/// <exception cref="ArgumentException"></exception>
46	public static string GetTypeFullName(IDictionary<string, MappingTypeFactory> typeFactories, AbstractMappingAspect instance)
47	{	×
48	var realObject = GetRealObject(instance);	×
49	var realTypeName = GetRealTypeName(realObject);	×
50
51	if (!typeFactories.ContainsKey(realTypeName))	×
52	{	×
53	throw new ArgumentException("Only allowed types may be (de)serialized");	×
54	}
55
56	return realTypeName;	×
57	}	×
58
59	private static string GetRealTypeName(MarshalByRefObject realObject)
60	{	×
61	if (RemotingServices.IsTransparentProxy(realObject))	×
62	{	×
63	var objRef = RemotingServices.GetObjRefForProxy(realObject);	×
64	return EnsureSimpleTypeName(objRef.TypeInfo.TypeName);	×
65	}
66
67	return realObject.GetType().FullName;	×
68	}	×
69
70	private static MarshalByRefObject GetRealObject(AbstractMappingAspect instance)
71	{	×
72	if (instance is IGetRealObject<PluginAction> pluginAction)	×
73	{	×
74	return pluginAction.GetRealObject();	×
75	}
76	else if (instance is IGetRealObject<PluginTrigger> pluginTrigger)	×
77	{	×
78	return pluginTrigger.GetRealObject();	×
79	}
80
81	return instance;	×
82	}	×
83	}

luttje / Key2Joy / 6517266969

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous