6456507598

Committed 09 Oct 2023 12:19PM UTC coverage: 89.115% (-0.4%) from 89.541%

Build # 6456507598

Build Type

push

github

Committed by

DifferentialOrange

Commit Message

test: support tests with vshard

The patch updates all tests to work with `vshard` and `cartridge`
at the same time. But tests of the `cartridge` role of the cartridge
or special features are skipping for `vshard`.

If `cartridge` is not installed or not supported (Tarantool 3.0+),
tests will run only with `vshard`.

The source of `vshard_helpers` folder is `vshard` repository [1] with
minor modifications.

1. https://github.com/tarantool/vshard/tree/b3c27b326/test/luatest_helpers

Closes #364

Run Details

4560 of 5117 relevant lines covered (89.11%)

17535.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.28

/crud/common/call.lua

local errors = require('errors')

local dev_checks = require('crud.common.dev_checks')
local utils = require('crud.common.utils')
local sharding_utils = require('crud.common.sharding.utils')
local fiber_clock = require('fiber').clock
local const = require('crud.common.const')

local BaseIterator = require('crud.common.map_call_cases.base_iter')
local BasePostprocessor = require('crud.common.map_call_cases.base_postprocessor')

local CallError = errors.new_class('CallError')

local call = {}

function call.get_vshard_call_name(mode, prefer_replica, balance)
    dev_checks('string', '?boolean', '?boolean')

    if mode ~= 'write' and mode ~= 'read' then
        return nil, CallError:new("Unknown call mode: %s", mode)
    end

    if mode == 'write' then
        return 'callrw'
    end

    if not prefer_replica and not balance then
        return 'callro'
    end

    if not prefer_replica and balance then
        return 'callbro'
    end

    if prefer_replica and not balance then
        return 'callre'
    end

    -- prefer_replica and balance
    return 'callbre'
end

local function wrap_vshard_err(vshard_router, err, func_name, replicaset_uuid, bucket_id)
    -- Do not rewrite ShardingHashMismatchError class.
    if err.class_name == sharding_utils.ShardingHashMismatchError.name then
        return errors.wrap(err)
    end

    if replicaset_uuid == nil then
        local replicaset, _ = vshard_router:route(bucket_id)
        if replicaset == nil then
            return CallError:new(
                "Function returned an error, but we couldn't figure out the replicaset: %s", err
            )
        end

        replicaset_uuid = replicaset.uuid
    end

    err = utils.update_storage_call_error_description(err, func_name, replicaset_uuid)
    err = errors.wrap(err)

    return CallError:new(utils.format_replicaset_error(
        replicaset_uuid, "Function returned an error: %s", err
    ))
end

function call.map(vshard_router, func_name, func_args, opts)
    dev_checks('table', 'string', '?table', {
        mode = 'string',
        prefer_replica = '?boolean',
        balance = '?boolean',
        timeout = '?number',
        replicasets = '?table',
        iter = '?table',
        postprocessor = '?table',
    })
    opts = opts or {}

    local vshard_call_name, err = call.get_vshard_call_name(opts.mode, opts.prefer_replica, opts.balance)
    if err ~= nil then
        return nil, err
    end

    local timeout = opts.timeout or const.DEFAULT_VSHARD_CALL_TIMEOUT

    local iter = opts.iter
    if iter == nil then
        iter, err = BaseIterator:new({
                        func_args = func_args,
                        replicasets = opts.replicasets,
                        vshard_router = vshard_router,
                    })
        if err ~= nil then
            return nil, err
        end
    end

    local postprocessor = opts.postprocessor
    if postprocessor == nil then
        postprocessor = BasePostprocessor:new()
    end

    local futures_by_replicasets = {}
    local call_opts = {is_async = true}
    while iter:has_next() do
        local args, replicaset = iter:get()
        local future = replicaset[vshard_call_name](replicaset, func_name, args, call_opts)
        futures_by_replicasets[replicaset.uuid] = future
    end

    local deadline = fiber_clock() + timeout
    for replicaset_uuid, future in pairs(futures_by_replicasets) do
        local wait_timeout = deadline - fiber_clock()
        if wait_timeout < 0 then
            wait_timeout = 0
        end

        local result, err = future:wait_result(wait_timeout)

        local result_info = {
            key = replicaset_uuid,
            value = result,
        }

        local err_info = {
            err_wrapper = wrap_vshard_err,
            err = err,
            wrapper_args = {func_name, replicaset_uuid},
        }

        local early_exit = postprocessor:collect(result_info, err_info)
        if early_exit then
            break
        end
    end

    return postprocessor:get()
end

function call.single(vshard_router, bucket_id, func_name, func_args, opts)
    dev_checks('table', 'number', 'string', '?table', {
        mode = 'string',
        prefer_replica = '?boolean',
        balance = '?boolean',
        timeout = '?number',
    })

    local vshard_call_name, err = call.get_vshard_call_name(opts.mode, opts.prefer_replica, opts.balance)
    if err ~= nil then
        return nil, err
    end

    local timeout = opts.timeout or const.DEFAULT_VSHARD_CALL_TIMEOUT

    local res, err = vshard_router[vshard_call_name](vshard_router, bucket_id, func_name, func_args, {
        timeout = timeout,
    })

    if err ~= nil then
        return nil, wrap_vshard_err(vshard_router, err, func_name, nil, bucket_id)
    end

    if res == box.NULL then
        return nil
    end

    return res
end

function call.any(vshard_router, func_name, func_args, opts)
    dev_checks('table', 'string', '?table', {
        timeout = '?number',
    })

    local timeout = opts.timeout or const.DEFAULT_VSHARD_CALL_TIMEOUT

    local replicasets, err = vshard_router:routeall()
    if replicasets == nil then
        return nil, CallError:new("Failed to get router replicasets: %s", err.err)
    end
    local replicaset = select(2, next(replicasets))

    local res, err = replicaset:call(func_name, func_args, {
        timeout = timeout,
    })
    if err ~= nil then
        return nil, wrap_vshard_err(vshard_router, err, func_name, replicaset.uuid)
    end

    if res == box.NULL then
        return nil
    end

    return res
end

return call

1	local errors = require('errors')	344✔
2
3	local dev_checks = require('crud.common.dev_checks')	344✔
4	local utils = require('crud.common.utils')	344✔
5	local sharding_utils = require('crud.common.sharding.utils')	344✔
6	local fiber_clock = require('fiber').clock	688✔
7	local const = require('crud.common.const')	344✔
8
9	local BaseIterator = require('crud.common.map_call_cases.base_iter')	344✔
10	local BasePostprocessor = require('crud.common.map_call_cases.base_postprocessor')	344✔
11
12	local CallError = errors.new_class('CallError')	344✔
13
14	local call = {}	344✔
15
16	function call.get_vshard_call_name(mode, prefer_replica, balance)	344✔
17	dev_checks('string', '?boolean', '?boolean')	158,676✔
18
19	if mode ~= 'write' and mode ~= 'read' then	158,676✔
20	return nil, CallError:new("Unknown call mode: %s", mode)	4✔
21	end
22
23	if mode == 'write' then	158,674✔
24	return 'callrw'	122,805✔
25	end
26
27	if not prefer_replica and not balance then	35,869✔
28	return 'callro'	35,839✔
29	end
30
31	if not prefer_replica and balance then	30✔
32	return 'callbro'	12✔
33	end
34
35	if prefer_replica and not balance then	18✔
36	return 'callre'	12✔
37	end
38
39	-- prefer_replica and balance
40	return 'callbre'	6✔
41	end
42
43	local function wrap_vshard_err(vshard_router, err, func_name, replicaset_uuid, bucket_id)
44	-- Do not rewrite ShardingHashMismatchError class.
45	if err.class_name == sharding_utils.ShardingHashMismatchError.name then	988✔
46	return errors.wrap(err)	170✔
47	end
48
49	if replicaset_uuid == nil then	486✔
50	local replicaset, _ = vshard_router:route(bucket_id)	25✔
51	if replicaset == nil then	25✔
52	return CallError:new(	×
53	"Function returned an error, but we couldn't figure out the replicaset: %s", err	×
54	)
55	end
56
57	replicaset_uuid = replicaset.uuid	25✔
58	end
59
60	err = utils.update_storage_call_error_description(err, func_name, replicaset_uuid)	972✔
61	err = errors.wrap(err)	972✔
62
63	return CallError:new(utils.format_replicaset_error(	972✔
64	replicaset_uuid, "Function returned an error: %s", err	486✔
65	))	972✔
66	end
67
68	function call.map(vshard_router, func_name, func_args, opts)	344✔
69	dev_checks('table', 'string', '?table', {	32,129✔
70	mode = 'string',
71	prefer_replica = '?boolean',
72	balance = '?boolean',
73	timeout = '?number',
74	replicasets = '?table',
75	iter = '?table',
76	postprocessor = '?table',
77	})
78	opts = opts or {}	32,129✔
79
80	local vshard_call_name, err = call.get_vshard_call_name(opts.mode, opts.prefer_replica, opts.balance)	32,129✔
81	if err ~= nil then	32,129✔
82	return nil, err	1✔
83	end
84
85	local timeout = opts.timeout or const.DEFAULT_VSHARD_CALL_TIMEOUT	32,128✔
86
87	local iter = opts.iter	32,128✔
88	if iter == nil then	32,128✔
89	iter, err = BaseIterator:new({	546✔
90	func_args = func_args,	273✔
91	replicasets = opts.replicasets,	273✔
92	vshard_router = vshard_router,	273✔
93	})	273✔
94	if err ~= nil then	273✔
95	return nil, err	×
96	end
97	end
98
99	local postprocessor = opts.postprocessor	32,128✔
100	if postprocessor == nil then	32,128✔
101	postprocessor = BasePostprocessor:new()	546✔
102	end
103
104	local futures_by_replicasets = {}	32,128✔
105	local call_opts = {is_async = true}	32,128✔
106	while iter:has_next() do	137,044✔
107	local args, replicaset = iter:get()	36,394✔
108	local future = replicaset[vshard_call_name](replicaset, func_name, args, call_opts)	36,394✔
109	futures_by_replicasets[replicaset.uuid] = future	36,394✔
110	end
111
112	local deadline = fiber_clock() + timeout	64,256✔
113	for replicaset_uuid, future in pairs(futures_by_replicasets) do	100,613✔
114	local wait_timeout = deadline - fiber_clock()	72,772✔
115	if wait_timeout < 0 then	36,386✔
116	wait_timeout = 0	6✔
117	end
118
119	local result, err = future:wait_result(wait_timeout)	36,386✔
120
121	local result_info = {	36,386✔
122	key = replicaset_uuid,	36,386✔
123	value = result,	36,386✔
124	}
125
126	local err_info = {	36,386✔
127	err_wrapper = wrap_vshard_err,	36,386✔
128	err = err,	36,386✔
129	wrapper_args = {func_name, replicaset_uuid},	36,386✔
130	}
131
132	local early_exit = postprocessor:collect(result_info, err_info)	36,386✔
133	if early_exit then	36,386✔
134	break	29✔
135	end
136	end
137
138	return postprocessor:get()	32,128✔
139	end
140
141	function call.single(vshard_router, bucket_id, func_name, func_args, opts)	344✔
142	dev_checks('table', 'number', 'string', '?table', {	91,102✔
143	mode = 'string',
144	prefer_replica = '?boolean',
145	balance = '?boolean',
146	timeout = '?number',
147	})
148
149	local vshard_call_name, err = call.get_vshard_call_name(opts.mode, opts.prefer_replica, opts.balance)	91,102✔
150	if err ~= nil then	91,102✔
151	return nil, err	1✔
152	end
153
154	local timeout = opts.timeout or const.DEFAULT_VSHARD_CALL_TIMEOUT	91,101✔
155
156	local res, err = vshard_router[vshard_call_name](vshard_router, bucket_id, func_name, func_args, {	182,202✔
157	timeout = timeout,	91,101✔
158	})
159
160	if err ~= nil then	91,101✔
161	return nil, wrap_vshard_err(vshard_router, err, func_name, nil, bucket_id)	238✔
162	end
163
164	if res == box.NULL then	90,982✔
165	return nil	×
166	end
167
168	return res	90,982✔
169	end
170
171	function call.any(vshard_router, func_name, func_args, opts)	344✔
172	dev_checks('table', 'string', '?table', {	217✔
173	timeout = '?number',
174	})
175
176	local timeout = opts.timeout or const.DEFAULT_VSHARD_CALL_TIMEOUT	217✔
177
178	local replicasets, err = vshard_router:routeall()	217✔
179	if replicasets == nil then	217✔
180	return nil, CallError:new("Failed to get router replicasets: %s", err.err)	×
181	end
182	local replicaset = select(2, next(replicasets))	217✔
183
184	local res, err = replicaset:call(func_name, func_args, {	434✔
185	timeout = timeout,	217✔
186	})
187	if err ~= nil then	217✔
188	return nil, wrap_vshard_err(vshard_router, err, func_name, replicaset.uuid)	6✔
189	end
190
191	if res == box.NULL then	214✔
192	return nil	38✔
193	end
194
195	return res	176✔
196	end
197
198	return call	344✔

tarantool / crud / 6456507598

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous