6423986614

Committed 05 Oct 2023 08:11PM UTC coverage: 84.961% (+0.001%) from 84.96%

Build # 6423986614

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #32 from CMU-17313Q/fixing-anonymous-final

Fixing anonymous posts details - icons and displayname on group pages

Run Details

10224 of 13274 branches covered (0.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

3 existing lines in 3 files now uncovered.

22611 of 25373 relevant lines covered (89.11%)

3125.64 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.55

/src/messaging/notifications.js

'use strict';

const winston = require('winston');

const user = require('../user');
const notifications = require('../notifications');
const sockets = require('../socket.io');
const plugins = require('../plugins');
const meta = require('../meta');

module.exports = function (Messaging) {
    Messaging.notifyQueue = {}; // Only used to notify a user of a new chat message, see Messaging.notifyUser

    Messaging.notifyUsersInRoom = async (fromUid, roomId, messageObj) => {
        let uids = await Messaging.getUidsInRoom(roomId, 0, -1);
        uids = await user.blocks.filterUids(fromUid, uids);

        let data = {
            roomId: roomId,
            fromUid: fromUid,
            message: messageObj,
            uids: uids,
        };
        data = await plugins.hooks.fire('filter:messaging.notify', data);
        if (!data || !data.uids || !data.uids.length) {
            return;
        }

        uids = data.uids;
        uids.forEach((uid) => {
            data.self = parseInt(uid, 10) === parseInt(fromUid, 10) ? 1 : 0;
            Messaging.pushUnreadCount(uid);
            sockets.in(`uid_${uid}`).emit('event:chats.receive', data);
        });
        if (messageObj.system) {
            return;
        }
        // Delayed notifications
        let queueObj = Messaging.notifyQueue[`${fromUid}:${roomId}`];
        if (queueObj) {
            queueObj.message.content += `\n${messageObj.content}`;
            clearTimeout(queueObj.timeout);
        } else {
            queueObj = {
                message: messageObj,
            };
            Messaging.notifyQueue[`${fromUid}:${roomId}`] = queueObj;
        }

        queueObj.timeout = setTimeout(async () => {
            try {
                await sendNotifications(fromUid, uids, roomId, queueObj.message);
            } catch (err) {
                winston.error(`[messaging/notifications] Unabled to send notification\n${err.stack}`);
            }
        }, meta.config.notificationSendDelay * 1000);
    };

    async function sendNotifications(fromuid, uids, roomId, messageObj) {
        const isOnline = await user.isOnline(uids);
        uids = uids.filter((uid, index) => !isOnline[index] && parseInt(fromuid, 10) !== parseInt(uid, 10));
        if (!uids.length) {
            return;
        }

        const { displayname } = messageObj.fromUser;

        const isGroupChat = await Messaging.isGroupChat(roomId);
        const notification = await notifications.create({
            type: isGroupChat ? 'new-group-chat' : 'new-chat',
            subject: `[[email:notif.chat.subject, ${displayname}]]`,
            bodyShort: `[[notifications:new_message_from, ${displayname}]]`,
            bodyLong: messageObj.content,
            nid: `chat_${fromuid}_${roomId}`,
            from: fromuid,
            path: `/chats/${messageObj.roomId}`,
        });

        delete Messaging.notifyQueue[`${fromuid}:${roomId}`];
        notifications.push(notification, uids);
    }
};

1	'use strict';
2
3	const winston = require('winston');	20✔
4
5	const user = require('../user');	20✔
6	const notifications = require('../notifications');	20✔
7	const sockets = require('../socket.io');	20✔
8	const plugins = require('../plugins');	20✔
9	const meta = require('../meta');	20✔
10
11	module.exports = function (Messaging) {	20✔
12	Messaging.notifyQueue = {}; // Only used to notify a user of a new chat message, see Messaging.notifyUser	20✔
13
14	Messaging.notifyUsersInRoom = async (fromUid, roomId, messageObj) => {	20✔
15	let uids = await Messaging.getUidsInRoom(roomId, 0, -1);	176✔
16	uids = await user.blocks.filterUids(fromUid, uids);	176✔
17
18	let data = {	176✔
19	roomId: roomId,
20	fromUid: fromUid,
21	message: messageObj,
22	uids: uids,
23	};
24	data = await plugins.hooks.fire('filter:messaging.notify', data);	176✔
25	if (!data \|\| !data.uids \|\| !data.uids.length) {	176✔
26	return;	4✔
27	}
28
29	uids = data.uids;	172✔
30	uids.forEach((uid) => {	172✔
31	data.self = parseInt(uid, 10) === parseInt(fromUid, 10) ? 1 : 0;	364✔
32	Messaging.pushUnreadCount(uid);	364✔
33	sockets.in(`uid_${uid}`).emit('event:chats.receive', data);	364✔
34	});
35	if (messageObj.system) {	172✔
36	return;	144✔
37	}
38	// Delayed notifications
39	let queueObj = Messaging.notifyQueue[`${fromUid}:${roomId}`];	28✔
40	if (queueObj) {	28✔
41	queueObj.message.content += `\n${messageObj.content}`;	7✔
42	clearTimeout(queueObj.timeout);	7✔
43	} else {
44	queueObj = {	21✔
45	message: messageObj,
46	};
47	Messaging.notifyQueue[`${fromUid}:${roomId}`] = queueObj;	21✔
48	}
49
50	queueObj.timeout = setTimeout(async () => {	28✔
51	try {	22✔
52	await sendNotifications(fromUid, uids, roomId, queueObj.message);	22✔
53	} catch (err) {
54	winston.error(`[messaging/notifications] Unabled to send notification\n${err.stack}`);	8✔
55	}
56	}, meta.config.notificationSendDelay * 1000);
57	};
58
59	async function sendNotifications(fromuid, uids, roomId, messageObj) {
60	const isOnline = await user.isOnline(uids);	22✔
61	uids = uids.filter((uid, index) => !isOnline[index] && parseInt(fromuid, 10) !== parseInt(uid, 10));	56✔
62	if (!uids.length) {	22!
UNCOV 63	return;	×
64	}
65
66	const { displayname } = messageObj.fromUser;	22✔
67
68	const isGroupChat = await Messaging.isGroupChat(roomId);	22✔
69	const notification = await notifications.create({	14✔
70	type: isGroupChat ? 'new-group-chat' : 'new-chat',	14✔
71	subject: `[[email:notif.chat.subject, ${displayname}]]`,
72	bodyShort: `[[notifications:new_message_from, ${displayname}]]`,
73	bodyLong: messageObj.content,
74	nid: `chat_${fromuid}_${roomId}`,
75	from: fromuid,
76	path: `/chats/${messageObj.roomId}`,
77	});
78
79	delete Messaging.notifyQueue[`${fromuid}:${roomId}`];	14✔
80	notifications.push(notification, uids);	14✔
81	}
82	};

CMU-17313Q / fall23-nodebb-generation-z / 6423986614

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous