6343399494

Committed 28 Sep 2023 07:28PM UTC coverage: 84.932% (-0.04%) from 84.968%

Build # 6343399494

Build Type

Pull #45

github

Committed by

web-flow

Commit Message

Merge 93975d1d9 into 83bbf7ae1

Pull Request Pull Request #45: Implemented Resolve Back-End and Linked it to the Front-End

Run Details

10187 of 13235 branches covered (0.0%)

Branch coverage included in aggregate %.

3 of 9 new or added lines in 2 files covered. (33.33%)

3 existing lines in 2 files now uncovered.

22579 of 25344 relevant lines covered (89.09%)

3098.91 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.75

/src/controllers/topics.js

'use strict';

const nconf = require('nconf');
const qs = require('querystring');

const user = require('../user');
const meta = require('../meta');
const topics = require('../topics');
const categories = require('../categories');
const posts = require('../posts');
const privileges = require('../privileges');
const helpers = require('./helpers');
const pagination = require('../pagination');
const utils = require('../utils');
const analytics = require('../analytics');
// imported the db --maria
const db = require('../database');


const topicsController = module.exports;

const url = nconf.get('url');
const relative_path = nconf.get('relative_path');
const upload_url = nconf.get('upload_url');

topicsController.get = async function getTopic(req, res, next) {
    const tid = req.params.topic_id;

    if (
        (req.params.post_index && !utils.isNumber(req.params.post_index) && req.params.post_index !== 'unread') ||
        !utils.isNumber(tid)
    ) {
        return next();
    }
    let postIndex = parseInt(req.params.post_index, 10) || 1;
    const [
        userPrivileges,
        settings,
        topicData,
        rssToken,
    ] = await Promise.all([
        privileges.topics.get(tid, req.uid),
        user.getSettings(req.uid),
        topics.getTopicData(tid),
        user.auth.getFeedToken(req.uid),
    ]);

    let currentPage = parseInt(req.query.page, 10) || 1;
    const pageCount = Math.max(1, Math.ceil((topicData && topicData.postcount) / settings.postsPerPage));
    const invalidPagination = (settings.usePagination && (currentPage < 1 || currentPage > pageCount));
    if (
        !topicData ||
        userPrivileges.disabled ||
        invalidPagination ||
        (topicData.scheduled && !userPrivileges.view_scheduled)
    ) {
        return next();
    }

    if (!userPrivileges['topics:read'] || (!topicData.scheduled && topicData.deleted && !userPrivileges.view_deleted)) {
        return helpers.notAllowed(req, res);
    }

    if (req.params.post_index === 'unread') {
        postIndex = await topics.getUserBookmark(tid, req.uid);
    }

    if (!res.locals.isAPI && (!req.params.slug || topicData.slug !== `${tid}/${req.params.slug}`) && (topicData.slug && topicData.slug !== `${tid}/`)) {
        return helpers.redirect(res, `/topic/${topicData.slug}${postIndex ? `/${postIndex}` : ''}${generateQueryString(req.query)}`, true);
    }

    if (utils.isNumber(postIndex) && topicData.postcount > 0 && (postIndex < 1 || postIndex > topicData.postcount)) {
        return helpers.redirect(res, `/topic/${tid}/${req.params.slug}${postIndex > topicData.postcount ? `/${topicData.postcount}` : ''}${generateQueryString(req.query)}`);
    }
    postIndex = Math.max(1, postIndex);
    const sort = req.query.sort || settings.topicPostSort;
    const set = sort === 'most_votes' ? `tid:${tid}:posts:votes` : `tid:${tid}:posts`;
    const reverse = sort === 'newest_to_oldest' || sort === 'most_votes';
    if (settings.usePagination && !req.query.page) {
        currentPage = calculatePageFromIndex(postIndex, settings);
    }
    const { start, stop } = calculateStartStop(currentPage, postIndex, settings);

    await topics.getTopicWithPosts(topicData, set, req.uid, start, stop, reverse);

    topics.modifyPostsByPrivilege(topicData, userPrivileges);
    topicData.tagWhitelist = categories.filterTagWhitelist(topicData.tagWhitelist, userPrivileges.isAdminOrMod);

    topicData.privileges = userPrivileges;
    topicData.topicStaleDays = meta.config.topicStaleDays;
    topicData['reputation:disabled'] = meta.config['reputation:disabled'];
    topicData['downvote:disabled'] = meta.config['downvote:disabled'];
    topicData['feeds:disableRSS'] = meta.config['feeds:disableRSS'] || 0;
    topicData['signatures:hideDuplicates'] = meta.config['signatures:hideDuplicates'];
    topicData.bookmarkThreshold = meta.config.bookmarkThreshold;
    topicData.necroThreshold = meta.config.necroThreshold;
    topicData.postEditDuration = meta.config.postEditDuration;
    topicData.postDeleteDuration = meta.config.postDeleteDuration;
    topicData.scrollToMyPost = settings.scrollToMyPost;
    topicData.updateUrlWithPostIndex = settings.updateUrlWithPostIndex;
    topicData.allowMultipleBadges = meta.config.allowMultipleBadges === 1;
    topicData.privateUploads = meta.config.privateUploads === 1;
    topicData.showPostPreviewsOnHover = meta.config.showPostPreviewsOnHover === 1;
    topicData.rssFeedUrl = `${relative_path}/topic/${topicData.tid}.rss`;
    if (req.loggedIn) {
        topicData.rssFeedUrl += `?uid=${req.uid}&token=${rssToken}`;
    }

    topicData.postIndex = postIndex;

    await Promise.all([
        buildBreadcrumbs(topicData),
        addOldCategory(topicData, userPrivileges),
        addTags(topicData, req, res),
        incrementViewCount(req, tid),
        markAsRead(req, tid),
        analytics.increment([`pageviews:byCid:${topicData.category.cid}`]),
    ]);

    topicData.pagination = pagination.create(currentPage, pageCount, req.query);
    topicData.pagination.rel.forEach((rel) => {
        rel.href = `${url}/topic/${topicData.slug}${rel.href}`;
        res.locals.linkTags.push(rel);
    });

    res.render('topic', topicData);
};

function generateQueryString(query) {
    const qString = qs.stringify(query);
    return qString.length ? `?${qString}` : '';
}

function calculatePageFromIndex(postIndex, settings) {
    return 1 + Math.floor((postIndex - 1) / settings.postsPerPage);
}

function calculateStartStop(page, postIndex, settings) {
    let startSkip = 0;

    if (!settings.usePagination) {
        if (postIndex > 1) {
            page = 1;
        }
        startSkip = Math.max(0, postIndex - Math.ceil(settings.postsPerPage / 2));
    }

    const start = ((page - 1) * settings.postsPerPage) + startSkip;
    const stop = start + settings.postsPerPage - 1;
    return { start: Math.max(0, start), stop: Math.max(0, stop) };
}

async function incrementViewCount(req, tid) {
    const allow = req.uid > 0 || (meta.config.guestsIncrementTopicViews && req.uid === 0);
    if (allow) {
        req.session.tids_viewed = req.session.tids_viewed || {};
        const now = Date.now();
        const interval = meta.config.incrementTopicViewsInterval * 60000;
        if (!req.session.tids_viewed[tid] || req.session.tids_viewed[tid] < now - interval) {
            await topics.increaseViewCount(tid);
            req.session.tids_viewed[tid] = now;
        }
    }
}

async function markAsRead(req, tid) {
    if (req.loggedIn) {
        const markedRead = await topics.markAsRead([tid], req.uid);
        const promises = [topics.markTopicNotificationsRead([tid], req.uid)];
        if (markedRead) {
            promises.push(topics.pushUnreadCount(req.uid));
        }
        await Promise.all(promises);
    }
}

async function buildBreadcrumbs(topicData) {
    const breadcrumbs = [
        {
            text: topicData.category.name,
            url: `${relative_path}/category/${topicData.category.slug}`,
            cid: topicData.category.cid,
        },
        {
            text: topicData.title,
        },
    ];
    const parentCrumbs = await helpers.buildCategoryBreadcrumbs(topicData.category.parentCid);
    topicData.breadcrumbs = parentCrumbs.concat(breadcrumbs);
}

async function addOldCategory(topicData, userPrivileges) {
    if (userPrivileges.isAdminOrMod && topicData.oldCid) {
        topicData.oldCategory = await categories.getCategoryFields(
            topicData.oldCid, ['cid', 'name', 'icon', 'bgColor', 'color', 'slug']
        );
    }
}

async function addTags(topicData, req, res) {
    const postIndex = parseInt(req.params.post_index, 10) || 0;
    const postAtIndex = topicData.posts.find(p => parseInt(p.index, 10) === parseInt(Math.max(0, postIndex - 1), 10));
    let description = '';
    if (postAtIndex && postAtIndex.content) {
        description = utils.stripHTMLTags(utils.decodeHTMLEntities(postAtIndex.content));
    }

    if (description.length > 255) {
        description = `${description.slice(0, 255)}...`;
    }
    description = description.replace(/\n/g, ' ');

    res.locals.metaTags = [
        {
            name: 'title',
            content: topicData.titleRaw,
        },
        {
            name: 'description',
            content: description,
        },
        {
            property: 'og:title',
            content: topicData.titleRaw,
        },
        {
            property: 'og:description',
            content: description,
        },
        {
            property: 'og:type',
            content: 'article',
        },
        {
            property: 'article:published_time',
            content: utils.toISOString(topicData.timestamp),
        },
        {
            property: 'article:modified_time',
            content: utils.toISOString(topicData.lastposttime),
        },
        {
            property: 'article:section',
            content: topicData.category ? topicData.category.name : '',
        },
    ];

    await addOGImageTags(res, topicData, postAtIndex);

    res.locals.linkTags = [
        {
            rel: 'canonical',
            href: `${url}/topic/${topicData.slug}`,
        },
    ];

    if (!topicData['feeds:disableRSS']) {
        res.locals.linkTags.push({
            rel: 'alternate',
            type: 'application/rss+xml',
            href: topicData.rssFeedUrl,
        });
    }

    if (topicData.category) {
        res.locals.linkTags.push({
            rel: 'up',
            href: `${url}/category/${topicData.category.slug}`,
        });
    }
}

async function addOGImageTags(res, topicData, postAtIndex) {
    const uploads = postAtIndex ? await posts.uploads.listWithSizes(postAtIndex.pid) : [];
    const images = uploads.map((upload) => {
        upload.name = `${url + upload_url}/${upload.name}`;
        return upload;
    });
    if (topicData.thumbs) {
        const path = require('path');
        const thumbs = topicData.thumbs.filter(
            t => t && images.every(img => path.normalize(img.name) !== path.normalize(url + t.url))
        );
        images.push(...thumbs.map(thumbObj => ({ name: url + thumbObj.url })));
    }
    if (topicData.category.backgroundImage && (!postAtIndex || !postAtIndex.index)) {
        images.push(topicData.category.backgroundImage);
    }
    if (postAtIndex && postAtIndex.user && postAtIndex.user.picture) {
        images.push(postAtIndex.user.picture);
    }
    images.forEach(path => addOGImageTag(res, path));
}

function addOGImageTag(res, image) {
    let imageUrl;
    if (typeof image === 'string' && !image.startsWith('http')) {
        imageUrl = url + image.replace(new RegExp(`^${relative_path}`), '');
    } else if (typeof image === 'object') {
        imageUrl = image.name;
    } else {
        imageUrl = image;
    }

    res.locals.metaTags.push({
        property: 'og:image',
        content: imageUrl,
        noEscape: true,
    }, {
        property: 'og:image:url',
        content: imageUrl,
        noEscape: true,
    });

    if (typeof image === 'object' && image.width && image.height) {
        res.locals.metaTags.push({
            property: 'og:image:width',
            content: String(image.width),
        }, {
            property: 'og:image:height',
            content: String(image.height),
        });
    }
}

topicsController.teaser = async function (req, res, next) {
    const tid = req.params.topic_id;
    if (!utils.isNumber(tid)) {
        return next();
    }
    const canRead = await privileges.topics.can('topics:read', tid, req.uid);
    if (!canRead) {
        return res.status(403).json('[[error:no-privileges]]');
    }
    const pid = await topics.getLatestUndeletedPid(tid);
    if (!pid) {
        return res.status(404).json('not-found');
    }
    const postData = await posts.getPostSummaryByPids([pid], req.uid, { stripTags: false });
    if (!postData.length) {
        return res.status(404).json('not-found');
    }
    res.json(postData[0]);
};

topicsController.pagination = async function (req, res, next) {
    const tid = req.params.topic_id;
    const currentPage = parseInt(req.query.page, 10) || 1;

    if (!utils.isNumber(tid)) {
        return next();
    }

    const [userPrivileges, settings, topic] = await Promise.all([
        privileges.topics.get(tid, req.uid),
        user.getSettings(req.uid),
        topics.getTopicData(tid),
    ]);

    if (!topic) {
        return next();
    }

    if (!userPrivileges.read || !privileges.topics.canViewDeletedScheduled(topic, userPrivileges)) {
        return helpers.notAllowed(req, res);
    }

    const postCount = topic.postcount;
    const pageCount = Math.max(1, Math.ceil(postCount / settings.postsPerPage));

    const paginationData = pagination.create(currentPage, pageCount);
    paginationData.rel.forEach((rel) => {
        rel.href = `${url}/topic/${topic.slug}${rel.href}`;
    });

    res.json({ pagination: paginationData });
};

// added a controller function for the resolve attribute
topicsController.postIsResolved = async function (req, res) {
    // added a try and catch to test for exceptions
    try {
        // retrieve the topicID
        const tid = Number(req.params.topic_id);
        await db.setObjectField(`topic:${tid}`, 'isResolved', true);
        const topicData = await topicsController.get(req, req.params);
        // an API response for success!
        helpers.formatApiResponse(200, res, topicData);
    } catch (error) {
        // Handling the error from the API
        helpers.formatApiResponse(500, res, { error: 'Error' });
    }
};

1	'use strict';
2
3	const nconf = require('nconf');	4✔
4	const qs = require('querystring');	4✔
5
6	const user = require('../user');	4✔
7	const meta = require('../meta');	4✔
8	const topics = require('../topics');	4✔
9	const categories = require('../categories');	4✔
10	const posts = require('../posts');	4✔
11	const privileges = require('../privileges');	4✔
12	const helpers = require('./helpers');	4✔
13	const pagination = require('../pagination');	4✔
14	const utils = require('../utils');	4✔
15	const analytics = require('../analytics');	4✔
16	// imported the db --maria
17	const db = require('../database');	4✔
18
19
20	const topicsController = module.exports;	4✔
21
22	const url = nconf.get('url');	4✔
23	const relative_path = nconf.get('relative_path');	4✔
24	const upload_url = nconf.get('upload_url');	4✔
25
26	topicsController.get = async function getTopic(req, res, next) {	4✔
27	const tid = req.params.topic_id;	120✔
28
29	if (	120✔
30	(req.params.post_index && !utils.isNumber(req.params.post_index) && req.params.post_index !== 'unread') \|\|	260✔
31	!utils.isNumber(tid)
32	) {
33	return next();	36✔
34	}
35	let postIndex = parseInt(req.params.post_index, 10) \|\| 1;	84✔
36	const [
37	userPrivileges,
38	settings,
39	topicData,
40	rssToken,
41	] = await Promise.all([	84✔
42	privileges.topics.get(tid, req.uid),
43	user.getSettings(req.uid),
44	topics.getTopicData(tid),
45	user.auth.getFeedToken(req.uid),
46	]);
47
48	let currentPage = parseInt(req.query.page, 10) \|\| 1;	84✔
49	const pageCount = Math.max(1, Math.ceil((topicData && topicData.postcount) / settings.postsPerPage));	84✔
50	const invalidPagination = (settings.usePagination && (currentPage < 1 \|\| currentPage > pageCount));	84✔
51	if (	84✔
52	!topicData \|\|	324✔
53	userPrivileges.disabled \|\|
54	invalidPagination \|\|
55	(topicData.scheduled && !userPrivileges.view_scheduled)
56	) {
57	return next();	24✔
58	}
59
60	if (!userPrivileges['topics:read'] \|\| (!topicData.scheduled && topicData.deleted && !userPrivileges.view_deleted)) {	60✔
61	return helpers.notAllowed(req, res);	4✔
62	}
63
64	if (req.params.post_index === 'unread') {	56!
65	postIndex = await topics.getUserBookmark(tid, req.uid);	×
66	}
67
68	if (!res.locals.isAPI && (!req.params.slug \|\| topicData.slug !== `${tid}/${req.params.slug}`) && (topicData.slug && topicData.slug !== `${tid}/`)) {	56✔
69	return helpers.redirect(res, `/topic/${topicData.slug}${postIndex ? `/${postIndex}` : ''}${generateQueryString(req.query)}`, true);	8!
70	}
71
72	if (utils.isNumber(postIndex) && topicData.postcount > 0 && (postIndex < 1 \|\| postIndex > topicData.postcount)) {	48✔
73	return helpers.redirect(res, `/topic/${tid}/${req.params.slug}${postIndex > topicData.postcount ? `/${topicData.postcount}` : ''}${generateQueryString(req.query)}`);	4!
74	}
75	postIndex = Math.max(1, postIndex);	44✔
76	const sort = req.query.sort \|\| settings.topicPostSort;	44✔
77	const set = sort === 'most_votes' ? `tid:${tid}:posts:votes` : `tid:${tid}:posts`;	44!
78	const reverse = sort === 'newest_to_oldest' \|\| sort === 'most_votes';	44✔
79	if (settings.usePagination && !req.query.page) {	44✔
80	currentPage = calculatePageFromIndex(postIndex, settings);	20✔
81	}
82	const { start, stop } = calculateStartStop(currentPage, postIndex, settings);	44✔
83
84	await topics.getTopicWithPosts(topicData, set, req.uid, start, stop, reverse);	44✔
85
86	topics.modifyPostsByPrivilege(topicData, userPrivileges);	44✔
87	topicData.tagWhitelist = categories.filterTagWhitelist(topicData.tagWhitelist, userPrivileges.isAdminOrMod);	44✔
88
89	topicData.privileges = userPrivileges;	44✔
90	topicData.topicStaleDays = meta.config.topicStaleDays;	44✔
91	topicData['reputation:disabled'] = meta.config['reputation:disabled'];	44✔
92	topicData['downvote:disabled'] = meta.config['downvote:disabled'];	44✔
93	topicData['feeds:disableRSS'] = meta.config['feeds:disableRSS'] \|\| 0;	44✔
94	topicData['signatures:hideDuplicates'] = meta.config['signatures:hideDuplicates'];	44✔
95	topicData.bookmarkThreshold = meta.config.bookmarkThreshold;	44✔
96	topicData.necroThreshold = meta.config.necroThreshold;	44✔
97	topicData.postEditDuration = meta.config.postEditDuration;	44✔
98	topicData.postDeleteDuration = meta.config.postDeleteDuration;	44✔
99	topicData.scrollToMyPost = settings.scrollToMyPost;	44✔
100	topicData.updateUrlWithPostIndex = settings.updateUrlWithPostIndex;	44✔
101	topicData.allowMultipleBadges = meta.config.allowMultipleBadges === 1;	44✔
102	topicData.privateUploads = meta.config.privateUploads === 1;	44✔
103	topicData.showPostPreviewsOnHover = meta.config.showPostPreviewsOnHover === 1;	44✔
104	topicData.rssFeedUrl = `${relative_path}/topic/${topicData.tid}.rss`;	44✔
105	if (req.loggedIn) {	44✔
106	topicData.rssFeedUrl += `?uid=${req.uid}&token=${rssToken}`;	16✔
107	}
108
109	topicData.postIndex = postIndex;	44✔
110
111	await Promise.all([	44✔
112	buildBreadcrumbs(topicData),
113	addOldCategory(topicData, userPrivileges),
114	addTags(topicData, req, res),
115	incrementViewCount(req, tid),
116	markAsRead(req, tid),
117	analytics.increment([`pageviews:byCid:${topicData.category.cid}`]),
118	]);
119
120	topicData.pagination = pagination.create(currentPage, pageCount, req.query);	44✔
121	topicData.pagination.rel.forEach((rel) => {	44✔
122	rel.href = `${url}/topic/${topicData.slug}${rel.href}`;	×
123	res.locals.linkTags.push(rel);	×
124	});
125
126	res.render('topic', topicData);	44✔
127	};
128
129	function generateQueryString(query) {
130	const qString = qs.stringify(query);	12✔
131	return qString.length ? `?${qString}` : '';	12✔
132	}
133
134	function calculatePageFromIndex(postIndex, settings) {
135	return 1 + Math.floor((postIndex - 1) / settings.postsPerPage);	20✔
136	}
137
138	function calculateStartStop(page, postIndex, settings) {
139	let startSkip = 0;	44✔
140
141	if (!settings.usePagination) {	44✔
142	if (postIndex > 1) {	24!
143	page = 1;	×
144	}
145	startSkip = Math.max(0, postIndex - Math.ceil(settings.postsPerPage / 2));	24✔
146	}
147
148	const start = ((page - 1) * settings.postsPerPage) + startSkip;	44✔
149	const stop = start + settings.postsPerPage - 1;	44✔
150	return { start: Math.max(0, start), stop: Math.max(0, stop) };	44✔
151	}
152
153	async function incrementViewCount(req, tid) {
154	const allow = req.uid > 0 \|\| (meta.config.guestsIncrementTopicViews && req.uid === 0);	44✔
155	if (allow) {	44!
156	req.session.tids_viewed = req.session.tids_viewed \|\| {};	44✔
157	const now = Date.now();	44✔
158	const interval = meta.config.incrementTopicViewsInterval * 60000;	44✔
159	if (!req.session.tids_viewed[tid] \|\| req.session.tids_viewed[tid] < now - interval) {	44!
160	await topics.increaseViewCount(tid);	44✔
161	req.session.tids_viewed[tid] = now;	44✔
162	}
163	}
164	}
165
166	async function markAsRead(req, tid) {
167	if (req.loggedIn) {	44✔
168	const markedRead = await topics.markAsRead([tid], req.uid);	16✔
169	const promises = [topics.markTopicNotificationsRead([tid], req.uid)];	16✔
170	if (markedRead) {	16✔
171	promises.push(topics.pushUnreadCount(req.uid));	8✔
172	}
173	await Promise.all(promises);	16✔
174	}
175	}
176
177	async function buildBreadcrumbs(topicData) {
178	const breadcrumbs = [	44✔
179	{
180	text: topicData.category.name,
181	url: `${relative_path}/category/${topicData.category.slug}`,
182	cid: topicData.category.cid,
183	},
184	{
185	text: topicData.title,
186	},
187	];
188	const parentCrumbs = await helpers.buildCategoryBreadcrumbs(topicData.category.parentCid);	44✔
189	topicData.breadcrumbs = parentCrumbs.concat(breadcrumbs);	44✔
190	}
191
192	async function addOldCategory(topicData, userPrivileges) {
193	if (userPrivileges.isAdminOrMod && topicData.oldCid) {	44!
194	topicData.oldCategory = await categories.getCategoryFields(	×
195	topicData.oldCid, ['cid', 'name', 'icon', 'bgColor', 'color', 'slug']
196	);
197	}
198	}
199
200	async function addTags(topicData, req, res) {
201	const postIndex = parseInt(req.params.post_index, 10) \|\| 0;	44✔
202	const postAtIndex = topicData.posts.find(p => parseInt(p.index, 10) === parseInt(Math.max(0, postIndex - 1), 10));	44✔
203	let description = '';	44✔
204	if (postAtIndex && postAtIndex.content) {	44✔
205	description = utils.stripHTMLTags(utils.decodeHTMLEntities(postAtIndex.content));	36✔
206	}
207
208	if (description.length > 255) {	44!
209	description = `${description.slice(0, 255)}...`;	×
210	}
211	description = description.replace(/\n/g, ' ');	44✔
212
213	res.locals.metaTags = [	44✔
214	{
215	name: 'title',
216	content: topicData.titleRaw,
217	},
218	{
219	name: 'description',
220	content: description,
221	},
222	{
223	property: 'og:title',
224	content: topicData.titleRaw,
225	},
226	{
227	property: 'og:description',
228	content: description,
229	},
230	{
231	property: 'og:type',
232	content: 'article',
233	},
234	{
235	property: 'article:published_time',
236	content: utils.toISOString(topicData.timestamp),
237	},
238	{
239	property: 'article:modified_time',
240	content: utils.toISOString(topicData.lastposttime),
241	},
242	{
243	property: 'article:section',
244	content: topicData.category ? topicData.category.name : '',	44!
245	},
246	];
247
248	await addOGImageTags(res, topicData, postAtIndex);	44✔
249
250	res.locals.linkTags = [	44✔
251	{
252	rel: 'canonical',
253	href: `${url}/topic/${topicData.slug}`,
254	},
255	];
256
257	if (!topicData['feeds:disableRSS']) {	44!
258	res.locals.linkTags.push({	44✔
259	rel: 'alternate',
260	type: 'application/rss+xml',
261	href: topicData.rssFeedUrl,
262	});
263	}
264
265	if (topicData.category) {	44!
266	res.locals.linkTags.push({	44✔
267	rel: 'up',
268	href: `${url}/category/${topicData.category.slug}`,
269	});
270	}
271	}
272
273	async function addOGImageTags(res, topicData, postAtIndex) {
274	const uploads = postAtIndex ? await posts.uploads.listWithSizes(postAtIndex.pid) : [];	44✔
275	const images = uploads.map((upload) => {	44✔
276	upload.name = `${url + upload_url}/${upload.name}`;	×
277	return upload;	×
278	});
279	if (topicData.thumbs) {	44!
280	const path = require('path');	44✔
281	const thumbs = topicData.thumbs.filter(	44✔
282	t => t && images.every(img => path.normalize(img.name) !== path.normalize(url + t.url))	×
283	);
284	images.push(...thumbs.map(thumbObj => ({ name: url + thumbObj.url })));	44✔
285	}
286	if (topicData.category.backgroundImage && (!postAtIndex \|\| !postAtIndex.index)) {	44!
287	images.push(topicData.category.backgroundImage);	×
288	}
289	if (postAtIndex && postAtIndex.user && postAtIndex.user.picture) {	44✔
290	images.push(postAtIndex.user.picture);	4✔
291	}
292	images.forEach(path => addOGImageTag(res, path));	44✔
293	}
294
295	function addOGImageTag(res, image) {
296	let imageUrl;
297	if (typeof image === 'string' && !image.startsWith('http')) {	4!
298	imageUrl = url + image.replace(new RegExp(`^${relative_path}`), '');	4✔
299	} else if (typeof image === 'object') {	×
300	imageUrl = image.name;	×
301	} else {
302	imageUrl = image;	×
303	}
304
305	res.locals.metaTags.push({	4✔
306	property: 'og:image',
307	content: imageUrl,
308	noEscape: true,
309	}, {
310	property: 'og:image:url',
311	content: imageUrl,
312	noEscape: true,
313	});
314
315	if (typeof image === 'object' && image.width && image.height) {	4!
316	res.locals.metaTags.push({	×
317	property: 'og:image:width',
318	content: String(image.width),
319	}, {
320	property: 'og:image:height',
321	content: String(image.height),
322	});
323	}
324	}
325
326	topicsController.teaser = async function (req, res, next) {	4✔
327	const tid = req.params.topic_id;	12✔
328	if (!utils.isNumber(tid)) {	12✔
329	return next();	4✔
330	}
331	const canRead = await privileges.topics.can('topics:read', tid, req.uid);	8✔
332	if (!canRead) {	8✔
333	return res.status(403).json('[[error:no-privileges]]');	4✔
334	}
335	const pid = await topics.getLatestUndeletedPid(tid);	4✔
336	if (!pid) {	4!
337	return res.status(404).json('not-found');	×
338	}
339	const postData = await posts.getPostSummaryByPids([pid], req.uid, { stripTags: false });	4✔
340	if (!postData.length) {	4!
341	return res.status(404).json('not-found');	×
342	}
343	res.json(postData[0]);	4✔
344	};
345
346	topicsController.pagination = async function (req, res, next) {	4✔
347	const tid = req.params.topic_id;	12✔
348	const currentPage = parseInt(req.query.page, 10) \|\| 1;	12✔
349
350	if (!utils.isNumber(tid)) {	12✔
351	return next();	4✔
352	}
353
354	const [userPrivileges, settings, topic] = await Promise.all([	8✔
355	privileges.topics.get(tid, req.uid),
356	user.getSettings(req.uid),
357	topics.getTopicData(tid),
358	]);
359
360	if (!topic) {	8✔
361	return next();	4✔
362	}
363
364	if (!userPrivileges.read \|\| !privileges.topics.canViewDeletedScheduled(topic, userPrivileges)) {	4!
365	return helpers.notAllowed(req, res);	×
366	}
367
368	const postCount = topic.postcount;	4✔
369	const pageCount = Math.max(1, Math.ceil(postCount / settings.postsPerPage));	4✔
370
371	const paginationData = pagination.create(currentPage, pageCount);	4✔
372	paginationData.rel.forEach((rel) => {	4✔
373	rel.href = `${url}/topic/${topic.slug}${rel.href}`;	×
374	});
375
376	res.json({ pagination: paginationData });	4✔
377	};
378
379	// added a controller function for the resolve attribute
380	topicsController.postIsResolved = async function (req, res) {	4✔
381	// added a try and catch to test for exceptions
NEW 382	try {	×
383	// retrieve the topicID
NEW 384	const tid = Number(req.params.topic_id);	×
NEW 385	await db.setObjectField(`topic:${tid}`, 'isResolved', true);	×
NEW 386	const topicData = await topicsController.get(req, req.params);	×
387	// an API response for success!
NEW 388	helpers.formatApiResponse(200, res, topicData);	×
389	} catch (error) {
390	// Handling the error from the API
NEW 391	helpers.formatApiResponse(500, res, { error: 'Error' });	×
392	}
393	};

CMU-17313Q / fall23-nodebb-just-relax / 6343399494

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous