• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

realm / realm-core / nicola.cabiddu_1042

27 Sep 2023 06:04PM UTC coverage: 91.085% (-1.8%) from 92.915%
nicola.cabiddu_1042

Pull #6766

Evergreen

nicola-cab
Fix logic for dictionaries
Pull Request #6766: Client Reset for collections in mixed / nested collections

97276 of 178892 branches covered (0.0%)

1994 of 2029 new or added lines in 7 files covered. (98.28%)

4556 existing lines in 112 files now uncovered.

237059 of 260260 relevant lines covered (91.09%)

6321099.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.32
/src/realm/replication.cpp
1
/*************************************************************************
2
 *
3
 * Copyright 2016 Realm Inc.
4
 *
5
 * Licensed under the Apache License, Version 2.0 (the "License");
6
 * you may not use this file except in compliance with the License.
7
 * You may obtain a copy of the License at
8
 *
9
 * http://www.apache.org/licenses/LICENSE-2.0
10
 *
11
 * Unless required by applicable law or agreed to in writing, software
12
 * distributed under the License is distributed on an "AS IS" BASIS,
13
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14
 * See the License for the specific language governing permissions and
15
 * limitations under the License.
16
 *
17
 **************************************************************************/
18

19
#include <realm/replication.hpp>
20
#include <realm/util/logger.hpp>
21

22
#include <realm/list.hpp>
23
#include <realm/path.hpp>
24
#include <iostream>
25

26
using namespace realm;
27
using namespace realm::util;
28

29
const char* Replication::history_type_name(int type)
30
{
18✔
31
    switch (type) {
18✔
32
        case hist_None:
✔
UNCOV
33
            return "None";
×
UNCOV
34
        case hist_OutOfRealm:
✔
UNCOV
35
            return "Local out of Realm";
×
36
        case hist_InRealm:
12✔
37
            return "Local in-Realm";
12✔
38
        case hist_SyncClient:
6✔
39
            return "SyncClient";
6✔
40
        case hist_SyncServer:
✔
UNCOV
41
            return "SyncServer";
×
UNCOV
42
        default:
✔
UNCOV
43
            return "Unknown";
×
44
    }
18✔
45
}
18✔
46

47
void Replication::initialize(DB&)
48
{
140,439✔
49
    // Nothing needs to be done here
69,066✔
50
}
140,439✔
51

52
void Replication::do_initiate_transact(Group&, version_type, bool)
53
{
1,375,116✔
54
    char* data = m_stream.get_data();
1,375,116✔
55
    size_t size = m_stream.get_size();
1,375,116✔
56
    m_encoder.set_buffer(data, data + size);
1,375,116✔
57
}
1,375,116✔
58

59
Replication::version_type Replication::prepare_commit(version_type orig_version)
60
{
1,345,188✔
61
    char* data = m_stream.get_data();
1,345,188✔
62
    size_t size = m_encoder.write_position() - data;
1,345,188✔
63
    version_type new_version = prepare_changeset(data, size, orig_version); // Throws
1,345,188✔
64
    return new_version;
1,345,188✔
65
}
1,345,188✔
66

67
void Replication::add_class(TableKey table_key, StringData name, Table::Type type)
68
{
202,668✔
69
    if (auto logger = get_logger()) {
202,668✔
70
        if (type == Table::Type::Embedded) {
162,624✔
71
            logger->log(util::Logger::Level::debug, "Add %1 class '%2'", type, name);
19,161✔
72
        }
19,161✔
73
        else {
143,463✔
74
            logger->log(util::Logger::Level::debug, "Add class '%1'", name);
143,463✔
75
        }
143,463✔
76
    }
162,624✔
77
    unselect_all();
202,668✔
78
    m_encoder.insert_group_level_table(table_key); // Throws
202,668✔
79
}
202,668✔
80

81
void Replication::add_class_with_primary_key(TableKey tk, StringData name, DataType pk_type, StringData pk_name, bool,
82
                                             Table::Type table_type)
83
{
129,423✔
84
    if (auto logger = get_logger()) {
129,423✔
85
        logger->log(util::Logger::Level::debug, "Add %1 class '%2' with primary key property '%3' of %4", table_type,
100,833✔
86
                    Group::table_name_to_class_name(name), pk_name, pk_type);
100,833✔
87
    }
100,833✔
88
    REALM_ASSERT(table_type != Table::Type::Embedded);
129,423✔
89
    unselect_all();
129,423✔
90
    m_encoder.insert_group_level_table(tk); // Throws
129,423✔
91
}
129,423✔
92

93
void Replication::erase_class(TableKey tk, StringData table_name, size_t)
94
{
7,566✔
95
    if (auto logger = get_logger()) {
7,566✔
96
        logger->log(util::Logger::Level::debug, "Remove class '%1'", Group::table_name_to_class_name(table_name));
24✔
97
    }
24✔
98
    unselect_all();
7,566✔
99
    m_encoder.erase_class(tk); // Throws
7,566✔
100
}
7,566✔
101

102

103
void Replication::insert_column(const Table* t, ColKey col_key, DataType type, StringData col_name,
104
                                Table* target_table)
105
{
751,644✔
106
    if (auto logger = get_logger()) {
751,644✔
107
        const char* collection_type = "";
698,820✔
108
        if (col_key.is_collection()) {
698,820✔
109
            if (col_key.is_list()) {
209,847✔
110
                collection_type = "list ";
94,944✔
111
            }
94,944✔
112
            else if (col_key.is_dictionary()) {
114,903✔
113
                collection_type = "dictionary ";
52,692✔
114
            }
52,692✔
115
            else {
62,211✔
116
                collection_type = "set ";
62,211✔
117
            }
62,211✔
118
        }
209,847✔
119
        if (target_table) {
698,820✔
120
            logger->log(util::Logger::Level::debug, "On class '%1': Add property '%2' %3linking '%4'",
75,075✔
121
                        t->get_class_name(), col_name, collection_type, target_table->get_class_name());
75,075✔
122
        }
75,075✔
123
        else {
623,745✔
124
            logger->log(util::Logger::Level::debug, "On class '%1': Add property '%2' %3of %4", t->get_class_name(),
623,745✔
125
                        col_name, collection_type, type);
623,745✔
126
        }
623,745✔
127
    }
698,820✔
128
    select_table(t);                  // Throws
751,644✔
129
    m_encoder.insert_column(col_key); // Throws
751,644✔
130
}
751,644✔
131

132
void Replication::erase_column(const Table* t, ColKey col_key)
133
{
531✔
134
    if (auto logger = get_logger()) {
531✔
135
        logger->log(util::Logger::Level::debug, "On class '%1': Remove property '%2'", t->get_class_name(),
438✔
136
                    t->get_column_name(col_key));
438✔
137
    }
438✔
138
    select_table(t);                 // Throws
531✔
139
    m_encoder.erase_column(col_key); // Throws
531✔
140
}
531✔
141

142
void Replication::create_object(const Table* t, GlobalKey id)
143
{
4,299,516✔
144
    if (auto logger = get_logger()) {
4,299,516✔
145
        logger->log(util::Logger::Level::debug, "Create object '%1'", t->get_class_name());
2,622,963✔
146
    }
2,622,963✔
147
    select_table(t);                              // Throws
4,299,516✔
148
    m_encoder.create_object(id.get_local_key(0)); // Throws
4,299,516✔
149
}
4,299,516✔
150

151
void Replication::create_object_with_primary_key(const Table* t, ObjKey key, Mixed pk)
152
{
448,617✔
153
    if (auto logger = get_logger()) {
448,617✔
154
        logger->log(util::Logger::Level::debug, "Create object '%1' with primary key %2", t->get_class_name(), pk);
191,277✔
155
    }
191,277✔
156
    select_table(t);              // Throws
448,617✔
157
    m_encoder.create_object(key); // Throws
448,617✔
158
}
448,617✔
159

160
void Replication::remove_object(const Table* t, ObjKey key)
161
{
5,008,032✔
162
    if (auto logger = get_logger()) {
5,008,032✔
163
        if (t->is_embedded()) {
2,459,268✔
164
            logger->log(util::Logger::Level::debug, "Remove embedded object '%1'", t->get_class_name());
8,817✔
165
        }
8,817✔
166
        else if (t->get_primary_key_column()) {
2,450,451✔
167
            logger->log(util::Logger::Level::debug, "Remove object '%1' with primary key %2", t->get_class_name(),
42,903✔
168
                        t->get_primary_key(key));
42,903✔
169
        }
42,903✔
170
        else {
2,407,548✔
171
            logger->log(util::Logger::Level::debug, "Remove object '%1'[%2]", t->get_class_name(), key);
2,407,548✔
172
        }
2,407,548✔
173
    }
2,459,268✔
174
    select_table(t);              // Throws
5,008,032✔
175
    m_encoder.remove_object(key); // Throws
5,008,032✔
176
}
5,008,032✔
177

178
inline void Replication::select_obj(ObjKey key)
179
{
16,721,154✔
180
    if (key == m_selected_obj) {
16,721,154✔
181
        return;
2,942,370✔
182
    }
2,942,370✔
183
    if (auto logger = get_logger()) {
13,778,784✔
184
        if (logger->would_log(util::Logger::Level::debug)) {
2,972,802✔
185
            auto class_name = m_selected_table->get_class_name();
2,971,305✔
186
            if (m_selected_table->get_primary_key_column()) {
2,971,305✔
187
                auto pk = m_selected_table->get_primary_key(key);
168,444✔
188
                logger->log(util::Logger::Level::debug, "Mutating object '%1' with primary key %2", class_name, pk);
168,444✔
189
            }
168,444✔
190
            else if (m_selected_table->is_embedded()) {
2,802,861✔
191
                auto obj = m_selected_table->get_object(key);
34,440✔
192
                logger->log(util::Logger::Level::debug, "Mutating object '%1' with path '%2'", class_name,
34,440✔
193
                            obj.get_id());
34,440✔
194
            }
34,440✔
195
            else {
2,768,421✔
196
                logger->log(util::Logger::Level::debug, "Mutating anonymous object '%1'[%2]", class_name, key);
2,768,421✔
197
            }
2,768,421✔
198
        }
2,971,305✔
199
    }
2,972,802✔
200
    m_selected_obj = key;
13,778,784✔
201
}
13,778,784✔
202

203
void Replication::do_set(const Table* t, ColKey col_key, ObjKey key, _impl::Instruction variant)
204
{
16,445,628✔
205
    if (variant != _impl::Instruction::instr_SetDefault) {
16,445,628✔
206
        select_table(t); // Throws
16,444,479✔
207
        select_obj(key);
16,444,479✔
208
        m_encoder.modify_object(col_key, key); // Throws
16,444,479✔
209
    }
16,444,479✔
210
}
16,445,628✔
211

212
void Replication::set(const Table* t, ColKey col_key, ObjKey key, Mixed value, _impl::Instruction variant)
213
{
16,434,150✔
214
    do_set(t, col_key, key, variant); // Throws
16,434,150✔
215
    if (auto logger = get_logger()) {
16,434,150✔
216
        if (logger->would_log(util::Logger::Level::trace)) {
3,114,360✔
217
            if (col_key.get_type() == col_type_Link && value.is_type(type_Link)) {
36!
UNCOV
218
                auto target_table = t->get_opposite_table(col_key);
×
UNCOV
219
                if (target_table->is_embedded()) {
×
UNCOV
220
                    logger->log(util::Logger::Level::trace, "   Creating embedded object '%1' in '%2'",
×
UNCOV
221
                                target_table->get_class_name(), t->get_column_name(col_key));
×
UNCOV
222
                }
×
UNCOV
223
                else if (target_table->get_primary_key_column()) {
×
UNCOV
224
                    auto link = value.get<ObjKey>();
×
UNCOV
225
                    auto pk = target_table->get_primary_key(link);
×
UNCOV
226
                    logger->log(util::Logger::Level::trace, "   Linking object '%1' with primary key %2 from '%3'",
×
UNCOV
227
                                target_table->get_class_name(), pk, t->get_column_name(col_key));
×
UNCOV
228
                }
×
UNCOV
229
                else {
×
UNCOV
230
                    logger->log(util::Logger::Level::trace, "   Linking object '%1'[%2] from '%3'",
×
UNCOV
231
                                target_table->get_class_name(), key, t->get_column_name(col_key));
×
UNCOV
232
                }
×
UNCOV
233
            }
×
234
            else {
36✔
235
                logger->log(util::Logger::Level::trace, "   Set '%1' to %2", t->get_column_name(col_key),
36✔
236
                            value.to_string(util::Logger::max_width_of_value));
36✔
237
            }
36✔
238
        }
36✔
239
    }
3,114,360✔
240
}
16,434,150✔
241

242
void Replication::nullify_link(const Table* t, ColKey col_key, ObjKey key)
243
{
759✔
244
    select_table(t); // Throws
759✔
245
    select_obj(key);
759✔
246
    m_encoder.modify_object(col_key, key); // Throws
759✔
247
    if (auto logger = get_logger()) {
759✔
248
        logger->log(util::Logger::Level::trace, "   Nullify '%1'", t->get_column_name(col_key));
669✔
249
    }
669✔
250
}
759✔
251

252
void Replication::add_int(const Table* t, ColKey col_key, ObjKey key, int_fast64_t value)
253
{
10,431✔
254
    do_set(t, col_key, key); // Throws
10,431✔
255
    if (auto logger = get_logger()) {
10,431✔
256
        logger->log(util::Logger::Level::trace, "   Adding %1 to '%2'", value, t->get_column_name(col_key));
87✔
257
    }
87✔
258
}
10,431✔
259

260

261
Path Replication::get_prop_name(Path&& path) const
262
{
32,475✔
263
    Path ret(std::move(path));
32,475✔
264
    auto col_key = ret[0].get_col_key();
32,475✔
265
    auto prop_name = m_selected_table->get_column_name(col_key);
32,475✔
266
    ret[0] = PathElement(prop_name);
32,475✔
267
    return ret;
32,475✔
268
}
32,475✔
269

270
void Replication::log_collection_operation(const char* operation, const CollectionBase& collection, Mixed value,
271
                                           Mixed index) const
272
{
18✔
273
    auto logger = get_logger();
18✔
274
    auto path = collection.get_short_path();
18✔
275
    auto col_key = path[0].get_col_key();
18✔
276
    auto prop_name = m_selected_table->get_column_name(col_key);
18✔
277
    path[0] = PathElement(prop_name);
18✔
278
    std::string position;
18✔
279
    if (!index.is_null()) {
18✔
280
        position = util::format(" at position %1", index);
12✔
281
    }
12✔
282
    if (Table::is_link_type(col_key.get_type()) && value.is_type(type_Link)) {
18!
UNCOV
283
        auto target_table = m_selected_table->get_opposite_table(col_key);
×
UNCOV
284
        if (target_table->is_embedded()) {
×
UNCOV
285
            logger->log(util::Logger::Level::trace, "   %1 embedded object '%2' in %3%4 ", operation,
×
UNCOV
286
                        target_table->get_class_name(), path, position);
×
UNCOV
287
        }
×
UNCOV
288
        else if (target_table->get_primary_key_column()) {
×
UNCOV
289
            auto link = value.get<ObjKey>();
×
UNCOV
290
            auto pk = target_table->get_primary_key(link);
×
UNCOV
291
            logger->log(util::Logger::Level::trace, "   %1 object '%2' with primary key %3 in %4%5", operation,
×
UNCOV
292
                        target_table->get_class_name(), pk, path, position);
×
UNCOV
293
        }
×
UNCOV
294
        else {
×
UNCOV
295
            auto link = value.get<ObjKey>();
×
UNCOV
296
            logger->log(util::Logger::Level::trace, "   %1 object '%2'[%3] in %4%5", operation,
×
UNCOV
297
                        target_table->get_class_name(), link, path, position);
×
UNCOV
298
        }
×
UNCOV
299
    }
×
300
    else {
18✔
301
        logger->log(util::Logger::Level::trace, "   %1 %2 in %3%4", operation,
18✔
302
                    value.to_string(util::Logger::max_width_of_value), path, position);
18✔
303
    }
18✔
304
}
18✔
305
void Replication::list_insert(const CollectionBase& list, size_t list_ndx, Mixed value, size_t)
306
{
1,168,890✔
307
    select_collection(list);                                     // Throws
1,168,890✔
308
    m_encoder.collection_insert(list.translate_index(list_ndx)); // Throws
1,168,890✔
309
    if (auto logger = get_logger()) {
1,168,890✔
310
        if (logger->would_log(util::Logger::Level::trace)) {
519,792✔
311
            log_collection_operation("Insert", list, value, int64_t(list_ndx));
6✔
312
        }
6✔
313
    }
519,792✔
314
}
1,168,890✔
315

316
void Replication::list_set(const CollectionBase& list, size_t list_ndx, Mixed value)
317
{
42,744✔
318
    select_collection(list);                                  // Throws
42,744✔
319
    m_encoder.collection_set(list.translate_index(list_ndx)); // Throws
42,744✔
320
    if (auto logger = get_logger()) {
42,744✔
321
        if (logger->would_log(util::Logger::Level::trace)) {
8,970✔
UNCOV
322
            log_collection_operation("Set", list, value, int64_t(list_ndx));
×
UNCOV
323
        }
×
324
    }
8,970✔
325
}
42,744✔
326

327
void Replication::list_erase(const CollectionBase& list, size_t link_ndx)
328
{
208,539✔
329
    select_collection(list);                                    // Throws
208,539✔
330
    m_encoder.collection_erase(list.translate_index(link_ndx)); // Throws
208,539✔
331
    if (auto logger = get_logger()) {
208,539✔
332
        logger->log(util::Logger::Level::trace, "   Erase '%1' at position %2", get_prop_name(list.get_short_path()),
6,654✔
333
                    link_ndx);
6,654✔
334
    }
6,654✔
335
}
208,539✔
336

337
void Replication::list_move(const CollectionBase& list, size_t from_link_ndx, size_t to_link_ndx)
338
{
1,638✔
339
    select_collection(list);                                                                           // Throws
1,638✔
340
    m_encoder.collection_move(list.translate_index(from_link_ndx), list.translate_index(to_link_ndx)); // Throws
1,638✔
341
    if (auto logger = get_logger()) {
1,638✔
342
        logger->log(util::Logger::Level::trace, "   Move %1 to %2 in '%3'", from_link_ndx, to_link_ndx,
1,512✔
343
                    get_prop_name(list.get_short_path()));
1,512✔
344
    }
1,512✔
345
}
1,638✔
346

347
void Replication::set_insert(const CollectionBase& set, size_t set_ndx, Mixed value)
348
{
60,720✔
349
    select_collection(set);               // Throws
60,720✔
350
    m_encoder.collection_insert(set_ndx); // Throws
60,720✔
351
    if (auto logger = get_logger()) {
60,720✔
352
        if (logger->would_log(util::Logger::Level::trace)) {
59,796✔
353
            log_collection_operation("Insert", set, value, Mixed());
6✔
354
        }
6✔
355
    }
59,796✔
356
}
60,720✔
357

358
void Replication::set_erase(const CollectionBase& set, size_t set_ndx, Mixed value)
359
{
11,562✔
360
    select_collection(set);              // Throws
11,562✔
361
    m_encoder.collection_erase(set_ndx); // Throws
11,562✔
362
    if (auto logger = get_logger()) {
11,562✔
363
        logger->log(util::Logger::Level::trace, "   Erase %1 from '%2'", value, get_prop_name(set.get_short_path()));
11,412✔
364
    }
11,412✔
365
}
11,562✔
366

367
void Replication::set_clear(const CollectionBase& set)
368
{
2,430✔
369
    select_collection(set);                 // Throws
2,430✔
370
    m_encoder.collection_clear(set.size()); // Throws
2,430✔
371
    if (auto logger = get_logger()) {
2,430✔
372
        logger->log(util::Logger::Level::trace, "   Clear '%1'", get_prop_name(set.get_short_path()));
2,346✔
373
    }
2,346✔
374
}
2,430✔
375

376
void Replication::do_select_table(const Table* table)
377
{
1,399,557✔
378
    m_encoder.select_table(table->get_key()); // Throws
1,399,557✔
379
    m_selected_table = table;
1,399,557✔
380
    m_selected_list = CollectionId();
1,399,557✔
381
    m_selected_obj = ObjKey();
1,399,557✔
382
}
1,399,557✔
383

384
void Replication::do_select_collection(const CollectionBase& list)
385
{
277,959✔
386
    select_table(list.get_table().unchecked_ptr());
277,959✔
387
    ColKey col_key = list.get_col_key();
277,959✔
388
    ObjKey key = list.get_owner_key();
277,959✔
389
    auto path = list.get_stable_path();
277,959✔
390

138,045✔
391
    select_obj(key);
277,959✔
392

138,045✔
393
    m_encoder.select_collection(col_key, key, path); // Throws
277,959✔
394
    m_selected_list = CollectionId(list.get_table()->get_key(), key, std::move(path));
277,959✔
395
}
277,959✔
396

397
void Replication::list_clear(const CollectionBase& list)
398
{
4,644✔
399
    select_collection(list);           // Throws
4,644✔
400
    m_encoder.collection_clear(list.size()); // Throws
4,644✔
401
    if (auto logger = get_logger()) {
4,644✔
402
        logger->log(util::Logger::Level::trace, "   Clear '%1'", get_prop_name(list.get_short_path()));
3,897✔
403
    }
3,897✔
404
}
4,644✔
405

406
void Replication::link_list_nullify(const Lst<ObjKey>& list, size_t link_ndx)
407
{
1,716✔
408
    select_collection(list);
1,716✔
409
    m_encoder.collection_erase(link_ndx);
1,716✔
410
    if (auto logger = get_logger()) {
1,716✔
411
        logger->log(util::Logger::Level::trace, "   Nullify '%1' position %2",
1,656✔
412
                    m_selected_table->get_column_name(list.get_col_key()), link_ndx);
1,656✔
413
    }
1,656✔
414
}
1,716✔
415

416
void Replication::dictionary_insert(const CollectionBase& dict, size_t ndx, Mixed key, Mixed value)
417
{
84,690✔
418
    select_collection(dict);
84,690✔
419
    m_encoder.collection_insert(ndx);
84,690✔
420
    if (auto logger = get_logger()) {
84,690✔
421
        if (logger->would_log(util::Logger::Level::trace)) {
70,968✔
422
            log_collection_operation("Insert", dict, value, key);
6✔
423
        }
6✔
424
    }
70,968✔
425
}
84,690✔
426

427
void Replication::dictionary_set(const CollectionBase& dict, size_t ndx, Mixed key, Mixed value)
428
{
8,316✔
429
    select_collection(dict);
8,316✔
430
    m_encoder.collection_set(ndx);
8,316✔
431
    if (auto logger = get_logger()) {
8,316✔
432
        if (logger->would_log(util::Logger::Level::trace)) {
8,166✔
UNCOV
433
            log_collection_operation("Set", dict, value, key);
×
UNCOV
434
        }
×
435
    }
8,166✔
436
}
8,316✔
437

438
void Replication::dictionary_erase(const CollectionBase& dict, size_t ndx, Mixed key)
439
{
11,934✔
440
    select_collection(dict);
11,934✔
441
    m_encoder.collection_erase(ndx);
11,934✔
442
    if (auto logger = get_logger()) {
11,934✔
443
        logger->log(util::Logger::Level::trace, "   Erase %1 from '%2'", key, get_prop_name(dict.get_short_path()));
4,350✔
444
    }
4,350✔
445
}
11,934✔
446

447
void Replication::dictionary_clear(const CollectionBase& dict)
448
{
2,352✔
449
    select_collection(dict);
2,352✔
450
    m_encoder.collection_clear(dict.size());
2,352✔
451
    if (auto logger = get_logger()) {
2,352✔
452
        logger->log(util::Logger::Level::trace, "   Clear '%1'", get_prop_name(dict.get_short_path()));
2,304✔
453
    }
2,304✔
454
}
2,352✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc