6310285782

Committed 26 Sep 2023 08:47AM UTC coverage: 36.367% (-0.5%) from 36.866%

Build # 6310285782

Build Type

Pull #658

github

Committed by

dkfellows

Commit Message

Merge branch 'master' into java-17

Pull Request Pull Request #658: Update Java version to 17 and JEE to 9

Run Details

1675 of 1675 new or added lines in 266 files covered. (100.0%)

8368 of 23010 relevant lines covered (36.37%)

0.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

74.74

/SpiNNaker-allocserv/src/main/java/uk/ac/manchester/spinnaker/alloc/allocator/Spalloc.java

/*
 * Copyright (c) 2021 The University of Manchester
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package uk.ac.manchester.spinnaker.alloc.allocator;

import static java.lang.Math.max;
import static java.lang.String.format;
import static java.lang.Thread.currentThread;
import static java.util.Objects.isNull;
import static java.util.Objects.nonNull;
import static java.util.stream.Collectors.toList;
import static java.util.stream.Collectors.toSet;
import static org.slf4j.LoggerFactory.getLogger;
import static uk.ac.manchester.spinnaker.alloc.Constants.TRIAD_CHIP_SIZE;
import static uk.ac.manchester.spinnaker.alloc.Constants.TRIAD_DEPTH;
import static uk.ac.manchester.spinnaker.alloc.db.Row.int64;
import static uk.ac.manchester.spinnaker.alloc.db.Row.integer;
import static uk.ac.manchester.spinnaker.alloc.db.Row.string;
import static uk.ac.manchester.spinnaker.alloc.db.Row.chip;
import static uk.ac.manchester.spinnaker.alloc.model.JobState.READY;
import static uk.ac.manchester.spinnaker.alloc.model.PowerState.OFF;
import static uk.ac.manchester.spinnaker.alloc.model.PowerState.ON;
import static uk.ac.manchester.spinnaker.utils.CollectionUtils.copy;
import static uk.ac.manchester.spinnaker.utils.OptionalUtils.apply;

import java.io.Serial;
import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Formatter;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import java.util.Set;

import org.slf4j.Logger;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;

import com.fasterxml.jackson.annotation.JsonIgnore;
import com.google.errorprone.annotations.FormatMethod;
import com.google.errorprone.annotations.concurrent.GuardedBy;

import uk.ac.manchester.spinnaker.alloc.SpallocProperties.AllocatorProperties;
import uk.ac.manchester.spinnaker.alloc.admin.ReportMailSender;
import uk.ac.manchester.spinnaker.alloc.allocator.Epochs.Epoch;
import uk.ac.manchester.spinnaker.alloc.db.DatabaseAPI.Connection;
import uk.ac.manchester.spinnaker.alloc.db.DatabaseAPI.Query;
import uk.ac.manchester.spinnaker.alloc.db.DatabaseAPI.Update;
import uk.ac.manchester.spinnaker.alloc.db.DatabaseAwareBean;
import uk.ac.manchester.spinnaker.alloc.db.Row;
import uk.ac.manchester.spinnaker.alloc.model.BoardCoords;
import uk.ac.manchester.spinnaker.alloc.model.ConnectionInfo;
import uk.ac.manchester.spinnaker.alloc.model.Direction;
import uk.ac.manchester.spinnaker.alloc.model.DownLink;
import uk.ac.manchester.spinnaker.alloc.model.JobDescription;
import uk.ac.manchester.spinnaker.alloc.model.JobListEntryRecord;
import uk.ac.manchester.spinnaker.alloc.model.JobState;
import uk.ac.manchester.spinnaker.alloc.model.MachineDescription;
import uk.ac.manchester.spinnaker.alloc.model.MachineDescription.JobInfo;
import uk.ac.manchester.spinnaker.alloc.model.MachineListEntryRecord;
import uk.ac.manchester.spinnaker.alloc.model.PowerState;
import uk.ac.manchester.spinnaker.alloc.proxy.ProxyCore;
import uk.ac.manchester.spinnaker.alloc.security.Permit;
import uk.ac.manchester.spinnaker.alloc.web.IssueReportRequest;
import uk.ac.manchester.spinnaker.alloc.web.IssueReportRequest.ReportedBoard;
import uk.ac.manchester.spinnaker.machine.ChipLocation;
import uk.ac.manchester.spinnaker.machine.HasChipLocation;
import uk.ac.manchester.spinnaker.machine.HasCoreLocation;
import uk.ac.manchester.spinnaker.machine.board.BMPCoords;
import uk.ac.manchester.spinnaker.machine.board.PhysicalCoords;
import uk.ac.manchester.spinnaker.machine.board.TriadCoords;
import uk.ac.manchester.spinnaker.spalloc.messages.BoardCoordinates;
import uk.ac.manchester.spinnaker.spalloc.messages.BoardPhysicalCoordinates;

/**
 * The core implementation of the Spalloc service.
 *
 * @author Donal Fellows
 */
@Service
public class Spalloc extends DatabaseAwareBean implements SpallocAPI {
        private static final String NO_BOARD_MSG =
                        "request does not identify an existing board "
                                        + "or uses a prohibited coordinate";

        private static final Logger log = getLogger(Spalloc.class);

        @Autowired
        private PowerController powerController;

        @Autowired
        private Epochs epochs;

        @Autowired
        private QuotaManager quotaManager;

        @Autowired
        private ReportMailSender emailSender;

        @Autowired
        private AllocatorProperties props;

        @Autowired
        private ProxyRememberer rememberer;

        @Autowired
        private AllocatorTask allocator;

        @GuardedBy("this")
        private transient Map<String, List<BoardCoords>> downBoardsCache =
                        new HashMap<>();

        @GuardedBy("this")
        private transient Map<String, List<DownLink>> downLinksCache =
                        new HashMap<>();

        @Override
        public Map<String, Machine> getMachines(boolean allowOutOfService) {
                return executeRead(c -> getMachines(c, allowOutOfService));
        }

        private Map<String, Machine> getMachines(Connection conn,
                        boolean allowOutOfService) {
                try (var listMachines = conn.query(GET_ALL_MACHINES)) {
                        return Row.stream(listMachines.call(
                                        row -> new MachineImpl(conn, row), allowOutOfService))
                                        .toMap(Machine::getName, (m) -> m);
                }
        }

        private final class ListMachinesSQL extends AbstractSQL {
                private final Query listMachines = conn.query(GET_ALL_MACHINES);

                private final Query countMachineThings =
                                conn.query(COUNT_MACHINE_THINGS);

                private final Query getTags = conn.query(GET_TAGS);

                @Override
                public void close() {
                        listMachines.close();
                        countMachineThings.close();
                        getTags.close();
                        super.close();
                }

                private MachineListEntryRecord makeMachineListEntryRecord(Row row) {
                        int id = row.getInt("machine_id");
                        var rec = new MachineListEntryRecord();
                        rec.setId(id);
                        rec.setName(row.getString("machine_name"));
                        if (!countMachineThings.call1((m) -> {
                                rec.setNumBoards(m.getInt("board_count"));
                                rec.setNumInUse(m.getInt("in_use"));
                                rec.setNumJobs(m.getInt("num_jobs"));
                                rec.setTags(getTags.call(string("tag"), id));
                                // We have to return something but don't read the result
                                return true;
                        }, id).isPresent()) {
                                throw new AssertionError("No result from count machine things");
                        }
                        return rec;
                }
        }

        @Override
        public List<MachineListEntryRecord>
                        listMachines(boolean allowOutOfService) {
                try (var sql = new ListMachinesSQL()) {
                        return sql.transactionRead(
                                        () -> sql.listMachines.call(
                                                        sql::makeMachineListEntryRecord,
                                                        allowOutOfService));
                }
        }

        @Override
        public Optional<Machine> getMachine(String name,
                        boolean allowOutOfService) {
                return executeRead(
                                conn -> getMachine(name, allowOutOfService, conn).map(m -> m));
        }

        private Optional<MachineImpl> getMachine(int id, boolean allowOutOfService,
                        Connection conn) {
                try (var idMachine = conn.query(GET_MACHINE_BY_ID)) {
                        return idMachine.call1(row -> new MachineImpl(conn, row),
                                        id, allowOutOfService);
                }
        }

        private Optional<MachineImpl> getMachine(String name,
                        boolean allowOutOfService, Connection conn) {
                try (var namedMachine = conn.query(GET_NAMED_MACHINE)) {
                        return namedMachine.call1(row -> new MachineImpl(conn, row),
                                        name, allowOutOfService);
                }
        }

        private final class DescribeMachineSQL extends AbstractSQL {
                final Query namedMachine = conn.query(GET_NAMED_MACHINE);

                final Query countMachineThings = conn.query(COUNT_MACHINE_THINGS);

                final Query getTags = conn.query(GET_TAGS);

                final Query getJobs = conn.query(GET_MACHINE_JOBS);

                final Query getCoords = conn.query(GET_JOB_BOARD_COORDS);

                final Query getLive = conn.query(GET_LIVE_BOARDS);

                final Query getDead = conn.query(GET_DEAD_BOARDS);

                final Query getQuota = conn.query(GET_USER_QUOTA);

                @Override
                public void close() {
                        namedMachine.close();
                        countMachineThings.close();
                        getTags.close();
                        getJobs.close();
                        getCoords.close();
                        getLive.close();
                        getDead.close();
                        getQuota.close();
                        super.close();
                }
        }

        @Override
        public Optional<MachineDescription> getMachineInfo(String machine,
                        boolean allowOutOfService, Permit permit) {
                try (var sql = new DescribeMachineSQL()) {
                        return sql.transactionRead(() -> apply(
                                        sql.namedMachine.call1(Spalloc::getBasicMachineInfo,
                                                        machine, allowOutOfService),
                                        md -> sql.countMachineThings.call1(integer("in_use"),
                                                        md.getId()).ifPresent(md::setNumInUse),
                                        md -> md.setTags(
                                                        sql.getTags.call(string("tag"), md.getId())),
                                        md -> md.setJobs(sql.getJobs.call(
                                                        row -> getMachineJobInfo(permit, sql.getCoords,
                                                                        row),
                                                        md.getId())),
                                        md -> md.setLive(sql.getLive.call(
                                                        row -> new BoardCoords(row, !permit.admin),
                                                        md.getId())),
                                        md -> md.setDead(sql.getDead.call(
                                                        row -> new BoardCoords(row, !permit.admin),
                                                        md.getId())),
                                        md -> sql.getQuota.call1(int64("quota_total"), permit.name)
                                                        .ifPresent(md::setQuota)));
                }
        }

        private static MachineDescription getBasicMachineInfo(Row row) {
                var md = new MachineDescription();
                md.setId(row.getInt("machine_id"));
                md.setName(row.getString("machine_name"));
                md.setWidth(row.getInt("width"));
                md.setHeight(row.getInt("height"));
                return md;
        }

        private static JobInfo getMachineJobInfo(Permit permit, Query getCoords,
                        Row row) {
                int jobId = row.getInt("job_id");
                var mayUnveil = permit.unveilFor(row.getString("owner_name"));
                var owner = mayUnveil ? row.getString("owner_name") : null;

                var ji = new JobInfo();
                ji.setId(jobId);
                ji.setOwner(owner);
                ji.setBoards(
                                getCoords.call(r -> new BoardCoords(r, !mayUnveil), jobId));
                return ji;
        }

        @Override
        public Jobs getJobs(boolean deleted, int limit, int start) {
                return executeRead(conn -> {
                        if (deleted) {
                                try (var jobs = conn.query(GET_JOB_IDS)) {
                                        return new JobCollection(
                                                        jobs.call(this::makeJob, limit, start));
                                }
                        } else {
                                try (var jobs = conn.query(GET_LIVE_JOB_IDS)) {
                                        return new JobCollection(
                                                        jobs.call(this::makeJob, limit, start));
                                }
                        }
                });
        }

        /**
         * Makes "partial" jobs; some fields are shrouded, modifications are
         * disabled.
         *
         * @param row
         *            The row to make the job from.
         */
        private Job makeJob(Row row) {
                int jobId = row.getInt("job_id");
                int machineId = row.getInt("machine_id");
                var jobState = row.getEnum("job_state", JobState.class);
                var keepalive = row.getInstant("keepalive_timestamp");
                return new JobImpl(jobId, machineId, jobState, keepalive);
        }

        @Override
        public List<JobListEntryRecord> listJobs(Permit permit) {
                return executeRead(conn -> {
                        try (var listLiveJobs = conn.query(LIST_LIVE_JOBS);
                                        var countPoweredBoards = conn.query(COUNT_POWERED_BOARDS);
                                        var getCoords = conn.query(GET_JOB_BOARD_COORDS)) {
                                return listLiveJobs.call(row -> makeJobListEntryRecord(permit,
                                                countPoweredBoards, getCoords, row));
                        }
                });
        }

        private static JobListEntryRecord makeJobListEntryRecord(Permit permit,
                        Query countPoweredBoards, Query getCoords, Row row) {
                var rec = new JobListEntryRecord();
                int id = row.getInt("job_id");
                rec.setId(id);
                rec.setState(row.getEnum("job_state", JobState.class));
                var numBoards = row.getInteger("allocation_size");
                rec.setPowered(nonNull(numBoards) && numBoards.equals(countPoweredBoards
                                .call1(integer("c"), id).orElseThrow()));
                rec.setMachineId(row.getInt("machine_id"));
                rec.setMachineName(row.getString("machine_name"));
                rec.setCreationTimestamp(row.getInstant("create_timestamp"));
                rec.setKeepaliveInterval(row.getDuration("keepalive_interval"));
                rec.setBoards(getCoords.call(r -> new BoardCoords(r, false), id));
                rec.setOriginalRequest(row.getBytes("original_request"));
                var owner = row.getString("user_name");
                if (permit.unveilFor(owner)) {
                        rec.setOwner(owner);
                        rec.setHost(row.getString("keepalive_host"));
                }
                return rec;
        }

        @Override
        public Optional<Job> getJob(Permit permit, int id) {
                return executeRead(conn -> getJob(id, conn).map(j -> (Job) j));
        }

        private Optional<JobImpl> getJob(int id, Connection conn) {
                try (var s = conn.query(GET_JOB)) {
                        return s.call1(row -> new JobImpl(conn, row), id);
                }
        }

        @Override
        public Optional<JobDescription> getJobInfo(Permit permit, int id) {
                return executeRead(conn -> {
                        try (var s = conn.query(GET_JOB);
                                        var chipDimensions = conn.query(GET_JOB_CHIP_DIMENSIONS);
                                        var countPoweredBoards = conn.query(COUNT_POWERED_BOARDS);
                                        var getCoords = conn.query(GET_JOB_BOARD_COORDS)) {
                                return s.call1(row -> jobDescription(id, row,
                                                chipDimensions, countPoweredBoards, getCoords), id);
                        }
                });
        }

        private static JobDescription jobDescription(int id, Row job,
                        Query chipDimensions, Query countPoweredBoards, Query getCoords) {
                /*
                 * We won't deliver this object to the front end unless they are allowed
                 * to see it in its entirety.
                 */
                var jd = new JobDescription();
                jd.setId(id);
                jd.setMachine(job.getString("machine_name"));
                jd.setState(job.getEnum("job_state", JobState.class));
                jd.setOwner(job.getString("owner"));
                jd.setOwnerHost(job.getString("keepalive_host"));
                jd.setStartTime(job.getInstant("create_timestamp"));
                jd.setKeepAlive(job.getDuration("keepalive_interval"));
                jd.setRequestBytes(job.getBytes("original_request"));
                chipDimensions.call1(cd -> {
                        jd.setWidth(cd.getInt("width"));
                        jd.setHeight(cd.getInt("height"));
                        // We have to return something but we ignore it anyway
                        return true;
                }, id);
                int poweredCount =
                                countPoweredBoards.call1(integer("c"), id).orElseThrow();
                jd.setBoards(getCoords.call(r -> new BoardCoords(r, false), id));
                jd.setPowered(jd.getBoards().size() == poweredCount);
                return jd;
        }

        @Override
        public Optional<Job> createJobInGroup(String owner, String groupName,
                        CreateDescriptor descriptor, String machineName, List<String> tags,
                        Duration keepaliveInterval, byte[] req) {
                return execute(conn -> {
                        int user = getUser(conn, owner).orElseThrow(
                                        () -> new RuntimeException("no such user: " + owner));
                        int group = selectGroup(conn, owner, groupName);
                        if (!quotaManager.mayCreateJob(group)) {
                                // No quota left
                                return Optional.empty();
                        }

                        var m = selectMachine(conn, machineName, tags);
                        if (!m.isPresent()) {
                                // Cannot find machine!
                                return Optional.empty();
                        }
                        var machine = m.orElseThrow();

                        var id = insertJob(conn, machine, user, group, keepaliveInterval,
                                        req);
                        if (!id.isPresent()) {
                                // Insert failed
                                return Optional.empty();
                        }
                        int jobId = id.orElseThrow();

                        var scale = props.getPriorityScale();

                        if (machine.getArea() < descriptor.getArea()) {
                                throw new IllegalArgumentException(
                                                "request cannot fit on machine");
                        }

                        // Ask the allocator engine to do the allocation
                        int numBoards = descriptor.visit(new CreateVisitor<Integer>() {
                                @Override
                                public Integer numBoards(CreateNumBoards nb) {
                                        try (var insertReq = conn.update(INSERT_REQ_N_BOARDS)) {
                                                insertReq.call(jobId, nb.numBoards, nb.maxDead,
                                                                (int) (nb.getArea() * scale.getSize()));
                                        }
                                        return nb.numBoards;
                                }

                                @Override
                                public Integer dimensions(CreateDimensions d) {
                                        try (var insertReq = conn.update(INSERT_REQ_SIZE)) {
                                                insertReq.call(jobId, d.width, d.height, d.maxDead,
                                                                (int) (d.getArea() * scale.getDimensions()));
                                        }
                                        return max(1, d.getArea() - d.maxDead);
                                }

                                /*
                                 * Request by area rooted at specific location; resolve to board
                                 * ID now, as that doesn't depend on whether the board is
                                 * currently in use.
                                 */
                                @Override
                                public Integer dimensionsAt(CreateDimensionsAt da) {
                                        try (var insertReq = conn.update(INSERT_REQ_SIZE_BOARD)) {
                                                insertReq.call(jobId,
                                                                locateBoard(conn, machine.name, da, true),
                                                                da.width, da.height, da.maxDead,
                                                                (int) scale.getSpecificBoard());
                                        }
                                        return max(1, da.getArea() - da.maxDead);
                                }

                                /*
                                 * Request by specific location; resolve to board ID now, as
                                 * that doesn't depend on whether the board is currently in
                                 * use.
                                 */
                                @Override
                                public Integer board(CreateBoard b) {
                                        try (var insertReq = conn.update(INSERT_REQ_BOARD)) {
                                                /*
                                                 * This doesn't pass along the max dead boards; only
                                                 * after one!
                                                 */
                                                insertReq.call(jobId,
                                                                locateBoard(conn, machine.name, b, false),
                                                                (int) scale.getSpecificBoard());
                                        }
                                        return 1;
                                }
                        });

                        // DB now changed; can report success
                        JobLifecycle.log.info(
                                        "created job {} on {} for {} asking for {} board(s)", jobId,
                                        machine.name, owner, numBoards);

                        allocator.scheduleAllocateNow();
                        return getJob(jobId, conn).map(ji -> (Job) ji);
                });
        }

        @Override
        public Optional<Job> createJob(String owner, CreateDescriptor descriptor,
                        String machineName, List<String> tags, Duration keepaliveInterval,
                        byte[] originalRequest) {
                return execute(conn -> createJobInGroup(
                                owner, getOnlyGroup(conn, owner), descriptor, machineName,
                                tags, keepaliveInterval, originalRequest));
        }

        @Override
        public Optional<Job> createJobInCollabSession(String owner,
                        String nmpiCollab, CreateDescriptor descriptor,
                        String machineName, List<String> tags, Duration keepaliveInterval,
                        byte[] originalRequest) {
                var quotaUnits = quotaManager.mayCreateNMPISession(nmpiCollab);
                if (quotaUnits.isEmpty()) {
                        return Optional.empty();
                }

                // Use the Collab name as the group, as it should exist
                var job = execute(conn -> createJobInGroup(
                                owner, nmpiCollab, descriptor, machineName,
                                tags, keepaliveInterval, originalRequest));
                // On failure to get job, just return; shouldn't happen as quota checked
                // earlier, but just in case!
                if (job.isEmpty()) {
                        return job;
                }

                quotaManager.associateNMPISession(
                                job.get().getId(), owner, nmpiCollab, quotaUnits.get());

                // Return the job created
                return job;
        }

        @Override
        public Optional<Job> createJobForNMPIJob(String owner, int nmpiJobId,
                        CreateDescriptor descriptor, String machineName, List<String> tags,
                        Duration keepaliveInterval,        byte[] originalRequest) {
                var collab = quotaManager.mayUseNMPIJob(owner, nmpiJobId);
                if (collab.isEmpty()) {
                        return Optional.empty();
                }
                var quotaDetails = collab.get();

                var job = execute(conn -> createJobInGroup(
                                owner, quotaDetails.collabId(), descriptor, machineName,
                                tags, keepaliveInterval, originalRequest));
                // On failure to get job, just return; shouldn't happen as quota checked
                // earlier, but just in case!
                if (job.isEmpty()) {
                        return job;
                }

                quotaManager.associateNMPIJob(job.get().getId(), nmpiJobId,
                                quotaDetails.quotaUnits());

                // Return the job created
                return job;
        }

        /**
         * Get the specified group.
         *
         * @param conn
         *            DB connection
         * @param user
         *            Who is the user?
         * @param groupName
         *            What group did they specify? (May be {@code null} to say "pick
         *            the unique valid possibility for the owner".)
         * @return The group ID.
         * @throws GroupsException
         *             If we can't get a definite group to account against.
         */
        private int selectGroup(Connection conn, String user, String groupName) {
                try (var getGroup = conn.query(GET_GROUP_BY_NAME_AND_MEMBER)) {
                        return getGroup.call1(integer("group_id"), user, groupName)
                                        .orElseThrow(() -> new NoSuchGroupException(
                                                        "group %s does not exist or %s "
                                                                        + "is not a member of it",
                                                        groupName, user));
                }
        }

        private String getOnlyGroup(Connection conn, String user) {
                try (var listGroups = conn.query(GET_GROUP_NAMES_OF_USER)) {
                        // No name given; need to guess.
                        var groups = listGroups.call(row -> row.getString("group_name"),
                                        user);
                        if (groups.size() > 1) {
                                throw new NoSuchGroupException(
                                                "User is a member of more than one group, so the group"
                                                + " must be selected in the request");
                        }
                        if (groups.size() == 0) {
                                throw new NoSuchGroupException(
                                                "User is not a member of any group!");
                        }
                        return groups.get(0);
                }
        }

        private static Optional<Integer> getUser(Connection conn, String userName) {
                try (var getUser = conn.query(GET_USER_ID)) {
                        return getUser.call1(integer("user_id"), userName);
                }
        }

        /**
         * Resolve a machine name and {@link HasBoardCoords} to a board identifier.
         *
         * @param conn
         *            How to get to the DB.
         * @param machineName
         *            The name of the machine.
         * @param b
         *            The request that is the coordinate holder.
         * @param requireTriadRoot
         *            Whether we require the Z coordinate to be zero.
         * @return The board ID.
         * @throws IllegalArgumentException
         *             If the board doesn't exist or it is a board that is not a
         *             root of a triad when a triad root is required.
         */
        private Integer locateBoard(Connection conn, String machineName,
                        HasBoardCoords b, boolean requireTriadRoot) {
                record BoardLocated(int boardId, int z) {
                        BoardLocated(Row row) {
                                this(row.getInt("board_id"), row.getInt("z"));
                        }
                }

                try (var findTriad = conn.query(FIND_BOARD_BY_NAME_AND_XYZ);
                                var findPhysical = conn.query(FIND_BOARD_BY_NAME_AND_CFB);
                                var findIP = conn.query(FIND_BOARD_BY_NAME_AND_IP_ADDRESS)) {
                        if (nonNull(b.triad)) {
                                return findTriad.call1(BoardLocated::new,
                                                machineName, b.triad.x(), b.triad.y(), b.triad.z())
                                                .filter(board -> !requireTriadRoot || board.z == 0)
                                                .map(board -> board.boardId)
                                                .orElseThrow(() -> new IllegalArgumentException(
                                                                NO_BOARD_MSG));
                        } else if (nonNull(b.physical)) {
                                return findPhysical.call1(
                                                BoardLocated::new, machineName, b.physical.c(),
                                                                b.physical.f(), b.physical.b())
                                                .filter(board -> !requireTriadRoot || board.z == 0)
                                                .map(board -> board.boardId)
                                                .orElseThrow(() -> new IllegalArgumentException(
                                                                NO_BOARD_MSG));
                        } else {
                                return findIP.call1(BoardLocated::new, machineName, b.ip)
                                                .filter(board -> !requireTriadRoot || board.z == 0)
                                                .map(board -> board.boardId)
                                                .orElseThrow(() -> new IllegalArgumentException(
                                                                NO_BOARD_MSG));
                        }
                }
        }

        private static Optional<Integer> insertJob(Connection conn, MachineImpl m,
                        int owner, int group, Duration keepaliveInterval, byte[] req) {
                try (var makeJob = conn.update(INSERT_JOB)) {
                        return makeJob.key(m.id, owner, group, keepaliveInterval, req);
                }
        }

        private Optional<MachineImpl> selectMachine(Connection conn,
                        String machineName, List<String> tags) {
                if (nonNull(machineName)) {
                        return getMachine(machineName, false, conn);
                } else if (!tags.isEmpty()) {
                        for (var m : getMachines(conn, false).values()) {
                                var mi = (MachineImpl) m;
                                if (mi.tags.containsAll(tags)) {
                                        /*
                                         * Originally, spalloc checked if allocation was possible;
                                         * we just assume that it is because there really isn't ever
                                         * going to be that many different machines on one service.
                                         */
                                        return Optional.of(mi);
                                }
                        }
                }
                return Optional.empty();
        }

        @Override
        public void purgeDownCache() {
                synchronized (this) {
                        downBoardsCache.clear();
                        downLinksCache.clear();
                }
        }

        private static String mergeDescription(HasChipLocation coreLocation,
                        String description) {
                if (isNull(description)) {
                        description = "<null>";
                }
                if (coreLocation instanceof HasCoreLocation loc) {
                        description += format(" (at core %d of chip %s)", loc.getP(),
                                        loc.asChipLocation());
                } else if (nonNull(coreLocation)) {
                        description +=
                                        format(" (at chip %s)", coreLocation.asChipLocation());
                }
                return description;
        }

        private record Problem(int boardId, Integer jobId) {
                Problem(Row row) {
                        this(row.getInt("board_id"), row.getInt("job_id"));
                }
        }

        @Override
        public void reportProblem(String address, HasChipLocation coreLocation,
                        String description, Permit permit) {
                try (var sql = new BoardReportSQL()) {
                        var desc = mergeDescription(coreLocation, description);
                        var email = sql.transaction(() -> {
                                var machines = getMachines(sql.getConnection(), true).values();
                                for (var m : machines) {
                                        var mail = sql.findBoardNet.call1(
                                                        Problem::new, m.getId(), address)
                                                        .flatMap(prob -> reportProblem(prob, desc, permit,
                                                                        sql));
                                        if (mail.isPresent()) {
                                                return mail;
                                        }
                                }
                                return Optional.empty();
                        });
                        // Outside the transaction!
                        email.ifPresent(emailSender::sendServiceMail);
                } catch (ReportRollbackExn e) {
                        log.warn("failed to handle problem report", e);
                }
        }

        private Optional<EmailBuilder> reportProblem(Problem problem,
                        String description,        Permit permit, BoardReportSQL sql) {
                var email = new EmailBuilder(problem.jobId);
                email.header(description, 1, permit.name);
                int userId = getUser(sql.getConnection(), permit.name).orElseThrow(
                                () -> new ReportRollbackExn("no such user: %s", permit.name));
                sql.insertReport.key(problem.boardId, problem.jobId,
                                description, userId).ifPresent(email::issue);
                return takeBoardsOutOfService(sql, email).map(acted -> {
                        email.footer(acted);
                        return email;
                });
        }

        private record Reported(int boardId, int x, int y, int z, String address,
                        int numReports) {
                Reported(Row row) {
                        this(row.getInt("board_id"), row.getInt("x"), row.getInt("y"),
                                        row.getInt("z"), row.getString("address"),
                                        row.getInt("numReports"));
                }
        }

        /**
         * Take boards out of service if they've been reported frequently enough.
         *
         * @param sql
         *            How to touch the DB
         * @param email
         *            The email we are building.
         * @return The number of boards taken out of service
         */
        private Optional<Integer> takeBoardsOutOfService(BoardReportSQL sql,
                        EmailBuilder email) {
                int acted = 0;
                for (var report : sql.getReported.call(Reported::new,
                                props.getReportActionThreshold())) {
                        if (sql.setFunctioning.call(false, report.boardId) > 0) {
                                email.serviceActionDone(report);
                                acted++;
                        }
                }
                if (acted > 0) {
                        purgeDownCache();
                }
                return acted > 0 ? Optional.of(acted) : Optional.empty();
        }

        private static DownLink makeDownLinkFromRow(Row row) {
                // Non-standard column names to reduce number of queries
                var board1 = new BoardCoords(row.getInt("board_1_x"),
                                row.getInt("board_1_y"), row.getInt("board_1_z"),
                                row.getInt("board_1_c"), row.getInt("board_1_f"),
                                row.getInteger("board_1_b"), row.getString("board_1_addr"));
                var board2 = new BoardCoords(row.getInt("board_2_x"),
                                row.getInt("board_2_y"), row.getInt("board_2_z"),
                                row.getInt("board_2_c"), row.getInt("board_2_f"),
                                row.getInteger("board_2_b"), row.getString("board_2_addr"));
                return new DownLink(board1, row.getEnum("dir_1", Direction.class),
                                board2, row.getEnum("dir_2", Direction.class));
        }

        private final class MachineImpl implements Machine {
                private final int id;

                private final boolean inService;

                private final String name;

                private final Set<String> tags;

                private final int width;

                private final int height;

                private boolean lookedUpWraps;

                private boolean hWrap;

                private boolean vWrap;

                @JsonIgnore
                private final Epoch epoch;

                MachineImpl(Connection conn, Row rs) {
                        id = rs.getInt("machine_id");
                        name = rs.getString("machine_name");
                        width = rs.getInt("width");
                        height = rs.getInt("height");
                        inService = rs.getBoolean("in_service");
                        lookedUpWraps = false;
                        try (var getTags = conn.query(GET_TAGS)) {
                                tags = Row.stream(copy(getTags.call(string("tag"), id)))
                                                .toSet();
                        }

                        this.epoch = epochs.getMachineEpoch(id);
                }

                private int getArea() {
                        return width * height * TRIAD_DEPTH;
                }

                @Override
                public boolean waitForChange(Duration timeout) {
                        if (isNull(epoch)) {
                                log.info("Machine {} epoch is null!", id);
                                return true;
                        }
                        try {
                                log.info("Waiting for change in epoch for {}", id);
                                return epoch.waitForChange(timeout);
                        } catch (InterruptedException interrupted) {
                                log.info("Interrupted waiting for change on {}", id);
                                return false;
                        }
                }

                private BoardLocation boardLoc(Row row) {
                        return new BoardLocationImpl(row, this);
                }

                @Override
                public Optional<BoardLocation> getBoardByChip(HasChipLocation chip) {
                        try (var conn = getConnection();
                                        var findBoard = conn.query(findBoardByGlobalChip)) {
                                return conn.transaction(false, () -> findBoard
                                                .call1(this::boardLoc, id, chip.getX(), chip.getY()));
                        }
                }

                @Override
                public Optional<BoardLocation> getBoardByPhysicalCoords(
                                PhysicalCoords coords) {
                        try (var conn = getConnection();
                                        var findBoard = conn.query(findBoardByPhysicalCoords)) {
                                return conn.transaction(false,
                                                () -> findBoard.call1(this::boardLoc, id, coords.c(),
                                                                coords.f(), coords.b()));
                        }
                }

                @Override
                public Optional<BoardLocation> getBoardByLogicalCoords(
                                TriadCoords coords) {
                        try (var conn = getConnection();
                                        var findBoard = conn.query(findBoardByLogicalCoords)) {
                                return conn.transaction(false,
                                                () -> findBoard.call1(this::boardLoc, id, coords.x(),
                                                                coords.y(), coords.z()));
                        }
                }

                @Override
                public Optional<BoardLocation> getBoardByIPAddress(String address) {
                        try (var conn = getConnection();
                                        var findBoard = conn.query(findBoardByIPAddress)) {
                                return conn.transaction(false,
                                                () -> findBoard.call1(this::boardLoc, id, address));
                        }
                }

                @Override
                public String getRootBoardBMPAddress() {
                        try (var conn = getConnection();
                                        var rootBMPaddr = conn.query(GET_ROOT_BMP_ADDRESS)) {
                                return conn
                                                .transaction(false,
                                                                () -> rootBMPaddr.call1(string("address"), id))
                                                .orElse(null);
                        }
                }

                @Override
                public List<Integer> getBoardNumbers() {
                        try (var conn = getConnection();
                                        var boardNumbers = conn.query(GET_BOARD_NUMBERS)) {
                                return conn.transaction(false, () -> boardNumbers.call(
                                                integer("board_num"), id));
                        }
                }

                @Override
                public List<BoardCoords> getDeadBoards() {
                        // Assume that the list doesn't change for the duration of this obj
                        synchronized (Spalloc.this) {
                                var down = downBoardsCache.get(name);
                                if (nonNull(down)) {
                                        return copy(down);
                                }
                        }
                        try (var conn = getConnection();
                                        var boardNumbers = conn.query(GET_DEAD_BOARDS)) {
                                var downBoards = conn.transaction(false,
                                                () -> boardNumbers.call(
                                                                row -> new BoardCoords(row, false), id));
                                synchronized (Spalloc.this) {
                                        downBoardsCache.putIfAbsent(name, downBoards);
                                }
                                return copy(downBoards);
                        }
                }

                @Override
                public List<DownLink> getDownLinks() {
                        // Assume that the list doesn't change for the duration of this obj
                        synchronized (Spalloc.this) {
                                var down = downLinksCache.get(name);
                                if (nonNull(down)) {
                                        return copy(down);
                                }
                        }
                        try (var conn = getConnection();
                                        var boardNumbers = conn.query(GET_DEAD_LINKS)) {
                                var downLinks = conn.transaction(false, () -> boardNumbers
                                                .call(Spalloc::makeDownLinkFromRow, id));
                                synchronized (Spalloc.this) {
                                        downLinksCache.putIfAbsent(name, downLinks);
                                }
                                return copy(downLinks);
                        }
                }

                @Override
                public List<Integer> getAvailableBoards() {
                        try (var conn = getConnection();
                                        var boardNumbers = conn
                                                        .query(GET_AVAILABLE_BOARD_NUMBERS)) {
                                return conn.transaction(false, () -> boardNumbers.call(
                                                integer("board_num"), id));
                        }
                }

                @Override
                public int getId() {
                        return id;
                }

                @Override
                public String getName() {
                        return name;
                }

                @Override
                public Set<String> getTags() {
                        return tags;
                }

                @Override
                public int getWidth() {
                        return width;
                }

                @Override
                public int getHeight() {
                        return height;
                }

                @Override
                public boolean isInService() {
                        return inService;
                }

                @Override
                public String getBMPAddress(BMPCoords bmp) {
                        try (var conn = getConnection();
                                        var bmpAddr = conn.query(GET_BMP_ADDRESS)) {
                                return conn
                                                .transaction(false,
                                                                () -> bmpAddr.call1(string("address"), id,
                                                                                bmp.cabinet(), bmp.frame()))
                                                .orElse(null);
                        }
                }

                @Override
                public List<Integer> getBoardNumbers(BMPCoords bmp) {
                        try (var conn = getConnection();
                                        var boardNumbers = conn.query(GET_BMP_BOARD_NUMBERS)) {
                                return conn.transaction(false,
                                                () -> boardNumbers.call(integer("board_num"), id,
                                                                bmp.cabinet(), bmp.frame()));
                        }
                }

                @Override
                public boolean equals(Object other) {
                        // Equality is defined exactly by the database ID
                        return (other instanceof MachineImpl m) && (id == m.id);
                }

                @Override
                public int hashCode() {
                        return id;
                }

                @Override
                public String toString() {
                        return "Machine(" + name + ")";
                }

                private void retrieveWraps() {
                        try (var conn = getConnection();
                                        var getWraps = conn.query(GET_MACHINE_WRAPS)) {
                                /*
                                 * No locking; not too bothered which thread asks as result will
                                 * be the same either way
                                 */
                                lookedUpWraps =
                                                conn.transaction(false, () -> getWraps.call1(rs -> {
                                                        hWrap = rs.getBoolean("horizontal_wrap");
                                                        vWrap = rs.getBoolean("vertical_wrap");
                                                        return true;
                                                }, id)).orElse(false);
                        }
                }

                @Override
                public boolean isHorizonallyWrapped() {
                        if (!lookedUpWraps) {
                                retrieveWraps();
                        }
                        return hWrap;
                }

                @Override
                public boolean isVerticallyWrapped() {
                        if (!lookedUpWraps) {
                                retrieveWraps();
                        }
                        return vWrap;
                }
        }

        private final class JobCollection implements Jobs {
                @JsonIgnore
                private final Epoch epoch;

                private final List<Job> jobs;

                private JobCollection(List<Job> jobs) {
                        this.jobs = jobs;
                        if (jobs.isEmpty()) {
                                epoch = null;
                        } else {
                                epoch = epochs.getJobsEpoch(
                                                jobs.stream().map(Job::getId).collect(toList()));
                        }
                }

                @Override
                public boolean waitForChange(Duration timeout) {
                        if (isNull(epoch)) {
                                return true;
                        }
                        try {
                                return epoch.waitForChange(timeout);
                        } catch (InterruptedException interrupted) {
                                currentThread().interrupt();
                                return false;
                        }
                }

                /**
                 * Get the set of jobs changed.
                 *
                 * @param timeout
                 *            The timeout to wait for until something happens.
                 * @return The set of changed job identifiers.
                 */
                @Override
                public Collection<Integer> getChanged(Duration timeout) {
                        if (isNull(epoch)) {
                                return jobs.stream().map(Job::getId).collect(toSet());
                        }
                        try {
                                return epoch.getChanged(timeout);
                        } catch (InterruptedException interrupted) {
                                currentThread().interrupt();
                                return jobs.stream().map(Job::getId).collect(toSet());
                        }
                }

                @Override
                public List<Job> jobs() {
                        return copy(jobs);
                }

                @Override
                public List<Integer> ids() {
                        return jobs.stream().map(Job::getId).collect(toList());
                }
        }

        private final class BoardReportSQL extends AbstractSQL {
                final Query findBoardByChip = conn.query(findBoardByJobChip);

                final Query findBoardByTriad = conn.query(findBoardByLogicalCoords);

                final Query findBoardPhys = conn.query(findBoardByPhysicalCoords);

                final Query findBoardNet = conn.query(findBoardByIPAddress);

                final Update insertReport = conn.update(INSERT_BOARD_REPORT);

                final Query getReported = conn.query(GET_REPORTED_BOARDS);

                final Update setFunctioning = conn.update(SET_FUNCTIONING_FIELD);

                final Query getNamedMachine = conn.query(GET_NAMED_MACHINE);

                @Override
                public void close() {
                        findBoardByChip.close();
                        findBoardByTriad.close();
                        findBoardPhys.close();
                        findBoardNet.close();
                        insertReport.close();
                        getReported.close();
                        setFunctioning.close();
                        getNamedMachine.close();
                        super.close();
                }
        }

        /** Used to assemble an issue-report email for sending. */
        private static final class EmailBuilder {
                /**
                 * More efficient than several String.format() calls, and much clearer
                 * than a mess of direct {@link StringBuilder} calls!
                 */
                private final Formatter b = new Formatter(Locale.UK);

                private final int id;

                /**
                 * @param id
                 *            The job ID
                 */
                EmailBuilder(int id) {
                        this.id = id;
                }

                void header(String issue, int numBoards, String who) {
                        b.format("Issues \"%s\" with %d boards reported by %s\n\n", issue,
                                        numBoards, who);
                }

                void chip(ReportedBoard board) {
                        b.format("\tBoard for job (%d) chip %s\n", //
                                        id, board.chip());
                }

                void triad(ReportedBoard board) {
                        b.format("\tBoard for job (%d) board (X:%d,Y:%d,Z:%d)\n", //
                                        id, board.x(), board.y(), board.z());
                }

                void phys(ReportedBoard board) {
                        b.format(
                                        "\tBoard for job (%d) board "
                                                        + "[Cabinet:%d,Frame:%d,Board:%d]\n", //
                                        id, board.cabinet(), board.frame(), board.board());
                }

                void ip(ReportedBoard board) {
                        b.format("\tBoard for job (%d) board (IP: %s)\n", //
                                        id, board.address());
                }

                void issue(int issueId) {
                        b.format("\t\tAction: noted as issue #%d\n", //
                                        issueId);
                }

                void footer(int numActions) {
                        b.format("\nSummary: %d boards taken out of service.\n",
                                        numActions);
                }

                void serviceActionDone(Reported report) {
                        b.format(
                                        "\tAction: board (X:%d,Y:%d,Z:%d) (IP: %s) "
                                                        + "taken out of service once not in use "
                                                        + "(%d problems reported)\n",
                                        report.x, report.y, report.z,
                                        report.address, report.numReports);
                }

                /** @return The assembled message body. */
                @Override
                public String toString() {
                        return b.toString();
                }
        }

        private final class JobImpl implements Job {
                @JsonIgnore
                private Epoch epoch;

                private final int id;

                private final int machineId;

                private Integer width;

                private Integer height;

                private Integer depth;

                private JobState state;

                /** If not {@code null}, the ID of the root board of the job. */
                private Integer root;

                private ChipLocation chipRoot;

                private String owner;

                private String keepaliveHost;

                private Instant startTime;

                private Instant keepaliveTime;

                private Instant finishTime;

                private String deathReason;

                private byte[] request;

                private boolean partial;

                private MachineImpl cachedMachine;

                JobImpl(int id, int machineId) {
                        this.epoch = epochs.getJobsEpoch(id);
                        this.id = id;
                        this.machineId = machineId;
                        partial = true;
                }

                JobImpl(int jobId, int machineId, JobState jobState,
                                Instant keepalive) {
                        this(jobId, machineId);
                        state = jobState;
                        keepaliveTime = keepalive;
                }

                JobImpl(Connection conn, Row row) {
                        this.id = row.getInt("job_id");
                        this.machineId = row.getInt("machine_id");
                        width = row.getInteger("width");
                        height = row.getInteger("height");
                        depth = row.getInteger("depth");
                        root = row.getInteger("root_id");
                        owner = row.getString("owner");
                        if (nonNull(root)) {
                                try (var boardRoot = conn.query(GET_ROOT_OF_BOARD)) {
                                        chipRoot = boardRoot.call1(chip("root_x", "root_y"), root)
                                                        .orElse(null);
                                }
                        }
                        state = row.getEnum("job_state", JobState.class);
                        keepaliveHost = row.getString("keepalive_host");
                        keepaliveTime = row.getInstant("keepalive_timestamp");
                        startTime = row.getInstant("create_timestamp");
                        finishTime = row.getInstant("death_timestamp");
                        deathReason = row.getString("death_reason");
                        request = row.getBytes("original_request");
                        partial = false;

                        this.epoch = epochs.getJobsEpoch(id);
                }

                /**
                 * Get the machine that this job is running on. May used a cached value.
                 * A transaction is required, but may be a read-only transaction.
                 *
                 * @param conn
                 *            The connection to the DB
                 * @return The overall machine handle.
                 */
                private synchronized MachineImpl getJobMachine(Connection conn) {
                        if (cachedMachine == null || !cachedMachine.epoch.isValid()) {
                                cachedMachine = Spalloc.this.getMachine(machineId, true, conn)
                                                .orElseThrow();
                        }
                        return cachedMachine;
                }

                @Override
                public void access(String keepaliveAddress) {
                        if (partial) {
                                throw new PartialJobException();
                        }
                        try (var conn = getConnection();
                                        var keepAlive = conn.update(UPDATE_KEEPALIVE)) {
                                conn.transaction(() -> keepAlive.call(keepaliveAddress, id));
                        }
                }

                @Override
                public void destroy(String reason) {
                        if (partial) {
                                throw new PartialJobException();
                        }
                        powerController.destroyJob(id, reason);
                        rememberer.killProxies(id);
                }

                @Override
                public boolean waitForChange(Duration timeout) {
                        if (isNull(epoch)) {
                                return true;
                        }
                        try {
                                return epoch.waitForChange(timeout);
                        } catch (InterruptedException interrupted) {
                                currentThread().interrupt();
                                return false;
                        }
                }

                @Override
                public int getId() {
                        return id;
                }

                @Override
                public JobState getState() {
                        return state;
                }

                @Override
                public Instant getStartTime() {
                        return startTime;
                }

                @Override
                public Optional<Instant> getFinishTime() {
                        return Optional.ofNullable(finishTime);
                }

                @Override
                public Optional<String> getReason() {
                        return Optional.ofNullable(deathReason);
                }

                @Override
                public Optional<String> getKeepaliveHost() {
                        if (partial) {
                                return Optional.empty();
                        }
                        return Optional.ofNullable(keepaliveHost);
                }

                @Override
                public Instant getKeepaliveTimestamp() {
                        return keepaliveTime;
                }

                @Override
                public Optional<byte[]> getOriginalRequest() {
                        if (partial) {
                                return Optional.empty();
                        }
                        return Optional.ofNullable(request);
                }

                @Override
                public Optional<SubMachine> getMachine() {
                        if (isNull(root)) {
                                return Optional.empty();
                        }
                        return executeRead(conn -> Optional.of(new SubMachineImpl(conn)));
                }

                @Override
                public Optional<BoardLocation> whereIs(int x, int y) {
                        if (isNull(root)) {
                                return Optional.empty();
                        }
                        try (var conn = getConnection();
                                        var findBoard = conn.query(findBoardByJobChip)) {
                                return conn.transaction(false, () -> findBoard
                                                .call1(row -> new BoardLocationImpl(row,
                                                                getJobMachine(conn)), id, root, x, y));
                        }
                }

                // -------------------------------------------------------------
                // Bad board report handling

                @Override
                public String reportIssue(IssueReportRequest report, Permit permit) {
                        try (var q = new BoardReportSQL()) {
                                var email = new EmailBuilder(id);
                                var result = q.transaction(
                                                () -> reportIssue(report, permit, email, q));
                                emailSender.sendServiceMail(email);
                                for (var m : report.boards().stream()
                                                .map(b -> q.getNamedMachine.call1(
                                                                r -> r.getInt("machine_id"), b.machine(), true))
                                                .collect(toSet())) {
                                        if (m.isPresent()) {
                                                epochs.machineChanged(m.get());
                                        }
                                }

                                return result;
                        } catch (ReportRollbackExn e) {
                                return e.getMessage();
                        }
                }

                /**
                 * Report an issue with some boards and assemble the email to send. This
                 * may result in boards being taken out of service (i.e., no longer
                 * being available to be allocated; their current allocation will
                 * continue).
                 * <p>
                 * <strong>NB:</strong> The sending of the email sending is
                 * <em>outside</em> the transaction that this code is executed in.
                 *
                 * @param report
                 *            The report from the user.
                 * @param permit
                 *            Who the user is.
                 * @param email
                 *            The email we're assembling.
                 * @param q
                 *            SQL access queries.
                 * @return Summary of action taken message, to go to user.
                 * @throws ReportRollbackExn
                 *             If the report is bad somehow.
                 */
                private String reportIssue(IssueReportRequest report, Permit permit,
                                EmailBuilder email, BoardReportSQL q) throws ReportRollbackExn {
                        email.header(report.issue(), report.boards().size(), permit.name);
                        int userId = getUser(q.getConnection(), permit.name)
                                        .orElseThrow(() -> new ReportRollbackExn(
                                                        "no such user: %s", permit.name));
                        for (var board : report.boards()) {
                                addIssueReport(q, getJobBoardForReport(q, board, email),
                                                report.issue(), userId, email);
                        }
                        return takeBoardsOutOfService(q, email).map(acted -> {
                                email.footer(acted);
                                return format("%d boards taken out of service", acted);
                        }).orElse("report noted");
                }

                /**
                 * Convert a board locator (for an issue report) into a board ID.
                 *
                 * @param q
                 *            How to touch the DB
                 * @param board
                 *            What board are we talking about
                 * @param email
                 *            The email we are building.
                 * @return The board ID
                 * @throws ReportRollbackExn
                 *             If the board can't be converted to an ID
                 */
                private int getJobBoardForReport(BoardReportSQL q, ReportedBoard board,
                                EmailBuilder email) throws ReportRollbackExn {
                        Problem r;
                        if (nonNull(board.chip())) {
                                r = q.findBoardByChip
                                                .call1(Problem::new, id, root, board.chip().getX(),
                                                                board.chip().getY())
                                                .orElseThrow(() -> new ReportRollbackExn(board.chip()));
                                email.chip(board);
                        } else if (nonNull(board.x())) {
                                r = q.findBoardByTriad
                                                .call1(Problem::new, machineId, board.x(), board.y(),
                                                                board.z())
                                                .orElseThrow(() -> new ReportRollbackExn(
                                                                "triad (%s,%s,%s) not in machine", board.x(),
                                                                board.y(), board.z()));
                                if (isNull(r.jobId) || id != r.jobId) {
                                        throw new ReportRollbackExn(
                                                        "triad (%s,%s,%s) not allocated to job %d",
                                                        board.x(), board.y(), board.z(), id);
                                }
                                email.triad(board);
                        } else if (nonNull(board.cabinet())) {
                                r = q.findBoardPhys
                                                .call1(Problem::new, machineId, board.cabinet(),
                                                                board.frame(), board.board())
                                                .orElseThrow(() -> new ReportRollbackExn(
                                                                "physical board [%s,%s,%s] not in machine",
                                                                board.cabinet(), board.frame(), board.board()));
                                if (isNull(r.jobId) || id != r.jobId) {
                                        throw new ReportRollbackExn(
                                                        "physical board [%s,%s,%s] not allocated to job %d",
                                                        board.cabinet(), board.frame(), board.board(), id);
                                }
                                email.phys(board);
                        } else if (nonNull(board.address())) {
                                r = q.findBoardNet
                                                .call1(Problem::new, machineId, board.address())
                                                .orElseThrow(() -> new ReportRollbackExn(
                                                                "board at %s not in machine", board.address()));
                                if (isNull(r.jobId) || id != r.jobId) {
                                        throw new ReportRollbackExn(
                                                        "board at %s not allocated to job %d",
                                                        board.address(), id);
                                }
                                email.ip(board);
                        } else {
                                throw new UnsupportedOperationException();
                        }
                        return r.boardId;
                }

                /**
                 * Record a reported issue with a board.
                 *
                 * @param u
                 *            How to touch the DB
                 * @param boardId
                 *            What board has the issue?
                 * @param issue
                 *            What is the issue?
                 * @param userId
                 *            Who is doing the report?
                 * @param email
                 *            The email we are building.
                 */
                private void addIssueReport(BoardReportSQL u, int boardId, String issue,
                                int userId, EmailBuilder email) {
                        u.insertReport.key(boardId, id, issue, userId)
                                        .ifPresent(email::issue);
                }

                // -------------------------------------------------------------

                @Override
                public Optional<ChipLocation> getRootChip() {
                        return Optional.ofNullable(chipRoot);
                }

                @Override
                public Optional<String> getOwner() {
                        if (partial) {
                                return Optional.empty();
                        }
                        return Optional.ofNullable(owner);
                }

                @Override
                public Optional<Integer> getWidth() {
                        return Optional.ofNullable(width);
                }

                @Override
                public Optional<Integer> getHeight() {
                        return Optional.ofNullable(height);
                }

                @Override
                public Optional<Integer> getDepth() {
                        return Optional.ofNullable(depth);
                }

                @Override
                public void rememberProxy(ProxyCore proxy) {
                        rememberer.rememberProxyForJob(id, proxy);
                }

                @Override
                public void forgetProxy(ProxyCore proxy) {
                        rememberer.removeProxyForJob(id, proxy);
                }

                @Override
                public boolean equals(Object other) {
                        // Equality is defined exactly by the database ID
                        return (other instanceof JobImpl j) && (id == j.id);
                }

                @Override
                public int hashCode() {
                        return id;
                }

                @Override
                public String toString() {
                        return format("Job(id=%s,dims=(%s,%s,%s),start=%s,finish=%s)", id,
                                        width, height, depth, startTime, finishTime);
                }

                private final class SubMachineImpl implements SubMachine {
                        /** The machine that this sub-machine is part of. */
                        private final Machine machine;

                        /** The root X coordinate of this sub-machine. */
                        private int rootX;

                        /** The root Y coordinate of this sub-machine. */
                        private int rootY;

                        /** The root Z coordinate of this sub-machine. */
                        private int rootZ;

                        /** The connection details of this sub-machine. */
                        private List<ConnectionInfo> connections;

                        /** The board locations of this sub-machine. */
                        private List<BoardCoordinates> boards;

                        private List<Integer> boardIds;

                        private SubMachineImpl(Connection conn) {
                                machine = getJobMachine(conn);
                                try (var getRootXY = conn.query(GET_ROOT_COORDS);
                                                var getBoardInfo = conn.query(GET_BOARD_CONNECT_INFO)) {
                                        getRootXY.call1(row -> {
                                                rootX = row.getInt("x");
                                                rootY = row.getInt("y");
                                                rootZ = row.getInt("z");
                                                // We have to return something,
                                                // but it doesn't matter what
                                                return true;
                                        }, root);
                                        int capacityEstimate = width * height;
                                        connections = new ArrayList<>(capacityEstimate);
                                        boards = new ArrayList<>(capacityEstimate);
                                        boardIds = new ArrayList<>(capacityEstimate);
                                        getBoardInfo.call(row -> {
                                                boardIds.add(row.getInt("board_id"));
                                                boards.add(new BoardCoordinates(row.getInt("x"),
                                                                row.getInt("y"), row.getInt("z")));
                                                connections.add(new ConnectionInfo(
                                                                relativeChipLocation(row.getInt("root_x"),
                                                                                row.getInt("root_y")),
                                                                row.getString("address")));
                                                // We have to return something,
                                                // but it doesn't matter what
                                                return true;
                                        }, id);
                                }
                        }

                        private ChipLocation relativeChipLocation(int x, int y) {
                                x -= chipRoot.getX();
                                y -= chipRoot.getY();
                                // Allow for wrapping
                                if (x < 0) {
                                        x += machine.getWidth() * TRIAD_CHIP_SIZE;
                                }
                                if (y < 0) {
                                        y += machine.getHeight() * TRIAD_CHIP_SIZE;
                                }
                                return new ChipLocation(x, y);
                        }

                        @Override
                        public Machine getMachine() {
                                return machine;
                        }

                        @Override
                        public int getRootX() {
                                return rootX;
                        }

                        @Override
                        public int getRootY() {
                                return rootY;
                        }

                        @Override
                        public int getRootZ() {
                                return rootZ;
                        }

                        @Override
                        public int getWidth() {
                                return width;
                        }

                        @Override
                        public int getHeight() {
                                return height;
                        }

                        @Override
                        public int getDepth() {
                                return depth;
                        }

                        @Override
                        public List<ConnectionInfo> getConnections() {
                                return connections;
                        }

                        @Override
                        public List<BoardCoordinates> getBoards() {
                                return boards;
                        }

                        @Override
                        public PowerState getPower() {
                                try (var conn = getConnection();
                                                var power = conn.query(GET_SUM_BOARDS_POWERED)) {
                                        return conn.transaction(false,
                                                        () -> power.call1(integer("total_on"), id)
                                                                        .map(totalOn -> totalOn < boardIds.size()
                                                                                        ? OFF
                                                                                        : ON)
                                                                        .orElse(null));
                                }
                        }

                        @Override
                        public void setPower(PowerState ps) {
                                if (partial) {
                                        throw new PartialJobException();
                                }
                                powerController.setPower(id, ps, READY);
                        }
                }
        }

        /**
         * Board location implementation. Does not retain database connections after
         * creation.
         *
         * @author Donal Fellows
         */
        private final class BoardLocationImpl implements BoardLocation {
                private JobImpl job;

                private final String machineName;

                private final int machineWidth;

                private final int machineHeight;

                private final ChipLocation chip;

                private final ChipLocation boardChip;

                private final BoardCoordinates logical;

                private final BoardPhysicalCoordinates physical;

                // Transaction is open
                private BoardLocationImpl(Row row, Machine machine) {
                        machineName = row.getString("machine_name");
                        logical = new BoardCoordinates(row.getInt("x"), row.getInt("y"),
                                        row.getInt("z"));
                        physical = new BoardPhysicalCoordinates(row.getInt("cabinet"),
                                        row.getInt("frame"), row.getInteger("board_num"));
                        chip = row.getChip("chip_x", "chip_y");
                        machineWidth = machine.getWidth();
                        machineHeight = machine.getHeight();
                        var boardX = row.getInteger("board_chip_x");
                        if (nonNull(boardX)) {
                                boardChip = row.getChip("board_chip_x", "board_chip_y");
                        } else {
                                boardChip = chip;
                        }

                        var jobId = row.getInteger("job_id");
                        if (nonNull(jobId)) {
                                job = new JobImpl(jobId, machine.getId());
                                job.chipRoot = row.getChip("job_root_chip_x",
                                                "job_root_chip_y");
                        }
                }

                @Override
                public ChipLocation getBoardChip() {
                        return boardChip;
                }

                @Override
                public ChipLocation getChipRelativeTo(ChipLocation rootChip) {
                        int x = chip.getX() - rootChip.getX();
                        if (x < 0) {
                                x += machineWidth * TRIAD_CHIP_SIZE;
                        }
                        int y = chip.getY() - rootChip.getY();
                        if (y < 0) {
                                y += machineHeight * TRIAD_CHIP_SIZE;
                        }
                        return new ChipLocation(x, y);
                }

                @Override
                public String getMachine() {
                        return machineName;
                }

                @Override
                public BoardCoordinates getLogical() {
                        return logical;
                }

                @Override
                public BoardPhysicalCoordinates getPhysical() {
                        return physical;
                }

                @Override
                public ChipLocation getChip() {
                        return chip;
                }

                @Override
                public Job getJob() {
                        return job;
                }
        }

        static class PartialJobException extends IllegalStateException {
                @Serial
                private static final long serialVersionUID = 2997856394666135483L;

                PartialJobException() {
                        super("partial job only");
                }
        }
}

class ReportRollbackExn extends RuntimeException {
        private static final long serialVersionUID = 1L;

        @FormatMethod
        ReportRollbackExn(String msg, Object... args) {
                super(format(msg, args));
        }

        ReportRollbackExn(HasChipLocation chip) {
                this("chip at (%d,%d) not in job's allocation", chip.getX(),
                                chip.getY());
        }
}

abstract class GroupsException extends RuntimeException {
        @Serial
        private static final long serialVersionUID = 6607077117924279611L;

        GroupsException(String message) {
                super(message);
        }

        GroupsException(String message, Throwable cause) {
                super(message, cause);
        }
}

class NoSuchGroupException extends GroupsException {
        @Serial
        private static final long serialVersionUID = 5193818294198205503L;

        @FormatMethod
        NoSuchGroupException(String msg, Object... args) {
                super(format(msg, args));
        }
}

class MultipleGroupsException extends GroupsException {
        @Serial
        private static final long serialVersionUID = 6284332340565334236L;

        @FormatMethod
        MultipleGroupsException(String msg, Object... args) {
                super(format(msg, args));
        }
}

SpiNNakerManchester / JavaSpiNNaker / 6310285782

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous