6284547049

Committed 23 Sep 2023 03:28PM UTC coverage: 82.083% (+0.7%) from 81.372%

Build # 6284547049

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #1531 from liip/2-to-3

2 to 3

Run Details

19 of 24 new or added lines in 6 files covered. (79.17%)

21 existing lines in 4 files now uncovered.

1860 of 2266 relevant lines covered (82.08%)

67.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/DependencyInjection/Compiler/NonFunctionalFilterExceptionPass.php

<?php

/*
 * This file is part of the `liip/LiipImagineBundle` project.
 *
 * (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Liip\ImagineBundle\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
 * For transitioning from Symfony 4 to Symfony 5 with the removal
 * of the kernel.root_dir parameter.
 */
class NonFunctionalFilterExceptionPass implements CompilerPassInterface
{
    public function process(ContainerBuilder $container): void
    {
        $canFiltersStillFunction = $container->hasParameter('kernel.root_dir');
        $throwWarning = function (string $filterName) use ($canFiltersStillFunction) {
            $message = sprintf(
                'The "%s" filter %s in Symfony 5.0. Please use "%s_image" and adapt the "image" option to be relative to the "%%kernel.project_dir%%" instead of "%%kernel.root_dir%%".',
                $filterName,
                $canFiltersStillFunction ? 'is deprecated and will not work' : 'no longer works',
                $filterName
            );

            if ($canFiltersStillFunction) {
                @trigger_error($message, E_USER_DEPRECATED);
            } else {
                throw new \InvalidArgumentException($message);
            }
        };

        $filterSets = $container->getParameter('liip_imagine.filter_sets');
        foreach ($filterSets as $filterSet) {
            foreach ($filterSet['filters'] as $filterName => $filter) {
                if ('paste' === $filterName) {
                    $throwWarning('paste');
                }

                if ('watermark' === $filterName) {
                    $throwWarning('watermark');
                }
            }
        }

        // remove the definitions entirely if kernel.root_dir does not exist
        if (!$canFiltersStillFunction) {
            $container->removeDefinition('liip_imagine.filter.loader.watermark');
            $container->removeDefinition('liip_imagine.filter.loader.paste');
        }
    }
}

1	<?php
2
3	/*
4	* This file is part of the `liip/LiipImagineBundle` project.
5	*
6	* (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
7	*
8	* For the full copyright and license information, please view the LICENSE.md
9	* file that was distributed with this source code.
10	*/
11
12	namespace Liip\ImagineBundle\DependencyInjection\Compiler;
13
14	use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
15	use Symfony\Component\DependencyInjection\ContainerBuilder;
16
17	/**
18	* For transitioning from Symfony 4 to Symfony 5 with the removal
19	* of the kernel.root_dir parameter.
20	*/
21	class NonFunctionalFilterExceptionPass implements CompilerPassInterface
22	{
23	public function process(ContainerBuilder $container): void
24	{
25	$canFiltersStillFunction = $container->hasParameter('kernel.root_dir');	×
26	$throwWarning = function (string $filterName) use ($canFiltersStillFunction) {	×
27	$message = sprintf(	×
UNCOV 28	'The "%s" filter %s in Symfony 5.0. Please use "%s_image" and adapt the "image" option to be relative to the "%%kernel.project_dir%%" instead of "%%kernel.root_dir%%".',	×
UNCOV 29	$filterName,	×
30	$canFiltersStillFunction ? 'is deprecated and will not work' : 'no longer works',	×
UNCOV 31	$filterName	×
UNCOV 32	);	×
33
34	if ($canFiltersStillFunction) {	×
35	@trigger_error($message, E_USER_DEPRECATED);	×
36	} else {
37	throw new \InvalidArgumentException($message);	×
38	}
UNCOV 39	};	×
40
41	$filterSets = $container->getParameter('liip_imagine.filter_sets');	×
42	foreach ($filterSets as $filterSet) {	×
43	foreach ($filterSet['filters'] as $filterName => $filter) {	×
44	if ('paste' === $filterName) {	×
45	$throwWarning('paste');	×
46	}
47
48	if ('watermark' === $filterName) {	×
49	$throwWarning('watermark');	×
50	}
51	}
52	}
53
54	// remove the definitions entirely if kernel.root_dir does not exist
55	if (!$canFiltersStillFunction) {	×
56	$container->removeDefinition('liip_imagine.filter.loader.watermark');	×
57	$container->removeDefinition('liip_imagine.filter.loader.paste');	×
58	}
59	}
60	}

liip / LiipImagineBundle / 6284547049

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous