push
github
Handle table unsinking in the presence of IRFL_TAB_NOMM. Reported by Sergey Kaplun. (cherry-picked from commit 0ef51b495) Table `NEWREF` storage for non-constant keys also emits `FREF` IR with `IRFL_TAB_NOMM` to invalidate the metamethod cache. When table creation and `NEWREF` are sinked, the corresponding `FSTORE` is sinked too and should be restored on trace exit. However, `snap_unsink()` doesn't expect anything except `IRFL_TAB_META` as the second operand of `FREF`, so the corresponding assertion fails. This patch adds a switch-case statement to handle the `IRFL_TAB_NOMM` case. Since `FREF` with `IRFL_TAB_NOMM` always follows some hash store, we can avoid a duplication of the cache invalidation, so this case just does nothing. Sergey Kaplun: * added the description and the test for the problem Part of tarantool/tarantool#8825
5335 of 5969 branches covered (0.0%)
Branch coverage included in aggregate %.
20464 of 23288 relevant lines covered (87.87%)
1286506.92 hits per line