6096268437

Committed 06 Sep 2023 11:10AM UTC coverage: 91.688% (-0.2%) from 91.905%

Build Type

push

github

Committed by fmrsabino

Commit Message

Add Safe Relay domain

Run Details

1207 of 1440 branches covered (0.0%)

Branch coverage included in aggregate %.

59 of 83 new or added lines in 9 files covered. (71.08%)

30 existing lines in 8 files now uncovered.

4617 of 4912 relevant lines covered (93.99%)

149.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.0

/src/domain/relay/limit-addresses.mapper.ts

import { Injectable } from '@nestjs/common';
import { SafeContractHelper } from './contracts/safe-contract.helper';
import { Erc20ContractHelper } from './contracts/erc20-contract.helper';
import { Hex } from 'viem/src/types/misc';

export interface RelayPayload {
  chainId: string;
  data: Hex;
  to: string;
  gasLimit: bigint;
}

@Injectable()
export class LimitAddressesMapper {
  constructor(
    private readonly safeContract: SafeContractHelper,
    private readonly erc20Contract: Erc20ContractHelper,
  ) {}

  getLimitAddresses(relayPayload: RelayPayload): string[] {
    if (this.isValidExecTransactionCall(relayPayload.to, relayPayload.data)) {
      return [relayPayload.to];
    }

    // TODO Handle Multisend

    // TODO Handle create proxy with nonce

    throw Error('Cannot get limit addresses – Invalid transfer');
  }

  private isValidExecTransactionCall(to: string, data: Hex): boolean {
    let execTransaction: { data: Hex; to: Hex; value: bigint };
    // If transaction is an execTransaction
    try {
      execTransaction = this.safeContract.decode(
        SafeContractHelper.EXEC_TRANSACTION,
        data,
      );
    } catch (e) {
      return false;
    }

    // If data of execTransaction is an ERC20 transfer
    try {
      const erc20DecodedData = this.erc20Contract.decode(
        Erc20ContractHelper.TRANSFER,
        execTransaction.data,
      );
      // If the ERC20 transfer targets 'self' (the Safe), we consider it to be invalid
      return erc20DecodedData.to !== to;
    } catch (e) {
      // TODO: noop/log
    }

    // If a transaction does not target 'self' consider it valid
    if (to !== execTransaction.to) {
      return true;
    }

    // Transaction targets 'self'
    // Block transactions targeting self with a value greater than 0
    if (Number(execTransaction.value) > 0) {
      return false;
    }

    const isCancellation = execTransaction.data === '0x';
    return isCancellation || this.safeContract.isCall(execTransaction.data);
  }
}

1	import { Injectable } from '@nestjs/common';	52✔
2	import { SafeContractHelper } from './contracts/safe-contract.helper';	52✔
3	import { Erc20ContractHelper } from './contracts/erc20-contract.helper';	52✔
4	import { Hex } from 'viem/src/types/misc';
5
6	export interface RelayPayload {
7	chainId: string;
8	data: Hex;
9	to: string;
10	gasLimit: bigint;
11	}
12
13	@Injectable()
14	export class LimitAddressesMapper {	52✔
15	constructor(
16	private readonly safeContract: SafeContractHelper,	402✔
17	private readonly erc20Contract: Erc20ContractHelper,	402✔
18	) {}
19
20	getLimitAddresses(relayPayload: RelayPayload): string[] {
21	if (this.isValidExecTransactionCall(relayPayload.to, relayPayload.data)) {	2✔
22	return [relayPayload.to];	2✔
23	}
24
25	// TODO Handle Multisend
26
27	// TODO Handle create proxy with nonce
28
NEW 29	throw Error('Cannot get limit addresses – Invalid transfer');	×
30	}
31
32	private isValidExecTransactionCall(to: string, data: Hex): boolean {
33	let execTransaction: { data: Hex; to: Hex; value: bigint };
34	// If transaction is an execTransaction
35	try {	2✔
36	execTransaction = this.safeContract.decode(	2✔
37	SafeContractHelper.EXEC_TRANSACTION,
38	data,
39	);
40	} catch (e) {
NEW 41	return false;	×
42	}
43
44	// If data of execTransaction is an ERC20 transfer
45	try {	2✔
46	const erc20DecodedData = this.erc20Contract.decode(	2✔
47	Erc20ContractHelper.TRANSFER,
48	execTransaction.data,
49	);
50	// If the ERC20 transfer targets 'self' (the Safe), we consider it to be invalid
NEW 51	return erc20DecodedData.to !== to;	×
52	} catch (e) {
53	// TODO: noop/log
54	}
55
56	// If a transaction does not target 'self' consider it valid
57	if (to !== execTransaction.to) {	2!
NEW 58	return true;	×
59	}
60
61	// Transaction targets 'self'
62	// Block transactions targeting self with a value greater than 0
63	if (Number(execTransaction.value) > 0) {	2!
NEW 64	return false;	×
65	}
66
67	const isCancellation = execTransaction.data === '0x';	2✔
68	return isCancellation \|\| this.safeContract.isCall(execTransaction.data);	2✔
69	}
70	}

safe-global / safe-client-gateway / 6096268437

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous