5993769794

Committed 27 Aug 2023 11:22PM UTC coverage: 18.282% (-0.08%) from 18.359%

Build # 5993769794

Build Type

push

github

Committed by

neon-sunset

Commit Message

perf: interleave CountMatches for V128, change runes enumerator to use common CopyTo impl.

Run Details

134 of 1038 branches covered (0.0%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 2 files covered. (100.0%)

479 of 2315 relevant lines covered (20.69%)

35564.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

19.35

/src/Extensions/VectorExtensions.cs

using System.Numerics;
using System.Runtime.Intrinsics;
using System.Runtime.Intrinsics.Arm;

namespace U8Primitives;

internal static class VectorExtensions
{
    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    internal static int CountMatches(this Vector256<byte> mask)
    {
        if (Vector256.IsHardwareAccelerated)
        {
            return BitOperations.PopCount(mask.ExtractMostSignificantBits());
        }

        var upper = mask.GetUpper();
        var lower = mask.GetLower();

        int upperCount, lowerCount;
        if (AdvSimd.Arm64.IsSupported)
        {
            var upperMatches = AdvSimd
                .ShiftRightLogicalNarrowingLower(upper.AsUInt16(), 4)
                .AsUInt64();
            var lowerMatches = AdvSimd
                .ShiftRightLogicalNarrowingLower(lower.AsUInt16(), 4)
                .AsUInt64();
            upperCount = BitOperations.PopCount(upperMatches.ToScalar()) >> 2;
            lowerCount = BitOperations.PopCount(lowerMatches.ToScalar()) >> 2;
        }
        else
        {
            var upperMatches = upper.ExtractMostSignificantBits();
            var lowerMatches = lower.ExtractMostSignificantBits();
            upperCount = BitOperations.PopCount(upperMatches);
            lowerCount = BitOperations.PopCount(lowerMatches);
        }

        return upperCount + lowerCount;
    }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    internal static int CountMatches(this Vector128<byte> mask)
    {
        // Is there really no way to use AddAcross here?
        if (AdvSimd.Arm64.IsSupported)
        {
            var matches = AdvSimd
                .ShiftRightLogicalNarrowingLower(mask.AsUInt16(), 4)
                .AsUInt64()
                .ToScalar();
            return BitOperations.PopCount(matches) >> 2;
        }

        return BitOperations.PopCount(mask.ExtractMostSignificantBits());
    }
}

1	using System.Numerics;
2	using System.Runtime.Intrinsics;
3	using System.Runtime.Intrinsics.Arm;
4
5	namespace U8Primitives;
6
7	internal static class VectorExtensions
8	{
9	[MethodImpl(MethodImplOptions.AggressiveInlining)]
10	internal static int CountMatches(this Vector256<byte> mask)
11	{
12	if (Vector256.IsHardwareAccelerated)	141!
13	{
14	return BitOperations.PopCount(mask.ExtractMostSignificantBits());	141✔
15	}
16
17	var upper = mask.GetUpper();	×
18	var lower = mask.GetLower();	×
19
20	int upperCount, lowerCount;
21	if (AdvSimd.Arm64.IsSupported)	×
22	{
23	var upperMatches = AdvSimd	×
24	.ShiftRightLogicalNarrowingLower(upper.AsUInt16(), 4)	×
25	.AsUInt64();	×
26	var lowerMatches = AdvSimd	×
27	.ShiftRightLogicalNarrowingLower(lower.AsUInt16(), 4)	×
28	.AsUInt64();	×
29	upperCount = BitOperations.PopCount(upperMatches.ToScalar()) >> 2;	×
30	lowerCount = BitOperations.PopCount(lowerMatches.ToScalar()) >> 2;	×
31	}
32	else
33	{
34	var upperMatches = upper.ExtractMostSignificantBits();	×
35	var lowerMatches = lower.ExtractMostSignificantBits();	×
36	upperCount = BitOperations.PopCount(upperMatches);	×
37	lowerCount = BitOperations.PopCount(lowerMatches);	×
38	}
39
40	return upperCount + lowerCount;	×
41	}
42
43	[MethodImpl(MethodImplOptions.AggressiveInlining)]
44	internal static int CountMatches(this Vector128<byte> mask)
45	{
46	// Is there really no way to use AddAcross here?
47	if (AdvSimd.Arm64.IsSupported)	6!
48	{
49	var matches = AdvSimd	×
50	.ShiftRightLogicalNarrowingLower(mask.AsUInt16(), 4)	×
51	.AsUInt64()	×
52	.ToScalar();	×
53	return BitOperations.PopCount(matches) >> 2;	×
54	}
55
56	return BitOperations.PopCount(mask.ExtractMostSignificantBits());	6✔
57	}
58	}

neon-sunset / U8String / 5993769794

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous