#9923

Committed 25 Aug 2023 10:16AM UTC coverage: 47.726% (-0.06%) from 47.788%

Build # #9923

Build Type

push

travis_ci

Committed by

web-flow

Commit Message

[IOTDB-6123] Pipe: reduce the de/ser to slove the slow log transfer problem (#10913) (#10959)

Co-authored-by: Steve Yurong Su <rong@apache.org>
(cherry picked from commit 0a5d4ec99)

Run Details

230 of 230 new or added lines in 17 files covered. (100.0%)

79990 of 167601 relevant lines covered (47.73%)

0.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

62.07

/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/ClientManager.java

/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

package org.apache.iotdb.commons.client;

import org.apache.iotdb.commons.client.exception.BorrowNullClientManagerException;
import org.apache.iotdb.commons.client.exception.ClientManagerException;
import org.apache.iotdb.commons.utils.TestOnly;

import org.apache.commons.pool2.KeyedObjectPool;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.Optional;

public class ClientManager<K, V> implements IClientManager<K, V> {

  private static final Logger logger = LoggerFactory.getLogger(ClientManager.class);

  private final KeyedObjectPool<K, V> pool;

  ClientManager(IClientPoolFactory<K, V> factory) {
    pool = factory.createClientPool(this);
  }

  @TestOnly
  public KeyedObjectPool<K, V> getPool() {
    return pool;
  }

  @Override
  public V borrowClient(K node) throws ClientManagerException {
    if (node == null) {
      throw new BorrowNullClientManagerException();
    }
    try {
      return pool.borrowObject(node);
    } catch (Exception e) {
      throw new ClientManagerException(e);
    }
  }

  /**
   * return a client V for node K to the ClientManager.
   *
   * <p>Note: We do not define this interface in IClientManager to make you aware that the return of
   * a client is automatic whenever a particular client is used.
   */
  public void returnClient(K node, V client) {
    Optional.ofNullable(node)
        .ifPresent(
            x -> {
              try {
                pool.returnObject(node, client);
              } catch (Exception e) {
                logger.warn(
                    String.format("Return client %s for node %s to pool failed.", client, node), e);
              }
            });
  }

  @Override
  public void clear(K node) {
    Optional.ofNullable(node)
        .ifPresent(
            x -> {
              try {
                pool.clear(node);
              } catch (Exception e) {
                logger.warn(String.format("Clear all client in pool for node %s failed.", node), e);
              }
            });
  }

  @Override
  public void close() {
    pool.close();
  }
}

1	/*
2	* Licensed to the Apache Software Foundation (ASF) under one
3	* or more contributor license agreements. See the NOTICE file
4	* distributed with this work for additional information
5	* regarding copyright ownership. The ASF licenses this file
6	* to you under the Apache License, Version 2.0 (the
7	* "License"); you may not use this file except in compliance
8	* with the License. You may obtain a copy of the License at
9	*
10	* http://www.apache.org/licenses/LICENSE-2.0
11	*
12	* Unless required by applicable law or agreed to in writing,
13	* software distributed under the License is distributed on an
14	* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15	* KIND, either express or implied. See the License for the
16	* specific language governing permissions and limitations
17	* under the License.
18	*/
19
20	package org.apache.iotdb.commons.client;
21
22	import org.apache.iotdb.commons.client.exception.BorrowNullClientManagerException;
23	import org.apache.iotdb.commons.client.exception.ClientManagerException;
24	import org.apache.iotdb.commons.utils.TestOnly;
25
26	import org.apache.commons.pool2.KeyedObjectPool;
27	import org.slf4j.Logger;
28	import org.slf4j.LoggerFactory;
29
30	import java.util.Optional;
31
32	public class ClientManager<K, V> implements IClientManager<K, V> {
33
34	private static final Logger logger = LoggerFactory.getLogger(ClientManager.class);	1✔
35
36	private final KeyedObjectPool<K, V> pool;
37
38	ClientManager(IClientPoolFactory<K, V> factory) {	1✔
39	pool = factory.createClientPool(this);	1✔
40	}	1✔
41
42	@TestOnly
43	public KeyedObjectPool<K, V> getPool() {
44	return pool;	1✔
45	}
46
47	@Override
48	public V borrowClient(K node) throws ClientManagerException {
49	if (node == null) {	1✔
50	throw new BorrowNullClientManagerException();	1✔
51	}
52	try {
53	return pool.borrowObject(node);	1✔
54	} catch (Exception e) {	1✔
55	throw new ClientManagerException(e);	1✔
56	}
57	}
58
59	/**
60	* return a client V for node K to the ClientManager.
61	*
62	* <p>Note: We do not define this interface in IClientManager to make you aware that the return of
63	* a client is automatic whenever a particular client is used.
64	*/
65	public void returnClient(K node, V client) {
66	Optional.ofNullable(node)	1✔
67	.ifPresent(	1✔
68	x -> {
69	try {
70	pool.returnObject(node, client);	1✔
71	} catch (Exception e) {	×
72	logger.warn(	×
73	String.format("Return client %s for node %s to pool failed.", client, node), e);	×
74	}	1✔
75	});	1✔
76	}	1✔
77
78	@Override
79	public void clear(K node) {
80	Optional.ofNullable(node)	×
81	.ifPresent(	×
82	x -> {
83	try {
84	pool.clear(node);	×
85	} catch (Exception e) {	×
86	logger.warn(String.format("Clear all client in pool for node %s failed.", node), e);	×
87	}	×
88	});	×
89	}	×
90
91	@Override
92	public void close() {
93	pool.close();	1✔
94	}	1✔
95	}

apache / iotdb / #9923

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous