5953891787

Committed 23 Aug 2023 04:20PM UTC coverage: 21.364%. Remained the same

Build # 5953891787

Build Type

push

github

Committed by

neon-sunset

Commit Message

fix: invalid rune count calculation on ARM64

Run Details

133 of 874 branches covered (15.22%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

481 of 2000 relevant lines covered (24.05%)

41214.18 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

42.86

/src/Extensions/VectorExtensions.cs

using System.Numerics;
using System.Runtime.Intrinsics;
using System.Runtime.Intrinsics.Arm;

namespace U8Primitives;

internal static class VectorExtensions
{
    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    internal static int CountMatches(this Vector256<byte> mask)
    {
        if (Vector256.IsHardwareAccelerated)
        {
            return BitOperations.PopCount(mask.ExtractMostSignificantBits());
        }

        return CountMatches(mask.GetLower()) + CountMatches(mask.GetUpper());
    }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    internal static int CountMatches(this Vector128<byte> mask)
    {
        // Is there really no way to use AddAcross here?
        if (AdvSimd.Arm64.IsSupported)
        {
            var matches = AdvSimd
                .ShiftRightLogicalNarrowingLower(mask.AsUInt16(), 4)
                .AsUInt64()
                .ToScalar();
            return BitOperations.PopCount(matches) >> 2;
        }

        return BitOperations.PopCount(mask.ExtractMostSignificantBits());
    }
}

1	using System.Numerics;
2	using System.Runtime.Intrinsics;
3	using System.Runtime.Intrinsics.Arm;
4
5	namespace U8Primitives;
6
7	internal static class VectorExtensions
8	{
9	[MethodImpl(MethodImplOptions.AggressiveInlining)]
10	internal static int CountMatches(this Vector256<byte> mask)
11	{
12	if (Vector256.IsHardwareAccelerated)	141!
13	{
14	return BitOperations.PopCount(mask.ExtractMostSignificantBits());	141✔
15	}
16
17	return CountMatches(mask.GetLower()) + CountMatches(mask.GetUpper());	×
18	}
19
20	[MethodImpl(MethodImplOptions.AggressiveInlining)]
21	internal static int CountMatches(this Vector128<byte> mask)
22	{
23	// Is there really no way to use AddAcross here?
24	if (AdvSimd.Arm64.IsSupported)	6!
25	{
26	var matches = AdvSimd	×
27	.ShiftRightLogicalNarrowingLower(mask.AsUInt16(), 4)	×
28	.AsUInt64()	×
29	.ToScalar();	×
30	return BitOperations.PopCount(matches) >> 2;	×
31	}
32
33	return BitOperations.PopCount(mask.ExtractMostSignificantBits());	6✔
34	}
35	}

neon-sunset / U8String / 5953891787

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous