5893084251

Committed 17 Aug 2023 03:49PM UTC coverage: 90.404% (+0.05%) from 90.355%

Build Type

push

github

Committed by Hector Gómez Varela

Commit Message

Refactor BalancesService

Run Details

909 of 1161 branches covered (78.29%)

Branch coverage included in aggregate %.

9 of 29 new or added lines in 4 files covered. (31.03%)

28 existing lines in 4 files now uncovered.

4376 of 4685 relevant lines covered (93.4%)

68.16 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

13.64

/src/domain/prices/prices.repository.ts

import { Inject, Injectable } from '@nestjs/common';
import {
  ILoggingService,
  LoggingService,
} from '../../logging/logging.interface';
import { IPricesApi } from '../interfaces/prices-api.interface';
import { IPricesRepository } from './prices.repository.interface';

@Injectable()
export class PricesRepository implements IPricesRepository {
  constructor(
    @Inject(LoggingService) private readonly loggingService: ILoggingService,
    @Inject(IPricesApi) private readonly pricesApi: IPricesApi,
  ) {}

  async getNativeCoinPrice(args: {
    nativeCoinId: string;
    fiatCode: string;
  }): Promise<number> {
    const result = await this.pricesApi.getNativeCoinPrice(args);
    const { nativeCoinId, fiatCode } = args;
    const nativeCoinPrice = result?.[nativeCoinId]?.[fiatCode];

    if (!nativeCoinPrice) {
      this.loggingService.error(`Error getting ${nativeCoinId} price`);
    }

    return nativeCoinPrice ?? 0;
  }

  async getTokenPrice(args: {
    nativeCoinId: string;
    tokenAddress: string;
    fiatCode: string;
  }): Promise<number> {
    const result = await this.pricesApi.getTokenPrice(args);
    const { tokenAddress, fiatCode } = args;
    const tokenPrice = result?.[tokenAddress.toLowerCase()]?.[fiatCode];

    if (!tokenPrice) {
      this.loggingService.warn(`Error getting ${tokenAddress} price`);
    }

    return tokenPrice ?? 0;
  }
}

1	import { Inject, Injectable } from '@nestjs/common';	30✔
2	import {	30✔
3	ILoggingService,
4	LoggingService,
5	} from '../../logging/logging.interface';
6	import { IPricesApi } from '../interfaces/prices-api.interface';	30✔
7	import { IPricesRepository } from './prices.repository.interface';
8
9	@Injectable()
10	export class PricesRepository implements IPricesRepository {	30✔
11	constructor(
12	@Inject(LoggingService) private readonly loggingService: ILoggingService,	198✔
13	@Inject(IPricesApi) private readonly pricesApi: IPricesApi,	198✔
14	) {}
15
16	async getNativeCoinPrice(args: {
17	nativeCoinId: string;
18	fiatCode: string;
19	}): Promise<number> {
NEW 20	const result = await this.pricesApi.getNativeCoinPrice(args);	×
NEW 21	const { nativeCoinId, fiatCode } = args;	×
NEW 22	const nativeCoinPrice = result?.[nativeCoinId]?.[fiatCode];	×
23
NEW 24	if (!nativeCoinPrice) {	×
NEW 25	this.loggingService.error(`Error getting ${nativeCoinId} price`);	×
26	}
27
NEW 28	return nativeCoinPrice ?? 0;	×
29	}
30
31	async getTokenPrice(args: {
32	nativeCoinId: string;
33	tokenAddress: string;
34	fiatCode: string;
35	}): Promise<number> {
NEW 36	const result = await this.pricesApi.getTokenPrice(args);	×
NEW 37	const { tokenAddress, fiatCode } = args;	×
NEW 38	const tokenPrice = result?.[tokenAddress.toLowerCase()]?.[fiatCode];	×
39
NEW 40	if (!tokenPrice) {	×
NEW 41	this.loggingService.warn(`Error getting ${tokenAddress} price`);	×
42	}
43
NEW 44	return tokenPrice ?? 0;	×
45	}
46	}

safe-global / safe-client-gateway-nest / 5893084251

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous