#9824

pending completion

Build # #9824

Build Type

push

travis_ci

Committed by

web-flow

Commit Message

Pipe: Remove parameters from iotdb-common.properties that users will not modify (#10851) (#10852)

(cherry picked from commit 11af323b7)

Run Details

14 of 14 new or added lines in 5 files covered. (100.0%)

79712 of 165790 relevant lines covered (48.08%)

0.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

52.0

/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/JMXService.java

/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */
package org.apache.iotdb.commons.service;

import org.apache.iotdb.commons.conf.IoTDBConstant;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.management.InstanceAlreadyExistsException;
import javax.management.InstanceNotFoundException;
import javax.management.MBeanRegistrationException;
import javax.management.MBeanServer;
import javax.management.MalformedObjectNameException;
import javax.management.NotCompliantMBeanException;
import javax.management.ObjectName;

import java.lang.management.ManagementFactory;

public class JMXService implements IService {

  private static final Logger logger = LoggerFactory.getLogger(JMXService.class);

  public JMXService() {
    // Empty constructor
  }

  /** function for registering MBean. */
  public static void registerMBean(Object mbean, String name) {
    try {
      MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
      ObjectName objectName = new ObjectName(name);
      if (!mbs.isRegistered(objectName)) {
        mbs.registerMBean(mbean, objectName);
      }
    } catch (MalformedObjectNameException
        | InstanceAlreadyExistsException
        | MBeanRegistrationException
        | NotCompliantMBeanException e) {
      logger.error("Failed to registerMBean {}", name, e);
    }
  }

  /** function for deregistering MBean. */
  public static void deregisterMBean(String name) {
    try {
      MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
      ObjectName objectName = new ObjectName(name);
      if (mbs.isRegistered(objectName)) {
        mbs.unregisterMBean(objectName);
      }
    } catch (MalformedObjectNameException
        | MBeanRegistrationException
        | InstanceNotFoundException e) {
      logger.error("Failed to unregisterMBean {}", name, e);
    }
  }

  @Override
  public ServiceType getID() {
    return ServiceType.JMX_SERVICE;
  }

  @Override
  public void start() {
    String jmxPort = System.getProperty(IoTDBConstant.IOTDB_JMX_PORT);
    if (jmxPort == null) {
      logger.debug("{} JMX port is undefined", this.getID().getName());
    }
  }

  @Override
  public void stop() {
    // do nothing.
  }
}

1	/*
2	* Licensed to the Apache Software Foundation (ASF) under one
3	* or more contributor license agreements. See the NOTICE file
4	* distributed with this work for additional information
5	* regarding copyright ownership. The ASF licenses this file
6	* to you under the Apache License, Version 2.0 (the
7	* "License"); you may not use this file except in compliance
8	* with the License. You may obtain a copy of the License at
9	*
10	* http://www.apache.org/licenses/LICENSE-2.0
11	*
12	* Unless required by applicable law or agreed to in writing,
13	* software distributed under the License is distributed on an
14	* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15	* KIND, either express or implied. See the License for the
16	* specific language governing permissions and limitations
17	* under the License.
18	*/
19	package org.apache.iotdb.commons.service;
20
21	import org.apache.iotdb.commons.conf.IoTDBConstant;
22
23	import org.slf4j.Logger;
24	import org.slf4j.LoggerFactory;
25
26	import javax.management.InstanceAlreadyExistsException;
27	import javax.management.InstanceNotFoundException;
28	import javax.management.MBeanRegistrationException;
29	import javax.management.MBeanServer;
30	import javax.management.MalformedObjectNameException;
31	import javax.management.NotCompliantMBeanException;
32	import javax.management.ObjectName;
33
34	import java.lang.management.ManagementFactory;
35
36	public class JMXService implements IService {
37
38	private static final Logger logger = LoggerFactory.getLogger(JMXService.class);	1✔
39
40	public JMXService() {	×
41	// Empty constructor
42	}	×
43
44	/** function for registering MBean. */
45	public static void registerMBean(Object mbean, String name) {
46	try {
47	MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();	1✔
48	ObjectName objectName = new ObjectName(name);	1✔
49	if (!mbs.isRegistered(objectName)) {	1✔
50	mbs.registerMBean(mbean, objectName);	1✔
51	}
52	} catch (MalformedObjectNameException	×
53	\| InstanceAlreadyExistsException
54	\| MBeanRegistrationException
55	\| NotCompliantMBeanException e) {
56	logger.error("Failed to registerMBean {}", name, e);	×
57	}	1✔
58	}	1✔
59
60	/** function for deregistering MBean. */
61	public static void deregisterMBean(String name) {
62	try {
63	MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();	1✔
64	ObjectName objectName = new ObjectName(name);	1✔
65	if (mbs.isRegistered(objectName)) {	1✔
66	mbs.unregisterMBean(objectName);	1✔
67	}
68	} catch (MalformedObjectNameException	×
69	\| MBeanRegistrationException
70	\| InstanceNotFoundException e) {
71	logger.error("Failed to unregisterMBean {}", name, e);	×
72	}	1✔
73	}	1✔
74
75	@Override
76	public ServiceType getID() {
77	return ServiceType.JMX_SERVICE;	×
78	}
79
80	@Override
81	public void start() {
82	String jmxPort = System.getProperty(IoTDBConstant.IOTDB_JMX_PORT);	×
83	if (jmxPort == null) {	×
84	logger.debug("{} JMX port is undefined", this.getID().getName());	×
85	}
86	}	×
87
88	@Override
89	public void stop() {
90	// do nothing.
91	}	×
92	}

apache / iotdb / #9824

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous