5806187201

pending completion

Build # 5806187201

Build Type

push

github

Committed by

web-flow

Commit Message

fix(arc): Fix shape rendering when data id equivalent of color string

For interpolation, make sure to be applied only necessary values.
Issue happened because colorish string were interpolated, which transformed
id values as interpolated color string.

Fix #3321

Run Details

5706 of 6614 branches covered (86.27%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

7514 of 7936 relevant lines covered (94.68%)

20481.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.0

/src/Plugin/Plugin.ts

/**
 * Copyright (c) 2017 ~ present NAVER Corp.
 * billboard.js project is licensed under the MIT license
 */
/**
 * Base class to generate billboard.js plugin
 * @class Plugin
 */
/**
 * Version info string for plugin
 * @name version
 * @static
 * @memberof Plugin
 * @type {string}
 * @example
 *   bb.plugin.stanford.version;  // ex) 1.9.0
 */
export default class Plugin {
        public $$;
        public options;
        static version = "__VERSION__";

        /**
         * Constructor
         * @param {Any} options config option object
         * @private
         */
        constructor(options = {}) {
                this.options = options;
        }

        /**
         * Lifecycle hook for 'beforeInit' phase.
         * @private
         */
        $beforeInit() {}

        /**
         * Lifecycle hook for 'init' phase.
         * @private
         */
        $init() {}

        /**
         * Lifecycle hook for 'afterInit' phase.
         * @private
         */
        $afterInit() {}

        /**
         * Lifecycle hook for 'redraw' phase.
         * @private
         */
        $redraw() {}

        /**
         * Lifecycle hook for 'willDestroy' phase.
         * @private
         */
        $willDestroy() {
                Object.keys(this).forEach(key => {
                        this[key] = null;
                        delete this[key];
                });
        }
}

1	/**
2	* Copyright (c) 2017 ~ present NAVER Corp.
3	* billboard.js project is licensed under the MIT license
4	*/
5	/**
6	* Base class to generate billboard.js plugin
7	* @class Plugin
8	*/
9	/**
10	* Version info string for plugin
11	* @name version
12	* @static
13	* @memberof Plugin
14	* @type {string}
15	* @example
16	* bb.plugin.stanford.version; // ex) 1.9.0
17	*/
18	export default class Plugin {	3✔
19	public $$;	30✔
20	public options;
21	static version = "__VERSION__";
22
23	/**
24	* Constructor
25	* @param {Any} options config option object
26	* @private
27	*/
28	constructor(options = {}) {	30✔
29	this.options = options;	30✔
30	}
31
32	/**	3✔
33	* Lifecycle hook for 'beforeInit' phase.
34	* @private
35	*/
36	$beforeInit() {}
37
38	/**	3✔
39	* Lifecycle hook for 'init' phase.
40	* @private
41	*/
42	$init() {}
43
44	/**	3✔
45	* Lifecycle hook for 'afterInit' phase.
46	* @private
47	*/
48	$afterInit() {}
49
50	/**	3✔
51	* Lifecycle hook for 'redraw' phase.
52	* @private
53	*/
54	$redraw() {}
55
56	/**	3✔
57	* Lifecycle hook for 'willDestroy' phase.
58	* @private
59	*/
UNCOV 60	$willDestroy() {	×
UNCOV 61	Object.keys(this).forEach(key => {	×
UNCOV 62	this[key] = null;	×
UNCOV 63	delete this[key];	×
64	});
65	}	3✔
66	}

naver / billboard.js / 5806187201

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous