5631056675

pending completion

Build # 5631056675

Build Type

push

github

Committed by

vmarseguerra

Commit Message

refactor(right): replaces rights with a static groups system

Run Details

751 of 1944 branches covered (38.63%)

Branch coverage included in aggregate %.

59 of 59 new or added lines in 35 files covered. (100.0%)

2702 of 5007 relevant lines covered (53.96%)

14.64 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

18.75

/api/controllers/v1/document/validate.js

const ControllerService = require('../../../services/ControllerService');
const DocumentService = require('../../../services/DocumentService');
const NotificationService = require('../../../services/NotificationService');
const RightService = require('../../../services/RightService');
const {
  NOTIFICATION_TYPES,
  NOTIFICATION_ENTITIES,
} = require('../../../services/NotificationService');

// eslint-disable-next-line consistent-return
module.exports = (req, res) => {
  const hasRight = RightService.hasGroup(
    req.token.groups,
    RightService.G.MODERATOR
  );
  if (!hasRight) {
    return res.forbidden('You are not authorized to validate a document.');
  }

  const isValidated = req.param('isValidated')
    ? !(req.param('isValidated').toLowerCase() === 'false')
    : true;
  const validationComment = req.param('validationComment', null);
  const id = req.param('id');

  if (isValidated === false && !validationComment) {
    return res.badRequest(
      `If the document with id ${req.param(
        'id'
      )} is refused, a comment must be provided.`
    );
  }

  TDocument.updateOne({ id })
    .set({
      dateValidation: new Date(),
      isValidated,
      validationComment,
      validator: req.token.id,
    })
    .then(async (updatedDocument) => {
      if (isValidated) {
        const populatedDoc = await TDocument.findOne(updatedDocument.id)
          .populate('author')
          .populate('authors')
          .populate('cave')
          .populate('descriptions')
          .populate('authorizationDocument')
          .populate('editor')
          .populate('entrance')
          .populate('identifierType')
          .populate('languages')
          .populate('library')
          .populate('license')
          .populate('massif')
          .populate('parent')
          .populate('regions')
          .populate('reviewer')
          .populate('subjects')
          .populate('type');
        await DocumentService.setNamesOfPopulatedDocument(populatedDoc);
        await DocumentService.addDocumentToElasticSearchIndexes(
          updatedDocument
        );
        await NotificationService.notifySubscribers(
          req,
          updatedDocument,
          req.token.id,
          NOTIFICATION_TYPES.VALIDATE,
          NOTIFICATION_ENTITIES.DOCUMENT
        );
      }

      const params = {
        controllerMethod: 'DocumentController.validate',
        notFoundMessage: `Document of id ${id} not found`,
        searchedItem: `Document of id ${id}`,
      };
      return ControllerService.treat(req, null, updatedDocument, params, res);
    });
};

1	const ControllerService = require('../../../services/ControllerService');	1✔
2	const DocumentService = require('../../../services/DocumentService');	1✔
3	const NotificationService = require('../../../services/NotificationService');	1✔
4	const RightService = require('../../../services/RightService');	1✔
5	const {
6	NOTIFICATION_TYPES,
7	NOTIFICATION_ENTITIES,
8	} = require('../../../services/NotificationService');	1✔
9
10	// eslint-disable-next-line consistent-return
11	module.exports = (req, res) => {	1✔
12	const hasRight = RightService.hasGroup(	×
13	req.token.groups,
14	RightService.G.MODERATOR
15	);
16	if (!hasRight) {	×
17	return res.forbidden('You are not authorized to validate a document.');	×
18	}
19
20	const isValidated = req.param('isValidated')	×
21	? !(req.param('isValidated').toLowerCase() === 'false')
22	: true;
23	const validationComment = req.param('validationComment', null);	×
24	const id = req.param('id');	×
25
26	if (isValidated === false && !validationComment) {	×
27	return res.badRequest(	×
28	`If the document with id ${req.param(
29	'id'
30	)} is refused, a comment must be provided.`
31	);
32	}
33
34	TDocument.updateOne({ id })	×
35	.set({
36	dateValidation: new Date(),
37	isValidated,
38	validationComment,
39	validator: req.token.id,
40	})
41	.then(async (updatedDocument) => {
42	if (isValidated) {	×
43	const populatedDoc = await TDocument.findOne(updatedDocument.id)	×
44	.populate('author')
45	.populate('authors')
46	.populate('cave')
47	.populate('descriptions')
48	.populate('authorizationDocument')
49	.populate('editor')
50	.populate('entrance')
51	.populate('identifierType')
52	.populate('languages')
53	.populate('library')
54	.populate('license')
55	.populate('massif')
56	.populate('parent')
57	.populate('regions')
58	.populate('reviewer')
59	.populate('subjects')
60	.populate('type');
61	await DocumentService.setNamesOfPopulatedDocument(populatedDoc);	×
62	await DocumentService.addDocumentToElasticSearchIndexes(	×
63	updatedDocument
64	);
65	await NotificationService.notifySubscribers(	×
66	req,
67	updatedDocument,
68	req.token.id,
69	NOTIFICATION_TYPES.VALIDATE,
70	NOTIFICATION_ENTITIES.DOCUMENT
71	);
72	}
73
74	const params = {	×
75	controllerMethod: 'DocumentController.validate',
76	notFoundMessage: `Document of id ${id} not found`,
77	searchedItem: `Document of id ${id}`,
78	};
79	return ControllerService.treat(req, null, updatedDocument, params, res);	×
80	});
81	};

GrottoCenter / grottocenter-api / 5631056675

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous