5631056675

pending completion

Build # 5631056675

Build Type

push

github

Committed by

vmarseguerra

Commit Message

refactor(right): replaces rights with a static groups system

Run Details

751 of 1944 branches covered (38.63%)

Branch coverage included in aggregate %.

59 of 59 new or added lines in 35 files covered. (100.0%)

2702 of 5007 relevant lines covered (53.96%)

14.64 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

20.59

/api/controllers/v1/description/update.js

const ControllerService = require('../../../services/ControllerService');
const ErrorService = require('../../../services/ErrorService');
const NotificationService = require('../../../services/NotificationService');
const DescriptionService = require('../../../services/DescriptionService');
const {
  NOTIFICATION_TYPES,
  NOTIFICATION_ENTITIES,
} = require('../../../services/NotificationService');
const { toSimpleDescription } = require('../../../services/mapping/converters');

module.exports = async (req, res) => {
  try {
    const descriptionId = req.param('id');
    const rawDescription = await TDescription.findOne(descriptionId);
    // TODO How to delete/restore entity ?
    if (!rawDescription || rawDescription.isDeleted) {
      return res.notFound({
        message: `Description of id ${descriptionId} not found.`,
      });
    }

    const newTitle = req.param('title');
    const newBody = req.param('body');
    const newLanguage = req.param('language');

    const updatedFields = {
      reviewer: req.token.id,
      // dateReviewed will be updated automaticly by the SQL historisation trigger
    };

    if (newTitle) updatedFields.title = newTitle;
    if (newBody) updatedFields.body = newBody;
    if (newLanguage) updatedFields.language = newLanguage;
    // TODO re-compute relevance ?

    await TDescription.updateOne({ id: descriptionId }).set(updatedFields);

    const populatedDescription = await DescriptionService.getDescription(
      descriptionId
    );
    await NotificationService.notifySubscribers(
      req,
      populatedDescription,
      req.token.id,
      NOTIFICATION_TYPES.UPDATE,
      NOTIFICATION_ENTITIES.DESCRIPTION
    );

    return ControllerService.treatAndConvert(
      req,
      null,
      populatedDescription,
      { controllerMethod: 'DescriptionController.update' },
      res,
      toSimpleDescription
    );
  } catch (e) {
    return ErrorService.getDefaultErrorHandler(res)(e);
  }
};

1	const ControllerService = require('../../../services/ControllerService');	1✔
2	const ErrorService = require('../../../services/ErrorService');	1✔
3	const NotificationService = require('../../../services/NotificationService');	1✔
4	const DescriptionService = require('../../../services/DescriptionService');	1✔
5	const {
6	NOTIFICATION_TYPES,
7	NOTIFICATION_ENTITIES,
8	} = require('../../../services/NotificationService');	1✔
9	const { toSimpleDescription } = require('../../../services/mapping/converters');	1✔
10
11	module.exports = async (req, res) => {	1✔
12	try {	×
13	const descriptionId = req.param('id');	×
14	const rawDescription = await TDescription.findOne(descriptionId);	×
15	// TODO How to delete/restore entity ?
16	if (!rawDescription \|\| rawDescription.isDeleted) {	×
17	return res.notFound({	×
18	message: `Description of id ${descriptionId} not found.`,
19	});
20	}
21
22	const newTitle = req.param('title');	×
23	const newBody = req.param('body');	×
24	const newLanguage = req.param('language');	×
25
26	const updatedFields = {	×
27	reviewer: req.token.id,
28	// dateReviewed will be updated automaticly by the SQL historisation trigger
29	};
30
31	if (newTitle) updatedFields.title = newTitle;	×
32	if (newBody) updatedFields.body = newBody;	×
33	if (newLanguage) updatedFields.language = newLanguage;	×
34	// TODO re-compute relevance ?
35
36	await TDescription.updateOne({ id: descriptionId }).set(updatedFields);	×
37
38	const populatedDescription = await DescriptionService.getDescription(	×
39	descriptionId
40	);
41	await NotificationService.notifySubscribers(	×
42	req,
43	populatedDescription,
44	req.token.id,
45	NOTIFICATION_TYPES.UPDATE,
46	NOTIFICATION_ENTITIES.DESCRIPTION
47	);
48
49	return ControllerService.treatAndConvert(	×
50	req,
51	null,
52	populatedDescription,
53	{ controllerMethod: 'DescriptionController.update' },
54	res,
55	toSimpleDescription
56	);
57	} catch (e) {
58	return ErrorService.getDefaultErrorHandler(res)(e);	×
59	}
60	};

GrottoCenter / grottocenter-api / 5631056675

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous