box / box-ios-sdk / 5309116140

push

github

chore: Make the contract of AuthModuleDispatcher clearer. (#899)

* fix: Always complete auth actions.

Removing ThreadSafeQueue, as it is only used in this one case, it has
more features than necessary, is not in fact thread safe as written, and
it introduces unnecessary thread hops.

Changing AuthModuleDispatcher, so that it is guaranteed to be retained
until all queued actions are complete (as long as they correctly call
the completion block).

Fixing OAuth2Session to ensure that it calls the auth action completion
block, even in the case it is deallocated. This is unlikely to happen
in practice, but this is unclear from local reasoning.

* Fix linter error

21 of 21 new or added lines in 2 files covered. (100.0%)

6733 of 7602 relevant lines covered (88.57%)

92.79 hits per line