5265281243

Committed 14 Jun 2023 09:14AM UTC coverage: 99.706% (-0.002%) from 99.708%

Build # 5265281243

Build Type

push

github

Committed by

web-flow

Commit Message

Port skew based child diffing (#4010)

* first attempt at porting skew-based

* down to only failing fragment test

* reduce complexity of placeChild

* 2 failing tests left

* port skew based diff

* add tests for other fixed issues

* simplify children diffing

* experiment

* remove more nextDom st uff

* one more try

* remove unused import

* simplify suspension check, i.e. whether dom is connected by replacing it with _original === null

* simplify if check

* remove lastDom helper

* simplify more checks

* always use insertBefore

* experiment

* add hyrating check back

* simplify matcher

* try removing isHydrating

* Revert "try removing isHydrating"

This reverts commit 787ad174d.

* remove isHydrating

* add the !isMounting back

Run Details

1149 of 1184 branches covered (97.04%)

24 of 24 new or added lines in 1 file covered. (100.0%)

679 of 681 relevant lines covered (99.71%)

850.68 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/compat/src/portals.js

import { createElement, render } from 'preact';

/**
 * @param {import('../../src/index').RenderableProps<{ context: any }>} props
 */
function ContextProvider(props) {
        this.getChildContext = () => props.context;
        return props.children;
}

/**
 * Portal component
 * @this {import('./internal').Component}
 * @param {object | null | undefined} props
 *
 * TODO: use createRoot() instead of fake root
 */
function Portal(props) {
        const _this = this;
        let container = props._container;

        _this.componentWillUnmount = function () {
                render(null, _this._temp);
                _this._temp = null;
                _this._container = null;
        };

        // When we change container we should clear our old container and
        // indicate a new mount.
        if (_this._container && _this._container !== container) {
                _this.componentWillUnmount();
        }

        // When props.vnode is undefined/false/null we are dealing with some kind of
        // conditional vnode. This should not trigger a render.
        if (props._vnode) {
                if (!_this._temp) {
                        _this._container = container;

                        // Create a fake DOM parent node that manages a subset of `container`'s children:
                        _this._temp = {
                                nodeType: 1,
                                parentNode: container,
                                childNodes: [],
                                appendChild(child) {
                                        this.childNodes.push(child);
                                        _this._container.appendChild(child);
                                },
                                insertBefore(child, before) {
                                        this.childNodes.push(child);
                                        _this._container.appendChild(child);
                                },
                                removeChild(child) {
                                        this.childNodes.splice(this.childNodes.indexOf(child) >>> 1, 1);
                                        _this._container.removeChild(child);
                                }
                        };
                }

                // Render our wrapping element into temp.
                render(
                        createElement(ContextProvider, { context: _this.context }, props._vnode),
                        _this._temp
                );
        }
        // When we come from a conditional render, on a mounted
        // portal we should clear the DOM.
        else if (_this._temp) {
                _this.componentWillUnmount();
        }
}

/**
 * Create a `Portal` to continue rendering the vnode tree at a different DOM node
 * @param {import('./internal').VNode} vnode The vnode to render
 * @param {import('./internal').PreactElement} container The DOM node to continue rendering in to.
 */
export function createPortal(vnode, container) {
        const el = createElement(Portal, { _vnode: vnode, _container: container });
        el.containerInfo = container;
        return el;
}

1	import { createElement, render } from 'preact';
2
3	/**
4	* @param {import('../../src/index').RenderableProps<{ context: any }>} props
5	*/
6	function ContextProvider(props) {
7	this.getChildContext = () => props.context;	44✔
8	return props.children;	44✔
9	}
10
11	/**
12	* Portal component
13	* @this {import('./internal').Component}
14	* @param {object \| null \| undefined} props
15	*
16	* TODO: use createRoot() instead of fake root
17	*/
18	function Portal(props) {
19	const _this = this;	52✔
20	let container = props._container;	52✔
21
22	_this.componentWillUnmount = function () {	52✔
23	render(null, _this._temp);	16✔
24	_this._temp = null;
25	_this._container = null;
26	};
27
28	// When we change container we should clear our old container and
29	// indicate a new mount.
30	if (_this._container && _this._container !== container) {	70✔
31	_this.componentWillUnmount();
32	}
33
34	// When props.vnode is undefined/false/null we are dealing with some kind of
35	// conditional vnode. This should not trigger a render.
36	if (props._vnode) {	52✔
37	if (!_this._temp) {	76✔
38	_this._container = container;
39
40	// Create a fake DOM parent node that manages a subset of `container`'s children:
41	_this._temp = {
42	nodeType: 1,
43	parentNode: container,
44	childNodes: [],
45	appendChild(child) {
46	this.childNodes.push(child);	×
47	_this._container.appendChild(child);
48	},
49	insertBefore(child, before) {
50	this.childNodes.push(child);	33✔
51	_this._container.appendChild(child);
52	},
53	removeChild(child) {
54	this.childNodes.splice(this.childNodes.indexOf(child) >>> 1, 1);	×
55	_this._container.removeChild(child);
56	}
57	};
58	}
59
60	// Render our wrapping element into temp.
61	render(
62	createElement(ContextProvider, { context: _this.context }, props._vnode),
63	_this._temp
64	);
65	}
66	// When we come from a conditional render, on a mounted
67	// portal we should clear the DOM.
68	else if (_this._temp) {	10✔
69	_this.componentWillUnmount();
70	}
71	}
72
73	/**
74	* Create a `Portal` to continue rendering the vnode tree at a different DOM node
75	* @param {import('./internal').VNode} vnode The vnode to render
76	* @param {import('./internal').PreactElement} container The DOM node to continue rendering in to.
77	*/
78	export function createPortal(vnode, container) {
79	const el = createElement(Portal, { _vnode: vnode, _container: container });	52✔
80	el.containerInfo = container;
81	return el;	52✔
82	}

preactjs / preact / 5265281243

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous