#4565

pending completion

Build # #4565

Build Type

push

coveralls-python

Committed by

web-flow

Commit Message

[no_severity] Re-add the constraint on very old bugs (#2102)

* Reverts commit f80bb6ba5

* Loosen the time limit cut more exponentially

Run Details

641 of 3223 branches covered (19.89%)

5 of 5 new or added lines in 1 file covered. (100.0%)

1823 of 8011 relevant lines covered (22.76%)

0.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/bugbot/rules/workflow/no_severity.py

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.

from datetime import datetime

import numpy
from libmozdata import utils as lmdutils

from bugbot import utils
from bugbot.bzcleaner import BzCleaner
from bugbot.escalation import Escalation
from bugbot.nag_me import Nag
from bugbot.round_robin import RoundRobin


class NoSeverity(BzCleaner, Nag):
    def __init__(self, typ, inactivity_days: int = 4):
        """Constructor

        Args:
            typ: the mode that the rule should run with (first or second). Nag
                emails will be sent only if `typ` is second.
            inactivity_days: number of days that a bug should be inactive before
                being considered.
        """
        super(NoSeverity, self).__init__()
        assert typ in {"first", "second"}
        self.typ = typ
        self.lookup_first = utils.get_config(self.name(), "first-step", 2)
        self.lookup_second = utils.get_config(self.name(), "second-step", 4)
        self.escalation = Escalation(
            self.people,
            data=utils.get_config(self.name(), "escalation-{}".format(typ)),
            skiplist=utils.get_config("workflow", "supervisor_skiplist", []),
        )
        self.round_robin = RoundRobin.get_instance()
        self.components_skiplist = utils.get_config("workflow", "components_skiplist")
        self.activity_date = str(
            numpy.busday_offset(lmdutils.get_date("today"), -inactivity_days)
        )

    def description(self):
        return "Bugs without a severity or statuses set"

    def nag_template(self):
        return self.template()

    def nag_preamble(self):
        return """<p>
  <ul>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#why-triage">Why triage?</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#what-do-you-triage">What do you triage?</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html">Priority definitions</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html">Severity definitions</a></li>
  </ul>
</p>"""

    def get_extra_for_template(self):
        return {
            "nweeks": self.lookup_first if self.typ == "first" else self.lookup_second
        }

    def get_extra_for_needinfo_template(self):
        return self.get_extra_for_template()

    def get_extra_for_nag_template(self):
        return self.get_extra_for_template()

    def has_product_component(self):
        return True

    def ignore_meta(self):
        return True

    def columns(self):
        return ["component", "id", "summary"]

    def handle_bug(self, bug, data):
        if (
            # check if the product::component is in the list
            utils.check_product_component(self.components_skiplist, bug)
            or utils.get_last_no_bot_comment_date(bug) > self.activity_date
        ):
            return None
        return bug

    def get_mail_to_auto_ni(self, bug):
        if self.typ == "second":
            return None

        mail, nick = self.round_robin.get(bug, self.date)
        if mail and nick:
            return {"mail": mail, "nickname": nick}

        return None

    def set_people_to_nag(self, bug, buginfo):
        priority = "default"
        if not self.filter_bug(priority):
            return None

        # don't nag in the first step (just a ni is enough)
        if self.typ == "first":
            return bug

        owners = self.round_robin.get(bug, self.date, only_one=False, has_nick=False)
        real_owner = bug["triage_owner"]
        self.add_triage_owner(owners, real_owner=real_owner)
        if not self.add(owners, buginfo, priority=priority):
            self.add_no_manager(buginfo["id"])
        return bug

    def get_bz_params(self, date):
        fields = [
            "triage_owner",
            "flags",
            "comments.creator",
            "comments.creation_time",
        ]
        params = {
            "include_fields": fields,
            "keywords": "intermittent-failure",
            "keywords_type": "nowords",
            "email2": "wptsync@mozilla.bugs",
            "emailreporter2": "1",
            "emailtype2": "notequals",
            "resolution": "---",
            "f31": "bug_type",
            "o31": "equals",
            "v31": "defect",
            "f32": "flagtypes.name",
            "o32": "notsubstring",
            "v32": "needinfo?",
            "f33": "bug_severity",
            "o33": "anyexact",
            "v33": "--, n/a",
            # This is temporary, it should be removed, see: https://github.com/mozilla/bugbot/issues/1889
            "n34": "1",
            "f34": "longdesc",
            "o34": "substring",
            "v34": "Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).",
        }
        self.date = lmdutils.get_date_ymd(date)
        first = f"-{self.lookup_first * 7}d"
        second = f"-{self.lookup_second * 7}d"
        if self.typ == "first":
            # TODO: change this when https://bugzilla.mozilla.org/1543984 will be fixed
            # Here we have to get bugs where product/component have been set (bug has been triaged)
            # between 4 and 2 weeks
            # If the product/component never changed after bug creation, we need to get them too
            # (second < p < first && c < first) ||
            # (second < c < first && p < first) ||
            # ((second < creation < first) && pc never changed)
            params.update(
                {
                    "f2": "flagtypes.name",
                    "o2": "notequals",
                    "v2": "needinfo?",
                    "j3": "OR",
                    "f3": "OP",
                    "j4": "AND",
                    "f4": "OP",
                    "n5": 1,  # we use a negation here to be sure that no change after first
                    "f5": "product",
                    "o5": "changedafter",
                    "v5": first,
                    "f6": "product",  # here the bug has changed
                    "o6": "changedafter",
                    "v6": second,
                    "n7": 1,
                    "f7": "component",
                    "o7": "changedafter",
                    "v7": first,
                    "f8": "CP",
                    "j9": "AND",
                    "f9": "OP",
                    "n10": 1,
                    "f10": "component",
                    "o10": "changedafter",
                    "v10": first,
                    "f11": "component",
                    "o11": "changedafter",
                    "v11": second,
                    "n12": 1,
                    "f12": "product",
                    "o12": "changedafter",
                    "v12": first,
                    "f13": "CP",
                    "j14": "AND",
                    "f14": "OP",
                    "f15": "creation_ts",
                    "o15": "lessthaneq",
                    "v15": first,
                    "f16": "creation_ts",
                    "o16": "greaterthan",
                    "v16": second,
                    "n17": 1,
                    "f17": "product",
                    "o17": "everchanged",
                    "n18": 1,
                    "f18": "component",
                    "o18": "everchanged",
                    "f19": "CP",
                    "j20": "OR",
                    "f20": "OP",
                    "f21": "bug_severity",
                    "o21": "changedfrom",
                    "v21": "critical",
                    "f22": "bug_severity",
                    "o22": "changedfrom",
                    "v22": "major",
                    "f23": "bug_severity",
                    "o23": "changedfrom",
                    "v23": "blocker",
                    "f24": "CP",
                    "f30": "CP",
                }
            )
        else:
            params.update(
                {
                    "j2": "OR",
                    "f2": "OP",
                    "j3": "AND",
                    "f3": "OP",
                    "f4": "product",
                    "o4": "changedbefore",
                    "v4": second,
                    "n5": 1,
                    "f5": "product",
                    "o5": "changedafter",
                    "v5": second,
                    "n6": 1,
                    "f6": "component",
                    "o6": "changedafter",
                    "v6": second,
                    "f7": "CP",
                    "j8": "AND",
                    "f8": "OP",
                    "f9": "component",
                    "o9": "changedbefore",
                    "v9": second,
                    "n10": 1,
                    "f10": "product",
                    "o10": "changedafter",
                    "v10": second,
                    "n11": 1,
                    "f11": "component",
                    "o11": "changedafter",
                    "v11": second,
                    "f12": "CP",
                    "j13": "AND",
                    "f13": "OP",
                    "f14": "creation_ts",
                    "o14": "lessthaneq",
                    "v14": second,
                    "n15": 1,
                    "f15": "product",
                    "o15": "everchanged",
                    "n16": 1,
                    "f16": "component",
                    "o16": "everchanged",
                    "f17": "CP",
                    "f18": "CP",
                    "n20": 1,
                    "j20": "OR",
                    "f20": "OP",
                    "f21": "bug_severity",
                    "o21": "changedfrom",
                    "v21": "critical",
                    "f22": "bug_severity",
                    "o22": "changedfrom",
                    "v22": "major",
                    "f23": "bug_severity",
                    "o23": "changedfrom",
                    "v23": "blocker",
                    "f30": "CP",
                }
            )

        # TODO: the following code can be removed in 2024.
        # https://github.com/mozilla/bugbot/issues/1596
        # Almost 500 old bugs have no severity set. The intent of the following
        # is to have them triaged in batches where every week we include more
        # bugs. Once the list of old bugs are reduced, we could safely remove
        # the following code.
        passed_time = datetime.now() - datetime.fromisoformat("2023-06-09")
        oldest_bug_months = 56 + passed_time.days
        n = utils.get_last_field_num(params)
        params.update(
            {
                f"f{n}": "creation_ts",
                f"o{n}": "greaterthan",
                f"v{n}": f"-{oldest_bug_months}m",
            }
        )

        return params


if __name__ == "__main__":
    NoSeverity("first").run()
    NoSeverity("second").run()

1	# This Source Code Form is subject to the terms of the Mozilla Public
2	# License, v. 2.0. If a copy of the MPL was not distributed with this file,
3	# You can obtain one at http://mozilla.org/MPL/2.0/.
4
5	from datetime import datetime	×
6
7	import numpy	×
8	from libmozdata import utils as lmdutils	×
9
10	from bugbot import utils	×
11	from bugbot.bzcleaner import BzCleaner	×
12	from bugbot.escalation import Escalation	×
13	from bugbot.nag_me import Nag	×
14	from bugbot.round_robin import RoundRobin	×
15
16
17	class NoSeverity(BzCleaner, Nag):	×
18	def __init__(self, typ, inactivity_days: int = 4):	×
19	"""Constructor
20
21	Args:
22	typ: the mode that the rule should run with (first or second). Nag
23	emails will be sent only if `typ` is second.
24	inactivity_days: number of days that a bug should be inactive before
25	being considered.
26	"""
27	super(NoSeverity, self).__init__()	×
28	assert typ in {"first", "second"}	×
29	self.typ = typ	×
30	self.lookup_first = utils.get_config(self.name(), "first-step", 2)	×
31	self.lookup_second = utils.get_config(self.name(), "second-step", 4)	×
32	self.escalation = Escalation(	×
33	self.people,
34	data=utils.get_config(self.name(), "escalation-{}".format(typ)),
35	skiplist=utils.get_config("workflow", "supervisor_skiplist", []),
36	)
37	self.round_robin = RoundRobin.get_instance()	×
38	self.components_skiplist = utils.get_config("workflow", "components_skiplist")	×
39	self.activity_date = str(	×
40	numpy.busday_offset(lmdutils.get_date("today"), -inactivity_days)
41	)
42
43	def description(self):	×
44	return "Bugs without a severity or statuses set"	×
45
46	def nag_template(self):	×
47	return self.template()	×
48
49	def nag_preamble(self):	×
50	return """<p>	×
51	<ul>
52	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#why-triage">Why triage?</a></li>
53	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#what-do-you-triage">What do you triage?</a></li>
54	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html">Priority definitions</a></li>
55	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html">Severity definitions</a></li>
56	</ul>
57	</p>"""
58
59	def get_extra_for_template(self):	×
60	return {	×
61	"nweeks": self.lookup_first if self.typ == "first" else self.lookup_second
62	}
63
64	def get_extra_for_needinfo_template(self):	×
65	return self.get_extra_for_template()	×
66
67	def get_extra_for_nag_template(self):	×
68	return self.get_extra_for_template()	×
69
70	def has_product_component(self):	×
71	return True	×
72
73	def ignore_meta(self):	×
74	return True	×
75
76	def columns(self):	×
77	return ["component", "id", "summary"]	×
78
79	def handle_bug(self, bug, data):	×
80	if (	×
81	# check if the product::component is in the list
82	utils.check_product_component(self.components_skiplist, bug)
83	or utils.get_last_no_bot_comment_date(bug) > self.activity_date
84	):
85	return None	×
86	return bug	×
87
88	def get_mail_to_auto_ni(self, bug):	×
89	if self.typ == "second":	×
90	return None	×
91
92	mail, nick = self.round_robin.get(bug, self.date)	×
93	if mail and nick:	×
94	return {"mail": mail, "nickname": nick}	×
95
96	return None	×
97
98	def set_people_to_nag(self, bug, buginfo):	×
99	priority = "default"	×
100	if not self.filter_bug(priority):	×
101	return None	×
102
103	# don't nag in the first step (just a ni is enough)
104	if self.typ == "first":	×
105	return bug	×
106
107	owners = self.round_robin.get(bug, self.date, only_one=False, has_nick=False)	×
108	real_owner = bug["triage_owner"]	×
109	self.add_triage_owner(owners, real_owner=real_owner)	×
110	if not self.add(owners, buginfo, priority=priority):	×
111	self.add_no_manager(buginfo["id"])	×
112	return bug	×
113
114	def get_bz_params(self, date):	×
115	fields = [	×
116	"triage_owner",
117	"flags",
118	"comments.creator",
119	"comments.creation_time",
120	]
121	params = {	×
122	"include_fields": fields,
123	"keywords": "intermittent-failure",
124	"keywords_type": "nowords",
125	"email2": "wptsync@mozilla.bugs",
126	"emailreporter2": "1",
127	"emailtype2": "notequals",
128	"resolution": "---",
129	"f31": "bug_type",
130	"o31": "equals",
131	"v31": "defect",
132	"f32": "flagtypes.name",
133	"o32": "notsubstring",
134	"v32": "needinfo?",
135	"f33": "bug_severity",
136	"o33": "anyexact",
137	"v33": "--, n/a",
138	# This is temporary, it should be removed, see: https://github.com/mozilla/bugbot/issues/1889
139	"n34": "1",
140	"f34": "longdesc",
141	"o34": "substring",
142	"v34": "Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).",
143	}
144	self.date = lmdutils.get_date_ymd(date)	×
145	first = f"-{self.lookup_first * 7}d"	×
146	second = f"-{self.lookup_second * 7}d"	×
147	if self.typ == "first":	×
148	# TODO: change this when https://bugzilla.mozilla.org/1543984 will be fixed
149	# Here we have to get bugs where product/component have been set (bug has been triaged)
150	# between 4 and 2 weeks
151	# If the product/component never changed after bug creation, we need to get them too
152	# (second < p < first && c < first) \|\|
153	# (second < c < first && p < first) \|\|
154	# ((second < creation < first) && pc never changed)
155	params.update(	×
156	{
157	"f2": "flagtypes.name",
158	"o2": "notequals",
159	"v2": "needinfo?",
160	"j3": "OR",
161	"f3": "OP",
162	"j4": "AND",
163	"f4": "OP",
164	"n5": 1, # we use a negation here to be sure that no change after first
165	"f5": "product",
166	"o5": "changedafter",
167	"v5": first,
168	"f6": "product", # here the bug has changed
169	"o6": "changedafter",
170	"v6": second,
171	"n7": 1,
172	"f7": "component",
173	"o7": "changedafter",
174	"v7": first,
175	"f8": "CP",
176	"j9": "AND",
177	"f9": "OP",
178	"n10": 1,
179	"f10": "component",
180	"o10": "changedafter",
181	"v10": first,
182	"f11": "component",
183	"o11": "changedafter",
184	"v11": second,
185	"n12": 1,
186	"f12": "product",
187	"o12": "changedafter",
188	"v12": first,
189	"f13": "CP",
190	"j14": "AND",
191	"f14": "OP",
192	"f15": "creation_ts",
193	"o15": "lessthaneq",
194	"v15": first,
195	"f16": "creation_ts",
196	"o16": "greaterthan",
197	"v16": second,
198	"n17": 1,
199	"f17": "product",
200	"o17": "everchanged",
201	"n18": 1,
202	"f18": "component",
203	"o18": "everchanged",
204	"f19": "CP",
205	"j20": "OR",
206	"f20": "OP",
207	"f21": "bug_severity",
208	"o21": "changedfrom",
209	"v21": "critical",
210	"f22": "bug_severity",
211	"o22": "changedfrom",
212	"v22": "major",
213	"f23": "bug_severity",
214	"o23": "changedfrom",
215	"v23": "blocker",
216	"f24": "CP",
217	"f30": "CP",
218	}
219	)
220	else:
221	params.update(	×
222	{
223	"j2": "OR",
224	"f2": "OP",
225	"j3": "AND",
226	"f3": "OP",
227	"f4": "product",
228	"o4": "changedbefore",
229	"v4": second,
230	"n5": 1,
231	"f5": "product",
232	"o5": "changedafter",
233	"v5": second,
234	"n6": 1,
235	"f6": "component",
236	"o6": "changedafter",
237	"v6": second,
238	"f7": "CP",
239	"j8": "AND",
240	"f8": "OP",
241	"f9": "component",
242	"o9": "changedbefore",
243	"v9": second,
244	"n10": 1,
245	"f10": "product",
246	"o10": "changedafter",
247	"v10": second,
248	"n11": 1,
249	"f11": "component",
250	"o11": "changedafter",
251	"v11": second,
252	"f12": "CP",
253	"j13": "AND",
254	"f13": "OP",
255	"f14": "creation_ts",
256	"o14": "lessthaneq",
257	"v14": second,
258	"n15": 1,
259	"f15": "product",
260	"o15": "everchanged",
261	"n16": 1,
262	"f16": "component",
263	"o16": "everchanged",
264	"f17": "CP",
265	"f18": "CP",
266	"n20": 1,
267	"j20": "OR",
268	"f20": "OP",
269	"f21": "bug_severity",
270	"o21": "changedfrom",
271	"v21": "critical",
272	"f22": "bug_severity",
273	"o22": "changedfrom",
274	"v22": "major",
275	"f23": "bug_severity",
276	"o23": "changedfrom",
277	"v23": "blocker",
278	"f30": "CP",
279	}
280	)
281
282	# TODO: the following code can be removed in 2024.
283	# https://github.com/mozilla/bugbot/issues/1596
284	# Almost 500 old bugs have no severity set. The intent of the following
285	# is to have them triaged in batches where every week we include more
286	# bugs. Once the list of old bugs are reduced, we could safely remove
287	# the following code.
288	passed_time = datetime.now() - datetime.fromisoformat("2023-06-09")	×
289	oldest_bug_months = 56 + passed_time.days	×
290	n = utils.get_last_field_num(params)	×
291	params.update(	×
292	{
293	f"f{n}": "creation_ts",
294	f"o{n}": "greaterthan",
295	f"v{n}": f"-{oldest_bug_months}m",
296	}
297	)
298
299	return params	×
300
301
302	if __name__ == "__main__":	×
303	NoSeverity("first").run()	×
304	NoSeverity("second").run()	×

mozilla / relman-auto-nag / #4565

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous