#725

pending completion

Build # #725

Build Type

push

circle-ci

Committed by

web-flow

Commit Message

chore: reducing coverage loss (#619)

* adding delete operation

* Adding Insert Statement

* checkpoint

* supporting multiple entries

* implemented for structured data error

* adding parser visitor for delete

* delete executor

* delete plan and rules

* adding delete to plan executor

* change position of LogicalDelete

* logical delimeter

* delete test case

* adding test case

* adding test case

* adding delete testcase

* adding predicate to delete executor

* adding delete to Image storage

* bug fix in delete

* fixing testcase

* adding test case for insert statement

* remove order_by from statement_binder.py

* better variable names, using Batch

* error message for insert

* removing order_by and limit from delete

* remove order_by and limit

* use f-string

* adding to changelog

* removing commit messages

* formatting

* fixing comments

* formatting

* eva insert f32 values

* fix: should delete range

* delete multiple rows

* udf bootstrap

* try to run tests in parallel

* minor fix for ray to work

* ray fixes

---------

Co-authored-by: Aryan-Rajoria <aryanrajoria1003@gmail.com>
Co-authored-by: Gaurav <gaurav21776@gmail.com>

Run Details

236 of 236 new or added lines in 53 files covered. (100.0%)

7003 of 9005 relevant lines covered (77.77%)

0.78 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

46.43

/eva/executor/drop_executor.py

# coding=utf-8
# Copyright 2018-2022 EVA
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import pandas as pd

from eva.catalog.catalog_manager import CatalogManager
from eva.executor.abstract_executor import AbstractExecutor
from eva.executor.executor_utils import ExecutorError
from eva.models.storage.batch import Batch
from eva.parser.table_ref import TableInfo
from eva.plan_nodes.drop_plan import DropPlan
from eva.storage.storage_engine import StorageEngine
from eva.utils.logging_manager import logger


class DropExecutor(AbstractExecutor):
    def __init__(self, node: DropPlan):
        super().__init__(node)

    def exec(self, *args, **kwargs):
        """Drop table executor"""
        catalog_manager = CatalogManager()

        assert len(self.node.table_infos) == 1, "Drop supports only single table"

        table_info: TableInfo = self.node.table_infos[0]

        if not catalog_manager.check_table_exists(
            table_info.table_name, table_info.database_name
        ):
            err_msg = "Table: {} does not exist".format(table_info)
            if self.node.if_exists:
                logger.warn(err_msg)
                return Batch(pd.DataFrame([err_msg]))
            else:
                logger.exception(err_msg)
                raise ExecutorError(err_msg)

        table_obj = catalog_manager.get_table_catalog_entry(
            table_info.table_name, table_info.database_name
        )
        storage_engine = StorageEngine.factory(table_obj)

        storage_engine.drop(table=table_obj)

        assert catalog_manager.delete_table_catalog_entry(
            table_obj
        ), "Failed to drop {}".format(table_info)

        yield Batch(
            pd.DataFrame(
                {"Table Successfully dropped: {}".format(table_info.table_name)},
                index=[0],
            )
        )

1	# coding=utf-8
2	# Copyright 2018-2022 EVA
3	#
4	# Licensed under the Apache License, Version 2.0 (the "License");
5	# you may not use this file except in compliance with the License.
6	# You may obtain a copy of the License at
7	#
8	# http://www.apache.org/licenses/LICENSE-2.0
9	#
10	# Unless required by applicable law or agreed to in writing, software
11	# distributed under the License is distributed on an "AS IS" BASIS,
12	# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	# See the License for the specific language governing permissions and
14	# limitations under the License.
15	import pandas as pd	1✔
16
17	from eva.catalog.catalog_manager import CatalogManager	1✔
18	from eva.executor.abstract_executor import AbstractExecutor	1✔
19	from eva.executor.executor_utils import ExecutorError	1✔
20	from eva.models.storage.batch import Batch	1✔
21	from eva.parser.table_ref import TableInfo	1✔
22	from eva.plan_nodes.drop_plan import DropPlan	1✔
23	from eva.storage.storage_engine import StorageEngine	1✔
24	from eva.utils.logging_manager import logger	1✔
25
26
27	class DropExecutor(AbstractExecutor):	1✔
28	def __init__(self, node: DropPlan):	1✔
29	super().__init__(node)	1✔
30
31	def exec(self, args, *kwargs):	1✔
32	"""Drop table executor"""
33	catalog_manager = CatalogManager()	×
34
35	assert len(self.node.table_infos) == 1, "Drop supports only single table"	×
36
37	table_info: TableInfo = self.node.table_infos[0]	×
38
39	if not catalog_manager.check_table_exists(	×
40	table_info.table_name, table_info.database_name
41	):
42	err_msg = "Table: {} does not exist".format(table_info)	×
43	if self.node.if_exists:	×
44	logger.warn(err_msg)	×
45	return Batch(pd.DataFrame([err_msg]))	×
46	else:
47	logger.exception(err_msg)	×
48	raise ExecutorError(err_msg)	×
49
50	table_obj = catalog_manager.get_table_catalog_entry(	×
51	table_info.table_name, table_info.database_name
52	)
53	storage_engine = StorageEngine.factory(table_obj)	×
54
55	storage_engine.drop(table=table_obj)	×
56
57	assert catalog_manager.delete_table_catalog_entry(	×
58	table_obj
59	), "Failed to drop {}".format(table_info)
60
61	yield Batch(	×
62	pd.DataFrame(
63	{"Table Successfully dropped: {}".format(table_info.table_name)},
64	index=[0],
65	)
66	)

georgia-tech-db / eva / #725

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous