#725

pending completion

Build # #725

Build Type

push

circle-ci

Committed by

web-flow

Commit Message

chore: reducing coverage loss (#619)

* adding delete operation

* Adding Insert Statement

* checkpoint

* supporting multiple entries

* implemented for structured data error

* adding parser visitor for delete

* delete executor

* delete plan and rules

* adding delete to plan executor

* change position of LogicalDelete

* logical delimeter

* delete test case

* adding test case

* adding test case

* adding delete testcase

* adding predicate to delete executor

* adding delete to Image storage

* bug fix in delete

* fixing testcase

* adding test case for insert statement

* remove order_by from statement_binder.py

* better variable names, using Batch

* error message for insert

* removing order_by and limit from delete

* remove order_by and limit

* use f-string

* adding to changelog

* removing commit messages

* formatting

* fixing comments

* formatting

* eva insert f32 values

* fix: should delete range

* delete multiple rows

* udf bootstrap

* try to run tests in parallel

* minor fix for ray to work

* ray fixes

---------

Co-authored-by: Aryan-Rajoria <aryanrajoria1003@gmail.com>
Co-authored-by: Gaurav <gaurav21776@gmail.com>

Run Details

236 of 236 new or added lines in 53 files covered. (100.0%)

7003 of 9005 relevant lines covered (77.77%)

0.78 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.11

/eva/executor/create_udf_executor.py

# coding=utf-8
# Copyright 2018-2022 EVA
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import pandas as pd

from eva.catalog.catalog_manager import CatalogManager
from eva.executor.abstract_executor import AbstractExecutor
from eva.models.storage.batch import Batch
from eva.plan_nodes.create_udf_plan import CreateUDFPlan
from eva.udfs.decorators.utils import load_io_from_udf_decorators
from eva.utils.errors import UDFIODefinitionError
from eva.utils.generic_utils import load_udf_class_from_file
from eva.utils.logging_manager import logger


class CreateUDFExecutor(AbstractExecutor):
    def __init__(self, node: CreateUDFPlan):
        super().__init__(node)

    def exec(self, *args, **kwargs):
        """Create udf executor

        Calls the catalog to insert a udf catalog entry.
        """
        catalog_manager = CatalogManager()
        # check catalog if it already has this udf entry
        if catalog_manager.get_udf_catalog_entry_by_name(self.node.name):
            if self.node.if_not_exists:
                msg = f"UDF {self.node.name} already exists, nothing added."
                logger.warn(msg)
                yield Batch(pd.DataFrame([msg]))
                return
            else:
                msg = f"UDF {self.node.name} already exists."
                logger.error(msg)
                raise RuntimeError(msg)

        # load the udf class from the file
        impl_path = self.node.impl_path.absolute().as_posix()
        try:
            # loading the udf class from the file
            udf = load_udf_class_from_file(impl_path, self.node.name)
            # initializing the udf class calls the setup method internally
            udf()
        except Exception as e:
            err_msg = f"Error creating UDF: {str(e)}"
            logger.error(err_msg)
            raise RuntimeError(err_msg)

        io_list = []
        try:
            if self.node.inputs:
                io_list.extend(self.node.inputs)
            else:
                # try to load the inputs from decorators, the inputs from CREATE statement take precedence
                io_list.extend(load_io_from_udf_decorators(udf, is_input=True))

            if self.node.outputs:
                io_list.extend(self.node.outputs)
            else:
                # try to load the outputs from decorators, the outputs from CREATE statement take precedence
                io_list.extend(load_io_from_udf_decorators(udf, is_input=False))
        except UDFIODefinitionError as e:
            err_msg = f"Error creating UDF, input/output definition incorrect: {str(e)}"
            logger.error(err_msg)
            raise RuntimeError(err_msg)

        catalog_manager.insert_udf_catalog_entry(
            self.node.name, impl_path, self.node.udf_type, io_list, self.node.metadata
        )
        yield Batch(
            pd.DataFrame([f"UDF {self.node.name} successfully added to the database."])
        )

1	# coding=utf-8
2	# Copyright 2018-2022 EVA
3	#
4	# Licensed under the Apache License, Version 2.0 (the "License");
5	# you may not use this file except in compliance with the License.
6	# You may obtain a copy of the License at
7	#
8	# http://www.apache.org/licenses/LICENSE-2.0
9	#
10	# Unless required by applicable law or agreed to in writing, software
11	# distributed under the License is distributed on an "AS IS" BASIS,
12	# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	# See the License for the specific language governing permissions and
14	# limitations under the License.
15	import pandas as pd	1✔
16
17	from eva.catalog.catalog_manager import CatalogManager	1✔
18	from eva.executor.abstract_executor import AbstractExecutor	1✔
19	from eva.models.storage.batch import Batch	1✔
20	from eva.plan_nodes.create_udf_plan import CreateUDFPlan	1✔
21	from eva.udfs.decorators.utils import load_io_from_udf_decorators	1✔
22	from eva.utils.errors import UDFIODefinitionError	1✔
23	from eva.utils.generic_utils import load_udf_class_from_file	1✔
24	from eva.utils.logging_manager import logger	1✔
25
26
27	class CreateUDFExecutor(AbstractExecutor):	1✔
28	def __init__(self, node: CreateUDFPlan):	1✔
29	super().__init__(node)	1✔
30
31	def exec(self, args, *kwargs):	1✔
32	"""Create udf executor
33
34	Calls the catalog to insert a udf catalog entry.
35	"""
36	catalog_manager = CatalogManager()	1✔
37	# check catalog if it already has this udf entry
38	if catalog_manager.get_udf_catalog_entry_by_name(self.node.name):	1✔
39	if self.node.if_not_exists:	×
40	msg = f"UDF {self.node.name} already exists, nothing added."	×
41	logger.warn(msg)	×
42	yield Batch(pd.DataFrame([msg]))	×
43	return	×
44	else:
45	msg = f"UDF {self.node.name} already exists."	×
46	logger.error(msg)	×
47	raise RuntimeError(msg)	×
48
49	# load the udf class from the file
50	impl_path = self.node.impl_path.absolute().as_posix()	1✔
51	try:	1✔
52	# loading the udf class from the file
53	udf = load_udf_class_from_file(impl_path, self.node.name)	1✔
54	# initializing the udf class calls the setup method internally
55	udf()	1✔
56	except Exception as e:	×
57	err_msg = f"Error creating UDF: {str(e)}"	×
58	logger.error(err_msg)	×
59	raise RuntimeError(err_msg)	×
60
61	io_list = []	1✔
62	try:	1✔
63	if self.node.inputs:	1✔
64	io_list.extend(self.node.inputs)	1✔
65	else:
66	# try to load the inputs from decorators, the inputs from CREATE statement take precedence
67	io_list.extend(load_io_from_udf_decorators(udf, is_input=True))	1✔
68
69	if self.node.outputs:	1✔
70	io_list.extend(self.node.outputs)	1✔
71	else:
72	# try to load the outputs from decorators, the outputs from CREATE statement take precedence
73	io_list.extend(load_io_from_udf_decorators(udf, is_input=False))	×
74	except UDFIODefinitionError as e:	1✔
75	err_msg = f"Error creating UDF, input/output definition incorrect: {str(e)}"	1✔
76	logger.error(err_msg)	1✔
77	raise RuntimeError(err_msg)	1✔
78
79	catalog_manager.insert_udf_catalog_entry(	1✔
80	self.node.name, impl_path, self.node.udf_type, io_list, self.node.metadata
81	)
82	yield Batch(	1✔
83	pd.DataFrame([f"UDF {self.node.name} successfully added to the database."])
84	)

georgia-tech-db / eva / #725

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous