5984

pending completion

Build # 5984

Build Type

Pull #1128

travis-ci

Committed by

ehebert

Commit Message

PERF: Remove memoization from minute bar position.

Instead of using the `remember_last` memoization on all calls to
`_find_position_of_minute`, add an instance local cache which is only
used by the `get_value` call. The `get_value` call is very hot, so any
extra overhead (e.g. creating the WeakArgs on every invocation) becomes
costly. The current usage `get_value` also has the property that it is
called with monotonically increasing, but with a high repeat count on
each value. (A further improvement could making a `get_value` which
supports being used by many sids, for use by the update portfolio
positions.)

The caching is not done at the `_find_position_of_minute_level` because
`unadjusted_window` always uses two positions on the tape (start and end
of range) which would cause the entries and removal into the cache which
would be invalidated both between the calls of start and end, and next
call of the function.

Pull Request Pull Request #1128: Fix regression on retrieval of minute positions.

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

9653 of 11462 relevant lines covered (84.22%)

0.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.43

/zipline/utils/pandas_utils.py

Build SHA Not Found

The commit SHA "c9bd6c3d0bd69500093cbafcb1b7b1337207b510" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

quantopian / zipline / 5984

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous