#881

Committed 05 Feb 2023 11:26PM UTC coverage: 86.546% (+0.6%) from 85.952%

Build # #881

Build Type

push

Committed by StellarBot

Commit Message

Merge #6157

6157: Improve index_queue_spawning r=hkaiser a=hkaiser

- synchronous for_each_partitioner now binds tasks to cores
- add scheduling properties: get_first_core and with_first_core
- index_queue_spawning now supports first_core
- adapt rotate to use first_core for partitions


Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>

Run Details

416 of 416 new or added lines in 18 files covered. (100.0%)

174866 of 202049 relevant lines covered (86.55%)

1824233.11 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.0

/libs/core/algorithms/include/hpx/parallel/algorithms/rotate.hpp

//  Copyright (c) 2007-2023 Hartmut Kaiser
//  Copyright (c) 2021-2022 Chuanqiu He
//
//  SPDX-License-Identifier: BSL-1.0
//  Distributed under the Boost Software License, Version 1.0. (See accompanying
//  file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)

/// \file hpx/parallel/algorithms/rotate.hpp

#pragma once

#if defined(DOXYGEN)
namespace hpx {
    /// Performs a left rotation on a range of elements. Specifically,
    /// \a rotate swaps the elements in the range [first, last) in such a way
    /// that the element new_first becomes the first element of the new range
    /// and new_first - 1 becomes the last element.
    ///
    /// \note   Complexity: Linear in the distance between \a first and \a last.
    ///
    /// \tparam FwdIter     The type of the source iterators used (deduced).
    ///                     This iterator type must meet the requirements of a
    ///                     forward iterator.
    ///
    /// \param first        Refers to the beginning of the sequence of elements
    ///                     the algorithm will be applied to.
    /// \param new_first    Refers to the element that should appear at the
    ///                     beginning of the rotated range.
    /// \param last         Refers to the end of the sequence of elements the
    ///                     algorithm will be applied to.
    ///
    /// The assignments in the parallel \a rotate algorithm
    /// execute in sequential order in the calling thread.
    ///
    /// \note The type of dereferenced \a FwdIter must meet the requirements
    ///       of \a MoveAssignable and \a MoveConstructible.
    ///
    /// \returns  The \a rotate algorithm returns a FwdIter.
    ///           The \a rotate algorithm returns the iterator to the new
    ///           location of the element pointed by first,equal to first +
    ///           (last - new_first).
    ///
    template <typename FwdIter>
    FwdIter rotate(FwdIter first, FwdIter new_first, FwdIter last);

    /// Performs a left rotation on a range of elements. Specifically,
    /// \a rotate swaps the elements in the range [first, last) in such a way
    /// that the element new_first becomes the first element of the new range
    /// and new_first - 1 becomes the last element. Executed according to the
    /// policy.
    ///
    /// \note   Complexity: Linear in the distance between \a first and \a last.
    ///
    /// \tparam ExPolicy    The type of the execution policy to use (deduced).
    ///                     It describes the manner in which the execution
    ///                     of the algorithm may be parallelized and the manner
    ///                     in which it executes the assignments.
    /// \tparam FwdIter     The type of the source iterators used (deduced).
    ///                     This iterator type must meet the requirements of a
    ///                     forward iterator.
    ///
    /// \param policy       The execution policy to use for the scheduling of
    ///                     the iterations.
    /// \param first        Refers to the beginning of the sequence of elements
    ///                     the algorithm will be applied to.
    /// \param new_first    Refers to the element that should appear at the
    ///                     beginning of the rotated range.
    /// \param last         Refers to the end of the sequence of elements the
    ///                     algorithm will be applied to.
    ///
    /// The assignments in the parallel \a rotate algorithm invoked
    /// with an execution policy object of type \a sequenced_policy
    /// execute in sequential order in the calling thread.
    ///
    /// The assignments in the parallel \a rotate algorithm invoked with
    /// an execution policy object of type \a parallel_policy or
    /// \a parallel_task_policy are permitted to execute in an unordered
    /// fashion in unspecified threads, and indeterminately sequenced
    /// within each thread.
    ///
    /// \note The type of dereferenced \a FwdIter must meet the requirements
    ///       of \a MoveAssignable and \a MoveConstructible.
    ///
    /// \returns  The \a rotate algorithm returns a \a hpx::future<FwdIter>
    ///           if the execution policy is of type
    ///           \a sequenced_task_policy or \a parallel_task_policy and
    ///           returns \a FwdIter otherwise.
    ///           The \a rotate algorithm returns the iterator equal to
    ///           first + (last - new_first).
    ///
    template <typename ExPolicy, typename FwdIter>
    typename parallel::util::detail::algorithm_result<ExPolicy, FwdIter>::type
    rotate(ExPolicy&& policy, FwdIter first, FwdIter new_first, FwdIter last);

    /// Copies the elements from the range [first, last), to another range
    /// beginning at \a dest_first in such a way, that the element
    /// \a new_first becomes the first element of the new range and
    /// \a new_first - 1 becomes the last element.
    ///
    /// \note   Complexity: Performs exactly \a last - \a first assignments.
    ///
    /// \tparam FwdIter     The type of the source iterators used (deduced).
    ///                     This iterator type must meet the requirements of
    ///                     a forward iterator.
    /// \tparam OutIter     The type of the source iterators used (deduced).
    ///                     This iterator type must meet the requirements of
    ///                     a output iterator.
    ///
    /// \param first        Refers to the beginning of the sequence of
    ///                     elements the algorithm will be applied to.
    /// \param new_first    Refers to the element that should appear at the
    ///                     beginning of the rotated range.
    /// \param last         Refers to the end of the sequence of elements
    ///                     the algorithm will be applied to.
    /// \param dest_first   Refers to the begin of the destination range.
    ///
    /// The assignments in the parallel \a rotate_copy algorithm
    /// execute in sequential order in the calling thread.
    ///
    /// \returns  The \a rotate_copy algorithm returns a output iterator,
    ///           The \a rotate_copy algorithm returns the output iterator
    ///           to the element past the last element copied.
    ///
    template <typename FwdIter, typename OutIter>
    OutIter rotate_copy(
        FwdIter first, FwdIter new_first, FwdIter last, OutIter dest_first);

    /// Copies the elements from the range [first, last), to another range
    /// beginning at \a dest_first in such a way, that the element
    /// \a new_first becomes the first element of the new range and
    /// \a new_first - 1 becomes the last element. Executed according to
    /// the policy.
    ///
    /// \note   Complexity: Performs exactly \a last - \a first assignments.
    ///
    /// \tparam ExPolicy    The type of the execution policy to use
    ///                     (deduced). It describes the manner in which the
    ///                     execution of the algorithm may be parallelized
    ///                     and the manner in which it executes the
    ///                     assignments.
    /// \tparam FwdIter1    The type of the source iterators used (deduced).
    ///                     This iterator type must meet the requirements of
    ///                     a forward iterator.
    /// \tparam FwdIter2    The type of the iterator representing the
    ///                     destination range (deduced).
    ///                     This iterator type must meet the requirements of
    ///                     a forward iterator.
    ///
    /// \param policy       The execution policy to use for the scheduling
    ///                     of the iterations.
    /// \param first        Refers to the beginning of the sequence of
    ///                     elements the algorithm will be applied to.
    /// \param new_first    Refers to the element that should appear at the
    ///                     beginning of the rotated range.
    /// \param last         Refers to the end of the sequence of elements
    ///                     the algorithm will be applied to.
    /// \param dest_first   Refers to the begin of the destination range.
    ///
    /// The assignments in the parallel \a rotate_copy algorithm
    /// execute in sequential order in the calling thread.
    ///
    /// The assignments in the parallel \a rotate_copy algorithm
    /// execute in an unordered
    /// fashion in unspecified threads, and indeterminately sequenced
    /// within each thread.
    ///
    /// \returns  The \a rotate_copy algorithm returns a
    ///           \a hpx::future<FwdIter2>
    ///           if the execution policy is of type
    ///           \a parallel_task_policy and
    ///           returns FwdIter2
    ///           otherwise.
    ///           The \a rotate_copy algorithm returns the output iterator
    ///           to the element past the last element copied.
    ///
    template <typename ExPolicy, typename FwdIter1, typename FwdIter2>
    typename parallel::util::detail::algorithm_result<ExPolicy, FwdIter2>::type
    rotate_copy(ExPolicy&& policy, FwdIter1 first, FwdIter1 new_first,
        FwdIter1 last, FwdIter2 dest_first);

}    // namespace hpx

#else    // DOXYGEN

#include <hpx/config.hpp>
#include <hpx/async_base/scheduling_properties.hpp>
#include <hpx/async_local/dataflow.hpp>
#include <hpx/concepts/concepts.hpp>
#include <hpx/execution/algorithms/when_all.hpp>
#include <hpx/execution/traits/is_execution_policy.hpp>
#include <hpx/futures/traits/is_future.hpp>
#include <hpx/iterator_support/traits/is_iterator.hpp>
#include <hpx/modules/execution.hpp>

#include <hpx/executors/execution_policy.hpp>
#include <hpx/executors/execution_policy_parameters.hpp>
#include <hpx/parallel/algorithms/copy.hpp>
#include <hpx/parallel/algorithms/detail/dispatch.hpp>
#include <hpx/parallel/algorithms/detail/rotate.hpp>
#include <hpx/parallel/algorithms/reverse.hpp>
#include <hpx/parallel/util/detail/algorithm_result.hpp>
#include <hpx/parallel/util/detail/sender_util.hpp>
#include <hpx/parallel/util/result_types.hpp>
#include <hpx/parallel/util/transfer.hpp>

#include <algorithm>
#include <cstddef>
#include <iterator>
#include <type_traits>
#include <utility>

namespace hpx::parallel {

    //
    inline namespace v1 {

        ///////////////////////////////////////////////////////////////////////////
        // rotate
        namespace detail {

            /// \cond NOINTERNAL
            template <typename ExPolicy, typename FwdIter, typename Sent>
            decltype(auto) rotate_helper(
                ExPolicy policy, FwdIter first, FwdIter new_first, Sent last)
            {
                std::ptrdiff_t const size_left =
                    detail::distance(first, new_first);
                std::ptrdiff_t size_right = detail::distance(new_first, last);

                // get number of cores currently used
                std::size_t const cores =
                    parallel::execution::processing_units_count(
                        policy.parameters(), policy.executor(),
                        hpx::chrono::null_duration, size_left + size_right);

                // get currently used first core
                std::size_t first_core =
                    hpx::execution::experimental::get_first_core(policy);

                // calculate number of cores to be used for left and right section
                // proportional to the ratio of their sizes
                std::size_t cores_left = 1;
                if (size_right > 0)
                {
                    double const partition_size_ratio =
                        static_cast<double>(size_left) /
                        static_cast<double>(size_left + size_right);

                    // avoid cores_left == 0 after integer rounding
                    cores_left = (std::max)(static_cast<std::size_t>(1),
                        static_cast<std::size_t>(
                            partition_size_ratio * static_cast<double>(cores)));
                }

                // cores_right should be at least 1.
                std::size_t cores_right =
                    (std::max)(static_cast<std::size_t>(1), cores - cores_left);

                // invoke the reverse operations on the left and right sections
                // concurrently
                auto p = policy(hpx::execution::task);

                auto left_policy =
                    execution::with_processing_units_count(p, cores_left);
                auto right_policy = execution::with_processing_units_count(
                    hpx::execution::experimental::with_first_core(
                        p, cores == 1 ? first_core : first_core + cores_left),
                    cores_right);

                detail::reverse<FwdIter> r;

                return hpx::dataflow(
                    hpx::launch::sync,
                    [=](auto&& f1, auto&& f2) mutable {
                        // propagate exceptions, if appropriate
                        static constexpr bool handle_futures =
                            hpx::traits::is_future_v<decltype((f1))> &&
                            hpx::traits::is_future_v<decltype((f2))>;

                        if constexpr (handle_futures)
                        {
                            f1.get();
                            f2.get();
                        }

                        r.call(p(hpx::execution::non_task), first, last);

                        std::advance(first, size_right);
                        return util::in_out_result<FwdIter, Sent>{first, last};
                    },
                    r.call(left_policy, first, new_first),
                    r.call(right_policy, new_first, last));
            }

            template <typename IterPair>
            struct rotate : algorithm<rotate<IterPair>, IterPair>
            {
                constexpr rotate() noexcept
                  : algorithm<rotate, IterPair>("rotate")
                {
                }

                template <typename ExPolicy, typename InIter, typename Sent>
                static constexpr IterPair sequential(
                    ExPolicy, InIter first, InIter new_first, Sent last)
                {
                    return detail::sequential_rotate(first, new_first, last);
                }

                template <typename ExPolicy, typename FwdIter, typename Sent>
                static decltype(auto) parallel(ExPolicy&& policy, FwdIter first,
                    FwdIter new_first, Sent last)
                {
                    return util::detail::algorithm_result<ExPolicy,
                        IterPair>::get(rotate_helper(HPX_FORWARD(ExPolicy,
                                                         policy),
                        first, new_first, last));
                }
            };
            /// \endcond
        }    // namespace detail

        // clang-format off
        template <typename ExPolicy, typename FwdIter,
            HPX_CONCEPT_REQUIRES_(
                hpx::is_execution_policy_v<ExPolicy> &&
                hpx::traits::is_iterator_v<FwdIter>
            )>
        // clang-format on
        HPX_DEPRECATED_V(1, 8,
            "hpx::parallel::rotate is deprecated, use hpx::rotate instead ")
            typename util::detail::algorithm_result<ExPolicy,
                util::in_out_result<FwdIter, FwdIter>>::type
            rotate(ExPolicy&& policy, FwdIter first, FwdIter new_first,
                FwdIter last)
        {
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter>),
                "Requires at least forward iterator.");

            using is_seq = std::integral_constant<bool,
                hpx::is_sequenced_execution_policy_v<ExPolicy> ||
                    !hpx::traits::is_bidirectional_iterator_v<FwdIter>>;

            return detail::rotate<util::in_out_result<FwdIter, FwdIter>>()
                .call2(HPX_FORWARD(ExPolicy, policy), is_seq(), first,
                    new_first, last);
        }

        ///////////////////////////////////////////////////////////////////////////
        // rotate_copy
        namespace detail {
            /// \cond NOINTERNAL

            // sequential rotate_copy
            template <typename InIter, typename Sent, typename OutIter>
            inline util::in_out_result<InIter, OutIter> sequential_rotate_copy(
                InIter first, InIter new_first, Sent last, OutIter dest_first)
            {
                util::in_out_result<InIter, OutIter> p1 =
                    util::copy(new_first, last, dest_first);
                util::in_out_result<InIter, OutIter> p2 =
                    util::copy(first, new_first, HPX_MOVE(p1.out));
                return util::in_out_result<InIter, OutIter>{
                    HPX_MOVE(p1.in), HPX_MOVE(p2.out)};
            }

            template <typename ExPolicy, typename FwdIter1, typename Sent,
                typename FwdIter2>
            hpx::future<util::in_out_result<FwdIter1, FwdIter2>>
            rotate_copy_helper(ExPolicy policy, FwdIter1 first,
                FwdIter1 new_first, Sent last, FwdIter2 dest_first)
            {
                using non_seq = std::false_type;

                auto p = hpx::execution::parallel_task_policy()
                             .on(policy.executor())
                             .with(policy.parameters());

                using copy_return_type =
                    util::in_out_result<FwdIter1, FwdIter2>;

                hpx::future<copy_return_type> f =
                    detail::copy<copy_return_type>().call2(
                        p, non_seq(), new_first, last, dest_first);

                return f.then([=](hpx::future<copy_return_type>&& result)
                                  -> hpx::future<copy_return_type> {
                    copy_return_type p1 = result.get();
                    return detail::copy<copy_return_type>().call2(
                        p, non_seq(), first, new_first, p1.out);
                });
            }

            template <typename IterPair>
            struct rotate_copy : algorithm<rotate_copy<IterPair>, IterPair>
            {
                constexpr rotate_copy() noexcept
                  : algorithm<rotate_copy, IterPair>("rotate_copy")
                {
                }

                template <typename ExPolicy, typename InIter, typename Sent,
                    typename OutIter>
                static util::in_out_result<InIter, OutIter> sequential(ExPolicy,
                    InIter first, InIter new_first, Sent last,
                    OutIter dest_first)
                {
                    return sequential_rotate_copy(
                        first, new_first, last, dest_first);
                }

                template <typename ExPolicy, typename FwdIter1, typename Sent,
                    typename FwdIter2>
                static typename util::detail::algorithm_result<ExPolicy,
                    util::in_out_result<FwdIter1, FwdIter2>>::type
                parallel(ExPolicy&& policy, FwdIter1 first, FwdIter1 new_first,
                    Sent last, FwdIter2 dest_first)
                {
                    return util::detail::algorithm_result<ExPolicy,
                        IterPair>::get(rotate_copy_helper(HPX_FORWARD(ExPolicy,
                                                              policy),
                        first, new_first, last, dest_first));
                }
            };
            /// \endcond
        }    // namespace detail

        // clang-format off
        template <typename ExPolicy, typename FwdIter1, typename FwdIter2,
            HPX_CONCEPT_REQUIRES_(
                hpx::traits::is_iterator_v<FwdIter1> &&
                hpx::is_execution_policy_v<ExPolicy> &&
                hpx::traits::is_iterator_v<FwdIter2>
            )>
        // clang-format on
        HPX_DEPRECATED_V(1, 8,
            "hpx::parallel::rotate_copy is deprecated, use hpx::rotate_copy "
            "instead ") typename util::detail::algorithm_result<ExPolicy,
            util::in_out_result<FwdIter1, FwdIter2>>::type
            rotate_copy(ExPolicy&& policy, FwdIter1 first, FwdIter1 new_first,
                FwdIter1 last, FwdIter2 dest_first)
        {
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter1>),
                "Requires at least forward iterator.");
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter2>),
                "Requires at least forward iterator.");

            using is_seq = std::integral_constant<bool,
                hpx::is_sequenced_execution_policy_v<ExPolicy> ||
                    !hpx::traits::is_bidirectional_iterator_v<FwdIter1>>;

            return detail::rotate_copy<
                util::in_out_result<FwdIter1, FwdIter2>>()
                .call2(HPX_FORWARD(ExPolicy, policy), is_seq(), first,
                    new_first, last, dest_first);
        }
    }    // namespace v1
}    // namespace hpx::parallel

// create new APIs, tag_fallback_invoke overloads.
namespace hpx {

    ///////////////////////////////////////////////////////////////////////////
    // CPO for hpx::rotate
    inline constexpr struct rotate_t final
      : hpx::detail::tag_parallel_algorithm<rotate_t>
    {
        // clang-format off
        template <typename FwdIter,
            HPX_CONCEPT_REQUIRES_(
                hpx::traits::is_iterator_v<FwdIter>
            )>
        // clang-format on
        friend FwdIter tag_fallback_invoke(
            hpx::rotate_t, FwdIter first, FwdIter new_first, FwdIter last)
        {
            static_assert(hpx::traits::is_forward_iterator_v<FwdIter>,
                "Requires at least forward iterator.");

            return parallel::util::get_second_element(
                hpx::parallel::v1::detail::rotate<
                    hpx::parallel::util::in_out_result<FwdIter, FwdIter>>()
                    .call(hpx::execution::seq, first, new_first, last));
        }

        // clang-format off
        template <typename ExPolicy, typename FwdIter,
            HPX_CONCEPT_REQUIRES_(
                hpx::is_execution_policy_v<ExPolicy> &&
                hpx::traits::is_iterator_v<FwdIter>
            )>
        // clang-format on
        friend decltype(auto) tag_fallback_invoke(hpx::rotate_t,
            ExPolicy&& policy, FwdIter first, FwdIter new_first, FwdIter last)
        {
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter>),
                "Requires at least forward iterator.");

            using is_seq = std::integral_constant<bool,
                hpx::is_sequenced_execution_policy_v<ExPolicy> ||
                    !hpx::traits::is_bidirectional_iterator_v<FwdIter>>;

            return parallel::util::get_second_element(
                hpx::parallel::v1::detail::rotate<
                    hpx::parallel::util::in_out_result<FwdIter, FwdIter>>()
                    .call2(HPX_FORWARD(ExPolicy, policy), is_seq(), first,
                        new_first, last));
        }

    } rotate{};

    ///////////////////////////////////////////////////////////////////////////
    // CPO for hpx::rotate_copy
    inline constexpr struct rotate_copy_t final
      : hpx::detail::tag_parallel_algorithm<rotate_copy_t>
    {
        // clang-format off
        template <typename FwdIter, typename OutIter,
            HPX_CONCEPT_REQUIRES_(
                hpx::traits::is_iterator_v<FwdIter> &&
                hpx::traits::is_iterator_v<OutIter>
            )>
        // clang-format on
        friend OutIter tag_fallback_invoke(hpx::rotate_copy_t, FwdIter first,
            FwdIter new_first, FwdIter last, OutIter dest_first)
        {
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter>),
                "Requires at least forward iterator.");
            static_assert((hpx::traits::is_output_iterator_v<OutIter>),
                "Requires at least output iterator.");

            return parallel::util::get_second_element(
                hpx::parallel::v1::detail::rotate_copy<
                    hpx::parallel::util::in_out_result<FwdIter, OutIter>>()
                    .call(hpx::execution::seq, first, new_first, last,
                        dest_first));
        }

        // clang-format off
        template <typename ExPolicy, typename FwdIter1, typename FwdIter2,
            HPX_CONCEPT_REQUIRES_(
                hpx::traits::is_iterator_v<FwdIter1> &&
                hpx::is_execution_policy_v<ExPolicy> &&
                hpx::traits::is_iterator_v<FwdIter2>
            )>
        // clang-format on
        friend typename parallel::util::detail::algorithm_result<ExPolicy,
            FwdIter2>::type
        tag_fallback_invoke(hpx::rotate_copy_t, ExPolicy&& policy,
            FwdIter1 first, FwdIter1 new_first, FwdIter1 last,
            FwdIter2 dest_first)
        {
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter1>),
                "Requires at least forward iterator.");
            static_assert((hpx::traits::is_forward_iterator_v<FwdIter2>),
                "Requires at least forward iterator.");

            using is_seq = std::integral_constant<bool,
                hpx::is_sequenced_execution_policy_v<ExPolicy> ||
                    !hpx::traits::is_forward_iterator_v<FwdIter1>>;

            return parallel::util::get_second_element(
                hpx::parallel::v1::detail::rotate_copy<
                    hpx::parallel::util::in_out_result<FwdIter1, FwdIter2>>()
                    .call2(HPX_FORWARD(ExPolicy, policy), is_seq(), first,
                        new_first, last, dest_first));
        }
    } rotate_copy{};
}    // namespace hpx

#endif    // DOXYGEN

STEllAR-GROUP / hpx / #881

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous