4028490717

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/google/santa/commit/<a class=hub.com/google/santa/commit/<a class="double-link" href="https://git"><a class=hub.com/google/santa/commit/<a class="double-link" href="https://git"><a class=hub.com/google/santa/commit/<a class="double-link" href="https://git"><a class=hub.com/google/santa/commit/<a class="double-link" href="https://git"><a class=hub.com/google/santa/commit/161acdbd235627607b9f912a58f87fa689f465c2">161acdbd2">&lt;a href=&quot;https://github.com/google/santa/commit/</a><a class="double-link" href="https://github.com/google/santa/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/google/santa/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/google/santa/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/google/santa/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/google/santa/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/google/santa/commit/161acdbd235627607b9f912a58f87fa689f465c2">161acdbd2</a><a href="https://github.com/google/santa/commit/161acdbd235627607b9f912a58f87fa689f465c2">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/google/santa/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/google/santa/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/google/santa/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/google/santa/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/google/santa/commit/161acdbd235627607b9f912a58f87fa689f465c2&quot;&gt;161acdbd2&lt;/a&gt;&lt;a href=&quot;https://github.com/google/santa/commit/161acdbd235627607b9f912a58f87fa689f465c2&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/google/santa/commit/161acdbd235627607b9f912a58f87fa689f465c2&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://github.com/google/santa/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://gi... (continued)

Pull Request Pull Request #1019: Fix: Rewrite the SNTMetricHTTPWriter to avoid potential stack corruption

Run Details

3806 of 7740 branches covered (49.17%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

13461 of 18947 relevant lines covered (71.05%)

16440.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.14

/Source/santametricservice/Writers/SNTMetricHTTPWriter.m

/// Copyright 2021 Google Inc. All rights reserved.
///
/// Licensed under the Apache License, Version 2.0 (the "License");
/// you may not use this file except in compliance with the License.
/// You may obtain a copy of the License at
///
///    http://www.apache.org/licenses/LICENSE-2.0
///
///    Unless required by applicable law or agreed to in writing, software
///    distributed under the License is distributed on an "AS IS" BASIS,
///    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
///    See the License for the specific language governing permissions and
///    limitations under the License.
#import <MOLAuthenticatingURLSession/MOLAuthenticatingURLSession.h>
#include <dispatch/dispatch.h>

#import "Source/common/SNTConfigurator.h"
#import "Source/common/SNTLogging.h"
#import "Source/santametricservice/Writers/SNTMetricHTTPWriter.h"

@implementation SNTMetricHTTPWriter {
 @private
  MOLAuthenticatingURLSession *_authSession;
}

- (instancetype)init {
  self = [super init];
  if (self) {
    _authSession = [[MOLAuthenticatingURLSession alloc] init];
  }
  return self;
}

/**
 * Post serialzied metrics to the specified URL one object at a time.
 **/
- (BOOL)write:(NSArray<NSData *> *)metrics toURL:(NSURL *)url error:(NSError **)error {
  __block NSError *_blockError = nil;

  NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];
  request.HTTPMethod = @"POST";
  [request setValue:@"application/json" forHTTPHeaderField:@"Content-Type"];

  _authSession.serverHostname = url.host;
  NSURLSession *_session = _authSession.session;
  NSURLSessionDataTask *task;

  dispatch_group_t requests = dispatch_group_create();

  for (NSData *metric in metrics) {
    dispatch_group_enter(requests);

    request.HTTPBody = (NSData *)metric;
    task = [_session
      dataTaskWithRequest:request
        completionHandler:^(NSData *_Nullable data, NSURLResponse *_Nullable response,
                            NSError *_Nullable err) {
          if (err != nil) {
            LOGD(@"SNTMetricHTTPWriter: %@", err);
            _blockError = err;
          } else if (response == nil) {
            // Overwrite the last error as any previous error should show up in
            // logs if making multiple requests.
            _blockError = nil;
          } else if ([response isKindOfClass:[NSHTTPURLResponse class]]) {
            NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)response;

            // Check HTTP error codes and create errors for any non-200.
            if (httpResponse && httpResponse.statusCode != 200) {
              _blockError = [[NSError alloc]
                initWithDomain:@"com.google.santa.metricservice.writers.http"
                          code:httpResponse.statusCode
                      userInfo:@{
                        NSLocalizedDescriptionKey :
                          [NSString stringWithFormat:@"received http status code %ld from %@",
                                                     httpResponse.statusCode, url]
                      }];
              LOGD(@"SNTMetricHTTPWriter: %@", _blockError);
            }
          }
          dispatch_group_leave(requests);
        }];

    [task resume];

    SNTConfigurator *config = [SNTConfigurator configurator];
    int64_t timeout = (int64_t)config.metricExportTimeout;

    // Wait up to timeout seconds for the request to complete.
    if (dispatch_group_wait(requests, dispatch_time(DISPATCH_TIME_NOW, timeout * NSEC_PER_SEC)) !=
        0) {
      [task cancel];
      NSString *errMsg =
        [NSString stringWithFormat:@"HTTP request to %@ timed out after %lu seconds", url,
                                   (unsigned long)timeout];

      _blockError = [[NSError alloc] initWithDomain:@"com.google.santa.metricservice.writers.http"
                                               code:ETIMEDOUT
                                           userInfo:@{NSLocalizedDescriptionKey : errMsg}];
    }
  }

  if (_blockError != nil) {
    // If the caller hasn't passed us an error then we ignore it.
    if (error != nil) {
      *error = [_blockError copy];
    }

    return NO;
  }

  return YES;
}
@end

1	/// Copyright 2021 Google Inc. All rights reserved.
2	///
3	/// Licensed under the Apache License, Version 2.0 (the "License");
4	/// you may not use this file except in compliance with the License.
5	/// You may obtain a copy of the License at
6	///
7	/// http://www.apache.org/licenses/LICENSE-2.0
8	///
9	/// Unless required by applicable law or agreed to in writing, software
10	/// distributed under the License is distributed on an "AS IS" BASIS,
11	/// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	/// See the License for the specific language governing permissions and
13	/// limitations under the License.
14	#import <MOLAuthenticatingURLSession/MOLAuthenticatingURLSession.h>
15	#include <dispatch/dispatch.h>
16
17	#import "Source/common/SNTConfigurator.h"
18	#import "Source/common/SNTLogging.h"
19	#import "Source/santametricservice/Writers/SNTMetricHTTPWriter.h"
20
21	@implementation SNTMetricHTTPWriter {
22	@private
23	MOLAuthenticatingURLSession *_authSession;
24	}
25
26	- (instancetype)init {	11✔
27	self = [super init];	11✔
28	if (self) {	11!
29	_authSession = [[MOLAuthenticatingURLSession alloc] init];	11✔
30	}	11✔
31	return self;	11✔
32	}	11✔
33
34	/**
35	* Post serialzied metrics to the specified URL one object at a time.
36	**/
37	- (BOOL)write:(NSArray<NSData > )metrics toURL:(NSURL )url error:(NSError *)error {	11✔
38	__block NSError *_blockError = nil;	11✔
39
40	NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];	11✔
41	request.HTTPMethod = @"POST";	11✔
42	[request setValue:@"application/json" forHTTPHeaderField:@"Content-Type"];	11✔
43
44	_authSession.serverHostname = url.host;	11✔
45	NSURLSession *_session = _authSession.session;	11✔
46	NSURLSessionDataTask *task;	11✔
47
48	dispatch_group_t requests = dispatch_group_create();	11✔
49
50	for (NSData *metric in metrics) {	12✔
51	dispatch_group_enter(requests);	12✔
52
53	request.HTTPBody = (NSData *)metric;	12✔
54	task = [_session	12✔
55	dataTaskWithRequest:request	12✔
56	completionHandler:^(NSData _Nullable data, NSURLResponse _Nullable response,	12✔
57	NSError *_Nullable err) {	12✔
58	if (err != nil) {	12✔
59	LOGD(@"SNTMetricHTTPWriter: %@", err);	3✔
60	_blockError = err;	3✔
61	} else if (response == nil) {	9!
62	// Overwrite the last error as any previous error should show up in
63	// logs if making multiple requests.
64	_blockError = nil;	×
65	} else if ([response isKindOfClass:[NSHTTPURLResponse class]]) {	9!
66	NSHTTPURLResponse httpResponse = (NSHTTPURLResponse )response;	9✔
67
68	// Check HTTP error codes and create errors for any non-200.
69	if (httpResponse && httpResponse.statusCode != 200) {	9!
70	_blockError = [[NSError alloc]	5✔
71	initWithDomain:@"com.google.santa.metricservice.writers.http"	5✔
72	code:httpResponse.statusCode	5✔
73	userInfo:@{	5✔
74	NSLocalizedDescriptionKey :	5✔
75	[NSString stringWithFormat:@"received http status code %ld from %@",	5✔
76	httpResponse.statusCode, url]	5✔
77	}];	5✔
78	LOGD(@"SNTMetricHTTPWriter: %@", _blockError);	5✔
79	}	5✔
80	}	9✔
81	dispatch_group_leave(requests);	12✔
82	}];	12✔
83
84	[task resume];	12✔
85
86	SNTConfigurator *config = [SNTConfigurator configurator];	12✔
87	int64_t timeout = (int64_t)config.metricExportTimeout;	12✔
88
89	// Wait up to timeout seconds for the request to complete.
90	if (dispatch_group_wait(requests, dispatch_time(DISPATCH_TIME_NOW, timeout * NSEC_PER_SEC)) !=	12!
91	0) {	×
92	[task cancel];	×
93	NSString *errMsg =	×
94	[NSString stringWithFormat:@"HTTP request to %@ timed out after %lu seconds", url,	×
95	(unsigned long)timeout];	×
96
97	_blockError = [[NSError alloc] initWithDomain:@"com.google.santa.metricservice.writers.http"	×
98	code:ETIMEDOUT	×
99	userInfo:@{NSLocalizedDescriptionKey : errMsg}];	×
100	}	×
101	}	12✔
102
103	if (_blockError != nil) {	11✔
104	// If the caller hasn't passed us an error then we ignore it.
105	if (error != nil) {	8✔
106	*error = [_blockError copy];	3✔
107	}	3✔
108
109	return NO;	8✔
110	}	8✔
111
112	return YES;	3✔
113	}	3✔
114	@end

google / santa / 4028490717

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous