#244

Build # #244

Build Type

push

Committed by

Commit Message

Introduce separate entry point for worker environments (#1660)

* Separate stripe into worker and default entrypoints, needs tests for worker

* Fix test, remove unused import

* Actually require child_process

* build

* Convert tests to TypeScript, add browser field

* Move more utils functions to nodeUtils

* Use _utils defined on Stripe object

* Add error messages to createNodeHttpClient and createNodeCryptoProvider

* Move platform-specific utils to new PlatformFunctions classes, add tests

* Abstract getUname to platform functions, set _platformFunctions on Webhooks

* Make generic createCryptoProvider in Webhooks

* Revert "Make generic createCryptoProvider in Webhooks"

This reverts commit c8af4d530.

* Remove stale file in lib

* Create generic createHttpClient that creates FetchHttpClient by default in workers

* Move getUname to PlatformFunctions (now returns a promise), and misc reviewer comments

* Make generic createCryptoProvider in Webhooks

* Removing this alias

* Fix DefaultPlatformFunctions getUname, fix test

* Add getMockPlatformFunctions test util, prefix _createCryptoProvider

Run Details

520 of 595 branches covered (87.39%)

Branch coverage included in aggregate %.

209 of 209 new or added lines in 8 files covered. (100.0%)

1282 of 1344 relevant lines covered (95.39%)

378.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/lib/platform/NodePlatformFunctions.js

"use strict";
const crypto = require("crypto");
const DefaultPlatformFunctions = require("./DefaultPlatformFunctions");
/**
 * Specializes DefaultPlatformFunctions using APIs available in Node.js.
 */
class NodePlatformFunctions extends DefaultPlatformFunctions {
    constructor() {
        super();
        this._exec = require('child_process').exec;
        this._UNAME_CACHE = null;
    }
    /** @override */
    uuid4() {
        // available in: v14.17.x+
        if (crypto.randomUUID) {
            return crypto.randomUUID();
        }
        return super.uuid4();
    }
    /**
     * @override
     * Node's built in `exec` function sometimes throws outright,
     * and sometimes has a callback with an error,
     * depending on the type of error.
     *
     * This unifies that interface by resolving with a null uname
     * if an error is encountered.
     */
    getUname() {
        if (!this._UNAME_CACHE) {
            this._UNAME_CACHE = new Promise((resolve, reject) => {
                try {
                    this._exec('uname -a', (err, uname) => {
                        if (err) {
                            return resolve(null);
                        }
                        resolve(uname);
                    });
                }
                catch (e) {
                    resolve(null);
                }
            });
        }
        return this._UNAME_CACHE;
    }
    /**
     * @override
     * Secure compare, from https://github.com/freewil/scmp
     */
    secureCompare(a, b) {
        if (!a || !b) {
            throw new Error('secureCompare must receive two arguments');
        }
        // return early here if buffer lengths are not equal since timingSafeEqual
        // will throw if buffer lengths are not equal
        if (a.length !== b.length) {
            return false;
        }
        // use crypto.timingSafeEqual if available (since Node.js v6.6.0),
        // otherwise use our own scmp-internal function.
        if (crypto.timingSafeEqual) {
            const textEncoder = new TextEncoder();
            const aEncoded = textEncoder.encode(a);
            const bEncoded = textEncoder.encode(b);
            return crypto.timingSafeEqual(aEncoded, bEncoded);
        }
        return super.secureCompare(a, b);
    }
}
module.exports = NodePlatformFunctions;

1	"use strict";
2	const crypto = require("crypto");	4✔
3	const DefaultPlatformFunctions = require("./DefaultPlatformFunctions");	4✔
4	/**
5	* Specializes DefaultPlatformFunctions using APIs available in Node.js.
6	*/
7	class NodePlatformFunctions extends DefaultPlatformFunctions {
8	constructor() {
9	super();	7✔
10	this._exec = require('child_process').exec;	7✔
11	this._UNAME_CACHE = null;	7✔
12	}
13	/** @override */
14	uuid4() {
15	// available in: v14.17.x+
16	if (crypto.randomUUID) {	15!
17	return crypto.randomUUID();	×
18	}
19	return super.uuid4();	15✔
20	}
21	/**
22	* @override
23	* Node's built in `exec` function sometimes throws outright,
24	* and sometimes has a callback with an error,
25	* depending on the type of error.
26	*
27	* This unifies that interface by resolving with a null uname
28	* if an error is encountered.
29	*/
30	getUname() {
31	if (!this._UNAME_CACHE) {	877✔
32	this._UNAME_CACHE = new Promise((resolve, reject) => {	9✔
33	try {	9✔
34	this._exec('uname -a', (err, uname) => {	9✔
35	if (err) {	8✔
36	return resolve(null);	2✔
37	}
38	resolve(uname);	6✔
39	});
40	}
41	catch (e) {
42	resolve(null);	1✔
43	}
44	});
45	}
46	return this._UNAME_CACHE;	877✔
47	}
48	/**
49	* @override
50	* Secure compare, from https://github.com/freewil/scmp
51	*/
52	secureCompare(a, b) {
53	if (!a \|\| !b) {	38✔
54	throw new Error('secureCompare must receive two arguments');	2✔
55	}
56	// return early here if buffer lengths are not equal since timingSafeEqual
57	// will throw if buffer lengths are not equal
58	if (a.length !== b.length) {	36✔
59	return false;	7✔
60	}
61	// use crypto.timingSafeEqual if available (since Node.js v6.6.0),
62	// otherwise use our own scmp-internal function.
63	if (crypto.timingSafeEqual) {	29✔
64	const textEncoder = new TextEncoder();	26✔
65	const aEncoded = textEncoder.encode(a);	26✔
66	const bEncoded = textEncoder.encode(b);	26✔
67	return crypto.timingSafeEqual(aEncoded, bEncoded);	26✔
68	}
69	return super.secureCompare(a, b);	3✔
70	}
71	}
72	module.exports = NodePlatformFunctions;	4✔

stripe / stripe-node / #244

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous